| 344c9f3 | Gyuho Lee | 06 May 2021, 08:59:14 UTC | Merge pull request #12896 from wilsonwang371/profiling-txn2 server: make applier use ReadTx() in Txn() instead of ConcurrentReadTx() | 06 May 2021, 08:59:14 UTC |
| 8af8f6a | Sam Batschelet | 05 May 2021, 21:01:43 UTC | Merge pull request #12918 from iflamed/fix-doc-demo-bug fix doc demo bug | 05 May 2021, 21:01:43 UTC |
| a8a3eea | 刘兵 | 05 May 2021, 05:57:10 UTC | fix doc demo bug the service parameter not used. | 05 May 2021, 05:57:10 UTC |
| 7296a07 | odidev | 04 May 2021, 20:29:47 UTC | Set ETCD_UNSUPPORTED_ARCH to ARM64 (#12557) Signed-off-by: odidev <odidev@puresoftware.com> | 04 May 2021, 20:29:47 UTC |
| b32bc91 | tangcong | 04 May 2021, 20:26:33 UTC | learner support snapshot RPC (#12890) * learner support snapshot RPC * CHANGELOG: update for 12890 | 04 May 2021, 20:26:33 UTC |
| 98083ea | Wilson Wang | 04 May 2021, 17:11:40 UTC | server: add experimental flag for using shared buffer in transacton write | 04 May 2021, 18:59:08 UTC |
| f1123d6 | Piotr Tabor | 04 May 2021, 14:51:59 UTC | fixup! Unify shared code (and constants) with cindex package. | 04 May 2021, 16:21:24 UTC |
| a78d072 | Piotr Tabor | 04 May 2021, 13:38:11 UTC | Simplify KVstore dependency on cindex. | 04 May 2021, 16:21:24 UTC |
| 2fb6f0a | Piotr Tabor | 28 April 2021, 06:49:40 UTC | Simplify lease management after cindex update is moved to 'hooks'. | 04 May 2021, 16:21:23 UTC |
| 2dbecea | Piotr Tabor | 12 April 2021, 17:49:58 UTC | Simplify KVStore interaction with cindex thanks to hooks. | 04 May 2021, 16:21:23 UTC |
| fe3254a | Piotr Tabor | 12 April 2021, 17:10:13 UTC | Remove explicit authStore->ConsistencyIndex updates, as they are taken care by hook. | 04 May 2021, 13:38:23 UTC |
| 5005167 | Piotr Tabor | 12 April 2021, 15:28:39 UTC | Integrate backend::hooks with consistent_index. Every transaction committed to backend is writing most recent consistent_index. Makes sure that even automatically trigger commits of batch-transactions stays "really" consistent a.d. the most recent WAL log index applied. | 04 May 2021, 13:38:23 UTC |
| d53d2db | Piotr Tabor | 09 April 2021, 16:43:13 UTC | Tests: Backend hooks support. | 04 May 2021, 13:38:22 UTC |
| 9f11b16 | Piotr Tabor | 09 April 2021, 12:18:18 UTC | backend: Hooks interface & implementation. | 04 May 2021, 13:38:22 UTC |
| a3fc535 | Piotr Tabor | 04 May 2021, 08:15:01 UTC | Merge pull request #12914 from ptabor/20210430-read-membership No-storeV2: Read membership information from the backend (Part5) | 04 May 2021, 08:15:01 UTC |
| 5615421 | Wilson Wang | 03 May 2021, 17:19:33 UTC | update variable declaration location | 03 May 2021, 17:30:15 UTC |
| eb128d2 | Gyuho Lee | 03 May 2021, 16:01:50 UTC | Merge pull request #12916 from wpedrak/pass-mlock-during-defrag server: reapply `Mlock` flag after defrag | 03 May 2021, 16:01:50 UTC |
| 6623c00 | wpedrak | 03 May 2021, 09:01:02 UTC | server: reapply `Mlock` flag after defrag | 03 May 2021, 09:01:02 UTC |
| c46e96d | Piotr Tabor | 29 April 2021, 21:12:56 UTC | Merge pull request #12910 from ptabor/20210430-zap-polish Finish migration zap.NewExample -> zaptest.NewLogger(t) in integration tests | 29 April 2021, 21:12:56 UTC |
| 3acf6e3 | Piotr Tabor | 29 April 2021, 20:32:26 UTC | Finish migration zap.NewExample -> zaptest.NewLogger(t) in integration tests | 29 April 2021, 20:32:26 UTC |
| 451f65d | Piotr Tabor | 29 April 2021, 17:25:04 UTC | Merge pull request #12908 from ptabor/20210429-client-retry-logging Clientv3 (retry interceptor) logs should use the configured logger | 29 April 2021, 17:25:04 UTC |
| cedbea6 | Piotr Tabor | 29 April 2021, 16:21:24 UTC | Merge pull request #12904 from wpedrak/limit_mlocked_memory server: replace mlockall with `Mlock` in `--experimental-memory-mlock` | 29 April 2021, 16:21:24 UTC |
| ffea153 | Piotr Tabor | 29 April 2021, 15:12:12 UTC | ClientV3 tests use integration.NewClient that configures proper logger. | 29 April 2021, 16:18:34 UTC |
| 835643e | Piotr Tabor | 29 April 2021, 16:01:45 UTC | Merge pull request #12906 from ptabor/20210429-etcdctl-v2-backup-cindex-fix 20210429 etcdctl v2 backup cindex fix | 29 April 2021, 16:01:45 UTC |
| e908ef3 | Piotr Tabor | 29 April 2021, 14:22:41 UTC | Merge pull request #12903 from lilic/exit-on-signal-int etcdctl/ctlv3: Cleanup keys on signal interrupt. | 29 April 2021, 14:22:41 UTC |
| 205a1a4 | Piotr Tabor | 29 April 2021, 11:44:39 UTC | Read membership information from the backend. | 29 April 2021, 11:45:45 UTC |
| bc8d3f6 | Piotr Tabor | 29 April 2021, 10:57:09 UTC | Clientv3 (retry) logs should use the configured logger. clientv3 logs (especially tests) were poluted with unattributed to testing.T log lines: ``` {"level":"warn","ts":"2021-04-29T12:42:11.055+0200","logger":"etcd-client","caller":"v3/retry_interceptor.go:64","msg":"retrying of unary invoker failed","target":"etcd-endpoints://0xc0000fafc0/#initially=[unix://localhost:m10]","attempt":0,"error":"rpc error: code = ResourceExhausted desc = etcdserver: mvcc: database space exceeded"} ``` The reasons were 2 fold: - Interceptors were copying logger before "WithLogger" could modify it. - We were not propagating the loggers in a few testing contexts. | 29 April 2021, 10:57:09 UTC |
| 586b238 | Lili Cosic | 23 April 2021, 07:40:20 UTC | etcdctl/ctlv3: Cleanup keys on signal interrupt of check perf If ctc+c is pressed during the run of etcdctl check perf, this deletes all the previously created keys that perf check created. | 29 April 2021, 10:55:36 UTC |
| 1145c57 | wpedrak | 29 April 2021, 10:08:52 UTC | server: replace mlockall with `Mlock` in `--experimental-memory-mlock` Implementation of `--experimental-memory-mlock` backed by `mlockall` syscall is replaced by `Mlock` flag (backed by mlock syscall) of bboltDB. | 29 April 2021, 10:08:52 UTC |
| 927b3a3 | wpedrak | 28 April 2021, 14:00:04 UTC | server: replace mlockall with `Mlock` in `--experimental-memory-mlock` Implementation of `--experimental-memory-mlock` backed by `mlockall` syscall is replaced by `Mlock` flag (backed by mlock syscall) of bboltDB. | 29 April 2021, 10:08:20 UTC |
| e90504f | Piotr Tabor | 29 April 2021, 07:34:54 UTC | Unify shared code (and constants) with cindex package. | 29 April 2021, 09:51:25 UTC |
| f53b70f | Piotr Tabor | 28 April 2021, 23:03:36 UTC | Embed: In case KVStoreHash verification fails, close the backend. In case of failed verification, the server used to keep opened backend (so the file was locked on OS level). | 29 April 2021, 09:51:25 UTC |
| 2ad893b | Piotr Tabor | 28 April 2021, 21:23:45 UTC | Integrate verification into e2e tests. | 29 April 2021, 09:51:24 UTC |
| 911204c | Piotr Tabor | 28 April 2021, 20:46:42 UTC | Fix `ETCDCTL_API=2 etcdctl backup --with-v3` consistent index consistency Prior to this CL, `ETCDCTL_API=2 etcdctl backup --with-v3` was readacting WAL log (by removal of some entries), but was NOT updating consistent_index in the backend. Also the WAL editing logic was buggy, as it didn't took in consideration the fact that when TERM changes, there can be entries with duplicated indexes in the log. So its NOT sufficient to subtract number of removed entries to get accurate log indexes. The PR replaces removing and shifting of WAL entries with replacing them with an no-op entries. Thanks to this consistent-index references are staying up to date. The PR also: - updates 'verification' logic to check whether consistent_index does not lag befor last snapshot - env-gated execution of verification framework in `etcdctl backup`. Tested with: ``` (./build.sh && cd tests && EXPECT_DEBUG=TRUE 'env' 'go' 'test' '-timeout=300m' 'go.etcd.io/etcd/tests/v3/e2e' -run=TestCtlV2Backup --count=1000 2>&1 | tee TestCtlV2BackupV3.log) ``` | 29 April 2021, 09:51:24 UTC |
| adc365e | Piotr Tabor | 28 April 2021, 11:52:59 UTC | etcdctl2: backup command logging cleanup (zap) | 28 April 2021, 21:26:17 UTC |
| 8d8d037 | Wilson Wang | 26 April 2021, 01:06:40 UTC | server: applier uses ReadTx instead of ConcurrentTx | 28 April 2021, 18:06:24 UTC |
| ed4a87d | Piotr Tabor | 28 April 2021, 06:45:15 UTC | Merge pull request #12901 from ptabor/20210427-verification Verification of persisted data | 28 April 2021, 06:45:15 UTC |
| 7107cb9 | Piotr Tabor | 28 April 2021, 06:44:06 UTC | fixup! Create 'datadir' package responsible for paths. | 28 April 2021, 06:44:06 UTC |
| c4b13a5 | Piotr Tabor | 27 April 2021, 15:10:41 UTC | Integrate verification framework Verification framework is integrated with: - integration tests (by default) - `ETCD_VERIFY=all etcdctl snapshot restore` command - etcd shutdown when running with `ETCD_VERIFY=all` env. | 28 April 2021, 05:56:16 UTC |
| 47b28b6 | Piotr Tabor | 27 April 2021, 15:06:47 UTC | Verification package: Verified given data-dir. For now verifies whete Backend.cindex is consistent with WAL log, but should get expanded to cover memberships & revisions. | 28 April 2021, 05:56:15 UTC |
| 6f8f506 | Piotr Tabor | 25 April 2021, 12:25:24 UTC | Create 'datadir' package responsible for paths. | 28 April 2021, 05:56:13 UTC |
| d2722ff | Piotr Tabor | 28 April 2021, 05:53:42 UTC | Merge pull request #12820 from ptabor/20210326-membership-from-be (no)StoreV2 (Part 2): Prepare to read membership information from backend | 28 April 2021, 05:53:42 UTC |
| 0675219 | Piotr Tabor | 02 April 2021, 19:08:03 UTC | v2 etcdctl backup: producing consistent state of membership | 27 April 2021, 17:34:34 UTC |
| a70386a | Piotr Tabor | 02 April 2021, 15:22:19 UTC | Simplify membership interface: Does not pass the 'unused' token. | 27 April 2021, 15:17:31 UTC |
| 4725567 | Piotr Tabor | 02 April 2021, 16:06:50 UTC | e2e tests: More logging and expect adopted to 3.4. | 27 April 2021, 15:17:31 UTC |
| 7ae3d25 | Piotr Tabor | 02 April 2021, 16:01:26 UTC | Membership: Add additional methods to trim/manage membership data in backend. | 27 April 2021, 15:17:31 UTC |
| aa65973 | Piotr Tabor | 02 April 2021, 15:58:13 UTC | etcd-dump-logs: Print full confState as json for debugging purposes. | 27 April 2021, 15:17:31 UTC |
| 768da49 | Piotr Tabor | 26 March 2021, 12:01:49 UTC | sever: v2store deprecation: Fix `etcdctl snapshot restore` to restore correct 'backend' (bbolt) context in aspect of membership. Prior to this change the 'restored' backend used to still contain: - old memberid (mvcc deletion used, why the membership is in bolt bucket, but not mvcc part): ``` mvs := mvcc.NewStore(s.lg, be, lessor, ci, mvcc.StoreConfig{CompactionBatchLimit: math.MaxInt32}) defer mvs.Close() txn := mvs.Write(traceutil.TODO()) btx := be.BatchTx() del := func(k, v []byte) error { txn.DeleteRange(k, nil) return nil } // delete stored members from old cluster since using new members btx.UnsafeForEach([]byte("members"), del) ``` - didn't get new members added. | 27 April 2021, 15:17:30 UTC |
| 06d6f09 | Gyuho Lee | 27 April 2021, 07:19:10 UTC | Merge pull request #12894 from MakDon/patch-1 etcdserver/mvcc: update tw.trace.Step condition | 27 April 2021, 07:19:10 UTC |
| c4f7d57 | Gyuho Lee | 26 April 2021, 21:37:53 UTC | Merge pull request #12898 from tangcong/add-disk-io-failure-case functional: add disk io failure case | 26 April 2021, 21:37:53 UTC |
| 4fb2209 | tangcong | 26 April 2021, 06:02:37 UTC | functional: add SHORT_TTL_LEASE_EXPIRE checker | 26 April 2021, 12:00:45 UTC |
| 16e38e4 | tangcong | 26 April 2021, 04:07:05 UTC | functional: add FAILPOINTS_WITH_DISK_IO_LATENCY case | 26 April 2021, 04:07:05 UTC |
| 370f9cf | tangcong | 26 April 2021, 03:43:50 UTC | fix: failed to get failpoints from member | 26 April 2021, 03:44:53 UTC |
| ddcb463 | Makdon | 25 April 2021, 15:07:45 UTC | etcdserver/mvcc: update trace.Step condition | 25 April 2021, 15:07:45 UTC |
| 9a3aff6 | Piotr Tabor | 23 April 2021, 12:55:44 UTC | Merge pull request #12889 from ptabor/20210423-deflake-TestFirstCommitNotification Deflake: TestFirstCommitNotification | 23 April 2021, 12:55:44 UTC |
| 9f55977 | Piotr Tabor | 22 April 2021, 19:40:02 UTC | Deflake: TestFirstCommitNotification Infrequently the test flaked. Reproducable with: ``` go test go.etcd.io/etcd/tests/v3/integration --run TestFirstCommitNotification --count=500 ``` The moveLeader finishes when configchange is commited by quorum. It doesn't guarantee that the 'empty' record was committed by the new leader. From time to time happened that appliedLeaderIndex was returning 9 (without empty entry) and the test flaked. In healthy case the appliedIndex returned 10. Fixed by putting kv pair after leader change. The pair is guaranteed to be stored on index when put finishes (so the empty entry as well). | 23 April 2021, 11:22:15 UTC |
| bd4f8e2 | Piotr Tabor | 22 April 2021, 22:45:59 UTC | Merge pull request #12885 from ptabor/20210422-error-codes-context Errors: `context cancelled` or `context deadline exceeded` are exposed as codes.Canceled, codes.DeadlineExceeded instead of 'codes.Unknown' | 22 April 2021, 22:45:59 UTC |
| 9a4b2bd | Piotr Tabor | 22 April 2021, 10:57:23 UTC | Errors: `context cancelled` or `context deadline exceeded` are exposed as codes.Canceled, codes.DeadlineExceeded instead of 'codes.Unknown' | 22 April 2021, 12:35:24 UTC |
| cc52d99 | Piotr Tabor | 21 April 2021, 10:29:01 UTC | Merge pull request #12883 from ptabor/20210421-backend-refactor-testing mvcc/backend tests: Refactor: Do not mix testing&prod code. | 21 April 2021, 10:29:01 UTC |
| d7d110b | Piotr Tabor | 09 April 2021, 13:49:50 UTC | mvcc/backend tests: Refactor: Do not mix testing&prod code. | 21 April 2021, 07:43:13 UTC |
| ea287dd | Piotr Tabor | 21 April 2021, 07:31:38 UTC | Merge pull request #12854 from ptabor/20210410-shouldApplyV3 (no)StoreV2 (Part 3): Applying consistency fix: ClusterVersionSet (and co) might get not applied on v2store | 21 April 2021, 07:31:38 UTC |
| ce3dae6 | Piotr Tabor | 21 April 2021, 07:30:02 UTC | Merge pull request #12873 from ptabor/20210417-test-docker-gcloud Makefile: Use `gcloud auth configure-docker` instead of `gcloud docker ...` for test-images | 21 April 2021, 07:30:02 UTC |
| 0f2c940 | Sam Batschelet | 21 April 2021, 01:18:15 UTC | Merge pull request #12880 from chaochn47/exclude_alarms_from_health_check etcdhttp/metrics.go: exclude alarms from health check conditionally with `?exclude=NOSPACE` | 21 April 2021, 01:18:15 UTC |
| b321c48 | Chao Chen | 20 April 2021, 20:17:26 UTC | Update CHANGELOG-3.5.md | 20 April 2021, 20:17:26 UTC |
| 140ea4f | Chao Chen | 20 April 2021, 20:17:09 UTC | etcdhttp/metrics.go: exclude alarms from health check conditionally with ?exclude=NOSPACE | 20 April 2021, 20:17:09 UTC |
| 8162d9c | Piotr Tabor | 19 April 2021, 21:08:42 UTC | Merge pull request #12876 from qsyqian/branch_management_link doc: fix branch management link | 19 April 2021, 21:08:42 UTC |
| 334e696 | Gyuho Lee | 19 April 2021, 17:12:42 UTC | Merge pull request #12878 from lilic/fix-docker-release Makefile, build.sh: Fix build process | 19 April 2021, 17:12:42 UTC |
| 51c28fc | Lili Cosic | 19 April 2021, 15:48:23 UTC | build.sh: Adjust building etcdctl to be same as etcd binary This fixes so that the ENV vars are taken in the same way as for etcd binary. | 19 April 2021, 15:51:46 UTC |
| 81652d1 | Lili Cosic | 19 April 2021, 15:46:36 UTC | Makefile: Fix build-docker-release-master Since the Dockerfile files are now per arch, this adjusts to detect ARCH and builds docker release from the Dockerfile.<ARCH> file. | 19 April 2021, 15:47:03 UTC |
| 11249fd | Piotr Tabor | 19 April 2021, 14:51:49 UTC | Merge pull request #12874 from ptabor/20210417-go1.16.3 Update go for 3.5: 1.15.x -> 1.16.3 | 19 April 2021, 14:51:49 UTC |
| 3423a94 | Piotr Tabor | 17 April 2021, 10:21:14 UTC | Update go for 3.5: 1.15 -> 1.16.(3). https://github.com/etcd-io/etcd/issues/12732 | 19 April 2021, 14:50:54 UTC |
| 2cbd86b | qsyqian | 19 April 2021, 07:25:19 UTC | doc: fix branch management link Fixes #12875 | 19 April 2021, 07:25:19 UTC |
| 2f77a1a | Piotr Tabor | 18 April 2021, 15:44:07 UTC | Merge pull request #12864 from ssbostan/master client: fix check datascale command for https endpoints | 18 April 2021, 15:44:07 UTC |
| 06ba0fc | Piotr Tabor | 17 April 2021, 10:58:46 UTC | Merge pull request #12846 from pyiyun/fix-snaptmpfile-bug etcdserver: remove temp files in snap dir when etcdserver starting | 17 April 2021, 10:58:46 UTC |
| 5ad8880 | Piotr Tabor | 17 April 2021, 10:11:09 UTC | Makefile: Use gcloud auth configure-docker instead of gcloud docker. | 17 April 2021, 10:11:09 UTC |
| 97a8aff | Saeid Bostandoust | 17 April 2021, 09:54:56 UTC | fix util.go file | 17 April 2021, 09:54:56 UTC |
| 80586c5 | chao | 16 April 2021, 23:39:34 UTC | etcdserver/util.go: reduce memory when logging range requests (#12871) * etcdserver/util.go: reduce memory when logging range requests Fixes #12835 * Update CHANGELOG-3.5.md | 16 April 2021, 23:39:34 UTC |
| 5744cdf | Piotr Tabor | 16 April 2021, 19:49:46 UTC | Merge pull request #12870 from ptabor/20210416-fix-flake-TestSnapshotV3RestoreMultiMemberAdd-master Fix TestSnapshotV3RestoreMultiMemberAdd flakes (leaks) | 16 April 2021, 19:49:46 UTC |
| 17b9823 | Piotr Tabor | 16 April 2021, 16:55:56 UTC | Fix TestSnapshotV3RestoreMultiMemberAdd flakes (leaks) - most important: unix's socket transport should not keep idle connections. For top-level Transport we close them using: https://github.com/etcd-io/etcd/blob/f3c518025e284d3d070a63d5969c69176f247b33/server/etcdserver/api/rafthttp/transport.go#L226 but currently we don't have access to close them witing the nest (unix) transport. Short idle deadline is good enough. - Use dialContext (instead of dial) to make sure context is passed down the stack - Make sure Context is cancelled as soon as the operation is done in pipeline - nit: use dedicated method to yeld goroutines. Tested with: ``` d=$(date +"%Y%m%d_%H%M") (cd tests && go test --timeout=60m ./integration/snapshot -run TestSnapshotV3RestoreMultiMemberAdd -v --count=180 2>&1 | tee log_${d}.log) ``` There were transports & cmux leaked: ``` leak.go:118: Test appears to have leaked a Transport: internal/poll.runtime_pollWait(0x7f6c5c3784c8, 0x72, 0xffffffffffffffff) /usr/lib/google-golang/src/runtime/netpoll.go:222 +0x55 internal/poll.(*pollDesc).wait(0xc003296298, 0x72, 0x0, 0x18, 0xffffffffffffffff) /usr/lib/google-golang/src/internal/poll/fd_poll_runtime.go:87 +0x45 internal/poll.(*pollDesc).waitRead(...) /usr/lib/google-golang/src/internal/poll/fd_poll_runtime.go:92 internal/poll.(*FD).Read(0xc003296280, 0xc0031f60a8, 0x18, 0x18, 0x0, 0x0, 0x0) /usr/lib/google-golang/src/internal/poll/fd_unix.go:166 +0x1d5 net.(*netFD).Read(0xc003296280, 0xc0031f60a8, 0x18, 0x18, 0x18, 0xc0009056e2, 0x203000) /usr/lib/google-golang/src/net/fd_posix.go:55 +0x4f net.(*conn).Read(0xc000010258, 0xc0031f60a8, 0x18, 0x18, 0x0, 0x0, 0x0) /usr/lib/google-golang/src/net/net.go:183 +0x91 github.com/soheilhy/cmux.(*bufferedReader).Read(0xc0003d24e0, 0xc0031f60a8, 0x18, 0x18, 0xc0003d24d0, 0xc0009056e2, 0xc000278400) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/buffer.go:53 +0x12d github.com/soheilhy/cmux.hasHTTP2Preface(0x1367e20, 0xc0003d24e0, 0x7f6c5c699f40) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/matchers.go:195 +0x8a github.com/soheilhy/cmux.matchersToMatchWriters.func1(0x7f6c5c699f40, 0xc000010258, 0x1367e20, 0xc0003d24e0, 0xc000010258) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:128 +0x39 github.com/soheilhy/cmux.(*cMux).serve(0xc003228690, 0x138c410, 0xc000010258, 0xc00327f740, 0xc0059ba860) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:192 +0x1e7 created by github.com/soheilhy/cmux.(*cMux).Serve /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:179 +0x191 internal/poll.runtime_pollWait(0x7f6c5c60f3f0, 0x72, 0xffffffffffffffff) /usr/lib/google-golang/src/runtime/netpoll.go:222 +0x55 internal/poll.(*pollDesc).wait(0xc000d53018, 0x72, 0x1000, 0x1000, 0xffffffffffffffff) /usr/lib/google-golang/src/internal/poll/fd_poll_runtime.go:87 +0x45 internal/poll.(*pollDesc).waitRead(...) /usr/lib/google-golang/src/internal/poll/fd_poll_runtime.go:92 internal/poll.(*FD).Read(0xc000d53000, 0xc000cfd000, 0x1000, 0x1000, 0x0, 0x0, 0x0) /usr/lib/google-golang/src/internal/poll/fd_unix.go:166 +0x1d5 net.(*netFD).Read(0xc000d53000, 0xc000cfd000, 0x1000, 0x1000, 0x3, 0x3, 0x1000000000001) /usr/lib/google-golang/src/net/fd_posix.go:55 +0x4f net.(*conn).Read(0xc00031a570, 0xc000cfd000, 0x1000, 0x1000, 0x0, 0x0, 0x0) /usr/lib/google-golang/src/net/net.go:183 +0x91 net/http.(*persistConn).Read(0xc00093b320, 0xc000cfd000, 0x1000, 0x1000, 0x577750, 0x60, 0x0) /usr/lib/google-golang/src/net/http/transport.go:1933 +0x77 bufio.(*Reader).fill(0xc005702fc0) /usr/lib/google-golang/src/bufio/bufio.go:101 +0x108 bufio.(*Reader).Peek(0xc005702fc0, 0x1, 0xc00077c660, 0xc003b082a0, 0xc000d08de0, 0x5ae586, 0x11dd6c0) /usr/lib/google-golang/src/bufio/bufio.go:139 +0x4f net/http.(*persistConn).readLoop(0xc00093b320) /usr/lib/google-golang/src/net/http/transport.go:2094 +0x1a8 created by net/http.(*Transport).dialConn /usr/lib/google-golang/src/net/http/transport.go:1754 +0xdaa net/http.(*persistConn).writeLoop(0xc00093b320) /usr/lib/google-golang/src/net/http/transport.go:2393 +0xf7 created by net/http.(*Transport).dialConn /usr/lib/google-golang/src/net/http/transport.go:1755 +0xdcf sync.runtime_Semacquire(0xc0059ba868) /usr/lib/google-golang/src/runtime/sema.go:56 +0x45 sync.(*WaitGroup).Wait(0xc0059ba860) /usr/lib/google-golang/src/sync/waitgroup.go:130 +0x65 github.com/soheilhy/cmux.(*cMux).Serve.func1(0xc003228690, 0xc0059ba860) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:158 +0x56 github.com/soheilhy/cmux.(*cMux).Serve(0xc003228690, 0x13698c0, 0xc00377a0f0) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:173 +0x115 go.etcd.io/etcd/server/v3/embed.(*Etcd).servePeers.func1(0xc0007cc360, 0x122b75f) /home/ptab/corp/etcd/server/embed/etcd.go:518 +0x2b9 go.etcd.io/etcd/server/v3/embed.(*Etcd).servePeers.func3(0xc00036d080, 0xc0059330a0) /home/ptab/corp/etcd/server/embed/etcd.go:549 +0x182 created by go.etcd.io/etcd/server/v3/embed.(*Etcd).servePeers /home/ptab/corp/etcd/server/embed/etcd.go:543 +0x73a --- FAIL: TestSnapshotV3RestoreMultiMemberAdd (17.74s) ``` | 16 April 2021, 18:17:28 UTC |
| 28a490b | pyiyun | 09 April 2021, 01:58:56 UTC | etcdserver: remove temp files in snap dir when etcdServer starting When etcd exits abnormally, tmp files will remain in snap dir, so clean up tmp files in snap dir when etcdserver starting. Fixes #12837 | 16 April 2021, 12:30:04 UTC |
| a9c4301 | Saeid Bostandoust | 15 April 2021, 23:21:04 UTC | fix check datascale command for https endpoints | 15 April 2021, 23:21:04 UTC |
| f3c5180 | Piotr Tabor | 15 April 2021, 22:07:35 UTC | Merge pull request #12861 from ptabor/20210413-test-logging-fixes Embedded server should not mess global loggers (by default) | 15 April 2021, 22:07:35 UTC |
| b47c5fc | Piotr Tabor | 15 April 2021, 15:54:37 UTC | Address review comments a.d. logging. | 15 April 2021, 15:54:37 UTC |
| c73da74 | Piotr Tabor | 15 April 2021, 15:37:03 UTC | Merge pull request #12862 from lilic/enable-race .travis.yaml: Enables race in the tests | 15 April 2021, 15:37:03 UTC |
| 2843fde | Lili Cosic | 15 April 2021, 12:06:45 UTC | .travis.yaml: Enables race in the tests As the TestV3WatchRestoreSnapshotUnsync flakiness was fixed, this removes the TODO and enables the race again. | 15 April 2021, 12:32:52 UTC |
| fad6391 | Piotr Tabor | 14 April 2021, 10:31:37 UTC | Configure proper logging for grpc integration tests. | 14 April 2021, 10:47:38 UTC |
| d72f7ef | Piotr Tabor | 14 April 2021, 10:16:11 UTC | Give control to Embedded servers whether they override global loggers So far each instance of embed server was overriding the grpc loggers and zap.global loggers. It's counter intutitive that last created Embedded server was 'wining' and more-over it was breaking grpc expectation to change it "only" before the grpc stack is being used. This PR introduces explicit call: `embed.Config::SetupGlobalLoggers()`, that changes the loggers where requested. The call is used by etcd main binary. The immediate benefit from this change is reduction of test flakiness, as there were flakes due to not a proper logger being used across tests. | 14 April 2021, 10:47:38 UTC |
| eafbc8c | Piotr Tabor | 14 April 2021, 07:16:11 UTC | Update zap logging dependency. In particular bring up zapgrpc V2 code: https://github.com/uber-go/zap/commit/89e382035d3a984a01e6c9c8be5462f11efac844 https://pkg.go.dev/google.golang.org/grpc/grpclog#LoggerV2 | 14 April 2021, 10:15:48 UTC |
| 57a092b | Piotr Tabor | 13 April 2021, 21:05:52 UTC | Merge pull request #12859 from tomwilkie/fix-mixin Fix the mixin. | 13 April 2021, 21:05:52 UTC |
| d69e46e | Piotr Tabor | 13 April 2021, 21:01:03 UTC | Make ShouldApplyV3 an enum - not bool | 13 April 2021, 21:01:03 UTC |
| 562d645 | Tom Wilkie | 13 April 2021, 18:38:55 UTC | Fix the mixin. Signed-off-by: Tom Wilkie <tom@grafana.com> | 13 April 2021, 18:38:55 UTC |
| 4388bfc | Piotr Tabor | 13 April 2021, 15:33:43 UTC | Merge pull request #12858 from hnlq715/patch-1 client: fix doc typo | 13 April 2021, 15:33:43 UTC |
| 5db0070 | 大可 | 13 April 2021, 14:22:42 UTC | Update doc.go | 13 April 2021, 14:22:42 UTC |
| d7e971e | 大可 | 13 April 2021, 08:33:24 UTC | client: fix doc typo | 13 April 2021, 08:33:24 UTC |
| b1c04ce | Piotr Tabor | 10 April 2021, 09:42:15 UTC | Applying consistency fix: ClusterVersionSet (and co) might get no applied on v2store ClusterVersionSet, ClusterMemberAttrSet, DowngradeInfoSet functions are writing both to V2store and backend. Prior this CL there were in a branch not executed if shouldApplyV3 was false, e.g. during restore when Backend is up-to-date (has high consistency-index) while v2store requires replay from WAL log. The most serious consequence of this bug was that v2store after restore could have different index (revision) than the same exact store before restore, so potentially different content between replicas. Also this change is supressing double-applying of Membership (ClusterConfig) changes on Backend (store v3) - that lackilly are not part of MVCC/KeyValue store, so they didn't caused Revisions to be bumped. Inspired by jingyih@ comment: https://github.com/etcd-io/etcd/pull/12820#issuecomment-815299406 | 12 April 2021, 07:43:48 UTC |
| 7f97dfd | Piotr Tabor | 09 April 2021, 14:41:54 UTC | Merge pull request #12795 from wpedrak/resend-read-index-on-first-commit-in-term etcdserver: resend ReadIndex request on empty apply request | 09 April 2021, 14:41:54 UTC |
| 08ea9cb | wpedrak | 31 March 2021, 09:04:19 UTC | etcdserver: integration test covering first commit in current term notification | 09 April 2021, 14:05:02 UTC |
| 3991a8c | wpedrak | 29 March 2021, 10:31:44 UTC | etcdserver: replace `forceVersionC` with `FirstCommitInTermNotify` | 09 April 2021, 09:30:42 UTC |
| 3d485fa | wpedrak | 23 March 2021, 15:39:05 UTC | etcdserver: resend ReadIndex request on empty apply request Empty apply indicates first commit in current term. It is first time when follower is sure, that it's ReadIndex request can be processed. | 09 April 2021, 09:30:42 UTC |
| bad0b4d | Piotr Tabor | 08 April 2021, 13:14:53 UTC | Merge pull request #12823 from mtulio/chore/dash-var-refresh chore/dash-var-refresh: change default refresh to 2(time range) | 08 April 2021, 13:14:53 UTC |
