| 254b1f2 | Stephan Hageboeck | 15 June 2020, 14:49:24 UTC | [TPython][Docs] Fix docstrings of TPython. (cherry picked from commit ad2206344917d3e8badde4159049f8432444f5f3) | 15 June 2020, 15:40:32 UTC |
| 1c6c331 | Stephan Hageboeck | 15 June 2020, 12:59:28 UTC | [RF][RelNotes] Rename section in release notes. | 15 June 2020, 13:03:26 UTC |
| 9e348d0 | Stephan Hageboeck | 12 June 2020, 17:16:26 UTC | [RF][ROOT-10845] Correct IsOnHeap() for RooFit objects. Since RooDataSet and RooArgSet use their own operator new, IsOnHeap was returning false. Now, memory is allocated using TStorage, which correctly sets the kIsOnHeap bit if necessary. | 15 June 2020, 12:26:54 UTC |
| a2696c0 | Stephan Hageboeck | 15 June 2020, 10:24:46 UTC | [RF][RelNotes] Properly typeset tables to support pandoc grid syntax. | 15 June 2020, 10:27:07 UTC |
| 9437f76 | Stephan Hageboeck | 15 June 2020, 08:24:24 UTC | [RelNotes] Redirect doxygen URLs to v622 instead of master. | 15 June 2020, 10:27:07 UTC |
| bc8a5e3 | Enric Tejedor Saavedra | 15 June 2020, 09:27:37 UTC | [PyROOT][Release Notes] Fix formatting for pandoc | 15 June 2020, 09:34:24 UTC |
| 75bb6cc | Axel Naumann | 15 June 2020, 06:24:54 UTC | [core] Fix deprecation macros: This caused premature deprecation warnings, as 6.22/01 is > 6.22/00. Fixes 6e64bf3351bc54da4c1b8831fb01ab285e3687cb. | 15 June 2020, 06:24:54 UTC |
| 66a01b9 | Axel Naumann | 14 June 2020, 15:57:08 UTC | "Update ROOT version files to v6.22/01." | 14 June 2020, 15:57:08 UTC |
| a4a30f9 | Axel Naumann | 14 June 2020, 15:51:48 UTC | "Update ROOT version files to v6.22/00." | 14 June 2020, 15:51:48 UTC |
| a1575c4 | Axel Naumann | 14 June 2020, 15:47:22 UTC | [relnotes] Add issues fixed in 6.22/00. | 14 June 2020, 15:47:22 UTC |
| dc5cab6 | Axel Naumann | 14 June 2020, 15:30:39 UTC | [relnotes] Set release date; prepare for next patch. | 14 June 2020, 15:30:39 UTC |
| eec3be2 | Axel Naumann | 14 June 2020, 15:29:36 UTC | [relnotes] Move PyROOT under Language Bindings, move RDF up. | 14 June 2020, 15:29:36 UTC |
| a712b0e | Axel Naumann | 14 June 2020, 15:28:14 UTC | [relnotes] Remove empty sections. | 14 June 2020, 15:28:14 UTC |
| aa00b75 | Philippe Canal | 13 June 2020, 03:02:16 UTC | Use correct comparison (cherry picked from commit d4c8339d943567bd1df3437b79e0d3d1c73cbeea) | 14 June 2020, 10:27:13 UTC |
| 38404c8 | Philippe Canal | 13 June 2020, 02:36:06 UTC | fix for ROOT_EXPERIMENTAL_GMI is set by jenkins so we need to augment the test for it (cherry picked from commit e4ac6694e3c70be7058c4de83bec5501a937e8f4) | 14 June 2020, 10:27:08 UTC |
| bf3c98c | Philippe Canal | 13 June 2020, 02:36:06 UTC | ROOT_EXPERIMENTAL_GMI is set by jenkins so we need to augment the test for it (cherry picked from commit 655a6ab398a56910147c30c8e09d97b2d32a7a0a) | 14 June 2020, 10:27:03 UTC |
| b322517 | Axel Naumann | 12 June 2020, 16:39:46 UTC | [unix] No linked so does not mean failure on MacOS: An empty list of linked libraries was interpreted as failure to extract the list of linked libraries; the default "-lCore -lRint..." was taken instead. When running python, no libs show up as linked. That caused "-lRint" to be claimed as linked, which was preventing gSystem.Load("libRint") within python, claiming that it is already loaded (as it is linked). Instead, if the library signaling the end of linked libraries is seen, and so far no libraries have been found as linked, set the list-of-linked-libraries to " ", i.e. not empty, triggering the "success" path in TSystem::GetLibraries(), and correctly reporting the linked libraries. This fixes JupyROOT-cppcompleter-doctest, JupyROOT-ROOT-kernel-notebook not finding TTabCom::TTabCom() because loadling libRint was mistakenly a no-op. (cherry picked from commit bcd5d2241271425103cac17bbcbcbdb447197395) | 12 June 2020, 20:01:53 UTC |
| 874878d | Oksana Shadura | 12 June 2020, 08:06:21 UTC | Remove deprecated python option, added an info message | 12 June 2020, 14:33:45 UTC |
| 4006034 | Enric Tejedor Saavedra | 12 June 2020, 08:01:05 UTC | [PyROOT] Include the deactivation of pyroot_experimental in the suggestion | 12 June 2020, 12:03:59 UTC |
| 676db98 | Philippe Canal | 11 June 2020, 19:57:04 UTC | Add missing read lock in THashTable::FindObject(const TObject *obj). Fix ROOT-10839 | 11 June 2020, 19:57:58 UTC |
| b2374fe | Enric Tejedor Saavedra | 11 June 2020, 09:51:52 UTC | [PyROOT][ROOT-10833] Use new API instead of deprecated one To prevent deprecation warning. | 11 June 2020, 14:42:11 UTC |
| 78afbd4 | Enrico Guiraud | 12 May 2020, 10:00:02 UTC | [TTreeReader] Use FindBranch as a fallback method to find branch FindBranch deals with full branch names more nicely. This fixes TTreeReader not being able to find the "i.x" branch in ROOT-10702. | 11 June 2020, 12:34:00 UTC |
| 5d02654 | Enrico Guiraud | 12 May 2020, 09:03:57 UTC | [DF] Use FindBranch as a fallback way to check branch existence FindBranch deals with full branch names more nicely. This fixes RDF not being able to find the "i.x" branch in ROOT-10702. | 11 June 2020, 12:34:00 UTC |
| 926550f | Enrico Guiraud | 08 May 2020, 14:04:45 UTC | [TTreeReader] Add test for ROOT-10702 | 11 June 2020, 12:34:00 UTC |
| 7000578 | Enrico Guiraud | 08 May 2020, 14:04:23 UTC | [TTree] Add test for ROOT-10702 | 11 June 2020, 12:34:00 UTC |
| 5a82561 | Enrico Guiraud | 29 April 2020, 13:22:00 UTC | [DF] Add test for ROOT-10702 | 11 June 2020, 12:34:00 UTC |
| 114a895 | Enrico Guiraud | 10 June 2020, 16:00:42 UTC | [DF] Do not call SetBranchAddress when not needed This removes spurious warnings from dataframe_snapshot.cxx. The problem (once again) was that map::operator[] creates entries if not present. | 11 June 2020, 08:43:46 UTC |
| 884ffc7 | Philippe Canal | 10 June 2020, 14:50:38 UTC | TTree::CopyAddress: update array allocation for all leaves. Fix ROOT-10837 (and technically it is a completion of the fix for ROOT-9393). See allow commit f8897bb49c2fc81e875a7fd70dec9f1f714e6398 and 6ad1a98455bec01ccfce6ea9ddde62154bedf1a4. Seen with CMS NanoAOD files: https://root-forum.cern.ch/t/merge-nanoaod-root-files/39707/13 When the files have several array branches using the same "leaf count" branch and the maximum array size increase from file to file, only the memory allocated for the "first" array is extended. This results in memory error for the other arrays. | 10 June 2020, 16:25:36 UTC |
| 3cabf5e | Philippe Canal | 08 June 2020, 19:25:36 UTC | TTree::SetBranchAddress and GetBranch release notes | 10 June 2020, 12:35:00 UTC |
| f7cad9f | Philippe Canal | 07 June 2020, 15:58:09 UTC | Use TBranch::GetFullName in TBranchProxy (GetFriendBranchName). This is necessary due to the change of GetBranch from depth-first to breast-first and increase the accuracy of the finding. | 10 June 2020, 12:31:34 UTC |
| 04f8ae3 | Philippe Canal | 04 June 2020, 22:15:34 UTC | Switch TTree::GetBranch from depth first to breadth first. This allow to find top level branch hidden behind lower level branches (that were insert/added first) With: struct Int { int x; }; struct FloatInt { float f; int x; }; and int x = 1; FloatInt s{2.1, 3}; TTree t("t", "t"); t.Branch("i", &i); t.Branch("x", &x); with the depth first (old version) algorithm t.GetBranch("x") was returning the branch "i.x" and the only way to retrieve the top level branch "x" was to use FindBranch or FindObject on the ListOfBranches. with the breadth firstd (new version) algorithm t.GetBranch("x") return the "x" top level branches (and thanks to the recent switch to using GetFullName in GetBranch, calling GetBranch with "i.x" will return the "i.x" branch as expected. | 10 June 2020, 12:31:34 UTC |
| 5928d20 | Philippe Canal | 04 June 2020, 20:49:26 UTC | For TTree::GetBranch uses GetFullName in the search | 10 June 2020, 12:31:34 UTC |
| fcd761d | Philippe Canal | 02 June 2020, 00:57:02 UTC | Switch branch to MakeClass when associated to a numerical type. If a TBranchElement's address is set directly to a numerical type (or array) automatically switched the branch to the Decomposed Object (MakeClass) mode. In particular, after this commit, the following will always work ``` chain->SetBranchAdress(fullnameofbranch, &address_of_numerical_type); ``` Prior to this commit, if the requested branch is a sub-branch of a split object, the user needs to **also** turn on MakeClass mode (also called Decomposed Object mode) explicit, now it is done implicitly. | 10 June 2020, 12:31:34 UTC |
| ea42dcc | Philippe Canal | 02 June 2020, 00:55:30 UTC | TChain: record and carry forward MakeClass state of branches. If branches are individual set in MakeClass (Decomposed Object) mode, record this information in TChainElement and apply it to the corresponding branches in each of the TTree. | 10 June 2020, 12:31:34 UTC |
| 5490efd | Philippe Canal | 02 June 2020, 00:13:57 UTC | TChain: always check the branch address. Even in the case the address is set before any TTree is loaded. With this commit, in addition to checking the address type in the case: ``` chain->LoadTree(0); chain->SetBranchAdress(branch_name, &address); ``` will also check them in the case: ``` chain->SetBranchAdress(branch_name, &address); chain->LoadTree(0); ``` (yep, it would silently fail before). | 10 June 2020, 12:31:34 UTC |
| be49edf | Philippe Canal | 02 June 2020, 00:07:31 UTC | Don't override user provided sub-branch address. Prior to this commit doing: ``` // Not setting the top level branch address. chain->SetBranchAdress(sub_branch_name, &address); chain->GetEntry(0); ``` Resulted in the address set to be forgotten. Note that a work-around was: ``` // Not setting the top level branch address. chain->GetEntry(0); chain->SetBranchAdress(sub_branch_name, &address); ``` But also the address needed to (in most cases) also be set again after each new tree was loaded. Note that, the following: ``` chain->SetBranchAdress(sub_branch_name, &address); chain->SetBranchAdress(top_level_branch_name, &other_address); chain->GetEntry(0); ``` will result (as one would expect) with the first SetBranchAddress being ignored/over-ridden. | 10 June 2020, 12:31:34 UTC |
| c5bfc36 | Philippe Canal | 02 June 2020, 00:06:01 UTC | Extent the use of TBranchElement::kAddressSet. Now also set it for top level branch and direct call to SetAddress and reset it in case of error. | 10 June 2020, 12:31:34 UTC |
| 1a9cd4a | Philippe Canal | 01 June 2020, 23:49:16 UTC | [NFC] Propagate info whether SetAddress is implicit | 10 June 2020, 12:31:34 UTC |
| 28a2542 | Philippe Canal | 01 June 2020, 22:20:37 UTC | Propagate branches' MakeClass mode in TTree::CopyAddresses | 10 June 2020, 12:31:34 UTC |
| a128650 | Philippe Canal | 01 June 2020, 22:18:19 UTC | Use GetFullName in CopyAddresses | 10 June 2020, 12:31:34 UTC |
| 4ae3cef | Philippe Canal | 01 June 2020, 21:25:38 UTC | Factor multiple calls to InheritsFrom | 10 June 2020, 12:31:34 UTC |
| 659ca93 | Philippe Canal | 22 May 2020, 19:08:16 UTC | TClusterIterator: deal correctly with TTree with 0 or 1 entry (and no basket flush) | 10 June 2020, 12:31:34 UTC |
| 4b36fc6 | Philippe Canal | 22 May 2020, 00:40:48 UTC | TTree::GetBranch uses GetFullName in the search | 10 June 2020, 12:31:34 UTC |
| ce60971 | Philippe Canal | 22 May 2020, 00:38:33 UTC | Add TBranch and TLeaf GetFullName routine | 10 June 2020, 12:31:34 UTC |
| 32ac50c | Philippe Canal | 04 June 2020, 19:39:53 UTC | R__HAS_DEFAULT_LZ4 is set without value so we must use defined op. | 10 June 2020, 12:31:34 UTC |
| 24ad703 | Philippe Canal | 10 April 2020, 16:52:27 UTC | TKey: remove unnecessary thread local | 10 June 2020, 12:31:34 UTC |
| 9460d18 | Enrico Guiraud | 09 June 2020, 16:44:50 UTC | [DF][NFC] Fix typos in RLoopManager.cxx | 09 June 2020, 16:50:04 UTC |
| 34505b3 | Massimiliano Galli | 26 May 2020, 07:41:51 UTC | [CMake][Exp PyROOT] Use ROOT_LIBRARY_PROPERTIES to set suffix to .so and prefix to lib for libcppyy and libcppyy_backend | 09 June 2020, 15:10:50 UTC |
| a5a0875 | Massimiliano Galli | 18 May 2020, 12:32:49 UTC | [CMake][Exp PyROOT] Build libcppyy and libROOTPythonizations with undefined symbols As a general rule, libraries containing C/C++ extensions that are meant to be loaded from Python, should not be linked against libPython; the reason for this is that when these libraries are imported, Python has already loaded the libPython symbols, and if these are different from the ones used to link against the extension module a crash can happen. libcppyy and libROOTPythonizations, being only imported from Python, do not need to link against libPython. On the other hand, this is needed for libROOTTPython, which is used only form C++. | 09 June 2020, 15:10:50 UTC |
| 5969e53 | Enric Tejedor Saavedra | 09 June 2020, 09:17:46 UTC | Add note about vector<string> iteration | 09 June 2020, 09:22:43 UTC |
| e85df05 | Axel Naumann | 08 June 2020, 16:02:03 UTC | [metacling] On Mac, try first without leading underscore: Fixes unnecessary loading of (wrong) cppyy library because a symbol named "_PyExc_SyntaxError" cannot be found by dlsym. (cherry picked from commit 1f143a7e0c7b5eb1dca5bd3442b6c6996c2f9147) | 09 June 2020, 07:10:59 UTC |
| bca8480 | Axel Naumann | 05 June 2020, 17:25:39 UTC | [clingutils] Add demangled name as alternate class name (ROOT-10804): clang might need to find a definition, that "we" might have. But we need to find it based on a type name from clang, from a fwd decl; or (as in ROOT-10804) based on a typename-from-typeid operation. So register that as an alias! The normalized-name-as-known-to-ROOT and typeid-name can be different, for instance for inline namespaces: stripped by ROOT, kept by typeid. ROOT-10804 has a complex case where a lookup of a template argument failed because it involves an inline namespace, and LHCb uses typeid demangling. LHCb's case needed a nested name from a type (`LHCb::Event::v1::Track`) that failed to load because `v1` is an inline namespace, thus failing instantiation of `KeyedContainer<LHCb::Event::v1::Track,Containers::KeyedObjectManager<Containers::hashmap> >` and making it invalid. The transaction unloading then fails to completely remove this instantiation (an unrelated bug), such that the remainders of the invalid decl are picked up by a subsequent template instantiation which then asserts because of the incomplete (invalid) declaration. We use the mangle/demangle trick from rootcling. Now that multiple locations need it, just store it with the AnnotatedRecordDecl. It will be needed for most classes; the overhead should be bearable. (cherry picked from commit d9e819b82632cf02b3aaa251f5922b457b41624e) | 08 June 2020, 16:03:31 UTC |
| 5d75226 | Olivier Couet | 08 June 2020, 12:04:03 UTC | Backport Workaround for bug in LOD calculation for tubes (#5817) | 08 June 2020, 12:04:03 UTC |
| af0fbee | moneta | 04 June 2020, 10:32:22 UTC | Update 6.22 Release notes for TMVA , Math and Histogram Library | 08 June 2020, 07:23:57 UTC |
| 70297eb | Enrico Guiraud | 06 June 2020, 15:18:17 UTC | [DF] Fix contiguousness check, take #2 | 07 June 2020, 11:29:39 UTC |
| 32d9e08 | Olivier Couet | 05 June 2020, 14:05:16 UTC | backport stressgraphics fix | 05 June 2020, 20:02:03 UTC |
| fe2c8a1 | Enric Tejedor Saavedra | 04 June 2020, 16:39:57 UTC | [PyROOT][CMake] Change ERROR to a WARNING when pyroot_experimental flag is used | 05 June 2020, 15:34:41 UTC |
| 5342c67 | Enric Tejedor Saavedra | 04 June 2020, 16:37:20 UTC | [PyROOT][CMake] Prevent pyroot=OFF and pyroot_legacy=ON | 05 June 2020, 15:34:41 UTC |
| fc683f0 | Enric Tejedor Saavedra | 05 June 2020, 11:30:52 UTC | [PyROOT][ReleaseNotes] Mention problems with inheritance of Python classes from C++ | 05 June 2020, 15:03:48 UTC |
| d2d4fc1 | Enric Tejedor Saavedra | 05 June 2020, 10:59:01 UTC | [PyROOT][ReleaseNotes] Add explanation about PyROOT CMake options | 05 June 2020, 15:03:48 UTC |
| 3c43e88 | Massimiliano Galli | 04 June 2020, 07:35:58 UTC | [CMake] Add comment concerning CMake minimum version required for MultiPython | 05 June 2020, 07:32:42 UTC |
| 6ab4147 | Massimiliano Galli | 03 June 2020, 08:33:15 UTC | [CMake][Exp PyROOT] Fix Python variables in root-config output | 05 June 2020, 07:32:42 UTC |
| 3204387 | Enrico Guiraud | 04 June 2020, 13:03:00 UTC | [DF] Fix diagnostic of sparse/contiguous storage in TTreeReaderArray | 05 June 2020, 07:15:06 UTC |
| 1ee0125 | Sergey Linev | 04 June 2020, 17:30:06 UTC | Fix circular includes Rtypes.h/TGenericClassInfo.h [ROOT-10820] Make possible to include TGenericClassInfo.h directly Co-authored-by: Philippe Canal <pcanal@fnal.gov> | 05 June 2020, 05:32:25 UTC |
| b6da19f | Enric Tejedor Saavedra | 03 June 2020, 14:29:11 UTC | [PyROOT] Add check for deprecated pyroot_experimental option | 04 June 2020, 16:24:56 UTC |
| c031975 | Enric Tejedor Saavedra | 03 June 2020, 10:32:23 UTC | [PyROOT] Remove pyroot_experimental flag, create pyroot_legacy | 04 June 2020, 16:24:56 UTC |
| 539eada | Stephan Hageboeck | 03 June 2020, 07:14:41 UTC | [RF] Fix pickling of RooTreeDataStore. [ROOT-10810] When RooTreeDataStore is streamed without a TFile (happens when pickling), there's no parent directory. It was assumed, however, that such a parent always exists. Here, this assumption is removed, and the default streaming behaviour is restored if the parent is not a TDirectory. (cherry picked from commit ff14b62014507f7bd944ef57ca52f4cad486a17f) | 04 June 2020, 08:26:54 UTC |
| 617a975 | Massimiliano Galli | 02 June 2020, 12:41:12 UTC | [CMake][Exp PyROOT] Remove subdirectories remnants | 04 June 2020, 07:50:08 UTC |
| 05f8e32 | Massimiliano Galli | 22 May 2020, 10:58:25 UTC | [Exp PyROOT] Raise detailed error when Python version is different from the one used to build libcppyy Suggested by Chris Burr | 04 June 2020, 07:22:18 UTC |
| f597803 | Enric Tejedor Saavedra | 02 June 2020, 16:30:55 UTC | [Exp PyROOT][Release notes] Mention PythonX_EXECUTABLE as a hinting mechanism | 02 June 2020, 16:35:35 UTC |
| 7cf974d | Enric Tejedor Saavedra | 28 May 2020, 13:38:49 UTC | [Exp PyROOT][Release notes] Add PyROOT section | 02 June 2020, 16:35:35 UTC |
| 4bcd9b6 | Enric Tejedor Saavedra | 28 May 2020, 13:38:04 UTC | [Exp PyROOT][Release notes] Add Multi-Python builds section | 02 June 2020, 16:35:35 UTC |
| c100d61 | Enrico Guiraud | 18 May 2020, 16:37:01 UTC | [TTreeProcessorMT] Fix wrong entries silently loaded for TChain+TEntryList Before this patch, TTreeProcessorMT+TChain+TEntryList could end up reading the wrong entries, because entries in sub-entrylists were treated as global entry numbers rather than TTree-local entry numbers. Now, in the presence of a TEntryList, cluster ranges are converted to the appropriate ranges of TEntryList entries, to play nice with TTreeReader::SetEntriesRange. This fixes ROOT-10753 for what concerns TTreeProcessorMT. | 31 May 2020, 16:37:36 UTC |
| 416418e | Enrico Guiraud | 18 May 2020, 12:05:53 UTC | [NFC] Update copyright year in TTreeProcessorMT.cxx | 31 May 2020, 16:37:36 UTC |
| e104ad2 | Enrico Guiraud | 19 May 2020, 14:24:31 UTC | [NFC][TTreeReader] Fix misleading indentation | 31 May 2020, 16:37:36 UTC |
| f1153cc | Enrico Guiraud | 19 May 2020, 12:28:22 UTC | [NFC][TTreeReader] Document TTreeReader's support of TEntryLists ...and related caveats. | 31 May 2020, 16:37:36 UTC |
| 1319425 | Enrico Guiraud | 15 May 2020, 15:50:29 UTC | [TTreeReader] Fix treatment of TEntryLists with sub-entrylists Before this patch, TTreeReader always considered entry numbers returned by TEntryLists as global entry numbers. In the case of a TChain+TEntryList with sub-entrylists, what are returned are actually local entry numbers. This fixes ROOT-10753 for what concerns TTreeReader. | 31 May 2020, 16:37:36 UTC |
| 2cb5781 | Enrico Guiraud | 15 May 2020, 15:46:17 UTC | [TTreeReader] Error out in case of TTree+TEntryList with sublists | 31 May 2020, 16:37:36 UTC |
| 8721a6f | Enrico Guiraud | 14 May 2020, 17:51:14 UTC | [TTreeReader] Add thorough testing of TEntryList support * test TTreeReader+TChain+TEntryLists * test TTreeReader+TTree+TEntryList+SetEntriesRange * test TTreeReader+TChain+TEntryList+SetEntriesRange In particular, we now test for ROOT-10753. | 31 May 2020, 16:37:36 UTC |
| 5b706a5 | Enrico Guiraud | 18 May 2020, 10:27:11 UTC | [DF] Work around ROOT-10775 in dataframe_entrylist.cxx | 31 May 2020, 16:37:36 UTC |
| 6e85a59 | Enrico Guiraud | 18 May 2020, 10:17:06 UTC | [DF] Add a sanity check to dataframe_entrylist test | 31 May 2020, 16:37:36 UTC |
| 2232b95 | Enrico Guiraud | 14 May 2020, 21:22:34 UTC | [DF] Check for ROOT-10753 in RDF+TEntryList tests Since all trees had identical entries, we missed that issue with TTreeReader+TEntryLists before, as well as issues in TTreeProcessorMT. The new test is more thorough. | 31 May 2020, 16:37:36 UTC |
| 4a94fc6 | Sergey Linev | 29 May 2020, 12:37:00 UTC | add missing includes in RootShower test | 29 May 2020, 16:33:37 UTC |
| 970802f | Stephan Hageboeck | 29 May 2020, 09:14:26 UTC | [RF] Accelerate finding of data in RooWorkspace. Switch on hash-assisted finding in workspaces with 50 or more datasets. | 29 May 2020, 14:23:13 UTC |
| 07830df | Stephan Hageboeck | 27 May 2020, 16:37:27 UTC | [RF][Docs] Clarify docs of RooAbsCollection::snapshot. (cherry picked from commit 1895f753a1b7d55f89f3a1ed148f0526125970ce) | 29 May 2020, 14:23:13 UTC |
| 17c9202 | Stephan Hageboeck | 27 May 2020, 16:33:39 UTC | [RF] Fix a double delete in RooFFTConvPdf. RooFFTConvPdf was double-deleting an element. This never caused any problems so far, but after implementing hash lookup in RooAbsCollection, the double delete started showing. (cherry picked from commit 7739053625e6c780ea5f344d27f85276ce876e89) | 29 May 2020, 14:23:13 UTC |
| a14c52d | Stephan Hageboeck | 27 May 2020, 14:04:26 UTC | [RF] Make use of hash-map assisted finding in a few classes. RooWorkspace, RooCustomizer and RooSimPdfBuilder now automatically switch on hash-map assisted finding in RooAbsCollection, as they regularly have to find elements instead of iterate. (cherry picked from commit 06702a73b21188f0c35c2e2bd66591a3adc068a1) | 29 May 2020, 14:23:13 UTC |
| 1920793 | Stephan Hageboeck | 26 May 2020, 17:10:20 UTC | [RF] Disable adding of RooDirItems to ROOT's memory-resident directory. Some old RooFit objects add themselves to ROOT's "/" directory. They are not associated to files, but RecursiveRemove still takes considerable time when large workspaces are created. Now, adding to a directory only has an effect when objects are added to directories *other than* "/". (cherry picked from commit 6cd628ff9dda875d0f97e2ed3504626705e7a409) | 29 May 2020, 14:23:13 UTC |
| 86302b5 | Stephan Hageboeck | 26 May 2020, 17:09:08 UTC | [RF] Modernise RooWorkspace::import(). Mostly replace old-style loops by range-based for loops, since this function is critical for building very large workspaces. (cherry picked from commit ee665884cd4feac472fa987277a568128d385d18) | 29 May 2020, 14:23:13 UTC |
| cbf19a9 | Stephan Hageboeck | 26 May 2020, 17:06:42 UTC | [RF] Add an unordered_map to RooAbsCollection for fast finding. When very large expression trees are imported into a RooWorkspace, long vectors of elements have to be searched for names of objects. That's a blocker for things like Higgs combination. So in case heavy finds are necessary, an unordered_map is created to side-track the linear find. This doesn't impact normal workflows that onlye iterate, since the hash-assisted finding is only active when find() is called on larger collections. (cherry picked from commit f10d93160b1c6a429418704d81e6a6e42874aa8c) | 29 May 2020, 14:23:13 UTC |
| f052a5f | Stephan Hageboeck | 26 May 2020, 16:14:24 UTC | [RF] Remove one unnecessary loop in RooHistFunc. (cherry picked from commit 604518c99bb83eba4dd120cd7305ca8ce52abb36) | 29 May 2020, 14:23:13 UTC |
| c6d9031 | Stephan Hageboeck | 26 May 2020, 16:15:38 UTC | [RF][NFC] Fix indentation in RooHistFunc. (cherry picked from commit f49d3b20114a6ea27a5406afba6253b6eb7227c9) | 29 May 2020, 14:23:13 UTC |
| 6f0d307 | Stephan Hageboeck | 26 May 2020, 14:43:17 UTC | [RF][NFC] Fix indentation of RooAbsArg::redirectServers(). (cherry picked from commit 30deb9e7bc90df9fcae95e41cba54a4785ec2784) | 29 May 2020, 14:23:13 UTC |
| 6a97797 | Stephan Hageboeck | 26 May 2020, 14:22:02 UTC | [RF][NFC] Fix indentation in RooWorkspace::import. (cherry picked from commit 25e07f612c2553d57ea57950321b4416b925d29b) | 29 May 2020, 14:23:13 UTC |
| 4549fd7 | Axel Naumann | 28 May 2020, 19:46:14 UTC | [cling] Flag an error-Transaction as kRolledBack (ROOT-10798): Even for the ErrorOut case the Transaction should be flagged as beyond kCompleted, to prevent it from being asserted on as "we have transaction without errors that was not committed" in ~IncrementalParser(). (cherry picked from commit 43ee232163d3cbc8d9b8a6d83501a82469009759) | 29 May 2020, 13:29:39 UTC |
| 02fdc06 | Vassil Vassilev | 29 May 2020, 10:23:43 UTC | [ROOT-10791][dyld] Do not try to compare two realpaths. This conservative assert intended to capture future uses of the shouldPermanentlyIgnore routine and check if we have specified an absolute non-symlinked path. Turns out that when we scan for libraries we iterate a given folder which may move files around. Then the iterable (official) filename's real path might differ at the point of iteration and the point of the check. Some file systems use a temporary filename while copying/moving file and the rename it to the real filename preserving atomicity of the operations. It looks like this exactly happens in the description of ROOT-10791 -- the iterator gives the expected real path of the filename which is not yet available when we ask for the real path of that path we get something different (using the same inode) eg: `mathsymb.ps` vs `mathsymb.ps_tmp_4810`. Instead of asserting, let the file system handles this instead. Kudos to Philippe Canal for investigating this sporadic failure. | 29 May 2020, 12:57:37 UTC |
| 3dfd4d2 | Sergey Linev | 29 May 2020, 11:06:41 UTC | update relase notes about source build | 29 May 2020, 11:14:30 UTC |
| db788f8 | Oksana Shadura | 29 May 2020, 08:01:44 UTC | :Add O.Shadura release notes (build system) | 29 May 2020, 10:09:03 UTC |
| 1a447e8 | Enrico Guiraud | 25 May 2020, 11:04:17 UTC | [DF] Fix type inference of TClonesArrays branches `TBranch::GetMother` might return the branch itself. In those cases, the logic we used to extract the name of the type stored in the branch returned the wrong type. This fixes part of ROOT-10792, specifically `Snapshot(..., {"tclonesarraybranch"})`. | 28 May 2020, 16:58:44 UTC |
| 2254e48 | Enrico Guiraud | 25 May 2020, 10:56:26 UTC | [DF] Fix treatment of TClonesArrays read as RVecs in Snapshot When a Snapshot of a TClonesArray branch that has been read as an RVec is performed (e.g. with `Snapshot<RVec<T>>(..., {"tclonesarraybranch"})`) we used to mis-diagnose that case and write the branch out as if it was a C-array, resulting in only the first leaf being written to disk. With this patch, we instead print a useful error message suggesting to use `Snapshot<TClonesArray>` instead, and then try to write out the RVec<T> as a std::vector<T>. The downside is that users might not have a dictionary for std::vector<T> and the fallback will fail. However, we do not have a proper TClonesArray object to fill the branch with, so this might be the best we can do in this case. This fixes part of ROOT-10792. | 28 May 2020, 16:58:44 UTC |
