https://github.com/SoftwareHeritage/swh-storage

sort by:
Revision Author Date Message Commit Date
9562953 Add function storage.algos.directory.directory_get It will be used i swh-storage to fetch a complete directory object, ie. with the raw_manifest and all branches. 02 May 2022, 10:26:23 UTC
fb55141 client: Migrate to _post method call to stop deprecation warnings 28 April 2022, 10:23:22 UTC
a942679 Bump mypy to v0.942 26 April 2022, 11:06:14 UTC
e6e658e pre-commit: Remove codespell commit-msg hook That hook can be frustrating as it can discard a long commit message if it finds a typo in it so better removing it. 21 April 2022, 11:39:50 UTC
f136559 User logger everywhere in tenacious.py 14 April 2022, 10:13:58 UTC
bbb4fc1 retry: re-raise original exception instead of a RetryError This will make the sentry reports more usable. If the exception changes across calls, the earlier exceptions are still logged and available as breadcrumbs. 13 April 2022, 13:37:57 UTC
75aa073 postgresql: ensure origin_visit(_status) queries use index When using an inner join for the single origin value, instead of a subquery, the query fails to use the (origin, visit) indexes and falls back to fetching all the visits (or all the statuses) for the origin and sorting them. This breaks down for origins with a lot of visits, such as the ones that are being used for end to end monitoring. Using a subselect to generate a single origin id value ensures that the queries can use the proper indexes. 12 April 2022, 12:21:50 UTC
035d4c1 origin_get_with_statuses: Rename RPC endpoint path Align RPC endpoint path with method name. 12 April 2022, 10:15:52 UTC
d255fb3 origin_get_with_statuses: Fix case when fetched visits list is empty Ensure to return an empty list of results when fetched visits list is empty, for instance when the provided page_token is greater or equal to latest origin visit. Related to T4090 12 April 2022, 10:06:28 UTC
7c9586a Add .git-blame-ignore-revs file with automatic reformatting commits 08 April 2022, 13:15:36 UTC
b146bb7 python: Reformat code with black 22.3.0 Related to T3922 08 April 2022, 13:15:09 UTC
93aecb6 pre-commit, tox: Bump black from 19.10b0 to 22.3.0 black is considered stable since release 22.1.0 and the version we are currently using is quite outdated and not compatible with click 8.1.0, so it is time to bump it to its latest stable release. Please note that E501 pycodestyle warning related to line length is replaced by B950 one from flake8-bugbear as recommended by black. https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length Related to T3922 08 April 2022, 13:13:51 UTC
567c8e4 interface: Add new method origin_visit_get_with_statuses It enables to retrieve in an efficient and paginated way the list of visits and all their statuses for a given origin. Previously, it was required to call origin_visit_status_get on each visit of the origin to get such list. Related to T4090 07 April 2022, 14:47:06 UTC
812590c requirements-test: Remove pytest pinning to < 7 pytest-postgresql 3.1.3 and pytest-redis 2.4.0 added support for pytest >= 7 so we can now drop the pytest pinning. 06 April 2022, 15:14:53 UTC
c6dc5cd Make postgresql's Storage client options configurable from config Adding a `query_options` member to postgresql's Storage, in conjunction with swh.core >= 2.5, allows to set/overwrite SQL client options from the storage configuration file. Default values are set, as they used to be, from the decorator arguments. But in addition to this, one can overload these value at run time from the storage configuration file. For example: .. code-block:: yaml storage: cls: postgresql db: testdb objstorage: cls: memory query_options: directory_ls: statement_timeout: 180000 will provide a Storage instance for which the timeout value for the `directory_ls` endpoint is 3mn (instead of the default 20s). 04 April 2022, 14:43:17 UTC
835feb6 Fix tenacious storage tests for swh.model 6 The logic for testing the tenacious storage proxy by interspersing bad objects with good ones triggers when the object list is larger than 3 items. However, the allowed error rate of 1 failure for a window of 3 objects would only work for lists larger than six objects (putting at least 2 good objects between each bad object). swh.model 6 made the directory, revision and release test object lists 3 object long, triggering the buggy code. Reducing the window size to 2 objects makes the test logic works for lists of 3 or more objects. 23 March 2022, 15:34:50 UTC
6fdaf8a Remove typing workarounds for Revision.author or Revision.committer being None swh-model 6.0.0 adds proper support for them. + fix issue found by mypy 23 March 2022, 10:01:34 UTC
3eff720 Add support for author=None and committer=None committer=None happens on some malformed commits generated by old dgit version; and it is possible for author=None to happen for the same reason. For now, this is not supported by swh-model, so tests temporarily disable attrs checks that swh-model relies on. 23 March 2022, 10:00:22 UTC
92c78ab pytest: Exclude build directory for tests discovery Due to test modules being copied in subdirectories of the build directory by setuptools, it makes pytest fail by raising ImportPathMismatchError exceptions when invoked from root directory of the module. So ignore the build folder to discover tests. 22 March 2022, 10:58:26 UTC
98b41c8 backfill: Add missing raw_manifest to directories This was not covered by tests so far, because swh.model.tests.swh_model_data.TEST_OBJECTS did not contain any object with a raw_manifest. But it will in swh-model > 5.0.0 16 March 2022, 11:24:46 UTC
8b65e42 backfill: Make integer_ranges() work on str args + add typing to RANGE_GENERATORS Without the type annotation, mypy errors with 'Cannot call function of unknown type' when called from a type-checked function. 15 March 2022, 16:19:22 UTC
77f7e6d postgresql: Remove unused listener code from db.py 15 March 2022, 12:36:42 UTC
ccde097 origin_visit_get_latest: Order by visit id instead of date This allows both the postgresql and cassandra backends to make efficient queries by using an index (resp. clustering key) instead of scanning all visits of the given origin then sorting by date. This does not affect the results for the last majority of cases, as ids are always in increasing chronological, unless an origin was re-loaded from an old archive. 11 March 2022, 12:43:36 UTC
600e87f origin_visit_get_latest: Materialize subquery on 'origin' table. postgresql's query planner does not understand the origin is unique, so it performs a partial index scan on origin_visit_pkey, which is inefficient on origins with many visits. This commit itself is not enough to make it use the proper index, but provides this necessary change that will be used by a future commit. 11 March 2022, 12:36:07 UTC
b0cdab5 postgresql: Increase timeouts that often fail According to Sentry, in the last 30 days: * directory_entry_get_by_path: 958 events, https://sentry.softwareheritage.org/share/issue/c4c2124953a145b2bd325f6f6b7df5a6/ * revision_get: 841 events, https://sentry.softwareheritage.org/share/issue/55fbe01c6f4d4c9bbf684c7608a62ad9/ * release_get: 14 events, https://sentry.softwareheritage.org/share/issue/37c53354541b4c4eaa1faf4e20a68418/ * origin_visit_find_by_date: 114 events, https://sentry.softwareheritage.org/share/issue/a674c12049a941968a717661a0226559/ * origin_get: 79 events, https://sentry.softwareheritage.org/share/issue/bf21d6bc7b24442eb18643d80d936d27/ ; 67 events, https://sentry.softwareheritage.org/share/issue/010a4b1e085a4e2089ba4897c6de6038/ 11 March 2022, 12:19:28 UTC
4e78014 Remove aiohttp from requirements.txt it's not used by swh.storage. 08 March 2022, 15:29:15 UTC
284a4ab Move metrics handling from backends to RPC server Motivation: replaces code duplication in the backends with a single one, to be consistent with the objstorage (which has many more backends) This also fixes the issue of metrics from 'extid_add' to be missing when using the postgresql storage. 02 March 2022, 11:32:18 UTC
215162b Update for swh.core 2.0.0 - Add expected entry points for swh.core 2 db handling new features: - add a ``swh.storge.get_datastore()`` function - add ``swh.storage.postgreql.storage.Storage.get_current_version()`` method - move sql migration scripts in ``swh/storage/sql/upgrades`` - modify sql initialization scripts to match swh.core 2 (remove dbversion management code). - Update tests to use the new template-based database handling; this should have only minimal impact on test execution performances. 24 February 2022, 10:05:01 UTC
386fb4d Add types-toml to requirements-test.txt 24 February 2022, 10:05:01 UTC
f578377 pre-commit: Bump hooks and add new one to check commit message spelling To install the new hook: $ pre-commit install -t commit-msg 10 February 2022, 16:29:28 UTC
8bf07c3 revision_walker: Actually pass ignore_displaynam to revision_log I somehow forgot to stage this change in the previous commit. 04 February 2022, 15:46:07 UTC
0f9f54b revision_walker: Add support for ignore_displayname. This is needed by the vault. 04 February 2022, 15:14:59 UTC
75a7f09 Add typing to revision_walker.py and make the state a dataclass 04 February 2022, 15:14:53 UTC
a3a63d8 Require pytest to be <7.0.0 04 February 2022, 14:02:23 UTC
4544d7c Introduce a new displayname field for persons in the PostgreSQL storage Extend the APIs for Revisions and Releases to honor the field by default, unless the new `ignore_displayname` argument is set. 01 February 2022, 12:03:52 UTC
97caa93 Make test_release_add_get_arbitrary non-flaky It was made flaky by d4ddd41535d0ce1cd50d51d297e154bf0ab6e649. 01 February 2022, 12:03:52 UTC
f868f3c Mostly use normalized Person objects in tests This opens up the possibility of eventually ignoring the `name` and `email` fields stored in database in favor of parsing them again from the fullname field (and therefore to update our parsing logic without having to affect stored data). 31 January 2022, 20:56:47 UTC
d4ddd41 postgresql: Use Person.from_fullname if name and email are None This allows us to populate sensible name and email values out of the new displayname field, without having to store them. 31 January 2022, 19:12:09 UTC
6f02524 Fix directory_add to actually insert the manifest + add directory_get_raw_manifest I don't expect directory_get_raw_manifest to be used, but it is needed for tests, so why not. 25 January 2022, 09:46:27 UTC
5874905 Stop using the deprecated 'TimestampWithTimezone.offset' attribute It will be replaced by what is currently called 'offset_bytes' 21 January 2022, 14:01:31 UTC
2e74138 Remove 'offset' and 'negative_utc' This only keeps 'offset_bytes' to store the timezone, to support swh-model v5.0.0. However, this keeps writing 'offset' and 'negative_utc' to the postgresql database, just in case we need to roll back this change. But they are not read anymore. 21 January 2022, 13:07:02 UTC
c68a4fd postgres: Add indices to keep track of objects with a raw_manifest They should be a rare occurence, so adding these indices allows us to count and enumerate them without expensive full table scans. 18 January 2022, 10:04:28 UTC
228de33 Fix sphinx error [2022-01-17T16:03:27.448Z] /var/lib/jenkins/workspace/DSTO/tests-on-diff@2/docs/index.rst:25:hardcoded link 'https://archive.softwareheritage.org/api/' could be replaced by an extlink (try using ':swh_web:`api/`' instead) 18 January 2022, 09:16:05 UTC
40a57d4 cassandra: Make content_missing run in linear time instead of quadratic Assuming all contents passed to content_missing() have (at least) a missing algo, the function used to iterate over the size of the arg squared in the worst case (when all contents are found). With this commit, it starts with bucketing them by hash, so it does not need to iterate over *all* found contents for each content passed as arg. 12 January 2022, 10:38:20 UTC
d5f1f0e cassandra: Rewrite content_missing to run queries concurrently. This is twice as fast, according to https://forge.softwareheritage.org/T3577#72791 12 January 2022, 10:37:57 UTC
4a24505 cassandra: Use concurrent queries in *_missing() instead of naive grouping Instead of grouping ids in queries in arbitrary batches (which forces the server node to coordinate with other nodes to complete the query), this sends queries with one id each, directly to the right node. This is the 'concurrent' algorithm from https://forge.softwareheritage.org/T3577#72791 which gives a >=2x speed-up on directories, and a >=8x speed-up on revisions. 06 January 2022, 11:43:09 UTC
259bf6f Improve documentation of the replay command 04 January 2022, 11:02:44 UTC
1071781 Move the 'error_reporter' config entry in a dedicated 'replayer' section 04 January 2022, 11:02:44 UTC
f3232e6 Add columns {,committer_}date_offset to rev/rel and raw_manifest to dir/rev/rel 22 December 2021, 12:29:11 UTC
f09a54d Pin mypy and drop type annotations which makes mypy unhappy This also drops: - spurious copyright headers to those files if present. - fix a type issue revealed by the new mypy Related to T3812 16 December 2021, 15:18:36 UTC
c40ceb3 Add tests checking round-tripping of dir/rev/rel/snp objects generated by Hypothesis 15 December 2021, 12:11:56 UTC
45687d8 Add test_revision_add_fractional_timezone 15 December 2021, 12:11:51 UTC
fb1b3a0 postgresql: Fix one-by-one error in db_to_date on negative dates Using `int()` on `date.timestamp()` rounded it up (toward zero), but the semantics of `model.Timestamp` is that the actual time is `ts.seconds + ts.microseconds/1000000`, so all negative dates were shifted one second up. In particular, this causes dates from `1969-12-31T23:59:59.000001` to `1969-12-31T23:59:59.999999` (inclusive) to smash into dates from `1970-01-01T00:00:00.000001` to `1970-01-01T00:00:00.999999`, which is how I discovered the issue. 13 December 2021, 11:54:35 UTC
34ca67e postgresql: Add tests for db_to_date. 09 December 2021, 15:23:44 UTC
7cb4128 proxies/retry: Remove no longer needed tenacity workarounds Now that we have packaged tenacity 6.2 for debian buster and use it in production, we can remove the workarounds to support tenacity < 5. 08 December 2021, 11:09:15 UTC
615fb99 test_cassandra: Fix failing tests since swh-model update Directory entries are now checked for name duplicates in swh-model so we must ensure the CrashyEntry class is properly initialized. Closes T3776 07 December 2021, 12:36:43 UTC
850a755 Add support for a redis-based reporting for invalid mirrorred objects The idea is that we check the BaseModel validity at journal deserialization time so that we still have access to the raw object from kafka for complete reporting (object id plus raw message from kafka). This uses a new ModelObjectDeserializer class that is responsible for deserializing the kafka message (still using kafka_to_value) then immediately create the BaseModel object from that dict. Its `convert` method is then passed as `value_deserializer` argument of the `JournalClient`. Then, for each deserialized object from kafka, if it's a HashableObject, check its validity by comparing the computed hash with its id. If it's invalid, report the error in logs, and if configured, register the invalid object in via the `reporter` callback. In the cli code, a `Redis.set()` is used a such a callback (if configured). So it simply stores invalid objects using the object id a key (typically its swhid), and the raw kafka message value as value. Related to T3693. 09 November 2021, 15:36:34 UTC
04bd15a Refactor fixer.fix_objects() to extract the inner object_fixers dict allowing to use this dict independently of the fix_objects() function. 09 November 2021, 15:36:34 UTC
d655c85 Remove now useless fixers keep the the fix_objects() function for bw compat for now. 09 November 2021, 15:36:34 UTC
55eed77 Add a --type option to 'swh storage replay' allows to choose replayed object types from the cli. 09 November 2021, 15:36:34 UTC
0262f1c Update extrinsic-metadata-specification.rst to match the current implementation * merged origin and artifact metadata * added metametadata * uses structures instead of dict * removed raw_extrinsic_metadata_get_latest 09 November 2021, 14:47:31 UTC
a5bfe5b interface: Add origin_snapshot_get_all method It enables to return in an efficient way the list of unique snapshot identifiers resulting from the visits of an origin. Previously it was required to query all visits of an origin then query all visit statuses for each visit to extract such information. Introduced method enables to extract origin snaphots information in a single datase query. Related to T3631 28 October 2021, 12:23:14 UTC
49a932c algos/revisions_walker: Handle case of revision without committer date Some revisions in the archive do not have committer date so workaround it to avoid errors when walking on such revisions when using the class CommitterDateRevisionsWalker. 22 October 2021, 09:32:28 UTC
c02be8e test_revisions_walker: Migrate from unittest to pytest 21 October 2021, 14:50:57 UTC
a986710 cassandra: Fix incomplete check of content existence in object_find_by_sha1_git content_missing_by_sha1_git only checks the index and not the main table. This is incorrect, because contents should not be considered written before an entry is written to the main table, even if an entry exists in one of the indexes. 18 October 2021, 11:10:54 UTC
e9fd74d serializers: Prepare rename of 'identifiers_enum' to 'swhids_enum'. This will be done in three steps to avoid any disruption: 1. (this step) add support for decoding the new name, but keep encoding as the old one 2. start encoding as the new name 3. remove support for decoding the old name 11 October 2021, 11:58:23 UTC
ea86a86 Rename imports of swh.model.identifiers to fix deprecation warnings. 11 October 2021, 11:58:23 UTC
3441f68 buffer: add some debug logging for number of objects sent 08 October 2021, 14:53:27 UTC
b604014 buffer: add a threshold for the estimated size of revision and release batches The size of individual revisions and releases is essentially unbounded. This means that, when the buffer storage is used as a way of limiting memory use for an ingestion process, it is still possible to go beyond the expected memory use when adding a batch of revisions or releases with large messages or other metadata. The duration of the database operations for revision_add or release_add is also commensurate to the size of the objects added in a batch, so using the buffer proxy to limit the time individual database operations takes was not effective. Adding a threshold on estimated sizes for batches of revision and release objects makes this overuse of memory and of database transaction time much less likely. 08 October 2021, 14:53:27 UTC
7c5b0ec buffer: add a threshold for the number of revision parents in one batch The size of individual revisions is essentially unbounded. This means that, when the buffer storage is used as a way of limiting memory use for an ingestion process, it is still possible to go beyond the expected memory use when adding a batch of revisions with extensive histories. The duration of the database operation for revision_add is also commensurate to the number of revision parents added in a batch, so using the buffer proxy to limit the time individual database operations takes was not effective. Adding a threshold on cumulated number of revision parents per batch makes this overuse of memory and of database transaction time much less likely. 08 October 2021, 13:42:35 UTC
5edc0ba buffer: add a threshold for the number of directory entries in one batch The size of individual directories is essentially unbounded. This means that, when the buffer storage is used as a way of limiting memory use for an ingestion process, it is still possible to go beyond the expected memory use when adding a batch of (very) large directories. The duration of the database operation for directory_add is also commensurate to the number of directory entries added in a batch, so using the buffer proxy to limit the time individual database operations takes was not effective. Adding a threshold on cumulated number of directory entries per batch makes this overuse of memory and of database transaction time much less likely. 08 October 2021, 13:13:05 UTC
abe95b3 filter: add filtering for release_add 08 October 2021, 12:11:32 UTC
c52b7b6 filter: do not call the underlying functions if there's nothing to add 08 October 2021, 10:20:22 UTC
5d5d4c9 buffer: Ensure that we don't send data from empty buffers This was already the case (as grouper called on an empty iterator just returns no batches), but add a test to enforce it. 08 October 2021, 09:45:25 UTC
113088a replay: add type annotation for process_replay_objects() 29 September 2021, 09:01:57 UTC
9a3589f replay: fix raw_extrinsic_metadata insertion and type annotation due to missing type annotation of the storage argument of _insert_objects(), we missed a bug in the processing of raw_extrinsic_metadata objects, passing set() as arguments of storage add methods. 29 September 2021, 08:48:13 UTC
21aff2d replay: fix annotation of collision_aware_content_add() now the callable is expected to return a dict. 29 September 2021, 08:48:13 UTC
8ba232c Fix support of swh-model 3.0.0 28 September 2021, 15:59:20 UTC
42bad90 postgresql: Don't raise StorageArgumentException in case of write conflicts 27 September 2021, 13:30:14 UTC
ec548ee Add bazaar as supported revision type This has a corresponding change in swh.model 23 September 2021, 08:55:35 UTC
61e9e4a cassandra: Make _content_get_from_hashes run concurrently This is used by directory_ls and content_get. 21 September 2021, 16:14:28 UTC
59e63db postgresql: Fix regression introduced in previous commit Methods snapshot_get and snapshot_get_branches should return None if the snapshot does not exist in the archive. Add missing tests to cover that case. 21 September 2021, 10:25:42 UTC
9465054 postgresql: Fix get_snapshot_branches return value for empty search When searching for branches in an existing snapshot, a PartialBranches object must be returned regardless the number of found branches. None should only be returned when a snapshot does not exist. This fixes an inconsistency between the postgresql and cassandra backends. Related to T3413 16 September 2021, 12:09:36 UTC
a9fde72 Allow filtering extids per extid_version/extid_type when reading This impacts both the `extid_get_from_extid` and `extid_get_from_target` endpoints. Whe extid_version/extid_type are not provided, this keeps the existing behavior of returning all extids matching. Related to T3567 15 September 2021, 16:34:59 UTC
589d20e migrate_extrinsic_metadata: Fix missing f-stringification 14 September 2021, 09:15:41 UTC
1c8337f migrate_extrinsic_metadata: Fix crash on deposit hal-02355563 10 September 2021, 17:25:51 UTC
3315738 migrate_extrinsic_metadata: Fix remaining pypi issues All packages now pass 10 September 2021, 17:25:03 UTC
8e94afa migrate_extrinsic_metadata: Fix off-by-one error, causing the first_id to be skipped 10 September 2021, 16:17:56 UTC
5facf66 cassandra: Make directory_ls fetch contents in batch instead of one-by-one This should make it run up to 100 times faster, even on average directories. 09 September 2021, 13:45:30 UTC
0570a42 content_get: Fetch rows concurrently Instead of fetching them one-by-one, with the very high latency this entails. This is preliminary work to make `directory_ls` less painfully slow. 09 September 2021, 13:43:42 UTC
50fb54f directory_entry_add_batch: Remove the temporary prepared statement entirely And fall back to concurrent insertion. 09 September 2021, 09:35:22 UTC
da7e63e directory_entry_add_batch: Reduce churn of prepared statements By reusing the 'steady state' main statement (which is quite large) across calls. 08 September 2021, 09:56:49 UTC
fc950de cassandra: Add option to select (hopefully) more efficient batch insertion algos This adds a new config option for the cassandra backend, 'directory_entries_insert_algo', with three possible values: * 'one-per-one' is the default, and preserves the current naive behavior * 'concurrent' and 'batch' are attempts at being more efficient 08 September 2021, 09:54:57 UTC
7dc2863 migrate_extrinsic_metadata: Add an option to limit the number of revisions This will be used as a second pass on objects that failed with older versions of the script. 06 September 2021, 12:45:40 UTC
834a49d test_directory_get_entries_pagination: don't depend on result order 03 September 2021, 12:56:15 UTC
e8aad0f cassandra: Remove stat_counters. They were inaccurate and a performance bottleneck. We can/should use swh-counters instead, now. 31 August 2021, 08:41:48 UTC
3ad1bec postgresql: Fix a column order mismatch between the query and object builder resulting in OriginVisitStatus trying to put a snapshot id in the metadata field Related to T3539 30 August 2021, 15:39:42 UTC
999ea6b cassandra: generate statsd metrics on method calls Related to T3517 30 August 2021, 15:25:59 UTC
47a6919 Add counting storage proxy It will be used in the Cassandra experiment. Currently we use the built-in counters of the Cassandra backend; but in addition to being inaccurate, they seem to be a bottleneck. This proxy will be a lightweight solution for counting object insertion, without needing to run Kafka on the test cluster. 27 August 2021, 11:31:37 UTC
b110d1b Add cvs as supported revision_type 24 August 2021, 14:39:03 UTC
back to top