Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
7b85a4d dario-piotrowicz 12 June 2021, 09:28:06 UTC fix(docs-infra): add horizontal margins to nav menu (#42561) add a 2px left and right margin to the aio-nav-menu to make sure that the items outline doesn't get cropped PR Close #42561 16 June 2021, 21:02:53 UTC
40612d1 dario-piotrowicz 11 June 2021, 21:23:24 UTC fix(docs-infra): fix width of sidenav icons (#42561) make sure that the width of the sidenav chervon icon is 2.4rem (this needs to be done using the flex property and not the width one as that can change in flex containers) also center chevron icon inside mat-icon container in order to maintain the correct icon positioning at any font-size PR Close #42561 16 June 2021, 21:02:53 UTC
91e307b dario-piotrowicz 11 June 2021, 20:37:42 UTC fix(docs-infra): prevent vertical nav item overflowing (#42561) prevent the overflowing unwanted effect that happens during a nav item opening and closing (during the chevron rotation) PR Close #42561 16 June 2021, 21:02:53 UTC
3b81528 Dario Piotrowicz 09 June 2021, 17:32:41 UTC fix(docs-infra): improve card layout for different browser font sizes (#42533) Remove the fixed height set on the card elements present in angular.io, allowing the cards to have a dynamic height derived from their content and thus removing overflow issues related to the browser's font-size, make other minor css related adjustments to allow the card to look good on the different browser's font-size settings PR Close #42533 16 June 2021, 21:02:24 UTC
f3a7987 Marius Bethge 04 June 2021, 14:10:18 UTC docs(forms): correct sample code for FormArray.reset (#42477) Remove unexpected this, correct output comment for arr.value and correct parameter type for FormArray.get(). PR Close #42477 16 June 2021, 21:01:55 UTC
62aca30 Pete Bacon Darwin 21 March 2021, 11:07:34 UTC feat(docs-infra): add support for "special elements" (#41299) This commit adds support for generating pages that document special Angular elements, such as `ng-content` and `ng-template`, which have special behavior in Angular but are not directives nor components. Resolves #41273 PR Close #41299 16 June 2021, 21:01:16 UTC
2d1347b Alex Rickabaugh 16 June 2021, 16:24:58 UTC Revert "refactor: remove checked-in locale files (#42230)" (#42583) This reverts commit 5822771946d6c72f8b4daa8959da368effe86d37. PR Close #42583 16 June 2021, 16:49:38 UTC
ec6dc78 Alex Rickabaugh 16 June 2021, 16:24:56 UTC Revert "build: convert CLDR locale extraction from Gulp to Bazel tool (#42230)" (#42583) This reverts commit 1eaeb23c753069ea9dca0aaaa40bf2fe4f618727. PR Close #42583 16 June 2021, 16:49:37 UTC
877cde8 Alex Rickabaugh 16 June 2021, 16:24:55 UTC Revert "build: wire up new CLDR generation tool within Bazel (#42230)" (#42583) This reverts commit 4957da82d3d9622bc692be1baa62039467a33d81. PR Close #42583 16 June 2021, 16:49:37 UTC
bf0e82c Alex Rickabaugh 16 June 2021, 16:24:54 UTC Revert "build: build locale files for legacy saucelabs job (#42230)" (#42583) This reverts commit c42041b4198ac0660f64235bf2dc95d166e1962f. PR Close #42583 16 June 2021, 16:49:37 UTC
76484f9 Alex Rickabaugh 16 June 2021, 16:24:53 UTC Revert "build: add documentation for `generate-locales-tool` (#42230)" (#42583) This reverts commit d4c880b467fb056791c8bed7cb8d6b235bc86590. PR Close #42583 16 June 2021, 16:49:37 UTC
2cd1c6c Alex Rickabaugh 16 June 2021, 16:24:52 UTC Revert "build: simplify generation of closure locale file (#42230)" (#42583) This reverts commit 8f24d71142ef7443eeb6614bfda5db3415a43c8b. PR Close #42583 16 June 2021, 16:49:37 UTC
d6cca3c Alex Rickabaugh 16 June 2021, 16:23:47 UTC Revert "build: generate alias locale data for closure locale (#42230)" (#42583) This reverts commit 044e0229bde8edb86e0d9e318bc358299ea6f814. PR Close #42583 16 June 2021, 16:49:37 UTC
b52e935 Daniel Trevino 14 June 2021, 21:53:25 UTC docs: add Daniel Trevino to contributors file (#42573) PR Close #42573 15 June 2021, 19:53:09 UTC
a66dd88 Kristiyan Kostadinov 13 June 2021, 09:05:00 UTC build: remove unnecessary polyfills from tests (#42567) Removes the polyfills for `MutationObserver` and `setPrototypeOf` from our testing setup, because none of the browsers that we support require them. It also removes a bit of code and one external dependency. PR Close #42567 14 June 2021, 21:14:41 UTC
4001e9d Andrew Scott 11 June 2021, 20:05:42 UTC fix(language-service): 'go to defininition' for objects defined in template (#42559) Previously, the "go to definition" action did no account for the possibility that something may actually be defined in a template. This change updates the logic in the definition builder to convert any results that are locations in template typecheck files to their corresponding locations in the template. PR Close #42559 14 June 2021, 21:13:48 UTC
228beea Andrew Scott 10 June 2021, 22:59:44 UTC fix(language-service): Use last child end span for parent without close tag (#42554) Unclosed element tags are not assigned an `endSourceSpan` by the parser. As a result, the visitor which determines the target node at a position for the language service was unable to determine that a given position was inside an unclosed parent. This happens because we update the `endSourceSpan` of template/element nodes to be the end tag (and there is not one for unclosed tags). Consequently, the visitor then cannot match a position to any child node location. This change updates the visitor logic to check if there are any `children` of a template/element node and updates the end span to be the end span of the last child. This allows our `isWithin` logic to identify that a child position is within the unclosed parent. Addresses one of the issues found during investigation of https://github.com/angular/vscode-ng-language-service/issues/1399 PR Close #42554 14 June 2021, 21:10:46 UTC
8c1e0e6 Andrew Scott 10 June 2021, 22:57:43 UTC fix(compiler): always match close tag to the nearest open element (#42554) This commit updates the parser logic to continue to try to match an end tag to an unclosed open tag on the stack. Previously, it would only push an error to the list and stop looking at unclosed elements. For example, the invalid HTML of `<li><div></li>`, has an unclosed element stack of [`li`, `div`] when it encounters the close `li` tag. We compare against the previously unclosed tag `div` and see that this is unexpected. Instead of simply giving up here, we continue to move up the unclosed tags until we find a match (if there is one). PR Close #42554 14 June 2021, 21:10:46 UTC
044e022 Paul Gschwendtner 10 June 2021, 18:56:25 UTC build: generate alias locale data for closure locale (#42230) Within Google, closure compiler is used for dealing with translations. We generate a closure-compatible locale file that allows for registration within Angular, so that Closure i18n works well together with Angular applications. Closure compiler does not limit its locales to BCP47-canonical locale identifiers. This commit updates the generation logic so that we also support deprecated (but aliased) locale identifiers, or other aliases which are likely used within Closure. We use CLDR's alias supplemental data for this. It instructs us to alias `iw` to `he` for example. `iw` is still supported in Closure. Note that we do not manually extract all locales supported in Closure; instead we only support the CLDR canonical locales (as done before) + common aliases that CLDR provides data for. We are not aware of other locale aliases within Closure that wouldn't be part of the CLDR aliases. If there would be, then Angular/Closure would fail accordingly. PR Close #42230 14 June 2021, 16:59:46 UTC
8f24d71 Paul Gschwendtner 02 June 2021, 13:50:07 UTC build: simplify generation of closure locale file (#42230) In the past, the closure file has been generated so that all individual locale files were imported individually. This resulted in a huge slow-down in g3 due to the large amount of imports. With 90bd984ff74f7605d7c08fd9fdbf610ba7fa67a5 this changed so that we inline the locale data for the g3 closure locale file. Also the file only contained data for locales being supported by Closure. For this a list of locales has been extracted from Closure Compiler, as well as a list of locale aliases. This logic is prone to CLDR version updates, and also broke as part of the Gulp -> Bazel migration where this logic has been slightly modified but caused issues in G3. e.g. a locale `zh-Hant` was requested in g3, but the locale data had the name of the alias locale that provided the data at index zero (which represents the locale name). Note that the locale names at index zero always could differentiate from the requested `goog.LOCALE` due to the aliasing logic. This just didn't come up before. We simplify this logic by generating a `goog.LOCALE` case for all locales CLDR provides data for. We don't need to bother about aliasing because with the refactorings to the CLDR generation tool, all locales are built (which also captures the aliases), and we can generate the locale file on the fly (which has not been done before). PR Close #42230 14 June 2021, 16:59:46 UTC
d4c880b Paul Gschwendtner 25 May 2021, 19:36:07 UTC build: add documentation for `generate-locales-tool` (#42230) The CLDR extraction tool has been reworked to run as part of Bazel. This adds a initial readme explaining what the tool generates. It's far from a detailed description but it can serve as foundation for more detailed explanations. PR Close #42230 14 June 2021, 16:59:46 UTC
c42041b Paul Gschwendtner 22 May 2021, 17:18:31 UTC build: build locale files for legacy saucelabs job (#42230) Given that the locale files are now generated through Bazel, the files are no longer checked-in and the legacy TSC compilation fails due to imports resolving to non-existent files. We fix this for the legacy saucelabs job by copying the generated TS files into the sources (which is acceptable for the isolated CI job) PR Close #42230 14 June 2021, 16:59:46 UTC
4957da8 Paul Gschwendtner 21 May 2021, 20:58:25 UTC build: wire up new CLDR generation tool within Bazel (#42230) Introduces a few Starlark macros for running the new Bazel CLDR generation tool. Wires up the new tool so that locales are generated properly. Also updates the existing `closure-locale` file to match the new output generated by the Bazel tool. This commit also re-adds a few locale files that aren't generated by CLDR 37, but have been accidentally left in the repository as the Gulp script never removed old locales from previous CLDR versions. This problem is solved with the Bazel generation of locale files, but for now we re-add these old CLDR 33 locale files to not break developers relying on these (even though the locale data indicies are incorrect; but there might be users accessing the data directly) PR Close #42230 14 June 2021, 16:59:46 UTC
1eaeb23 Paul Gschwendtner 21 May 2021, 20:57:42 UTC build: convert CLDR locale extraction from Gulp to Bazel tool (#42230) Converts the CLDR locale extraction script to a Bazel tool. This allows us to generate locale files within Bazel, so that locales don't need to live as sources within the repo. Also it allows us to get rid of the legacy Gulp tooling. The migration of the Gulp script to a Bazel tool involved the following things: 1. Basic conversion of the `extract.js` script to TypeScript. This mostly was about adding explicit types. e.g. adding `locale: string` or `localeData: CldrStatic`. 2. Split-up into separate files. Instead of keeping the large `extract.js` file, the tool has been split into separate files. The logic remains the same, just that code is more readable and maintainable. 3. Introduction of a new `index.ts` file that is the entry-point for the Bazel tool. Previously the Gulp tool just generated all locale files, the default locale and base currency files at once. The new entry-point accepts a mode to be passed as first process argument. based on that argument, either locales are generated into a specified directory, or the default locale, base currencies or closure file is generated. This allows us to generate files with a Bazel genrule where we simply run the tool and specify the outputs. Note: It's necessary to have multiple modes because files live in separate locations. e.g. the default locale in `@angular/core`, but the rest in `@angular/common`. 4. Removal of the `cldr-data-downloader` and custom CLDR resolution logic. Within Bazel we cannot run a downloader using network. We switch this to something more Bazel idiomatic with better caching. For this a new repository rule is introduced that downloads the CLDR JSON repository and extracts it. Within that rule we determine the supported locales so that they can be used to pre-declare outputs (for the locales) within Bazel analysis phase. This allows us to add the generated locale files to a `ts_library` (which we want to have for better testing, and consistent JS transpilation). Note that the removal of `cldr-data-downloader` also requires us to add logic for detecting locales without data. The CLDR data downloader overwrote the `availableLocales.json` file with a file that only lists locales that CLDR provides data for. We use the official `availableLocales` file CLDR provides, but filter out locales for which no data is available. This is needed until we update to CLDR 39 where data is available for all such locales listed in `availableLocales.json`. PR Close #42230 14 June 2021, 16:59:46 UTC
5822771 Paul Gschwendtner 21 May 2021, 20:52:45 UTC refactor: remove checked-in locale files (#42230) This is a pre-refactor commit allowing us to move the CLDR locale generation to Bazel where files would no longer be checked-in, except for the `closure-locale` file that is synced into Google3. PR Close #42230 14 June 2021, 16:59:46 UTC
e7c69b8 Ankit Choudhary 14 June 2021, 13:36:02 UTC docs: Grammatical error (#42571) Updated a minor grammatical error. PR Close #42571 14 June 2021, 16:59:14 UTC
7180ec9 Dylan Hunn 10 June 2021, 21:41:29 UTC fix(forms): changes to status not always being emitted to statusChanges observable for async validators. (#42553) When a FormControl, FormArray, or FormGroup is first constructed, if an async validator is attached, the `statusChanges` observable should receive a message when the validator complete (i.e. pending -> valid/invalid). If the validator was provided as part of the constructor options, it was not fired at construction time, which is fixed in this PR. Fixes #35309. PR Close #42553 14 June 2021, 16:57:57 UTC
56a0582 George Kalpakas 10 June 2021, 12:06:51 UTC fix(docs-infra): correctly serve `index.html` with a query string (#42547) Previously, due to a bug in Firebase hosting, requests to `/index.html?<query>` would lead to an infinite redirect and eventually a failure. This affected, for example, cache-busting requests from the ServiceWorker, which look like: `/index.html?ngsw-cache-bust=...` For more details see https://github.com/angular/angular/issues/42518#issuecomment-858545483 This commit temporarily works around the bug by explicitly redirecting `/index.html?<query>` to `/?<query>`. Fixes #42518 PR Close #42547 14 June 2021, 16:57:30 UTC
828fde6 George Kalpakas 11 June 2021, 17:14:57 UTC feat(docs-infra): implement popup to inform about the use of cookies (#42259) This commit adds a popup to angular.io to inform the user about the use of cookies. Once the user confirms having read the info, the popup will not be shown on subsequent visits. This commit is partly based on angular/material.angular.io#988. Fixes #42209 PR Close #42259 14 June 2021, 16:54:08 UTC
1a6a79b George Kalpakas 11 June 2021, 17:14:34 UTC refactor(docs-infra): provide `local-/sessionStorage` via DI (#42259) Previously, we had the same logic in a couple of places to safely access the `Window`'s `local-/sessionStorage` and provide a no-op fallback if necessary. Soon, we will need the same logic for the cookies popup (see #42209). This commit reduces code duplication by providing `local-/sessionStorage` as injectables and sharing the logic for accessing them safely. This also makes it easier to mock the storage in tests without having to mess with the actual `Window` object. NOTE: This commit actually decreases the payload size in the `main` bundle by 40B. PR Close #42259 14 June 2021, 16:54:08 UTC
a7d1e65 George Kalpakas 11 June 2021, 17:11:38 UTC test(docs-infra): fix warnings in `ThemeToggleComponent` unit tests. (#42259) due to unknown `<mat-icon>` element This commit fixes some warnings in the unit tests of the `ThemeToggleComponent`, which were caused by the following: - The `<mat-icon>` element used in `ToggleThemeComponent`'s template was not declared in tests. - The `dark-theme.css` and `light-theme.css` files requested by `ToggleThemeComponent` were not available. PR Close #42259 14 June 2021, 16:54:08 UTC
edf3e5a George Kalpakas 11 June 2021, 11:39:29 UTC build(docs-infra): align code with new CLI v12 apps (#42259) This commit aligns the angular.io config files more closely to how a newly generated CLI v12 app would look like. This helps validate the setup and makes it easier to apply new chages in the future (by preventing the angular.io layout from deviating too much from the default new app layout). PR Close #42259 14 June 2021, 16:54:08 UTC
5161084 Andrew Scott 25 May 2021, 21:27:52 UTC docs: remove section on tables from docs style guide (#42330) The approach for tables is more of an ad-hoc determination based on the complexity of what's in them. If/when we enable formatting of markdown files, that will also make the markdown format of tables easier to read and more consistent. fixes #23978 PR Close #42330 11 June 2021, 18:47:03 UTC
0c13e2b Mladen Jakovljević 10 June 2021, 09:50:37 UTC build(packaging): remove rehype (#42557) `rehype` dependency is now moved to the `dgeni-package`, thus it can be removed from the main dependencies list PR Close #42557 11 June 2021, 15:00:49 UTC
efb440e Ahmed Ayed 21 September 2020, 22:14:52 UTC refactor(router): compute correct history restoration when navigation is cancelled (#38884) We can’t determine whether the user actually meant the `back` or the `forward` using the popstate event (triggered by a browser back/forward) so we instead need to store information on the state and compute the distance the user is traveling withing the browser history. So by using the `History#go` method, we can bring the user back to the page where he is supposed to be after performing the action. implementation for #13586 PR Close #38884 10 June 2021, 21:09:21 UTC
52e0987 Renovate Bot 10 June 2021, 17:33:47 UTC build: update angular (#42461) PR Close #42461 10 June 2021, 21:08:42 UTC
5e4a886 Pete Bacon Darwin 10 June 2021, 09:42:44 UTC docs: fix i18n guide typo (#42545) Fixes #42538 PR Close #42545 10 June 2021, 21:04:43 UTC
cddb3a8 gobika21 10 June 2021, 06:05:44 UTC docs: fix typo in "deploy multiple locales" section (#42541) Fixes #42540 PR Close #42541 10 June 2021, 21:03:34 UTC
ec90d8d Pham Huu Hien 09 June 2021, 16:19:21 UTC docs: change field name from id to $id in schema.json file (#42528) fix error "SchematicsMyService" schema is using the keyword "id" which its support is deprecated. Use "$id" for schema ID. PR Close #42528 10 June 2021, 21:03:00 UTC
aef489f Aristeidis Bampakos 25 May 2021, 22:35:38 UTC docs: add note for naming libraries (#42335) PR Close #42335 10 June 2021, 20:58:41 UTC
e299683 Kapunahele Wong 09 June 2021, 17:39:24 UTC docs: improve accessibility of router example (#40914) PR Close #40914 10 June 2021, 17:28:33 UTC
299f92c JiaLiPassion 29 April 2021, 01:05:25 UTC fix(zone.js): only one listener should also re-throw an error correctly (#41868) Close #41867 In the previous commit https://github.com/angular/angular/pull/41562#issuecomment-822696973, the error thrown in the event listener will be caught and re-thrown, but there is a bug in the commit, if there is only one listener for the specified event name, the error will not be re-thrown, so this commit fixes the issue and make sure the error is re-thrown. PR Close #41868 10 June 2021, 16:24:03 UTC
665b986 Alan Agius 24 May 2021, 07:53:03 UTC docs: CLI users polyfills (#42263) With this change we remove polyfills that are listed in suggested/mandatory but are not needed by Angular CLI users, since the Angular CLI will include these polyfills by default. Closes #39793 PR Close #42263 09 June 2021, 23:10:47 UTC
22bda22 JoostK 09 June 2021, 19:25:43 UTC fix(compiler-cli): prevent prior compilations from being retained in watch builds (#42537) In watch builds, the compiler attempts to reuse as much information from a prior compilation as possible. To accomplish this, it keeps a reference to the most recently succeeded `TraitCompiler`, which contains all analysis data for the program. However, `TraitCompiler` has an internal reference to an `IncrementalBuild`, which is itself built on top of its prior state. Consequently, all prior compilations continued to be referenced, preventing garbage collection from cleaning up these instances. This commit changes the `AnalyzedIncrementalState` to no longer retain a `TraitCompiler` instance, but only the analysis data it contains. This breaks the retainer path to the prior incremental state, allowing it to be garbage collected. PR Close #42537 09 June 2021, 23:10:04 UTC
3961b3c Igor Minar 09 June 2021, 16:42:23 UTC fix(core): ensure that autoRegisterModuleById registration in ɵɵdefineNgModule is not DCE-ed by closure (#42529) Previously the autoRegisterModuleById registration was marked with noSideEffects wrapper to ensure that we don't end up retaining all NgModules. However the return value was not referenced by anything, so closure compiler removed it because it determined that this code has no side effects and is not referenced by anyone. This issue affects apps that use Closure Compiler and also rely on https://angular.io/api/core/getModuleFactory to retrieve factories by ID. This combination is used heavily in google3, especially in Pantheon. Fixes b/188453434 PR Close #42529 09 June 2021, 19:13:23 UTC
e36c5b4 Pete Bacon Darwin 09 June 2021, 06:09:28 UTC docs: fix `ngProjectAs` selector in example (#42523) Fixes #42522 PR Close #42523 09 June 2021, 19:10:20 UTC
28a4631 Jessica Janiuk 09 June 2021, 18:30:22 UTC release: cut the v12.1.0-next.5 release (#42534) 09 June 2021, 18:30:22 UTC
7b5e2fe Jessica Janiuk 09 June 2021, 18:10:00 UTC docs: release notes for the v12.0.4 release (#42532) 09 June 2021, 18:10:00 UTC
536c373 Andrew Scott 24 May 2021, 15:50:48 UTC docs: clarify onSameUrlNavigation behavior (#42275) `onSameUrlNavigation` only affects whether the Angular Router processes the URL and runs it through the navigation pipeline, retriggering redirects, guards, and resolvers. The name `reload` is a little confusing because it does _not_ reload the component. Developers _also_ need to implement a custom `RouteReuseStrategy` to trigger a component reload on same URL navigation. Fixes #21115 PR Close #42275 09 June 2021, 16:45:25 UTC
3c25242 George Kalpakas 09 June 2021, 11:15:24 UTC build(docs-infra): upgrade cli command docs sources to 18bbd044d (#42525) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/9cbb4059f...18bbd044d): **Modified** - help/generate.json PR Close #42525 09 June 2021, 16:14:39 UTC
3de774e David Shevitz 26 May 2021, 21:04:12 UTC docs: add guidance on adding filtering and sorting logic to componetns instead of pipes (#42368) Fixes #41652 PR Close #42368 09 June 2021, 00:53:30 UTC
e1a80d4 Renovate Bot 08 June 2021, 07:19:56 UTC build: update dependency mocha to v9 (#42514) PR Close #42514 08 June 2021, 22:26:44 UTC
230f0c4 Renovate Bot 07 June 2021, 08:49:27 UTC build: lock file maintenance (#42499) PR Close #42499 08 June 2021, 22:25:59 UTC
34ce635 Dylan Hunn 07 June 2021, 17:07:49 UTC feat(forms): undo revert and add ng-submitted class to forms that have been submitted. (#42132) (#42132) As previously discussed in pull/31070 and issues/30486, this would be useful because it is often desirable to apply styles to fields that are both `ng-invalid` and `ng-pristine` after the first attempt at form submission, but Angular does not provide any simple way to do this (although evidently Angularjs did). This will now be possible with a descendant selector such as `.ng-submitted .ng-invalid`. In this implementation, the directive that sets control status classes on forms and formGroups has its set of statuses widened to include `ng-submitted`. Then, in the event that `is('submitted')` is invoked, the `submitted` property of the control container is returned iff it exists. This is preferred over checking whether the container is a `Form` or `FormGroup` directly to avoid reflecting on those classes. Closes #30486. PR Close #42132. This reverts commit 00b1444d122a64a5b6772d694c838ce8b9ca7b7d, undoing the rollback of this change. PR Close #42132 08 June 2021, 21:02:29 UTC
0777fac Teri Glover 19 May 2021, 21:57:53 UTC docs: Edited to remove jargon in Reference, Glossary, and Style sections (#42187) PR Close #42187 08 June 2021, 19:51:05 UTC
2a28a1d kuncevic 13 May 2021, 11:24:02 UTC docs: add Angular Rocks podcast (#42078) PR Close #42078 08 June 2021, 19:50:13 UTC
4975a10 Santosh Yadav 30 May 2021, 19:48:23 UTC docs(platform-server): added commands for universal and add prerendering info (#36005) Fixes #36004 PR Close #36005 08 June 2021, 19:47:24 UTC
f3fde4b Sam Severance 18 May 2021, 13:32:02 UTC docs: Add selector for `PeekABooDirective` (#42146) PR Close #42146 08 June 2021, 19:46:06 UTC
43b4a8c Teri Glover 19 May 2021, 21:20:23 UTC docs: Edited to remove jargon in Reference Errors (#42186) PR Close #42186 08 June 2021, 19:45:23 UTC
5c0541f anups1 08 June 2021, 06:40:38 UTC docs: fix issue 24571 in ngOnChanges (#42517) fix issue #24571 in ngOnChanges doc PR Close #42517 08 June 2021, 19:44:30 UTC
f33fa04 Kapunahele Wong 30 March 2021, 19:31:38 UTC docs: improve accessibility of animations example (#41385) PR Close #41385 08 June 2021, 19:43:32 UTC
386550c Kapunahele Wong 16 March 2021, 18:22:09 UTC docs: improve accessibility of reactive-forms example (#41252) PR Close #41252 08 June 2021, 19:42:20 UTC
0031c8c Kapunahele Wong 02 April 2021, 19:30:22 UTC docs: improve accessibility of attribute-binding example (#41432) PR Close #41432 08 June 2021, 19:16:54 UTC
4ff636d Kapunahele Wong 22 March 2021, 20:18:25 UTC docs: improve accessibility of pipes example (#41317) PR Close #41317 08 June 2021, 19:16:08 UTC
8fe4002 Chris 24 March 2021, 06:06:00 UTC docs: clarify documentation regarding passing multiple configurations to ng build (#41333) Fixes #40923 PR Close #41333 08 June 2021, 18:49:24 UTC
08628b4 Tiago Temporin 07 May 2021, 10:54:09 UTC docs: add components to material community components description (#41987) PR Close #41987 08 June 2021, 18:48:40 UTC
f788e6b Pete Bacon Darwin 07 June 2021, 17:20:32 UTC refactor(docs-infra): prepare DocumentService to handle new disambiguated URLs (#42509) A subsequent commit is going to change disambiguated URLs. This commit prepares the AIO application to attempt the new URLs if the old URLs fail. This will help to mitigate problems that may occur during the period between deployment of the new version and the service-worker not being updated. PR Close #42509 08 June 2021, 18:45:53 UTC
c44ab4f Sam Severance 04 June 2021, 17:25:24 UTC fix(router): fix `serializeQueryParams` logic (#42481) corrects a bug that resulted in query params such as `[queryParams]={a: 1, b:[]}` being serialized as 'a=1&' instead of 'a=1' resolves #42445 PR Close #42481 08 June 2021, 17:43:00 UTC
171428e Andrew Scott 26 May 2021, 20:12:42 UTC docs: add selector documentation for `ViewChildren`, `ContentChildren`, and `ContentChild` (#42366) These notes are copied from `ViewChild`. In addition, `ContentChildren` and `ViewChildren` can specify multiple string selectors by separating each selector by a comma. fixes #21734 PR Close #42366 08 June 2021, 17:42:21 UTC
4cf442c MrJithil 06 June 2021, 18:19:05 UTC docs: add links to examples for ComponentFactoryResolver (#42496) Fixes #21705 PR Close #42496 08 June 2021, 17:41:33 UTC
645cad5 Pete Bacon Darwin 27 May 2021, 20:27:38 UTC docs(core): describe interactions between view-encapsulated components (#42397) This commit adds information to the view encapsulation guide that describes the styling interactions between components that use differing view encapsulation modes. Closes #40715 PR Close #42397 08 June 2021, 17:39:52 UTC
d10c38a MarsiBarsi 08 June 2021, 08:46:27 UTC docs: add Roman Sedov to contributors page (#42515) PR Close #42515 08 June 2021, 17:37:51 UTC
751f68d iRealNirmal 08 June 2021, 12:30:29 UTC docs: updated collaborators and add angular dev's link (#42516) Existing trusted collaborators link is not working and now link is updated to one of angular.io page also it was missing angular dev's link so added it. Closes #42513. PR Close #42516 08 June 2021, 17:37:16 UTC
66f49c2 Jessica Janiuk 08 June 2021, 16:41:19 UTC Revert "refactor: remove checked-in locale files" (#42521) This reverts commit 3a83ec8020f96c293fdc316854e199281d329111. PR Close #42521 08 June 2021, 17:06:24 UTC
e3b7093 Jessica Janiuk 08 June 2021, 16:40:57 UTC Revert "build: convert CLDR locale extraction from Gulp to Bazel tool" (#42521) This reverts commit b9759522260cd57392e44fe63c5b17a9f102c101. PR Close #42521 08 June 2021, 17:06:24 UTC
cb59bdf Jessica Janiuk 08 June 2021, 16:40:34 UTC Revert "build: wire up new CLDR generation tool within Bazel" (#42521) This reverts commit 40bf84c89decea1de08e43936c9886a391b02173. PR Close #42521 08 June 2021, 17:06:24 UTC
dc25efb Jessica Janiuk 08 June 2021, 16:40:09 UTC Revert "build: build locale files for legacy saucelabs job" (#42521) This reverts commit 018654fe672a8ab7a954ae6541706957926ac0f4. PR Close #42521 08 June 2021, 17:06:24 UTC
cc55fd6 Jessica Janiuk 08 June 2021, 16:39:51 UTC Revert "build: add documentation for `generate-locales-tool`" (#42521) This reverts commit 12d84d041a2b27bec77f18d7e433b01f105ac784. PR Close #42521 08 June 2021, 17:06:24 UTC
fa4b0b3 Jessica Janiuk 08 June 2021, 16:39:17 UTC Revert "build: simplify generation of closure locale file" (#42521) This reverts commit 5fca35de0de8da24b8a046616404e74ecb4547b4. PR Close #42521 08 June 2021, 17:06:24 UTC
f1d58ef Teri Glover 19 May 2021, 20:20:35 UTC docs: Edits to remove jargon in Reference Observables, Dependency Injection (#42185) PR Close #42185 08 June 2021, 01:24:48 UTC
b762820 Paul Gschwendtner 02 June 2021, 13:50:07 UTC build: simplify generation of closure locale file (#42230) In the past, the closure file has been generated so that all individual locale files were imported individually. This resulted in a huge slow-down in g3 due to the large amount of imports. With 90bd984ff74f7605d7c08fd9fdbf610ba7fa67a5 this changed so that we inline the locale data for the g3 closure locale file. Also the file only contained data for locales being supported by Closure. For this a list of locales has been extracted from Closure Compiler, as well as a list of locale aliases. This logic is prone to CLDR version updates, and also broke as part of the Gulp -> Bazel migration where this logic has been slightly modified but caused issues in G3. e.g. a locale `zh-Hant` was requested in g3, but the locale data had the name of the alias locale that provided the data at index zero (which represents the locale name). Note that the locale names at index zero always could differentiate from the requested `goog.LOCALE` due to the aliasing logic. This just didn't come up before. We simplify this logic by generating a `goog.LOCALE` case for all locales CLDR provides data for. We don't need to bother about aliasing because with the refactorings to the CLDR generation tool, all locales are built (which also captures the aliases), and we can generate the locale file on the fly (which has not been done before). PR Close #42230 07 June 2021, 22:34:39 UTC
7b28847 Paul Gschwendtner 25 May 2021, 19:36:07 UTC build: add documentation for `generate-locales-tool` (#42230) The CLDR extraction tool has been reworked to run as part of Bazel. This adds a initial readme explaining what the tool generates. It's far from a detailed description but it can serve as foundation for more detailed explanations. PR Close #42230 07 June 2021, 22:34:39 UTC
532caa7 Paul Gschwendtner 22 May 2021, 17:18:31 UTC build: build locale files for legacy saucelabs job (#42230) Given that the locale files are now generated through Bazel, the files are no longer checked-in and the legacy TSC compilation fails due to imports resolving to non-existent files. We fix this for the legacy saucelabs job by copying the generated TS files into the sources (which is acceptable for the isolated CI job) PR Close #42230 07 June 2021, 22:34:38 UTC
4641fc7 Paul Gschwendtner 21 May 2021, 20:58:25 UTC build: wire up new CLDR generation tool within Bazel (#42230) Introduces a few Starlark macros for running the new Bazel CLDR generation tool. Wires up the new tool so that locales are generated properly. Also updates the existing `closure-locale` file to match the new output generated by the Bazel tool. This commit also re-adds a few locale files that aren't generated by CLDR 37, but have been accidentally left in the repository as the Gulp script never removed old locales from previous CLDR versions. This problem is solved with the Bazel generation of locale files, but for now we re-add these old CLDR 33 locale files to not break developers relying on these (even though the locale data indicies are incorrect; but there might be users accessing the data directly) PR Close #42230 07 June 2021, 22:34:38 UTC
1f75a65 Paul Gschwendtner 21 May 2021, 20:57:42 UTC build: convert CLDR locale extraction from Gulp to Bazel tool (#42230) Converts the CLDR locale extraction script to a Bazel tool. This allows us to generate locale files within Bazel, so that locales don't need to live as sources within the repo. Also it allows us to get rid of the legacy Gulp tooling. The migration of the Gulp script to a Bazel tool involved the following things: 1. Basic conversion of the `extract.js` script to TypeScript. This mostly was about adding explicit types. e.g. adding `locale: string` or `localeData: CldrStatic`. 2. Split-up into separate files. Instead of keeping the large `extract.js` file, the tool has been split into separate files. The logic remains the same, just that code is more readable and maintainable. 3. Introduction of a new `index.ts` file that is the entry-point for the Bazel tool. Previously the Gulp tool just generated all locale files, the default locale and base currency files at once. The new entry-point accepts a mode to be passed as first process argument. based on that argument, either locales are generated into a specified directory, or the default locale, base currencies or closure file is generated. This allows us to generate files with a Bazel genrule where we simply run the tool and specify the outputs. Note: It's necessary to have multiple modes because files live in separate locations. e.g. the default locale in `@angular/core`, but the rest in `@angular/common`. 4. Removal of the `cldr-data-downloader` and custom CLDR resolution logic. Within Bazel we cannot run a downloader using network. We switch this to something more Bazel idiomatic with better caching. For this a new repository rule is introduced that downloads the CLDR JSON repository and extracts it. Within that rule we determine the supported locales so that they can be used to pre-declare outputs (for the locales) within Bazel analysis phase. This allows us to add the generated locale files to a `ts_library` (which we want to have for better testing, and consistent JS transpilation). Note that the removal of `cldr-data-downloader` also requires us to add logic for detecting locales without data. The CLDR data downloader overwrote the `availableLocales.json` file with a file that only lists locales that CLDR provides data for. We use the official `availableLocales` file CLDR provides, but filter out locales for which no data is available. This is needed until we update to CLDR 39 where data is available for all such locales listed in `availableLocales.json`. PR Close #42230 07 June 2021, 22:34:38 UTC
9421bcd Paul Gschwendtner 21 May 2021, 20:52:45 UTC refactor: remove checked-in locale files (#42230) This is a pre-refactor commit allowing us to move the CLDR locale generation to Bazel where files would no longer be checked-in, except for the `closure-locale` file that is synced into Google3. PR Close #42230 07 June 2021, 22:34:38 UTC
a493ea9 Andrew Scott 03 June 2021, 22:15:16 UTC fix(language-service): fix autocomplete info display for some cases (#42472) Before this commit, attribute completion display parts were retrieved but not assigned. In addition, the switch case was non-exhaustive because it did not include `StructuralDirectiveAttribute`. PR Close #42472 07 June 2021, 19:25:53 UTC
f85a120 George Kalpakas 07 June 2021, 17:44:08 UTC docs(router): fix code-example headers (#42507) Previously, the code-examples headers used in the "Creating custom route matches" tutorial contained the name of the example directory (`routing-with-urlmatcher`). This was confusing, because the user was previously instructed to create an app named `angular-custom-route-match` and switch to that directory. This commit fixes it by removing the root directory name from the headers, thus leaving the path of the file relative to the current working directory. This also aligns with code-examples in other guides. PR Close #42507 07 June 2021, 18:58:20 UTC
38c592e Paul Gschwendtner 07 June 2021, 14:17:03 UTC build: remove unused no-strict tsconfig file (#42506) In the past, when we enabled `--strict` in the repository, we added another tsconfig for code not being migrated to be `--strict` compatible. This was done for the deprecated http and webworker packages. Since these are now removed, we can rmeove the logic. PR Close #42506 07 June 2021, 17:47:47 UTC
64c8027 JoostK 05 June 2021, 18:52:19 UTC docs: clarify how type-only imports can be used to avoid NG3003 (#42491) Since #42453, type-only imports are not considered for cyclic imports. This commit adds a note to the NG3003 error documentation to mention using type-only imports to avoid the error. PR Close #42491 07 June 2021, 17:47:13 UTC
f4c55e4 Andrew Kushnir 25 May 2021, 20:09:31 UTC docs: provide more info on the `NO_ERRORS_SCHEMA` schema (#42327) The `NO_ERRORS_SCHEMA` schema can be used to ignore errors related to unknown elements or properties, but since it suppresses these errors it may also hide real problems in a template. This commit updates the `NO_ERRORS_SCHEMA` docs to mention that. Closes #39454. PR Close #42327 07 June 2021, 17:46:34 UTC
afd68e5 Kristiyan Kostadinov 23 May 2021, 10:14:02 UTC feat(compiler): emit diagnostic for shadow dom components with an invalid selector (#42245) This is based on a discussion we had a few weeks ago. Currently if a component uses `ViewEncapsulation.ShadowDom` and its selector doesn't meet the requirements for a custom element tag name, a vague error will be thrown at runtime saying something like "Element does not support attachShadowRoot". These changes add a new diagnostic to the compiler that validates the component selector and gives a better error message during compilation. PR Close #42245 07 June 2021, 17:44:57 UTC
cc904b5 Pete Bacon Darwin 23 May 2021, 10:59:55 UTC docs(core): clarify deprecation of `entryComponents` (#42248) These may still be needed in View Engine libraries. Closes #39958 PR Close #42248 07 June 2021, 17:02:01 UTC
b061e5b Alex Inkin 05 June 2021, 11:05:24 UTC fix(docs-infra): fix search results font color (#42488) Use the same white constant for no results message PR Close #42488 07 June 2021, 16:38:06 UTC
5d70f09 Gourav102 06 June 2021, 15:00:17 UTC docs: Corrected spelling (#42493) Corrected spelling of 'Properties'. PR Close #42493 07 June 2021, 16:36:18 UTC
cd22c7a Gourav102 06 June 2021, 16:37:20 UTC docs: Updated the code snippet path (#42494) PR Close #42494 07 June 2021, 16:32:57 UTC
3005917 Igor Minar 26 May 2021, 23:58:38 UTC docs: add node.js version info into the universal guide (#42375) Previously we didn't document what versions were supported. Since universal requires node.js I'm adding version information into the guide as a informative callout. Fixes #39436 PR Close #42375 04 June 2021, 22:21:21 UTC
4fc24ad Joey Perrott 04 June 2021, 18:59:12 UTC build: suppress errors in git hooks (#42484) When errors occur in git hooks, we can safely supress them as they are validated on CI. This is primarily coming up as an issue related to needing to reinstall node_modules PR Close #42484 04 June 2021, 20:34:01 UTC
a5b5136 Teri Glover 19 May 2021, 19:05:03 UTC docs: Edits to remove jargon in Reference NgModules (#42182) PR Close #42182 04 June 2021, 20:32:56 UTC
2d0ff0a Paul Gschwendtner 04 June 2021, 14:57:07 UTC ci: add lint error for files with missing trailing new-line (#42478) For quite a while it is an unspoken convention to add a trailing new-line files within the Angular repository. This was never enforced automatically, but has been frequently raised in pull requests through manual review. This commit sets up a lint rule so that this is "officially" enforced and doesn't require manual review. PR Close #42478 04 June 2021, 20:31:03 UTC
back to top