Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
8948c93 Paul Gschwendtner 07 June 2021, 19:03:01 UTC refactor(platform-server): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `platform-server` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:15 UTC
48c9a0d Paul Gschwendtner 07 June 2021, 19:02:34 UTC refactor(platform-browser-dynamic): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `platform-browser-dynamic` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:15 UTC
a2975c7 Paul Gschwendtner 07 June 2021, 19:02:10 UTC refactor(platform-browser): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `platform-browser` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:15 UTC
c74927d Paul Gschwendtner 07 June 2021, 19:01:40 UTC refactor(core): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `core` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:15 UTC
7313756 Paul Gschwendtner 07 June 2021, 19:00:45 UTC refactor(animations): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `animations` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:15 UTC
9073633 Paul Gschwendtner 07 June 2021, 19:00:18 UTC refactor(dev-infra): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `dev-infra` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:14 UTC
ccbb913 Paul Gschwendtner 07 June 2021, 15:25:45 UTC refactor(compiler-cli): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `compiler-cli` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:14 UTC
96c9326 Paul Gschwendtner 07 June 2021, 15:10:51 UTC refactor(compiler): ensure compatibility with noImplicitOverride (#42512) Adds the `override` keyword to the `compiler` sources to ensure compatibility with `noImplicitOverride`. PR Close #42512 12 July 2021, 20:11:14 UTC
c7d2063 Paul Gschwendtner 07 June 2021, 15:09:00 UTC build: enable noImplicitOverride in project (#42512) Enables the `noImplicitOverride` option to improve overall codehealth in the repository. PR Close #42512 12 July 2021, 20:11:14 UTC
e8be045 Arthur Ming 23 June 2021, 03:39:35 UTC refactor(core): optimize the implementation about finding context from error in ErrorHandler (#42581) in _findContext method, use conditional operator check whether the params 'error' exists and then us reccursion way to find context in original error if getDebugContext's result does not exist. PR Close #42581 12 July 2021, 19:00:19 UTC
1067be7 Arthur Ming 21 June 2021, 01:48:21 UTC build: update all symbol extractor (#42581) update all symbol extractor by running 'yarn symbol-extractor:update' script PR Close #42581 12 July 2021, 19:00:19 UTC
1e2d879 Arthur Ming 16 June 2021, 08:28:56 UTC refactor(core): optimize the implementation about finding context from error in ErrorHandler (#42581) in _findContext method, use conditional operator check whether the params 'error' exists and then use nullish coalescing operator instead conditional operator when getDebugContext's result does not exist. PR Close #42581 12 July 2021, 19:00:19 UTC
404c8d0 Kristiyan Kostadinov 03 July 2021, 09:59:58 UTC fix(compiler): incorrect context object being referenced from listener instructions inside embedded views (#42755) Currently unless a listener inside of an embedded view tries to reference something from the parent view, or if the reference is a local ref, we don't generate the view restoration instructions and we allow for the value to be picked up from the context object in the function parameters. The problem is that the listener is only run during creation mode and the context object may have been swapped out afterwards. These changes fix the issue by always generating the view restoration instructions for listeners inside templates. Fixes #42698. PR Close #42755 12 July 2021, 18:58:18 UTC
4c482bf JoostK 03 July 2021, 22:59:46 UTC fix(compiler-cli): properly emit literal types when recreating type parameters in a different file (#42761) In #42492 the template type checker became capable of replicating a wider range of generic type parameters for use in template type-check files. Any literal types within a type parameter would however emit invalid code, as TypeScript was emitting the literals using the text as extracted from the template type-check file instead of the original source file where the type node was taken from. This commit works around the issue by cloning any literal types and marking them as synthetic, signalling to TypeScript that the literal text has to be extracted from the node itself instead from the source file. This commit also excludes `import()` type nodes from being supported, as their module specifier may potentially need to be rewritten. Fixes #42667 PR Close #42761 12 July 2021, 18:48:34 UTC
40da386 behrooz bozorg chami 10 July 2021, 20:06:22 UTC docs(core): fix `ViewChildren` code examples to avoid TS error (#42816) Add a non-null assertion (`!`) in `ViewChildren` code examples to avoid a TypeScript error due to uninitialized property. Fixes #42811 PR Close #42816 12 July 2021, 16:48:30 UTC
4e73b88 Paul Gschwendtner 09 July 2021, 18:26:19 UTC build: no longer ship ecmascript module files within NPM packages (#42809) We accidentally started shipping `.mjs` files for the following modules (or module paths) as of the v12.1.0-next.2 tag: - `@angular/compiler-cli` - `@angular/common/locales` - `@angular/bazel` - `@angular/benchpress` - `@angular/core/schematics` - `@angular/elements/schematics` - `@angular/language-service` - `@angular/localize/schematics`, - `@angular/localize/tools` - `zone.js` This did not cause any issues for consumers but we want to not ship these files without having them wired up in `package.json` files. We accidentally started shipping these `.mjs` files due to a NodeJS update which wired up the other JavaScript module output flavors in the `pkg_npm` rule. https://github.com/bazelbuild/rules_nodejs/commit/911529fd364eb3ee1b8ecdc568a9fcf38a8b55ca PR Close #42809 12 July 2021, 16:42:01 UTC
9af5abb Paul Gschwendtner 09 July 2021, 18:22:50 UTC feat(dev-infra): add bazel rule for extracting JavaScript module flavors from targets (#42809) Introduces a rule that collects declared JavaScript module output files from a list of dependencies based on a configurable JavaScript module provider. The extracted outputs are exposed within the `DefaultInfo` provider. Targets defined using this rule can be used as input for rules that require JavaScript sources, or if there are multiple JavaScript output variants defined for a target while for example only the `JSModuleInfo` outputs are of interest. As an example: This rule is helpful in combination with `ts_library` and `ng_module` as those rule expose multiple output flavors (which are distinguishable by the JavaScript module providers as imported from `providers.bzl`). i.e. these rules expose flavors for named AMD modules and ECMAScript module output. If we want to ship a NPM package only using ECMAScript modules for example, we could extract all `JSEcmaScriptModuleInfo`-denoted output and feed that into the `pkg_npm` rule, compared to bringing in all output flavors. For reference: https://github.com/bazelbuild/rules_nodejs/blob/stable/packages/typescript/internal/build_defs.bzl#L334-L337 PR Close #42809 12 July 2021, 16:42:01 UTC
ef15b97 dario-piotrowicz 29 June 2021, 21:15:51 UTC docs(core): edit and add docs for ng-template (#42704) PR Close #42704 12 July 2021, 16:39:29 UTC
762e057 Paul Gschwendtner 06 July 2021, 13:45:55 UTC build: update to rules_nodejs v4.0.0-beta.0 (#42760) Updates the Bazel NodeJS rules to v4.0.0-beta.0. This is necessary so that the Angular components repo can update, and it's generally good to stay as up-to-date as possible with the Bazel rules as it's easy to fall behind, and updating early allows us to discover issues affecting our tooling earlier (where they are easier to address due to e.g. potential breaking change policy). PR Close #42760 09 July 2021, 21:50:15 UTC
9da68a7 Paul Gschwendtner 06 July 2021, 13:42:32 UTC refactor(bazel): compatibility with `rules_nodejs` v4.0.0 (#42760) This commit applies changes to `@angular/bazel` which are necessary to support the Bazel NodeJS rules v4.0.0. The Bazel NodeJS rules no longer support the `_tslibrary` option for the `LinkablePackageInfo` provider and therefore we need to stop using it. Due to this removal, we also need to add two new attributes called `package_name` and `package_path` so that the API of `ng_module` matches `ts_library`. Note: This is denoted as `refactor` as we currently are not able to merge feature commits into patch branches, but we want the tooling to not diverge significantly between the patch and next branch. It is planned to update the merge tooling to allow for such changes to land. PR Close #42760 09 July 2021, 21:50:15 UTC
12443ea Paul Gschwendtner 06 July 2021, 13:39:58 UTC build: remove `skydoc` and `rules_sass` from repository (#42760) Skydoc is no longer used as `@angular/bazel` is no longer a public API. The Sass rules were only used in a single place in the repo where Sass is not really needed and has just been added by accident most likely. We want to remove the Sass dependency in preparation for Rules NodeJS v4.x where the Sass rules currently still use an older version of `@bazel/worker` that is incompatible. PR Close #42760 09 July 2021, 21:50:15 UTC
53b281a Paul Gschwendtner 06 July 2021, 13:31:08 UTC build: remove outdated note when updating bazel version (#42760) We removed `bazel-toolchains` from the repository since dev-infra provides the RBE platforms now (in a way where they are not reliant on the Bazel version), so the comment in `.bazelversion` can be removed. PR Close #42760 09 July 2021, 21:50:14 UTC
b1fa1bf Paul Gschwendtner 06 July 2021, 13:29:19 UTC fix(dev-infra): `ng_rollup_bundle` rule should error if import cannot be resolved (#42760) Rollup just prints a warning if an import cannot be resolved and ends up being treated as an external dependency. This in combination with the `silent = True` attribute for `rollup_bundle` means that bundles might end up being extremely small without people noticing that it misses actual imports. To improve this situation, the warning is replaced by an error if an import cannot be resolved. This unveiles an issue with the `ng_rollup_bundle` macro from dev-infra where imports in View Engine were not resolved but ended up being treated as external. This did not prevent benchmarks using this macro from working because the ConcatJS devserver had builtin resolution for workspace manifest paths. Though given the new check for no unresolved imports, this will now cause errors within Rollup, and we need to fix the resolution. We can fix the issue by temporarily enabling workspace linking. This does not have any performance downsides. To enable workspace linking (which we might need more often in the future given the linker taking over patched module resolution), we had to rename the `angular` dependency to a more specific one so that the Angular linker could link into `node_modules/angular`. PR Close #42760 09 July 2021, 21:50:14 UTC
9d58ebf Alan Agius 09 July 2021, 05:21:57 UTC test(bazel): update `example_package.golden` (#42804) This is caused by the update of @microsoft/api-extractor to 7.18.1 PR Close #42804 09 July 2021, 19:14:56 UTC
625421c Alan Agius 09 July 2021, 04:22:23 UTC Revert "ci: configure renovate to ignore `@microsoft/api-extractor` (#42797)" (#42804) This reverts commit 1f3747b583955c37bd10151f3dd3ca9c84694ca3. PR Close #42804 09 July 2021, 19:14:56 UTC
c5351aa Alan Agius 09 July 2021, 04:21:51 UTC build: update `@microsoft/api-extractor` to `7.18.1` (#42804) microsoft/rushstack#2797 is fixed. PR Close #42804 09 July 2021, 19:14:56 UTC
3791ae0 Andrew Scott 02 July 2021, 19:38:04 UTC refactor(router): Adjust behavior for computed navigation restoration (#42751) When another navigation is triggered during an in-process navigation and the `canceledNavigationResolution` is `'computed'`, we should not attempt to restore the browser history using `history.go`. Doing that would trigger a third navigation through the router which would conflict with the new navigation that we were trying to process. Instead, we treat this as a redirect and skip the history restoration attempt. This acts similarly to returning `UrlTree` from a guard. Fixes issue described in https://github.com/angular/angular/pull/38884#issuecomment-863767152 PR Close #42751 09 July 2021, 17:19:09 UTC
5356796 George Kalpakas 07 July 2021, 15:37:25 UTC fix(docs-infra): fix margin of social icon on small screens (#42790) This commit fixes the margin of the social icons on small screens. This mainly affects screens between 420px and 480px, where only one social icon is show (due to limited space) but not necessarily the first one (in DOM order). **Before:** ![social icon before][1] **After:** ![social icon after][2] [1]: https://user-images.githubusercontent.com/8604205/124788616-2f5f0200-df52-11eb-9ec2-9e46b90cd286.png [2]: https://user-images.githubusercontent.com/8604205/124788623-2ff79880-df52-11eb-90ec-31b04973de68.png PR Close #42790 09 July 2021, 17:15:27 UTC
50b6aae Bastian 05 July 2021, 10:32:20 UTC docs: fix http example to show actual message in console (#42773) Previously, the error message in the console would print `[object Object]` and not the actual error message. With this change, the error message is printed in the console. PR Close #42773 09 July 2021, 17:14:35 UTC
9ec2419 Renovate Bot 09 July 2021, 05:46:30 UTC build: update all non-major dependencies (#42739) PR Close #42739 09 July 2021, 17:13:37 UTC
dfe9e1d Renovate Bot 07 July 2021, 23:36:14 UTC build: lock file maintenance (#42770) PR Close #42770 08 July 2021, 21:53:17 UTC
1f3747b Alan Agius 08 July 2021, 12:59:27 UTC ci: configure renovate to ignore `@microsoft/api-extractor` (#42797) This is an interm solution until https://github.com/microsoft/rushstack/issues/2797 is fixed. Related failures in the Angular repo https://app.circleci.com/jobs/github/angular/angular/1018749?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link PR Close #42797 08 July 2021, 21:50:56 UTC
89084ff Gabriele Franchitto 02 July 2021, 08:13:03 UTC docs(core): initializeApp method should return function (#42743) Update packages/core/src/application_init.ts Update application_init.ts Update application_init.ts Co-Authored-By: George Kalpakas <kalpakas.g@gmail.com> PR Close #42743 08 July 2021, 21:50:18 UTC
e7832a6 Borislav Ivanov 07 July 2021, 06:42:25 UTC docs(core): fix spelling error (#42783) Fix spelling error in migration schematics. PR Close #42783 08 July 2021, 21:49:46 UTC
c30502e Joey Perrott 05 May 2021, 16:56:55 UTC ci: use issue forms for issue creation (#42099) Use new issue forms from Github for creating issues. PR Close #42099 08 July 2021, 21:07:30 UTC
f6ddbbc mgechev 07 July 2021, 19:15:51 UTC ci: update the feature request bot (#42791) Introduce latest fixes in logging and labeling. PR Close #42791 08 July 2021, 21:06:09 UTC
e26bfc1 Alan Agius 08 July 2021, 13:03:52 UTC refactor(core): remove no longer needed types workaround (#42798) https://github.com/Microsoft/web-build-tools/issues/1050 has been solved and therefore we no longer need this workaround. PR Close #42798 08 July 2021, 21:05:45 UTC
cb2ca9a George Kalpakas 08 July 2021, 13:25:16 UTC fix(service-worker): correctly handle unrecoverable state when a client no longer exists (#42736) Previously, the ServiceWorker assumed that a client found in `clientVersionMap` would exist (i.e. it could be retrieved via `clients.get()`). However, if a browser tab had been closed, the corresponding client (while present in `clientVersionMap`, which is only updated on ServiceWorker initialization) would not be retrievable via `clients.get()`. This commit fixes it by checking whether the client exists before trying to notify it about an unrecoverable state. PR Close #42736 08 July 2021, 17:28:22 UTC
5aa0138 George Kalpakas 08 July 2021, 13:25:16 UTC refactor(service-worker): switch to the official TypeScript typings (#42736) Previously, we used custom typings for the ServiceWorker environment. This was necessary back when the ServiceWorker package was introduced, since there were no official typings. Since there are now official typings for Web Workers (including ServiceWorkers) offered by TypeScript as [lib.webworker.d.ts][1], this commit gets rid of our custom typings in favor of using the official ones. [1]: https://github.com/microsoft/TypeScript/blob/v4.3.4/lib/lib.webworker.d.ts PR Close #42736 08 July 2021, 17:28:22 UTC
a47aaab George Kalpakas 08 July 2021, 13:25:16 UTC test(service-worker): better align mock global scope implementation with actual implementation (#42736) This commit better aligns the mock `ServiceWorkerGlobalScope` implementation used in ServiceWorker tests (and the associated typings) with the actual implementation (and the official TypeScript typings). This allows verifying the ServiceWorker behavior in a slightly more realistic environment. This is in preparation of switching from our custom typings to the official TypeScript typings (`lib.webworker.d.ts`). PR Close #42736 08 July 2021, 17:28:22 UTC
7c2f800 George Kalpakas 08 July 2021, 13:25:16 UTC test(service-worker): better align mock client implementations with actual implementations (#42736) This commit better aligns the mock client implementations used in ServiceWorker tests (and the associated typings) with the actual implementations (and the official TypeScript typings). This allows verifying the ServiceWorker behavior in a slightly more realistic environment. This is in preparation of switching from our custom typings to the official TypeScript typings (`lib.webworker.d.ts`). PR Close #42736 08 July 2021, 17:28:22 UTC
ad9085f George Kalpakas 08 July 2021, 13:25:15 UTC refactor(service-worker): move mock client classes to their own file (#42736) In the ServiceWorker tests, we use mock implementations of the various client APIs that the ServiceWorker interacts with. Previously, these mock implementations were defined in the `testing/scope.ts` file. This added several extra classes to a file that already contains a few, making it harder to maintain. Therefore, this commit moves these mock client classes to a separate `testing/clients.ts` file. PR Close #42736 08 July 2021, 17:28:22 UTC
22a8123 George Kalpakas 08 July 2021, 13:25:15 UTC test(service-worker): better align mock event implementations with actual implementations (#42736) This commit better aligns the mock event implementations used in ServiceWorker tests (and the associated typings) with the actual implementations (and the official TypeScript typings). This allows verifying the ServiceWorker behavior in a slightly more realistic environment. This is in preparation of switching from our custom typings to the official TypeScript typings (`lib.webworker.d.ts`). PR Close #42736 08 July 2021, 17:28:22 UTC
a86c404 George Kalpakas 08 July 2021, 13:25:15 UTC refactor(service-worker): move mock event classes to their own file (#42736) In the ServiceWorker tests, we use mock implementations of the various events emitted during the ServiceWorker lifecycle. Previously, these mock implementations were defined in the `testing/scope.ts` file. This added several extra classes to a file that already contains a few, making it harder to maintain. Therefore, this commit moves these mock event classes to a separate `testing/events.ts` file. PR Close #42736 08 July 2021, 17:28:22 UTC
7df1fa5 George Kalpakas 08 July 2021, 13:25:15 UTC refactor(service-worker): make `SwTestHarness.envIsSupported()` a standalone function (#42736) This commit makes the `SwTestHarness.envIsSupported()` static method a standalone function. This function is used to determine whether the current environment provides the necessary APIs to run the SW tests and is independent of `SwTestHarness`, so is no need for it to be a static method of `SwTestHarness`. This is in preparation of switching from our custom typings to the official TypeScript typings (`lib.webworker.d.ts`). PR Close #42736 08 July 2021, 17:28:22 UTC
fe135e1 George Kalpakas 08 July 2021, 13:25:15 UTC refactor(service-worker): remove duplicate `Context` type (in favor of `ExtendableEvent`) (#42736) This commit removes the duplicate `Context` interface and uses the `ExtendableEvent` interface instead. This is in preparation of switching from our custom typings to the official TypeScript typings (`lib.webworker.d.ts`). PR Close #42736 08 July 2021, 17:28:21 UTC
ad00d08 George Kalpakas 08 July 2021, 13:25:14 UTC refactor(service-worker): remove unused variables and imports from tests (#42736) This commit removes some unused variables (and associated imports) from `integration_spec.ts`. PR Close #42736 08 July 2021, 17:28:21 UTC
ad08b17 David Gilson 24 June 2021, 08:36:55 UTC docs(forms): add diff between add and set control (#42638) PR Close #42638 08 July 2021, 17:27:43 UTC
f592a12 George Kalpakas 08 July 2021, 13:22:49 UTC fix(service-worker): avoid storing redundant metadata for hashed assets (#42606) The ServiceWorker needs to keep track of some metadata for unhashed asset resources to know if/when they might need to be revalidated. This applies to resources that do not exist on the filesystem at build-time (and thus cannot be hashed), such as fonts or images loaded from external sources. For hashed resources, this metadata is irrelevant, because the hash is enough to verify that the content hasn't changed and no revalidation is necessary. Previously, the ServiceWorker would store such metadata for hashed resources as well, even though it would never be used (thus taking up space unnecessarily). This commit fixes it by not storing metadata for hashed resources, i.e. those that are included in an asset-group's `hashes` array. PR Close #42606 08 July 2021, 17:27:16 UTC
a8698ce George Kalpakas 08 July 2021, 13:22:48 UTC docs(service-worker): add missing comma in example JSON data (#42606) PR Close #42606 08 July 2021, 17:27:16 UTC
30c82cd JoostK 03 July 2021, 22:02:57 UTC fix(compiler-cli): inline type checking instructions no longer prevent incremental reuse (#42759) Source files that contain directives or components that need an inline type constructor or inline template type-check block would always be considered as affected in incremental rebuilds. The inline operations cause the source file to be updated in the TypeScript program that is created for template type-checking, which becomes the reuse program in a subsequent incremental rebuild. In an incremental rebuild, the source files from the new user program are compared to those from the reuse program. The updated source files are not the same as the original source file from the user program, so the incremental engine would mark the file which needed inline operations as affected. This prevents incremental reuse for these files, causing sub-optimal rebuild performance. This commit attaches the original source file for source files that have been updated with inline operations, such that the incremental engine is able to compare source files using the original source file. Fixes #42543 PR Close #42759 07 July 2021, 22:17:25 UTC
95ba5b4 George Kalpakas 07 July 2021, 11:27:22 UTC fix(docs-infra): ensure the sidenav backdrop covers the floating ToC (#42787) Previously, on narrow pages where the sidenav was in `over` mode, the sidenav's backdrop only covered the main docs content but not the floating Table of Contents (ToC) on the right. This was inconsistent and confusing to the user, because they could interact with the ToC and scroll to different area of the main content while the sidenav and backdrop were still covering the content. This commit fixes it by ensuring the sidenav backdrop covers both the main content and the floating ToC (when present). Fixes #42778 PR Close #42787 07 July 2021, 20:40:00 UTC
8b95816 George Kalpakas 07 July 2021, 12:30:57 UTC fix(docs-infra): log more SW debug info (#42776) This commit expands the info printed to the console to help diagnose ServiceWorker issues to include the [internal debug info][1] retrieved from `/ngsw/state`. This will provide more useful data, such as the activated SW's version, state, clients, recent operations and any recent errors. NOTE: This temporarily increases the payload size. Removing this code and reclaiming the payload size is being tracked in #41117. [1]: https://angular.io/guide/service-worker-devops#locating-and-analyzing-debugging-information PR Close #42776 07 July 2021, 20:37:05 UTC
ed57e24 George Kalpakas 07 July 2021, 11:36:03 UTC refactor(docs-infra): replace deprecated Sass `/` division with `math.div()` (#42776) This commit replaces the deprecated `/` operators used for division in Sass files with the [recommended][1] `math.div()` function to get rid of build warnings ([example][2]). [1]: https://sass-lang.com/documentation/breaking-changes/slash-div [2]: https://circleci.com/gh/angular/angular/1017640 PR Close #42776 07 July 2021, 20:37:05 UTC
0ca196d George Kalpakas 07 July 2021, 11:36:03 UTC test(docs-infra): prevent warning due to missing expectation (#42776) Fix a unit test warning due to Jasmine not realizing that `httpMock.expectOne()` is an expectation. [Example][1]: > WARN: 'Spec 'DocumentService currentDocument should encode the request > path to be case-insensitive' has no expectations.' [1]: https://circleci.com/gh/angular/angular/1017640 PR Close #42776 07 July 2021, 20:37:05 UTC
4038994 George Kalpakas 07 July 2021, 11:36:03 UTC build(docs-infra): update @angular/* to 12.1.1 (#42776) Update `@angular/*` packages to latest 12.1.x versions (mainly to take advantage of recent ServiceWorker improvements, such as #42607 and #42622). PR Close #42776 07 July 2021, 20:37:05 UTC
6548a53 George Kalpakas 07 July 2021, 11:36:03 UTC build(docs-infra): update payload sizes (#42776) This commit updates the payload sizes for angular.io to make it easier to identify payload size changes from an imminent update of `@angular/*` packages. PR Close #42776 07 July 2021, 20:37:05 UTC
24ac378 dario-piotrowicz 02 July 2021, 20:57:21 UTC fix(docs-infra): slightly improve top-menu responsiveness (#42753) make sure that the top-menu links don't get overlapped by the search input, regardless on the browser's font-size and the window's width make also sure that the header's logo does not overlap the search input on narrow windows, again regardless on the browser's font-size PR Close #42753 07 July 2021, 20:36:38 UTC
e064f17 Ryan Andersen 01 July 2021, 13:11:56 UTC docs: add missing import to `CartService` tutorial instructions (#42701) PR Close #42701 07 July 2021, 16:54:55 UTC
0c0c32d Theoklitos Bampouris 02 July 2021, 08:04:48 UTC docs: change misspelled function (#42742) Change the router.navigateUrl() to the correct function router.navigate() according to code example. PR Close #42742 07 July 2021, 16:54:23 UTC
c9b47f2 Paul Gschwendtner 02 July 2021, 22:27:01 UTC fix(dev-infra): missing `pkg_npm` substitution for top-level targets being accessed (#42754) Currently if a top-level target or file within `//dev-infra` is being referenced. like `//dev-infra:tsconfig`, then the label is not subsituted properly and breaks consumption of the built NPM package. PR Close #42754 03 July 2021, 00:15:18 UTC
4c78984 Alan Agius 02 July 2021, 10:33:51 UTC fix(compiler-cli): support reflecting namespace declarations (#42728) DTS bundling, will cause originally namespaced imports become namespace declarations within the same file. Example: Before bundling ```ts import * as i1 from './router'; export declare class RouterModule { constructor(guard: any, router: Router); static ɵmod: i0.ɵɵNgModuleDeclaration<RouterModule, [typeof i1.RouterOutlet...]>; } ``` After bundling ``` declare namespace i1 { export { RouterOutletContract, RouterOutlet } } export declare class RouterModule { constructor(guard: any, router: Router); static ɵmod: i0.ɵɵNgModuleDeclaration<RouterModule, [typeof i1.RouterOutlet...]>; } ``` And therefore this commit adds support for reflecting types that are defined in such namespace declarations. Closes #42064 PR Close #42728 02 July 2021, 22:15:04 UTC
7e04116 Alan Agius 01 July 2021, 06:48:16 UTC fix(bazel): enable dts bundling for Ivy packages (#42728) It is now possible to bundle DTS files of Ivy libraries since the blocker https://github.com/microsoft/rushstack/issues/1029 has been addressed upstream. PR Close #42728 02 July 2021, 22:15:04 UTC
d041455 Alan Agius 01 July 2021, 06:24:46 UTC ci: remove `@microsoft/api-extractor` from `ignoreDeps` (#42728) We can now allow Renovate to manage this dependency. PR Close #42728 02 July 2021, 22:15:04 UTC
e99af18 Paul Gschwendtner 01 July 2021, 15:41:29 UTC build: update API goldens after api-extractor update (#42737) Given we have updated API extractor to the most recent version, we need to update the API goldens because the latest version uses alias exports to avoid collisions with default library globals (like `Event`). PR Close #42737 02 July 2021, 17:08:03 UTC
2feb4bc Paul Gschwendtner 11 June 2021, 15:28:37 UTC build: update api-extractor dependency to support typescript 4.3 (#42737) Updates the api-extractor dependencies of the repository, and within the `@angular/bazel` package so that TypeScript 4.3 is supported when a flattened typings file is generated. Without this update, the api extractor could fail if a referenced tsconfig use a TS 4.3-only option such as `noImplicitOverride`. Note: This could also be considered a `feat:` for `@angular/bazel`, but this package is not part of the public API anyway and we'd want that change to land in the patch branches too (to keep the goldens in sync between release branches as much as possible) PR Close #42737 02 July 2021, 17:08:03 UTC
6dd88aa Paul Gschwendtner 01 July 2021, 19:41:53 UTC fix(dev-infra): api-golden tool does not specify a tsconfig and breaks for consumers (#42737) Tools that are shipped as a Bazel rule with the shared dev-infra tool require a specific `tsconfig` as otherwise `ts_library` will accidentally look for a tsconfig in `@npm//:tsconfig` and the build will fail. We bring in our dev-infra tsconfig and reference it explicitly. PR Close #42737 02 July 2021, 17:08:03 UTC
e81efe6 George Kalpakas 02 July 2021, 09:08:05 UTC docs: convert commit SHAs and PR numbers in changelog to links (#42732) Since the recent update in the changelog format, the commit SHAs and PR numbers referenced there were not links, making it less straight-forward to get to the commit/PR corresponding to a change. The changelog generation tooling has been updated in a previous commit to output links for future changelog entries. This commit updates existing entries in `CHANGELOG.md` to have links for commit SHAs and corresponding PR numbers. PR Close #42732 02 July 2021, 16:23:45 UTC
c3620f9 George Kalpakas 02 July 2021, 09:08:05 UTC fix(dev-infra): convert commit SHAs and PR numbers to links when generating changelog (#42732) Previously, the commit SHAs and PR numbers referenced in the generated `CHANGELOG.md` were not automatically converted to links in the GitHub UI (as happens for release notes and issue/PR comments). This made it less straight-forward for someone reading the changelog to get to the commit/PR corresponding to a change. This commit updates the tooling that generates the changelog to convert the commit SHA and the corresponding PR number (referenced at the end of the commit message header) to links. PR Close #42732 02 July 2021, 16:23:45 UTC
19bcdfb George Kalpakas 02 July 2021, 10:31:46 UTC fix(docs-infra): correctly configure top-menu nav-item in the sidenav (#42747) Previously, the condition for showing the top-menu nav-menu in the sidenav was the same as that for switching the sidenav mode from docked (`mode: side`) to floating (`mode: over`). Therefore, the `isWide` input of the corresponding `NavMenuComponent` could be hard-coded to `false` (since the component would only be shown when the sidenav was in floating mode). In 61f6ed2fdfe58679cfada861624c759f1572a430, these two desicions were decoupled, which would result in the top-menu nav-item being shown in the sidenav while the sidenav is in docked mode (and thus the `isWide` input should be set to `true`). This commit fixes it by setting the `isWide` input based on the value of the `dockSideNav` property, as happens for the rest of the nav-menus. PR Close #42747 02 July 2021, 16:23:05 UTC
5aecf26 George Kalpakas 02 July 2021, 10:31:44 UTC refactor(docs-infra): simplify condition for determining sidenav mode (#42747) Previously, the `AppComponent#showTopMenu` property was taken into account when determining the `MatSidenav#mode` value. However, this was redundant, because in the only case in which the use of `showTopMenu` would make a difference (i.e. when `dockSideNav` was true and `isSideNavDoc` was false) the sidenav would be closed and the hamburger menu button would not be visible (thus there would be no way to open it manually). This commit simplifies the condition for determining the sidenav mode by removing `showTopMenu` from the expression. PR Close #42747 02 July 2021, 16:23:05 UTC
ffeea63 Andrew Scott 30 June 2021, 22:30:48 UTC fix(language-service): Do not override TS LS methods not supported by VE NgLS (#42727) Historically, our Language Service was built with the potential to be a drop-in replacement for the TypeScript Language Service with the added benefit of being able to provide Angular-specific information as well. While our VSCode extension does not use the Language Service in this way, it appears that other community-contributed plugins do. We don't really officially support this use-case but there's not real reason for us to override the TypeScript Language Service's implementation in the VE Angular Language Service so that it returns `undefined`. As with other non-implemented methods, we can just allow this to be deferred to TSLS. fixes #42715 PR Close #42727 01 July 2021, 22:23:50 UTC
74350a5 ivanwonder 24 June 2021, 02:28:42 UTC fix(compiler-cli): return directives for an element on a microsyntax template (#42640) When the template type checker try to get a symbol of a template node, it will not return the directives intended for an element on a microsyntax template, for example, `<div *ngFor="let user of users;" dir>`, the `dir` will be skipped, but it's needed in language service. Fixes https://github.com/angular/vscode-ng-language-service/issues/1420 PR Close #42640 01 July 2021, 16:35:24 UTC
bfa1b5d dario-piotrowicz 30 June 2021, 21:17:33 UTC fix(docs-infra): move dots inside Usage Notes anchor tag (#42725) in the html generated aio docs the dots of "Usage Notes..." should be part of the anchor tag, same as it is for "See More..." PR Close #42725 01 July 2021, 16:34:04 UTC
d997303 Renovate Bot 01 July 2021, 07:05:34 UTC build: update dependency husky to v7 (#42730) PR Close #42730 01 July 2021, 16:32:33 UTC
0f23f73 Kristiyan Kostadinov 26 June 2021, 09:28:12 UTC fix(core): error in TestBed if module is reset mid-compilation in ViewEngine (#42669) When `TestBed.compileComponents` is called under ViewEngine, we kick off a compilation and return a promise that resolves once the compilation is done. In most cases the consumer doesn't _have_ to await the returned promise, unless their components have external resources. The problem is that the test could be over by the time the promise has resolved, in which case we still cache the factory of the test module. This becomes a problem if another compilation is triggered right afterwards, because it'll see that we still have a `_moduleFactory` and it won't recreate the factory. These changes resolve the issue by saving a reference to the module type that is being compiled and checking against it when the promise resolves. Note that while this problem was discovered while trying to roll out the new test module teardown behavior in the Components repo (https://github.com/angular/components/pull/23070), it has been there for a long time. The new test behavior made it more apparent. PR Close #42669 30 June 2021, 21:32:23 UTC
1445dba Jessica Janiuk 30 June 2021, 20:29:51 UTC release: cut the v12.2.0-next.1 release (#42723) 30 June 2021, 20:29:51 UTC
24624e6 Joey Perrott 30 June 2021, 20:23:36 UTC docs: release notes for the v12.1.1 release (#42722) 30 June 2021, 20:23:36 UTC
59fe159 Paul Gschwendtner 28 June 2021, 17:54:20 UTC build: update API goldens to reflect new tool (#42688) Updates the TS API guardian goldens with their equivalents based on the new shared dev-infra tool. PR Close #42688 30 June 2021, 18:43:48 UTC
9db69a9 Paul Gschwendtner 28 June 2021, 17:50:44 UTC build: use api-golden tool from dev-infra for testing public API (#42688) Switches our TS API guardian targets to rather use the new tool from dev-infra that relies on Microsoft's API extractor. PR Close #42688 30 June 2021, 18:43:48 UTC
56bd21d Paul Gschwendtner 28 June 2021, 17:40:33 UTC feat(dev-infra): introduce shared tool for validating API signature (#42688) For the last years the Angular repositories relied on `ts-api-guardian` for testing the public API signature. This project worked well in general but its another inconvenience to maintain if we could rely on Microsoft's `api-extractor` tool. Especially since with TypeScript 4.3 issues with export aliases appeared that would require us to extend TS API guardian to support such exports. This is not as straightforward as it sounds, given it requires rewriting of declarations to show-case the proper name in the API golden. Microsoft's API extractor has integrated support for this. As of TypeScript 4.3, we want to start using the new `override` keyword. We are not able to use that keyword currently because an old version of API extractor is used in the `ng_module` rule to flatten the types into a single file. To fix this, we need to update `api-extractor`, but this unveils the issue with TS API guardian because the most recent version of api-extractor uses alias exports to avoid potential conflicts with globals available through the TypeScript default libraries (e.g. `dom.d.ts`). PR Close #42688 30 June 2021, 18:43:48 UTC
0e20b05 mgechev 21 June 2021, 20:59:01 UTC docs: add last updated date to roadmap (#42615) PR Close #42615 30 June 2021, 18:41:57 UTC
9f5cc7c Kristiyan Kostadinov 27 June 2021, 10:24:51 UTC feat(compiler): support number separators in templates (#42672) As of ES2021, JavaScript allows using underscores as separators inside numbers, in order to make them more readable (e.g. `1_000_000` vs `1000000`). TypeScript has had support for separators for a while so these changes expand the template parser to handle them as well. PR Close #42672 30 June 2021, 17:36:15 UTC
234b5ed Pete Bacon Darwin 29 June 2021, 16:30:12 UTC fix(platform-browser): in `Meta.addTag()` do not add duplicate meta tags (#42703) Previously, if there were two tags with the same "name" or "property" attribute selector, then only the first was checked for duplicates when deciding whether to add a new meta tag. Fixes #42700 Fixes #19606 PR Close #42703 30 June 2021, 17:35:30 UTC
f3965ff pavlenko 29 June 2021, 10:55:06 UTC docs: setting context value inside an interceptor (#42699) Usage of `get`/`set` methods should be done on a context object instead of a `HttpRequest` instance. PR Close #42699 30 June 2021, 16:13:46 UTC
8528073 Alan Agius 29 June 2021, 08:33:40 UTC fix(dev-infra): remove bots from special thanks section (#42697) With this change we remove known used bots from special thanks section in the changelog. PR Close #42697 29 June 2021, 18:13:50 UTC
f29fe5c Paul Gschwendtner 25 June 2021, 22:48:24 UTC fix(dev-infra): use API pagination for retrieving project branches (#42666) We rely on a Github API `/branches` request to determine the active release trains. Currently this logic is broken if more than 100 protected branches exist within a repository. This issue surfaced recently where the `items_per_page` setting was set to `30`, causing the merge tooling and release tooling to not detect the proper "latest" release train. This commit uses Github pagination for retrieving branches to determine the active release trains, and makes the logic more long-term proof. PR Close #42666 29 June 2021, 17:33:54 UTC
279e63f Paul Gschwendtner 25 June 2021, 22:45:48 UTC refactor(dev-infra): update octokit to latest version v18 (#42666) We previously held off with updating Octokit to v18 due to their more noticable issues with typings. This commit updates us to the latest version in order to take advantage of the new pagination API (which is also strongly-typed), and to not fall behind too much over time (Octokit seems to change quite often..) We work around the problem with the types for `getContent` by just using a type cast with a TODO (and link to the issue). Similarly we work around a problem where the Octokit types have an incorrect type for the name of the labels array in an API response. PR Close #42666 29 June 2021, 17:33:54 UTC
0274255 George Kalpakas 29 June 2021, 15:59:35 UTC refactor(docs-infra): make angular.io and docs examples compatible with RxJS v7 (#42660) This commit applies the necessary changes to make angular.io and (most) docs examples compatible with both RxJS v6 and v7. It also adds new steps to relevant CI jobs to test angular.io and docs examples against RxJS v7 as well (to catch potential regressions). NOTE: Some of the docs examples are not compatible with RxJS v7 and are therefore excluded from the tests. The SystemJS-based ngUpgrade examples in particular are excluded, since they require a different SystemJS configs to run against RxJS v6 and v7 and the extra complexity of managing that is not worth it for the 4 affected examples. PR Close #42660 29 June 2021, 17:29:58 UTC
188a738 George Kalpakas 29 June 2021, 15:59:35 UTC test(docs-infra): allow excluding certain docs examples from tests (#42660) This commit adds support for excluding certain docs examples from the command used to run tests. This is useful to run extra tests on CI that might not be compatible with all examples (for example, run tests with different versions of a dependency). In a subsequent commit, this will be used to run tests against RxJS v7 as a quick way to catch potential regressions. PR Close #42660 29 June 2021, 17:29:58 UTC
2c490d5 George Looshch 24 June 2021, 21:22:17 UTC docs: remove duplicate link to `guide/inputs-outputs.md` (#42654) When you click on `Understanding Angular > Components > Sharing data between child and parent directives and components` in navigation sidebar, another item gets selected: `Understanding Angular > Templates > Inputs and Outputs` Both of them are linked to the same guide but the view cannot handle situations when several entries point to the same guide. This commit fixes that by removing the second entry. Fixes #42652 PR Close #42654 29 June 2021, 16:27:47 UTC
41823ff Paul Gschwendtner 24 June 2021, 12:47:11 UTC feat(dev-infra): add command for printing release train information (#42644) Currently the active release trains are printed when a developer runs `ng-dev publish release`. This is not ideal because it requires the developer to provide an OAuth token, to be on the next branch, and to have no uncommitted changes, while the actual release train information is not dependent on these checks. This commit introduces a new command called `ng-dev release info` that can be used to retrieve relase information without the aforementioned requirements. Note that this command provides more detailed information about release branches than the `ng-dev caretaker check` command (which also requires on authentication as a side note). The `release info` command also prints active LTS branches for example. PR Close #42644 28 June 2021, 18:50:57 UTC
b54e8ae Alan Agius 24 June 2021, 10:59:11 UTC docs: update fonts optimization options description (#42642) In version 12.1, we included font inlining for Adobe fonts, see: https://github.com/angular/angular-cli/pull/21189 PR Close #42642 28 June 2021, 18:28:01 UTC
c93df7d Lars Gyrup Brink Nielsen 22 June 2021, 21:31:36 UTC docs: correct literal string example (#42623) Change literal string example `pi` to `'pi'`. PR Close #42623 28 June 2021, 17:05:09 UTC
1142b51 codebriefcase 23 June 2021, 03:51:58 UTC fix(docs-infra): styling fix on error pages (#42627) Add Center Aligment for heading texts and additional styles on 404 (not found) related pages PR Close #42627 28 June 2021, 16:50:24 UTC
4bea630 Dario Piotrowicz 27 June 2021, 15:34:32 UTC docs(core): add context jsdoc param to createEmbeddedView (#42675) PR Close #42675 28 June 2021, 16:34:17 UTC
2a260dc George Kalpakas 22 June 2021, 18:48:15 UTC docs: update Roadmap section header from "Done" to "Completed" (#42620) "Completed" just sounds better (to me). PR Close #42620 28 June 2021, 16:33:18 UTC
70def3d George Kalpakas 22 June 2021, 18:48:15 UTC fix(docs-infra): fix styling of `<summary>` elements on dark theme (#42620) Previously, the color of `<summary>` elements was hard-coded to `black`. This did not work well on the dark theme, where the background color of the page is also very dark. This commit fixes it by removing the explicit color style, thus letting `<summary>` elements inherit the color of their container. Closes #42616 PR Close #42620 28 June 2021, 16:33:18 UTC
e5b4b83 George Kalpakas 22 June 2021, 18:48:13 UTC fix(docs-infra): improve styling of completed Roadmap projects (#42620) This commit improves the styling of the "Completed projects" section of the Roadmap by (a) making it consistent with the rest of the Roadmap sections and (b) making it more similar with `<details>` elements on other pages. **Before:** _Collapsed:_ ![completed projects collapsed (before)][1] _Expanded:_ ![completed projects expanded (before)][2] **After:** _Collapsed:_ ![completed projects collapsed (after)][3] _Expanded:_ ![completed projects expanded (after)][4] [1]: https://user-images.githubusercontent.com/8604205/122917101-50c2ca00-d366-11eb-8348-01efd69cedf2.png [2]: https://user-images.githubusercontent.com/8604205/122917109-515b6080-d366-11eb-9f18-c794fcea8dd1.png [3]: https://user-images.githubusercontent.com/8604205/122917115-528c8d80-d366-11eb-947a-2d7da3950069.png [4]: https://user-images.githubusercontent.com/8604205/122917117-53252400-d366-11eb-93e7-9384a7431c0d.png PR Close #42620 28 June 2021, 16:33:17 UTC
fd78678 George Kalpakas 22 June 2021, 18:46:19 UTC refactor(docs-infra): make `<details>` styles more re-usable (#42620) This commit makes the styling for `<details>` elements (including expand/collapse actions in their `<summary>`) more re-usable. PR Close #42620 28 June 2021, 16:33:17 UTC
back to top