Skip to main content

Browse the archive

https://github.com/angular/angular
19 April 2024, 08:24:33 UTC
sort by:
Revision Author Date Message Commit Date
92368bc George Kalpakas 22 October 2020, 09:16:05 UTC build(docs-infra): upgrade cli command docs sources to bfcad1d71 (#39380) Updating [angular#10.2.x](https://github.com/angular/angular/tree/10.2.x) from [cli-builds#10.1.x](https://github.com/angular/cli-builds/tree/10.1.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/cba6d86ca...bfcad1d71): **Modified** - help/update.json PR Close #39380 22 October 2020, 20:48:56 UTC
eec5d2a AleksanderBodurri 20 October 2020, 03:50:06 UTC docs: update broken akita link in aio dev resources page (#39335) fixes #39331 PR Close #39335 22 October 2020, 20:43:55 UTC
cadb76c twerske 20 October 2020, 23:15:22 UTC refactor(core): group provider and circular errors (#39251) group together similar error messages as part of error code efforts ProviderNotFound & NodeInjector grouped into throwProviderNotFoundError Cyclic dependency errors grouped into throwCyclicDependencyError PR Close #39251 22 October 2020, 20:42:35 UTC
1146e47 ayazhafiz 05 October 2020, 04:31:22 UTC test(compiler): Demonstrate recoverable parsing of unterminated pipes (#39113) There is no actionable change in this commit other than to pretty-print EOF tokens. Actual parsing of unterminated pipes is already supported, this just adds a test for it. Part of #38596 PR Close #39113 22 October 2020, 20:41:52 UTC
38efd64 Joey Perrott 01 October 2020, 23:06:56 UTC refactor(dev-infra): create ng-dev executable locally in the repo (#39089) Rather than running ng-dev via ts-node, going forward ng-dev is generated and run locally via node. Additionally, the generated file is tested on each commit to ensure that the local generated version stays up to date. PR Close #39089 22 October 2020, 20:36:15 UTC
513ed49 Joey Perrott 20 October 2020, 21:47:13 UTC build: update bazelversion (#39351) Updates to the latest version of bazel PR Close #39351 21 October 2020, 18:59:42 UTC
61b1425 Andrew Kushnir 21 October 2020, 17:42:17 UTC release: cut the v10.2.0 release 21 October 2020, 17:42:17 UTC
71fb99f Keen Yee Liau 19 October 2020, 22:23:37 UTC fix(platform-server): Resolve absolute URL from baseUrl (#39334) This commit fixes a bug when `useAbsoluteUrl` is set to true and `ServerPlatformLocation` infers the base url from the supplied `url`. User should explicitly set the `baseUrl` when they turn on `useAbsoluteUrl`. Breaking change: If you use `useAbsoluteUrl` to setup `platform-server`, you now need to also specify `baseUrl`. We are intentionally making this a breaking change in a minor release, because if `useAbsoluteUrl` is set to `true` then the behavior of the application could be unpredictable, resulting in issues that are hard to discover but could be affecting production environments. PR Close #39334 (cherry picked from commit 7768aeb62fb6de5dd7777e713b0ceadb58366cd5) 21 October 2020, 16:46:22 UTC
7ca17a6 George Kalpakas 21 October 2020, 09:20:37 UTC build(docs-infra): upgrade cli command docs sources to cba6d86ca (#39360) Updating [angular#10.1.x](https://github.com/angular/angular/tree/10.1.x) from [cli-builds#10.1.x](https://github.com/angular/cli-builds/tree/10.1.x). ## Relevant changes in [commit range](https://github.com/angular/cli-builds/compare/ab97bc382...cba6d86ca): **Modified** - help/build.json - help/generate.json - help/test.json - help/xi18n.json PR Close #39360 21 October 2020, 15:27:13 UTC
3cce723 Arnaud Bernard 21 October 2020, 07:42:25 UTC docs: remove `style` commit type from CONTRIBUTING.md (#39357) Commit type Style is still present in Commiit Message Header while it shouldn't PR Close #39357 21 October 2020, 15:25:31 UTC
b7bf525 Kapunahele Wong 10 September 2020, 21:06:39 UTC docs: edit property binding doc (#38799) This commit edits the property binding doc copy and adds some docregions to clarify explanations. PR Close #38799 21 October 2020, 15:23:44 UTC
823200c Dave Shevitz 06 October 2020, 23:52:53 UTC docs: Add Component Overview topic to angular.io (#39186) PR Close #39186 20 October 2020, 17:47:45 UTC
cd8ec3d Jessica Janiuk 13 October 2020, 20:40:00 UTC docs: add Jessica Janiuk to contributors.json (#39253) PR Close #39253 19 October 2020, 23:25:18 UTC
02b8750 Josh Wiegand 15 October 2020, 02:28:29 UTC docs: clarify grammatical error (#39279) The sentence is grammatically incorrect. The new sentence fixes the error. PR Close #39279 19 October 2020, 21:32:42 UTC
32a8e72 Joey Perrott 15 October 2020, 17:58:51 UTC feat(dev-infra): prompt caretaker to confirm the merge branches on merge (#39333) Perviously, it was not immediately clear what branches a PR would merge into during the merge process. This prompt allows for caretakers to understand and acknowledge where the PR will merge to. PR Close #39333 19 October 2020, 19:06:17 UTC
7827d3e Aristeidis Bampakos 20 March 2020, 22:00:32 UTC docs: change definition of NgModules in Angular concepts guide (#36179) Indicate that the basic building block in Angular is the component which is organized into modules PR Close #36179 19 October 2020, 18:22:32 UTC
38db976 Johannes Hoppe 09 January 2020, 12:07:06 UTC docs: add Johannes Hoppe to GDE resources (#34694) PR Close #34694 19 October 2020, 15:04:58 UTC
d8632ed Ferdinand Malcher 09 January 2020, 12:06:48 UTC docs: add Ferdinand Malcher to GDE resources (#34694) PR Close #34694 19 October 2020, 15:04:58 UTC
10db995 Vlasis Charalampous 13 October 2020, 19:02:45 UTC refactor(docs-infra): fix `strictTemplates` failures in `accessibility` docs example (#39248) fix `strictTemplates` failures in `accessibility` docs example PR Close #39248 16 October 2020, 23:09:08 UTC
8fd59da Joey Perrott 15 October 2020, 15:58:38 UTC ci: separate the windows CI tests into build and test (#39289) Because the compiler-cli tests modify node_modules, this can cause failures on windows CI specifically as node_modules are symlinked to rather than copied. By running the test and build actions in separate commands, all of the tests are built to be executed before and tests are executed and modify the node_modules content. PR Close #39289 16 October 2020, 21:22:23 UTC
d8e313b Kapunahele Wong 14 September 2020, 21:12:32 UTC docs: edit attribute-binding doc and move colSpan note to property binding (#38860) This commit edits the copy of the attribute binding documentation, moves the colspan section that is primarily about property binding to the property binding document, and adds a docregion to the attribute-binding example to help clarify a point in the document. Part of the copy edit reformats the style precedence list in tabular format so that it is easier to read and understand. PR Close #38860 16 October 2020, 17:06:17 UTC
c602c9b Aristeidis Bampakos 19 August 2020, 07:19:39 UTC docs: Typos fixes in built-in directives guide (#38520) PR Close #38520 16 October 2020, 17:05:27 UTC
4a5f17c Pete Bacon Darwin 15 October 2020, 11:05:14 UTC build(docs-infra): add a tool to create new examples (#39283) This tool can be run from anywhere in the aio folder as: ```sh yarn create-example <example-name> ``` It will create some basic scaffold files to get the example started. After creation the developer should then use `yarn boilerplate:add` or similar to ensure that the example can be run and tested. You can optionally provide an absolute path to a pre-existing CLI project and it will copy over appropriate files (ignoring boilerplate) to the newly created example. ```sh yarn create-example <example-name> /path/to/other/cli/project ``` Fixes #39275 PR Close #39283 16 October 2020, 15:14:40 UTC
02405f1 mcalmus 13 March 2020, 12:28:40 UTC fix(core): guard reading of global `ngDevMode` for undefined. (#36055) When reading globals such as `ngDevMode` the read should be guarded by `typeof ngDevMode` otherwise it will throw if not defined in `"use strict"` mode. PR Close #36055 16 October 2020, 15:12:24 UTC
94d7ef3 Jessica Janiuk 14 October 2020, 22:11:01 UTC refactor(core): renames checkNoChangesMode to be clearer (#39277) getCheckNoChangesMode was discovered to be unclear as to the purpose of it. This refactor is a simple renaming to make it much clearer what that method and property does. PR Close #39277 16 October 2020, 00:01:22 UTC
4fd70a2 James Davies 15 October 2020, 23:03:09 UTC docs: Very minor spelling mistake (#39299) 1659: teh -> the PR Close #39299 16 October 2020, 00:00:20 UTC
af17038 Nicholas Papadopoulos 13 October 2020, 20:17:36 UTC docs: fix typo at console.log (#39252) PR Close #39252 15 October 2020, 21:15:37 UTC
95fcb41 CharaLagou 13 October 2020, 18:40:03 UTC docs(core): fix typo in the "Template statements" guide (#39244) PR Close #39244 15 October 2020, 21:14:26 UTC
f90c1f7 Joey Perrott 06 October 2020, 17:13:54 UTC refactor(dev-infra): remove branches created for g3 comparison (#39137) Previously, temporary branches were created to be used for comparison to the g3 branch, instead comparisons are now done using the branches latest shas. PR Close #39137 15 October 2020, 21:11:32 UTC
6efbc8b Stefanie Fluin 09 August 2019, 17:15:27 UTC docs: update readme (#32084) PR Close #32084 15 October 2020, 21:08:19 UTC
33c7d23 David Shevitz 24 September 2020, 20:11:29 UTC docs: Move pipes documentation from Components to Templates (#38983) PR Close #38983 15 October 2020, 21:07:29 UTC
670fac0 David Shevitz 17 September 2020, 16:39:51 UTC docs: deprecate displaying data in views topic (#38885) The Displaying Data in Views topic is actually a small tutorial that describes Angular features such as interpolation and structural directives. These content is already covered in our getting started tutorial and in Tour of Heroes. This change adds redirects to the Template Syntax section of the Getting Started tutorial and deletes displaying-data.md. PR Close #38885 15 October 2020, 21:05:29 UTC
9baa85f Joey Perrott 14 October 2020, 16:27:11 UTC ci: add jessicajaniuk to require-minimum-review reviewers (#39268) Add jessicajaniuk@ to the list of reviewers included in the required minimum reviewers list. PR Close #39268 15 October 2020, 18:06:05 UTC
72cdd42 macvag 13 October 2020, 17:16:26 UTC docs: Update output directory name in Deployment guide (#39247) The default output directory is no longer `dist/` but `dist/project-name/` PR Close #39247 15 October 2020, 16:08:24 UTC
591fa51 shaharkazaz 13 October 2020, 21:13:46 UTC docs: fix broken link (#39256) PR Close #39256 14 October 2020, 21:10:59 UTC
1623f5d Andrew Kushnir 07 October 2020, 04:45:28 UTC refactor(core): use relative import paths in micro benchmarks (#39142) This commit updates micro benchmarks to use relative path to Ivy runtime code. Keeping absolute locations caused issues with build optimizer that retained certain symbols and they appeared in the output twice. PR Close #39142 14 October 2020, 21:10:14 UTC
4207cff Andrew Kushnir 06 October 2020, 01:06:58 UTC test(core): add micro benchmarks for i18n scenarios (#39142) This commit adds micro benchmarks to run micro benchmarks for i18n-related logic in the following scenarios: - i18n static attributes - i18n attributes with interpolations - i18n blocks of static text - i18n blocks of text + interpolations - simple ICUs - nested ICUs First 4 scenarios also have baseline scenarios (non-i18n) so that we can compare i18n perf with non-i18n logic. PR Close #39142 14 October 2020, 21:10:14 UTC
f591fc8 Joey Perrott 07 October 2020, 20:25:08 UTC ci: setup windows from scratch (#39139) Rather than setting up windows by relying on attaching the saved workspace failes from the previous step, instead checkout and install the yarn items within the windows steps. Additionally, since the bazel remote cache is used and relied on, saving the cached results of the bazel runs to be resumed on subsequent runs does not provide enough value to make it worth the time consumed. PR Close #39139 14 October 2020, 21:09:50 UTC
c558c02 Joey Perrott 06 October 2020, 20:05:39 UTC ci: run windows CI jobs on PRs (#39139) Previously windows CI jobs were only run on upstream branches, with the addition of larger Windows executors as well as the improvement of setup speed in the windows environment setup script allows for the windows tests to pass in a reasonable timeframe. PR Close #39139 14 October 2020, 21:09:50 UTC
2664338 KingDarBoja 03 October 2020, 18:30:17 UTC docs: update marketing home loved-by-millions svg (#39105) docs: include entire worldmap docs: feedback changes on loved-by-millions PR Close #39105 14 October 2020, 21:09:26 UTC
5db7b4c atscott 14 October 2020, 20:33:19 UTC release: cut the v10.1.6 release 14 October 2020, 20:33:19 UTC
e08d021 Pete Bacon Darwin 14 October 2020, 15:30:09 UTC fix(ngcc): ensure that "inline exports" can be interpreted correctly (#39272) Previously, inline exports of the form `exports.foo = <implementation>;` were being interpreted (by the ngtsc `PartialInterpeter`) as `Reference` objects. This is not what is desired since it prevents the value of the export from being unpacked, such as when analyzing `NgModule` declarations: ``` exports.directives = [Directive1, Directive2]; @NgImport({declarations: [exports.directives]}) class AppModule {} ``` In this example the interpreter would think that `exports.directives` was a reference rather than an array that needs to be unpacked. This bug was picked up by the ngcc-validation repository. See https://github.com/angular/ngcc-validation/pull/1990 and https://circleci.com/gh/angular/ngcc-validation/17130 PR Close #39272 14 October 2020, 19:59:07 UTC
dae3a77 Pete Bacon Darwin 14 October 2020, 15:16:18 UTC refactor(compiler-cli): visit inline declarations with implementations differently (#39272) Some inline declarations are of the form: ``` exports.<name> = <implementation>; ``` In this case the declaration `node` is `exports.<name>`. When interpreting such inline declarations we actually want to visit the `implementation` expression rather than visiting the declaration `node`. This commit adds `implementation?: ts.Expression` to the `InlineDeclaration` type and updates the interpreter to visit these expressions as described above. PR Close #39272 14 October 2020, 19:59:07 UTC
02e75df Pete Bacon Darwin 03 October 2020, 20:14:59 UTC refactor(compiler-cli): ensure `isNamed....()` helpers check name is identity (#38959) (#39272) Previously the `node.name` property was only checked to ensure it was defined. But that meant that it was a `ts.BindingName`, which also includes `ts.BindingPattern`, which we do not support. But these helper methods were forcefully casting the value to `ts.Identifier. Now we also check that the `node.name` is actually an `ts.Identifier`. PR Close #38959 PR Close #39272 14 October 2020, 19:59:07 UTC
f752ab9 Pete Bacon Darwin 30 September 2020, 19:55:30 UTC fix(compiler-cli): support namespaced query types in directives (#38959) (#39272) Previously directive "queries" that relied upon a namespaced type ```ts queries: { 'mcontent': new core.ContentChild('test2'), } ``` caused an error to be thrown. This is now supported. PR Close #38959 PR Close #39272 14 October 2020, 19:59:07 UTC
9c875b3 Pete Bacon Darwin 29 September 2020, 19:58:57 UTC fix(ngcc): support inline export declarations in UMD files (#38959) (#39272) Previously, any declarations that were defined "inline" were not recognised by the `UmdReflectionHost`. For example, the following syntax was completely unrecognized: ```ts var Foo_1; exports.Foo = Foo_1 = (function() { function Foo() {} return Foo; })(); exports.Foo = Foo_1 = __decorate(SomeDecorator, Foo); ``` Such inline classes were ignored and not processed by ngcc. This lack of processing led to failures in Ivy applications that relied on UMD formats of libraries such as `syncfusion/ej2-angular-ui-components`. Now all known inline UMD exports are recognized and processed accordingly. Fixes #38947 PR Close #38959 PR Close #39272 14 October 2020, 19:59:07 UTC
8fa78d1 Pete Bacon Darwin 29 September 2020, 19:52:40 UTC test(ngcc): use `isNamedDeclaration()` helper to simplify tests (#38959) (#39272) Previously these tests were checking multiple specific expression types. The new helper function is more general and will also support `PropertyAccessExpression` nodes for `InlineDeclaration` types. PR Close #38959 PR Close #39272 14 October 2020, 19:59:07 UTC
26988f0 Pete Bacon Darwin 29 September 2020, 19:42:20 UTC refactor(compiler-cli): implement `DeclarationNode` node type (#38959) (#39272) Previously the `ConcreteDeclaration` and `InlineDeclaration` had different properties for the underlying node type. And the `InlineDeclaration` did not store a value that represented its declaration. It turns out that a natural declaration node for an inline type is the expression. For example in UMD/CommonJS this would be the `exports.<name>` property access node. So this expression is now used for the `node` of `InlineDeclaration` types and the `expression` property is dropped. To support this the codebase has been refactored to use a new `DeclarationNode` type which is a union of `ts.Declaration|ts.Expression` instead of `ts.Declaration` throughout. PR Close #38959 PR Close #39272 14 October 2020, 19:59:06 UTC
6acf117 Pete Bacon Darwin 27 September 2020, 10:57:38 UTC test(ngcc): use `isNamedFunctionDeclaration()` in UMD tests (#38959) (#39272) This makes these tests more resilient to changes in the test code structure. For example switching from ``` var SomeClass = <implementation>; exports.SomeClass = SomeClass; ``` to ``` exports.SomeClass = <implementation>; ``` PR Close #38959 PR Close #39272 14 October 2020, 19:59:06 UTC
8b731e3 Pete Bacon Darwin 27 September 2020, 12:03:21 UTC test(compiler-cli): make the `getDeclaration()` utility more resilient to code format (#38959) (#39272) Previously `getDeclaration()` would only return the first node that matched the name passed in and then assert the predicate on this single node. It also only considered a subset of possible declaration types that we might care about. Now the function will parse the whole tree collecting an array of all the nodes that match the name. It then filters this array based on the predicate and only errors if the filtered array is empty. This makes this function much more resilient to more esoteric code formats such as UMD. PR Close #38959 PR Close #39272 14 October 2020, 19:59:06 UTC
5378f78 Pete Bacon Darwin 27 September 2020, 10:54:37 UTC refactor(ngcc): simplify and break up ES2015 functions with helpers (#38959) (#39272) The protected helper functions can then be overridden by subclasses of the Esm2015ReflectionHost. PR Close #38959 PR Close #39272 14 October 2020, 19:59:06 UTC
495c40e Pete Bacon Darwin 27 September 2020, 10:42:43 UTC refactor(ngcc): simplify and rename `getClassDeclarationFromInnerDeclaration()` (#38959) (#39272) The new function does not try to restrict the kind of AST node that it finds, leaving that to the caller. This will make it more resuable in the UMD reflection host. PR Close #38959 PR Close #39272 14 October 2020, 19:59:06 UTC
9963c5d Pete Bacon Darwin 23 September 2020, 21:02:13 UTC fix(ngcc): handle aliases in UMD export declarations (#38959) (#39272) Sometimes UMD exports appear in the following form: ``` exports.MyClass = alias1 = alias2 = <<declaration>> ``` Previously the declaration of the export would have been captured as `alias1 = alias2 = <<declaration>>`, which the `PartialInterpreter` would have failed on, since it cannot handle assignments. Now we skip over these aliases capturing only the `<<declaration>>` expression. Fixes #38947 PR Close #38959 PR Close #39272 14 October 2020, 19:59:06 UTC
13c4a7b Pete Bacon Darwin 23 September 2020, 18:39:21 UTC fix(ngcc): map `exports` to the current module in UMD files (#38959) (#39272) UMD files export values by assigning them to an `exports` variable. When evaluating expressions ngcc was failing to cope with expressions like `exports.MyComponent`. This commit fixes the `UmdReflectionHost.getDeclarationOfIdentifier()` method to map the `exports` variable to the current source file. PR Close #38959 PR Close #39272 14 October 2020, 19:59:06 UTC
70e85d2 Pete Bacon Darwin 29 September 2020, 19:46:55 UTC test(ngcc): fix incorrect test setup (#38959) (#39272) The `SIMPLE_CLASS_FILE` contained a `ChildClass` that had an internal aliases implementation and extended a `SuperClass` base class. The call to `__extends` was using the wrong argument for the child class. PR Close #38959 PR Close #39272 14 October 2020, 19:59:06 UTC
dfb129d Pete Bacon Darwin 29 September 2020, 19:44:43 UTC refactor(compiler-cli): move map creation to avoid unnecessary work (#38959) (#39272) If the `symbol` for the given `node` does not exist then there is no point in creating the `map`. PR Close #38959 PR Close #39272 14 October 2020, 19:59:06 UTC
1a1407a Pete Bacon Darwin 27 September 2020, 10:29:58 UTC refactor(ngcc): rename `ExportStatement` to `ExportsStatement` (#38959) (#39272) This clarifies that this is specifically about statements of the form `exports.<name> = <declaration>`, rather than a general export statement such as `export class <ClassName> { ... }`. PR Close #38959 PR Close #39272 14 October 2020, 19:59:05 UTC
da71f76 Pete Bacon Darwin 27 September 2020, 10:04:31 UTC refactor(ngcc): remove unused imports (#38959) (#39272) The `isAssignment` and `isAssignmentStatement` are not used in this file. PR Close #38959 PR Close #39272 14 October 2020, 19:59:05 UTC
0c9b76e Pete Bacon Darwin 27 September 2020, 09:50:51 UTC refactor(compiler-cli): remove unnecessary constraint on `isDeclarationReference()` (#38959) (#39272) There is no need to check that the `ref.node` is of any particular type because immediately after this check the entry is tested to see if it passes `isClassDeclarationReference()`. The only difference is that the error that is reported is slightly different in the case that it is a `ref` but not one of the TS node types. Previously: ``` `Value at position ${idx} in the NgModule.${arrayName} of ${ className} is not a reference` ``` now ``` `Value at position ${idx} in the NgModule.${arrayName} of ${ className} is not a class` ``` Arguably the previous message was wrong, since this entry IS a reference but is not a class. PR Close #38959 PR Close #39272 14 October 2020, 19:59:05 UTC
db34b23 Pete Bacon Darwin 27 September 2020, 09:42:28 UTC test(compiler-cli): improve error message if a unit test is bad (#38959) (#39272) The message now also reports the name of the predicate function that failed. PR Close #38959 PR Close #39272 14 October 2020, 19:59:05 UTC
df09415 Alex Okrushko 07 October 2020, 02:03:15 UTC docs: add Discord as an official communication channel (#39149) PR Close #39149 14 October 2020, 17:23:16 UTC
5221df8 JoostK 13 October 2020, 21:06:07 UTC perf(ngcc): do not rescan program source files when referenced from multiple root files (#39254) When ngcc is configured to run with the `--use-program-dependencies` flag, as is the case in the CLI's asynchronous processing, it will scan all source files in the program, starting from the program's root files as configured in the tsconfig. Each individual root file could potentially rescan files that had already been scanned for an earlier root file, causing a severe performance penalty if the number of root files is large. This would be the case if glob patterns are used in the "include" specification of a tsconfig file. This commit avoids the performance penalty by keeping track of the files that have been scanned across all root files, such that no source file is scanned multiple times. Fixes #39240 PR Close #39254 14 October 2020, 16:34:11 UTC
bc35c6a atscott 13 October 2020, 21:31:03 UTC refactor(dev-infra): Adjust caretaker queries (#39257) - The current initial triage does not include PRs. This includes them by removing the issue filter - The merge assistance label is often applied to PRs that do not have status=success. Caretaker should handle these as well PR Close #39257 14 October 2020, 16:07:05 UTC
23fc2b4 sajeetharan 28 September 2020, 10:42:01 UTC updated sajee's profile (#39019) PR Close #39019 13 October 2020, 21:59:04 UTC
c16995e d0rian 13 October 2020, 17:05:35 UTC docs: fix typo in the Reactive Forms guide #5 (#39245) PR Close #39245 13 October 2020, 20:38:29 UTC
3487d5a David Shevitz 24 September 2020, 20:17:25 UTC docs: move Inputs and Outputs topic to Components section (#38984) PR Close #38984 12 October 2020, 19:40:50 UTC
1efc75c George Kalpakas 12 October 2020, 18:22:33 UTC fix(dev-infra): detect all commit message keywords that can close a PR (#39229) Previously, the `isCommitClosingPullRequest()` method (used in `ng-dev release` to detect whether a commit is closing a PR based on keywords found in the commit message) was only able to detect a subset of the keywords supported by GitHub. This is fine currently, because the merge script adds `PR Close #XYZ` when merging a PR, but it might break in the future. This commit makes the code more robust by ensuring the method can detect all keywords supported by GitHub for automatically closing a PR based on a commit message. Original discussion: https://github.com/angular/angular/pull/39135#discussion_r503440973 PR Close #39229 12 October 2020, 19:02:49 UTC
c4190e3 George Kalpakas 12 October 2020, 18:16:51 UTC fix(dev-infra): fix error message in `invokeSetNpmDistCommand()` function (#39229) In #39135, the commit message string was accidentally changed from a template literal to a regular string literal. This prevented the `npmDistTag` variable from being correctly displayed in the error message. This commit fixes it by switching it back to a template literal. NOTE: This was pointed out in https://github.com/angular/angular/pull/39135#discussion_r503361412, but the PR was accidentally merged before the review feedback had been addressed. PR Close #39229 12 October 2020, 19:02:49 UTC
5d98834 George Kalpakas 10 October 2020, 19:02:48 UTC fix(dev-infra): correctly check for commit that closes PR (#39135) The `ng-dev release publish` command needs to check whether a commit closed a pull request. This is implemented via checking the commit message for specific closing keywords referencing the pull request number. The regex used previously failed to correctly ensure that the specified pull request was referenced. For example, it would allow `#12345` to also match for `#1234`. This commit fixes the regex. PR Close #39135 12 October 2020, 17:47:14 UTC
529ff73 George Kalpakas 10 October 2020, 19:02:47 UTC refactor(dev-infra): several code style and typo fixes (#39135) This commit addresses comments from [my review][1] on PR #38656 (which was merged without comments addressed). The changes are mostly related to code style and typos. [1]: https://github.com/angular/angular/pull/38656#pullrequestreview-482129333 PR Close #39135 12 October 2020, 17:47:14 UTC
7912050 Taymon A. Beal 02 June 2020, 15:21:59 UTC refactor(animations): do not assign to innerHTML (#37397) This should not change behavior, but it prevents false-positive warnings in various static analysis tools, including tools used internally at Google. PR Close #37397 12 October 2020, 17:45:00 UTC
2d37e47 George Kalpakas 09 October 2020, 18:04:43 UTC build(docs-infra): support passing args to `ng serve` via `serve-and-sync` (#39201) When working on the docs, it is helpful to run a local instance of the angular.io app and run scripts that watch both the docs contents and the app build artifacts to automatically update the running instance on changes. Typically, this is achieved via the `start` and `docs-watch` npm scripts. As a convenience, one can run the `serve-and-sync` script, which runs both in one terminal. Previously, it was not possible to pass arguments to `ng nerve` (which is what the `start` script runs under the hood) when running it via `serve-and-sync`. This commit adds support for passing any arguments passed to `serve-and-sync` through to the `start` script. This can be useful for things like specifying a custom host or port. PR Close #39201 12 October 2020, 15:27:01 UTC
27c8066 George Kalpakas 10 October 2020, 16:28:59 UTC docs: add linkable section about updating commit messages in `CONTRIBUTING.md` (#39215) A common review request is updating the commit message of a commit. Since this is something that is not straight forward for inexperienced contributors, it is useful to be able to point a contributor to some docs outlining the process. This commit adds such a section in `CONTRIBUTING.md` (as discussed in https://github.com/angular/angular/pull/39110#discussion_r499935502). PR Close #39215 12 October 2020, 15:26:09 UTC
952fd86 Adam Plumer 08 October 2020, 01:38:46 UTC fix(elements): detect matchesSelector prototype without IIFE (#37799) Although in SSR we patch the global prototypes with DOM globals like Element and Node, this patch does not occur before the matches function is called in Angular Elements. This is similar to the behavior in @angular/upgrade. Fixes #24551 PR Close #37799 09 October 2020, 17:02:25 UTC
42be904 Andrew Scott 08 October 2020, 18:49:10 UTC feat(dev-infra): Add github links to caretaker checks (#39185) This commit adds links to the PR/Issue for queries in the caretaker check. PR Close #39185 09 October 2020, 16:39:33 UTC
52a0c6b crisbeto 05 September 2020, 09:30:54 UTC fix(compiler): incorrectly encapsulating @import containing colons and semicolons (#38716) At a high level, the current shadow DOM shim logic works by escaping the content of a CSS rule (e.g. `div {color: red;}` becomes `div {%BLOCK%}`), using a regex to parse out things like the selector and the rule body, and then re-adding the content after the selector has been modified. The problem is that the regex has to be very broad in order capture all of the different use cases, which can cause it to match strings suffixed with a semi-colon in some places where it shouldn't, like this URL from Google Fonts `https://fonts.googleapis.com/css2?family=Roboto:wght@400;500&display=swap`. Most of the time this is fine, because the logic that escapes the rule content to `%BLOCK%` will have converted it to something that won't be matched by the regex. However, it breaks down for rules like `@import` which don't have a body, but can still have quoted content with characters that can match the regex. These changes resolve the issue by making a second pass over the escaped string and replacing all of the remaining quoted content with `%QUOTED%` before parsing it with the regex. Once everything has been processed, we make a final pass where we restore the quoted content. In a previous iteration of this PR, I went with a shorter approach which narrowed down the regex so that it doesn't capture rules without a body. It fixed the issue, but it also ended up breaking some of the more contrived unit test cases. I decided not to pursue it further, because we would've ended up with a very long and brittle regex that likely would've broken in even weirder ways. Fixes #38587. PR Close #38716 09 October 2020, 15:33:05 UTC
8913aee Bjarki 08 October 2020, 00:28:39 UTC build: bump Chromium to next stable version: 84.0.4147 (#39179) Bump Chrome to the next stable release (84.0.4147) by following the instructions in dev-infra/browsers/README.md. With Chrome 86 about to be released as stable, the current local version (Chrome 83) is starting to lag behind. It also contains a bug that blocks Angular unit and integration tests from using Trusted Types. PR Close #39179 09 October 2020, 14:53:12 UTC
7628c36 Greg Magolan 25 June 2020, 08:32:41 UTC build: upgrade angular build, integration/bazel and @angular/bazel package to rule_nodejs 2.2.0 (#39182) Updates to rules_nodejs 2.2.0. This is the first major release in 7 months and includes a number of features as well as breaking changes. Release notes: https://github.com/bazelbuild/rules_nodejs/releases/tag/2.0.0 Features of note for angular/angular: * stdout/stderr/exit code capture; this could be potentially be useful * TypeScript (ts_project); a simpler tsc rule that ts_library that can be used in the repo where ts_library is too heavy weight Breaking changes of note for angular/angular: * loading custom rules from npm packages: `ts_library` is no longer loaded from `@npm_bazel_typescript//:index.bzl` (which no longer exists) but is now loaded from `@npm//@bazel/typescript:index.bzl` * with the loading changes above, `load("@npm//:install_bazel_dependencies.bzl", "install_bazel_dependencies")` is no longer needed in the WORKSPACE which also means that yarn_install does not need to run unless building/testing a target that depends on @npm. In angular/angular this is a minor improvement as almost everything depends on @npm. * @angular/bazel package is also updated in this PR to support the new load location; Angular + Bazel users that require it for ng_package (ng_module is no longer needed in OSS with Angular 10) will need to load from `@npm//@angular/bazel:index.bzl`. I investigated if it was possible to maintain backward compatability for the old load location `@npm_angular_bazel` but it is not since the package itself needs to be updated to load from `@npm//@bazel/typescript:index.bzl` instead of `@npm_bazel_typescript//:index.bzl` as it depends on ts_library internals for ng_module. * runfiles.resolve will now throw instead of returning undefined to match behavior of node require Other changes in angular/angular: * integration/bazel has been updated to use both ng_module and ts_libary with use_angular_plugin=true. The latter is the recommended way for rules_nodejs users to compile Angular 10 with Ivy. Bazel + Angular ViewEngine is supported with @angular/bazel <= 9.0.5 and Angular <= 8. There is still Angular ViewEngine example on rules_nodejs https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/angular_view_engine on these older versions but users that want to update to Angular 10 and are on Bazel must switch to Ivy and at that point ts_library with use_angular_plugin=true is more performant that ng_module. Angular example in rules_nodejs is configured this way as well: https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/angular. As an aside, we also have an example of building Angular 10 with architect() rule directly instead of using ts_library with angular plugin: https://github.com/bazelbuild/rules_nodejs/tree/stable/examples/angular_bazel_architect. NB: ng_module is still required for angular/angular repository as it still builds ViewEngine & @angular/bazel also provides the ng_package rule. ng_module can be removed in the future if ViewEngine is no longer needed in angular repo. * JSModuleInfo provider added to ng_module. this is for forward compat for future rules_nodejs versions. PR Close #39182 08 October 2020, 18:55:00 UTC
b417dd7 Chellappan 07 October 2020, 17:33:42 UTC docs: fix for HttpRequest expansion panel (#39166) Fixes #39156 PR Close #39166 08 October 2020, 16:38:10 UTC
8cf16b4 Alan Agius 06 October 2020, 10:29:58 UTC feat(docs-infra): add short url for strict mode guide (#39129) With this change we add a short url to strict mode guide (angular.io/strict -> angular.io/guide/strict-mode). This is important because of two reasons. 1) Reduce the clutter in the terminal when we include the strict mode guide url in a prompt. 2) Easiler to share in conferences, slides etc.. PR Close #39129 08 October 2020, 15:45:03 UTC
806aed6 Joey Perrott 07 October 2020, 20:19:33 UTC test(compiler-cli): temporarily disable integrationtest (#39168) Temporarily disable the //packages/compiler-cli/integrationtest:integrationtest target while continuing to investigate its unknown failures PR Close #39168 08 October 2020, 15:43:49 UTC
eb34037 atscott 07 October 2020, 22:15:24 UTC Revert "refactor(compiler-cli): wrap RHS of property write in parens (#39143)" (#39171) This reverts commit ba0df5250f667c337b61ef7415d178ef27024207. Causes CI failures PR Close #39171 07 October 2020, 23:09:07 UTC
ba0df52 Andrew Scott 06 October 2020, 22:02:19 UTC refactor(compiler-cli): wrap RHS of property write in parens (#39143) The right needs to be wrapped in parens or we cannot accurately match its span to just the RHS. For example, the span in `e = $event /*0,10*/` is ambiguous. It could refer to either the whole binary expression or just the RHS. We should instead generate `e = ($event /*0,10*/)` so we know the span 0,10 matches RHS. This is specifically needed for the TemplateTypeChecker/Language Service when mapping template positions to items in the TCB. PR Close #39143 07 October 2020, 21:49:47 UTC
c4553bb Joey Perrott 07 October 2020, 21:20:12 UTC release: cut the v10.1.5 release 07 October 2020, 21:20:12 UTC
cc13b37 Pete Bacon Darwin 07 October 2020, 19:56:53 UTC build(docs-infra): render optional decorator options with a ? (#39167) Decorator API pages list all their available options in an overview table and also in a detailed view. Now the rendered syntax of each option will show a `?` after the name if the option is not required. This is inline with how class and interface members are rendered. PR Close #39167 07 October 2020, 20:33:26 UTC
166df5d Kizashi Nagata 01 October 2020, 13:57:41 UTC refactor(common): remove `i` (ignore case) regex flag where it is not needed (#39077) It is not necessary to set IGNORECASE flag when the regex pattern does not contain alphabetic characters PR Close #39077 07 October 2020, 20:32:00 UTC
a5b4745 Sonu Kapoor 06 October 2020, 12:22:07 UTC docs: change heading to a sub-heading (#39131) This commit changes the heading of the section `Use TypeScript path mapping for peer dependencies` to a sub-heading of `Linked Libraries`. Fixes #39130 PR Close #39131 07 October 2020, 20:31:24 UTC
9f132d0 Nihal 01 October 2020, 15:59:29 UTC docs: remove explicit boolean type in examples as TS infers it automatically (#39081) In the `packages/examples/common/ngif/module.ts` file, the field `show` is given an explicit boolean type. Since typescript infers boolean type, it is redundant and this commit removes it. PR Close #39081 06 October 2020, 15:39:02 UTC
8dee378 George Kalpakas 04 October 2020, 19:30:47 UTC docs: add info about working with fixup commits (#39110) Using fixup commits when addressing review feedback can considerably improve the review experience on subsequent reviews. This commit adds information and guidelines for contributors on how to work with fixup commits. Fixes #33042 PR Close #39110 06 October 2020, 15:38:35 UTC
0845d11 Joey Perrott 05 October 2020, 22:42:11 UTC build: update bazelversion (#39123) Updates to the latest version of bazel PR Close #39123 06 October 2020, 00:08:08 UTC
7cfa57a Joey Perrott 05 October 2020, 22:46:36 UTC ci: use larger resource classes for bazel builds (#39124) Migrates to using larger resource classes for windows CI runs as well as updating the bazel rcs for windows and linux to use all/more of the resources available in the executors PR Close #39124 06 October 2020, 00:06:49 UTC
f80c220 ayazhafiz 25 September 2020, 16:45:46 UTC test(compiler): add tests for parsing of malformed property reads (#38998) The expression parser already has support for recovering on malformed property reads, but did not have tests describing the recovered ast in such cases. This commit adds tests to demonstrate such cases; in particular, the recovered ast is a full PropertyRead but with an empty property name. This is likely the most preferred option, as it does not constrain consumers of the AST to what the property name should look like. Furthermore, we cannot mark the property name as empty in any other way (e.g. an EmptyExpr) because the property name, as of present, is a string field rather than an AST itself. Note that tokens past a malformed property read are not preserved in the AST (for example in `foo.1234`, `1234` is not preserved in the AST). This is because the extra tokens do not belong to the singular expression created by the property read, and there is not a meaningful way to interpret a secondary expression in a single parsed expression. Part of #38596 PR Close #38998 05 October 2020, 21:24:47 UTC
7aa1241 David Shevitz 24 September 2020, 20:30:13 UTC docs: Migrate section, view encapsulation, from Component Styles topic into its own topic. (#38986) PR Close #38986 05 October 2020, 20:23:41 UTC
072b707 Joey Perrott 30 September 2020, 23:12:11 UTC ci: update to latest version of sauce-connect (#39073) Update to the latest version of sauce-connect, 4.6.2. PR Close #39073 05 October 2020, 19:53:28 UTC
223b80c Benjamin Qin 17 September 2020, 01:50:51 UTC docs(common): update docs for HttpClient methods (#38878) PR Close #38878 05 October 2020, 19:43:48 UTC
416403f bobin-knol 21 September 2020, 06:44:40 UTC docs: Made a minor change in the documentation (#38917) PR Close #38917 05 October 2020, 19:43:15 UTC
878e2f0 Joey Perrott 30 September 2020, 20:16:33 UTC feat(dev-infra): show CI status of all active release trains (#39067) As part of the ng-dev caretaker check command, show the status of the lastest CircleCI run for each active release train. PR Close #39067 05 October 2020, 17:23:34 UTC
4c30f51 Alison 02 October 2020, 21:39:08 UTC docs(upgrade): expand upon change detection implications for downgraded components (#39100) PR Close #39100 05 October 2020, 15:08:31 UTC
6791cd7 ayazhafiz 24 September 2020, 16:22:12 UTC refactor(compiler): iteratively parse interpolations (#38977) This patch refactors the interpolation parser to do so iteratively rather than using a regex. Doing so prepares us for supporting granular recovery on poorly-formed interpolations, for example when an interpolation does not terminate (`{{ 1 + 2`) or is not terminated properly (`{{ 1 + 2 {{ 2 + 3 }}`). Part of #38596 PR Close #38977 02 October 2020, 22:13:24 UTC
f50313f ayazhafiz 25 September 2020, 23:52:06 UTC feat(compiler): Recover on malformed keyed reads and keyed writes (#39004) This patch adds support for recovering well-formed (and near-complete) ASTs for semantically malformed keyed reads and keyed writes. See the added tests for details on the types of semantics we can now recover; in particular, notice that some assumptions are made about the form of a keyed read/write intended by a user. For example, in the malformed expression `a[1 + = 2`, we assume that the user meant to write a binary expression for the key of `a`, and assign that key the value `2`. In particular, we now parse this as `a[1 + <empty expression>] = 2`. There are some different interpretations that can be made here, but I think this is reasonable. The actual changes in the parser code are fairly minimal (a nice surprise!); the biggest addition is a `writeContext` that marks whether the `=` operator can serve as a recovery point after error detection. Part of #38596 PR Close #39004 02 October 2020, 18:37:03 UTC
back to top