https://github.com/apple/swift

sort by:
Revision Author Date Message Commit Date
669cbb6 [Preset] Add corelibs foundation presets (SR-9950) (cherry picked from commit e8733ced34db1244abca5052664492997772f573) 21 February 2019, 07:56:36 UTC
48e4b26 Update lldb branch for swift-5.1-branch 18 February 2019, 20:54:43 UTC
4f969b4 Merge pull request #22641 from fredriss/fixes-for-lldb-5.1 Fixes for lldb 5.1 16 February 2019, 15:29:41 UTC
663f49c [GSB] Consistently use nested type name match constraints. We generated a mix of "inferred" and "nested type name match" constraints for the case where we had two nested types with the same name and inferred that they are equal. Make them consistent by always using nested type name match constraints. This fixes a bug where we would get different canonical generic signatures in different source files because we inferred the same-type constraint with different requirement sources. Fixes rdar://problem/48049725. 16 February 2019, 01:00:12 UTC
c6b1b63 migrator: add ! to property access whose definition changes from nonnull to nullable. rdar://48090648 16 February 2019, 00:59:50 UTC
8c3a8bc [Preset] Add preset to build no-assertion build without test suite 16 February 2019, 00:58:12 UTC
14c838e [TypeChecker] Disable perf test-case for rdar://problem/21398466 Looks like obsoleted initializer has been removed, and there are no solutions available for 'init(truncatingBitPattern:)' which leads to performance regression with designated types enabled. Resolves: rdar://problem/48061151 16 February 2019, 00:57:31 UTC
c476fce [DebuggerSupport] Unbreak closures in the expression parser. The new trick is that of leavign an unresolved identifier for the expression parser to fill in. <rdar://problem/47982630> 16 February 2019, 00:56:55 UTC
0e8fc0c [Parse] Add a test for the change. 16 February 2019, 00:56:40 UTC
8f3cd35 [CSBindings] Preserve l-valueness of optional object type Result of force unwrap is always connected to its base optional type via `OptionalObject` constraint which preserves l-valueness, so in case where object type got inferred before optional type (because it got the type from context e.g. parameter type of a function call), we need to test type with and without l-value after delaying bindings for as long as possible. Resolves: rdar://problem/47967277 16 February 2019, 00:56:40 UTC
de378c3 Remove overly-permissive UnsafePointer init 16 February 2019, 00:56:40 UTC
188eff5 Fix crashes in Unsafe[Raw]BufferPointer with nil baseAddress. This fix updates various initializers to handle incoming empty buffers that happen to have a nil base. They should simply create another buffer with nil base rather than crashing! It is valid for an Unsafe[Raw]BufferPointer can have a nil base address. This allows round-tripping with C code that takes a pointer/length pair and uses `0` as the pointer value. The original design wrongly assumed that we would use a sentinel value for empty buffers and was never updated for or tested with the current design. Fixes <rdar://problem/47946984> Regression in Foundation.Data's UnsafeBufferPointer constructor. 16 February 2019, 00:56:40 UTC
ee0476d Extend transitive availability checking to initial value expressions Because initial value expressions aren't actually considered /within/ the VarDecl or PatternBindingDecl they're initializing, the existing logic to search for availability attributes wasn't kicking in, leading to errors when a conditionally-unavailable value was used in an initial value expression for a conditionally-unavailable binding. Fix this by walking the enclosing type or extension to find the appropriate PatternBindingDecl. https://bugs.swift.org/browse/SR-9867 16 February 2019, 00:56:40 UTC
a01fb66 Merge pull request #22661 from bob-wilson/rdar47777548 [master-next] Remove workaround for -Wobjc-property-assign-on-object-type 15 February 2019, 23:56:00 UTC
f1a6c4a [master-next] Remove workaround for -Wobjc-property-assign-on-object-type The issue was fixed in https://github.com/apple/swift/pull/19167 so we no longer need to disable this warning. rdar://problem/47777548 15 February 2019, 22:04:28 UTC
28d1cd3 [DebuggerSupport] Unbreak closures in the expression parser. The new trick is that of leavign an unresolved identifier for the expression parser to fill in. <rdar://problem/47982630> (cherry picked from commit 49b2f4eba7f438cae2072813579ee089a8dc2c31) 15 February 2019, 01:36:00 UTC
fbe3f49 RemoteAST: Clean up use of std::pair and std::tuple for opened existentials with named structs (cherry picked from commit 905a6def79fb70b7bc88dd3da0c917971f664c33) 15 February 2019, 01:20:29 UTC
7b9c8c6 RemoteAST: Tweak swift-remoteast-test to reuse the context I need this to reproduce a test failure. (cherry picked from commit c16fed7d71450a12e48c013faf9b504ca553a014) 15 February 2019, 01:20:29 UTC
2d7f4c1 RemoteAST: Add new entry point to unwrap an Error existential container The getDynamicTypeAndAddressForExistential() function takes the address of an existential value; so when looking at an Error, this is the address of the reference, not the address of the instance. lldb needs to look at Error instances too, so add a new entry point named getDynamicTypeAndAddressForError() which avoids the extra dereference. This will be tested on the lldb side. (cherry picked from commit 56a74c4cd399037059621dac0186343bd45461c4) 15 February 2019, 01:06:31 UTC
7bb21b1 RemoteAST: More consistent behavior of existentials inside classes LLDB calls getDynamicTypeAndAddressForExistential() on an existential value without knowing if its a class existential or opaque existential. Class existentials return the address of the instance itself here, whereas opaque existentials always returned the address of the payload value. This meant the caller could not usefully operate on the payload value if it was of class type, because there was no way of knowing if the extra dereference had occurred or not. Now, always load the reference if the wrapped type is a class, even if the existential is opaque. Will be tested on the lldb side with another change I'm working on. (cherry picked from commit bd3b45138f39d1885e9fbc88a3b541f0f9506a17) 15 February 2019, 01:06:27 UTC
ad1c3d4 RemoteAST: Re-enable existentials_objc.swift test now that its fixed (cherry picked from commit 1dd6765c84ff4979645936e0e24236c6169ca8f7) 15 February 2019, 00:56:02 UTC
f1e0b36 MetadataReader: Add support for NSError toll-free bridging An Error existential value can directly store a reference to an NSError instance without wrapping it in an Error container. When "projecting" such an existential, the dynamic type is the NSError's isa pointer, and the payload is the address of the instance itself. (cherry picked from commit 76ebaee07839f6dd7d7bed69eacc1bf3c672449e) 15 February 2019, 00:55:56 UTC
a663d2f MetadataReader: Fix caching of Objective C class metadata If resolving the type of an instance produces a class metadata for which we cannot build a type (for example, a special class like __NSCFNumber, which the ClangImporter does not produce a ClassDecl for), we try the superclass. The caching logic was broken in this case, so subsequent calls would return an empty type. (cherry picked from commit 28f305bf75faed937fdca155b2f2e03d5febe1d9) 15 February 2019, 00:55:50 UTC
b8ead05 [remote-ast] Disable non-deterministic test failure. This is failing for me ~10% of the time. It is resulting in spurious PR testing failures. SR-9908 (cherry picked from commit fffbbfe4de44ca005dabd2e9266b8caaa8b4d29e) 15 February 2019, 00:55:39 UTC
8ec4e5c MetadataReader: Add support for Objective-C tagged pointers (#22498) This allows Remote Mirrors and RemoteAST to inspect existentials containing instances of imported classes. (cherry picked from commit dc3abd14c370d214349ac15ff8862ea3f395b28f) 15 February 2019, 00:55:32 UTC
a09460e Merge pull request #22617 from aschwaighofer/fix_newtype_test_5.1 [5.1] Fix test for branch 14 February 2019, 18:37:34 UTC
4a2ac1b Rename lldb-test-depends -> lldb-test-deps This matches the change in upstream LLDB. I've also aligned the invocations to improve the readability and make it clear that they're separate commands executed after each other. (cherry picked from commit 5b1d826e9e310297d5fc2fc1a4683ba589059e1b) 14 February 2019, 18:10:52 UTC
345b216 Fix test for branch The optimizer decided to move casts around. rdar://48056043 14 February 2019, 16:47:17 UTC
54acc5e [CMake] StandaloneOverlay: set components before including apinotes/ (#22601) Otherwise, we'll think we don't need to install the API notes. No test because this configuration isn't (yet) tested publicly anywhere, but it is being tested within Apple. (cherry picked from commit bc35b34c6454cc960f3f58c5c7feb2074f16c43b) 14 February 2019, 01:58:57 UTC
a13defd Merge pull request #22599 from bob-wilson/rdar48056043 swift-5.1: temporarily disable the IRGen/newtype.swift test 14 February 2019, 00:49:28 UTC
70f0538 swift-5.1: temporarily disable the IRGen/newtype.swift test The expected output needs to be adjusted for differing optimizer behavior. Tracked by rdar://problem/48056043 14 February 2019, 00:47:00 UTC
7878ece Merge remote-tracking branch 'origin/swift-5.1-old-llvm-branch' into swift-5.1-branch 09 February 2019, 01:39:24 UTC
06120c9 More fixes in recent Swift changes to work with newer VFS code. 09 February 2019, 00:01:41 UTC
1b453be Update radar number in DebugInfo test The current radar tracking this disabled test is rdar://problem/47777473 See also the similar change on master-next in https://github.com/apple/swift/pull/22484 08 February 2019, 22:57:51 UTC
80ce2c3 Merge pull request #22387 from xiaobai/fix_modulecache_dbginfo_test [DebugInfo] Make modulecache test windows-compatible 08 February 2019, 22:25:01 UTC
9326ef4 [upstream-update] Update LLVMPasses for new objc arc intrinsics. We used to represent these just as normal LLVM functions, e.x.: declare objc_object* @objc_retain(objc_object*) declare void @objc_release(objc_object*) Recently, special objc intrinsics were added to LLVM. This pass updates these small (old) passes to use the new intrinsics. This turned out to not be too difficult since we never create these instructions. We only analyze them, move them, and delete them. rdar://47852297 08 February 2019, 22:22:57 UTC
b1be41a Implement some more LLVM intrinsic type-decoding rules. 08 February 2019, 22:22:57 UTC
b45ca04 Use the new ObjC retain/release intrinsics in IRGen. 08 February 2019, 22:22:57 UTC
8719f52 ClangImporter: adjust for SVN r349901 The constructor for `DeclRefExpr` now takes a `Context` parameter to avoid the call to `getASTContext`. Adjust the invocation accordingly. 08 February 2019, 22:22:57 UTC
437cfa7 IRGen: adjust for SVN r348827 CodeGenOptions.h was moved from Frontend to Basic. 08 February 2019, 22:22:57 UTC
40e2a7c master-next: Fix up recent Swift changes to work with newer VFS code. The main different here is that VFS moved from clang to llvm. 08 February 2019, 22:22:57 UTC
5e16a65 master-next: Update DebugInfo tests for llvm r347806 Check for the DISPFlagDefinition flag instead of "isDefinition: true". 08 February 2019, 22:22:56 UTC
93b29dc master-next: Add switch case for new Hurd triple in llvm r347832 08 February 2019, 22:22:56 UTC
0ac9a7d Update tests for upstream LLVM IR assembler changes 08 February 2019, 22:22:56 UTC
e787906 [test] Update ClangImporter/enum-anon.swift for Clang improvements (#20804) We previously weren't able to import something properly, but now it's working because of some change in Clang. Let's take it! rdar://problem/46263312 08 February 2019, 22:22:56 UTC
0dda766 IRGen: adjust for SVN r347239 DW_TAG_subprogram has its own flag word now. Adjust building the debug info. 08 February 2019, 22:22:56 UTC
37f8268 Fix compatibility with upstream clang changes 08 February 2019, 22:22:56 UTC
db1c894 ClangImporter: update for SVN r345605 Update for API changes in clang SVN r345605. 08 February 2019, 22:22:56 UTC
562e6f5 ClangImporter: adjust for SVN r345637 `ObjC1` has been removed from clang. Use `ObjC` to detect if Objective-C language support is enabled. 08 February 2019, 22:22:56 UTC
093d483 Merge pull request #22464 from moiseev/os-log-buffer-fix [overlay] Size the os_log pack buffer appropriately 08 February 2019, 18:11:40 UTC
0f493a6 [Sema] Improve diagnostics for access level of protocol witness in extension. (#22235) If the access level of a protocol witness does not satisfies a requirement, the compiler suggests marking it as the required level. This is not suitable when the witness is in an extension whose specified access level is less than the required level, since the fixit fights with other warnings in this case. This patch identifies such case and produces improved diagnostics. Resolves: SR-9793 08 February 2019, 17:31:01 UTC
2301bff Add some defensive checks against invalid serialization (#22466) If a non-serializable Decl or Type makes it into serialization logic in a release build, an invalid swiftmodule might be produced silently, leading to crashes in clients. Try to catch this with an on-in-Release check that /something/ was serialized. (This is my best guess at how rdar://problem/47459323 occurred.) 08 February 2019, 17:04:08 UTC
60da82b [GSB] [Diag] Constraint to concrete type using ":" should offer a fix-it (#22152) * [diag] add a diagnostic note for the fixit * [gsb] emit a diagnostic with fixit to replace ':' with '==' * [gsb] rename variable * [gsb] replace dyn_cast with isa * [test] add a test case * [test] update tests * [gsb] emit diagnostic for protocols as well * [gsb] simplify if statement * [gsb] rename a variable * [gsb] Create a helper to remove Self. prefix and add a new test case * [gsb] simplify checks * [gsb] move the diagnostic code to finalize() * [gsb] re-indent * [gsb] fix a typo * [gsb] pass values as copy * [gsb] show a fixit if the subject type is a member type * [test] update diagnostics in existing tests * [gsb] check if the subject type has an assoc type decl * [gsb] use requirement source * [test] add new tests * [gsb] use constraint struct and rename to invalidIsaConstraints 08 February 2019, 16:02:32 UTC
536e706 Merge pull request #22465 from nkcsgexi/interpolation-extract AST: TapExpr should return sub-expression's source locations if set. 08 February 2019, 15:56:43 UTC
4e0142e Merge pull request #22469 from nkcsgexi/address-comments SwiftSyntax: address some post-commit review comments 08 February 2019, 15:55:49 UTC
12ef6ea Merge pull request #22470 from slavapestov/remove-type-reconstruction-part-1 IDE: Remove getTypeFromMangledSymbolname() 08 February 2019, 12:55:28 UTC
daf7d24 Merge pull request #22471 from Azoy/main-cleanups 08 February 2019, 09:17:47 UTC
b2f0327 IDE: Remove getTypeFromMangledSymbolname() There was only one remaining usage other than in testing tools. Note that when a declaration mangling was passed in, the old entry point would (try to) return the type of the declaration. The new entry point no longer has this behavior. I changed the bridging-header-first test to run lldb-moduleimport-test with -decl-from-mangled instead of -type-from-mangled-old to preserve the behavior of the test. Also, I removed test/DebugInfo/DumpTypeFromMangledName.swift completely. This test only covered a handful of cases, and a bunch of them were declaration manglings rather than type manglings. The new tests in test/TypeDecoder/ are much more comprehensive. 08 February 2019, 07:56:05 UTC
a1d38c1 Merge pull request #22468 from slavapestov/remove-some-param-old-type Remove some uses of FunctionType::Param::getOldType() and other cleanups 08 February 2019, 06:37:35 UTC
f464cce cleanup around top level emission 08 February 2019, 06:36:42 UTC
a9f9f3d SwiftSyntax: address some post-commit review comments 08 February 2019, 05:45:06 UTC
dffa29f AST: Remove a few uses of FunctionType::Param::getOldType() 08 February 2019, 04:46:31 UTC
12fa026 Sema: Use AbstractStorageDecl::getValueInterfaceType() in a couple of spots 08 February 2019, 04:46:31 UTC
e18a61c Sema: Remove unused parameter from getTypeOfReference() 08 February 2019, 04:46:31 UTC
71ff168 Sema: Add a couple more counters 08 February 2019, 04:46:31 UTC
feb1401 Sema: Add test for operator returning Self We didn't have a test for it, as I discovered while adding some assertions. 08 February 2019, 04:46:31 UTC
26bf98f Merge pull request #22457 from nkcsgexi/hash-imple-syntax-nodes SyntaxNodes: implement the hash function for syntax nodes. 08 February 2019, 03:54:36 UTC
2c91da5 lib: update for LLVM API change TerminatorInst has been removed and been made into a regular Instruction. Use the `isTerminator` function instead of the dyn_cast. 08 February 2019, 01:54:59 UTC
4dc2eac [master-next] After LLVM r344359, Timer names with slashes do not work. The code in TimerGroup::printJSONValue asserts that the name does not need to be quoted. Perhaps we can get this fixed, but for now at least, rename a Timer that has a forward slash in its name. 08 February 2019, 01:54:44 UTC
5f3c2d1 [master-next] Update a test to pass if some calls are tail calls 08 February 2019, 01:54:25 UTC
d023e56 [master-next] Adjust sourcekitd-test PrintHelp call for LLVM r344097 The default "[options] <inputs>" text is now up to the caller to provide. 08 February 2019, 01:54:10 UTC
adcdc39 swift: update for LLVM SVN r344140 Update swift's usage of clang::vfs which has been hoisted into LLVM. 08 February 2019, 01:53:42 UTC
24dab81 Merge pull request #22428 from drodriguez/fix-android-host-compiler-usage [cmake] Recover original CMAKE_C/CXX_COMPILER after changing them. 08 February 2019, 01:38:40 UTC
6e8865d Merge pull request #22461 from apple/windows-sourcekit Update WindowsBuild.md 08 February 2019, 01:35:24 UTC
2ea00c3 Merge pull request #22442 from xedin/diagnose-construction-using-non-cost-metatype [ConstraintSystem] Detect invalid implicit ref to initializer on non-… 08 February 2019, 01:30:49 UTC
0d6cdd4 Merge pull request #22456 from adrian-prantl/typdefscopes 08 February 2019, 01:29:44 UTC
0c28b4c SyntaxNodes: implement the hash function for syntax nodes. This hash function will concatenate all interesting pieces of information of node definitions in a single string and call hash() on this string. 08 February 2019, 00:58:26 UTC
fb30547 Add trailing space that was accidentally removed in the previous change. We need a trailing space after the warning options to separate them from the following arguments. rdar://problem/44228136 08 February 2019, 00:53:39 UTC
6475226 Disable -Wobjc-property-assign-on-object-type in these tests for now. It's default-off, but the harness passes -Weverything. We should consider whether we should change the print-as-objc output. rdar://44228136 08 February 2019, 00:53:20 UTC
b0dd41b [master-next] Use the new AST getBeginLoc API instead of getLocStart The getLocStart API is deprecated and slated for removal from LLVM very soon. Switch to use getBeginLoc instead. I did not see any uses of the corresponding getLocEnd API. 08 February 2019, 00:53:03 UTC
411fae3 [master-next] Add HermitCore OS type for LLVM triples LLVM r340675 added a new HermitCore OS type to triples, which broke the Swift build because it is using -Werror,-Wswitch and the new value was not handled in swift::getPlatformNameForTriple 08 February 2019, 00:52:45 UTC
5617e4a AST: TapExpr should return sub-expression's source locations if set. Without source location, TapExpr could stop IDE from collecting parameters while perform refactoring. rdar://47835267 08 February 2019, 00:46:34 UTC
a17bc73 Merge pull request #22422 from compnerd/resilient-patterns test: correct a couple of tests for Windows 08 February 2019, 00:05:09 UTC
688b732 Merge pull request #22463 from benlangmuir/long_14 Fix 14.04 long test preset accidentally changed in last commit 07 February 2019, 23:55:53 UTC
8045a42 Merge pull request #22455 from bob-wilson/new-checkout-configs [update-checkout] Add new branch configs for Swift 5.1 07 February 2019, 23:55:25 UTC
065a00b Fix 14.04 long test preset accidentally changed in last commit 07 February 2019, 23:48:52 UTC
6eccf30 Merge pull request #22462 from benlangmuir/disable-14-sk Disable sourcekit-lsp and indexstore-db on Ubuntu 14.04 07 February 2019, 23:46:22 UTC
c51a6c0 Disable sourcekit-lsp and indexstore-db on Ubuntu 14.04 We need to decide if we want to support these configurations, and in the meantime it's better for us to disable them while we stabilize on the other platforms. Fixes the currently broken build on 14.04. 07 February 2019, 23:39:02 UTC
e74ef5d Update WindowsBuild.md Enable SourceKit builds by default even on Windows, this has been ported to Windows though the test suite is not yet ready. 07 February 2019, 23:03:17 UTC
711e1f3 Debug Info: Emit Clang-imported typedef declarations in the correct scope. 07 February 2019, 22:30:07 UTC
8dcfac6 Merge pull request #22168 from benrimmington/sr-6127 [stdlib] Fix memory leaks in readLine() 07 February 2019, 22:25:22 UTC
5ce1aa8 [update-checkout] Add new branch configs for Swift 5.1 Add a tentative branch config for "swift-5.1-branch". Not all of the repos are branched yet. I went ahead and added a reference to swift-5.1-branch for the Swift repo, so that I can use this to start pulling together something with cherry-picks from master-next. (The current master-next branch has moved past the point where we branched the LLVM repos for swift-5.1-branch, so we can't just grab a copy of master-next.) I also added a separate config for "swift-5.1-old-llvm-branch", which will be used temporarily to track the same Swift content as swift-5.1-branch but still building with the version of LLVM in swift-5.0-branch. 07 February 2019, 22:19:56 UTC
caac1bf [overlay] Size the os_log pack buffer appropriately Fixes: rdar://problem/31799909 07 February 2019, 22:19:07 UTC
21a4d54 Merge pull request #22449 from gottesmm/pr-fb26d1bf402324ef5ab4eac767964caff06d3e39 [silgenpattern] Fix the box handling in the old silgenpattern enum co… 07 February 2019, 22:01:00 UTC
920b2f7 Merge pull request #22415 from drodriguez/standarize-darwin-glibc-msvcrt [tests] Standarize the checks for Darwin, Glibc and MSVCRT. 07 February 2019, 20:52:45 UTC
b69bd97 Merge pull request #22397 from compnerd/separate-me-no-more test: correct paths in DebugInfo/line-directive (NFC) 07 February 2019, 20:50:33 UTC
d364bb3 [silgenpattern] Fix the box handling in the old silgenpattern enum code to not pass a load_borrow payload as BorrowAlways instead of TakeAlways. Thanks to Luiz Fernando Silva for the test case! SR-9871 rdar://problem/47852446 07 February 2019, 20:35:28 UTC
9bc5bd2 Merge pull request #22417 from milseman/null_and_void [String] Fix crash when given null UBP 07 February 2019, 18:46:01 UTC
c8acb7e `@objc extension` makes even 'private' members '@objc' (#22436) This regressed in a8fb416f9e, when we started using a helper function in more places. rdar://problem/47869562 07 February 2019, 18:10:38 UTC
d335158 test: correct a couple of tests for Windows On Windows, we do not emit the base type pointer and instead will fill that in at runtime just like the resilient strategy. Permit this in the IRGen checks. 07 February 2019, 18:02:25 UTC
back to top