https://github.com/coreos/etcd

sort by:
Revision Author Date Message Commit Date
06cec40 version: 3.2.26 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 11 January 2019, 18:04:58 UTC
ab4693d Merge pull request #10386 from hexfusion/release-3.2 [Cherry-pick 3.2] auth: disable CommonName auth for gRPC-gateway 11 January 2019, 18:01:12 UTC
a2b420c auth: disable CommonName auth for gRPC-gateway Signed-off-by: Sam Batschelet <sbatsche@redhat.com> 08 January 2019, 21:09:07 UTC
dfd8fe9 Merge pull request #10334 from gyuho/patch-grpc-proxy [Cherry-pick 3.2] grpcproxy: fix memory leak 18 December 2018, 04:35:23 UTC
ada4af3 grpcproxy: fix memory leak use set instead of slice as interval value fixes #10326 18 December 2018, 02:58:04 UTC
2e27fef version: bump up to 3.2.25+git 10 October 2018, 18:13:42 UTC
182de1a version: bump up to 3.2.25 10 October 2018, 17:53:11 UTC
6e15f11 etcdserver: add "etcd_server_read_indexes_failed_total" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 01:21:41 UTC
b6d1101 rafthttp: probe all raft transports This PR adds another probing routine to monitor the connection for Raft message transports. Previously, we only monitored snapshot transports. In our production cluster, we found one TCP connection had >8-sec latencies to a remote peer, but "etcd_network_peer_round_trip_time_seconds" metrics shows <1-sec latency distribution, which means etcd server was not sampling enough while such latency spikes happen outside of snapshot pipeline connection. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 01:17:16 UTC
86fdbdc etcdserver: add "etcd_server_health_success/failures" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 01:04:40 UTC
afa5bed Merge pull request #10162 from jingyih/automated-cherry-pick-of-#10153-origin-release-3.2 clientv3: automated cherry pick of #10153 to release-3.2 09 October 2018, 01:38:02 UTC
26cce20 clientv3: concurrency.Mutex.Lock() - preserve invariant Convenient invariant: - if werr == nil then lock is supposed to be locked at the moment. While we could not be confident in stronger invariant ('is exactly locked'), it were inconvenient that previous code could return `werr == nil` after Mutex.Unlock. It could happen when ctx is canceled/timeouted exactly after waitDeletes successfully returned werr == nil and before `<-ctx.Done()` checked. While such situation is very rare, it is still possible. fixes #10111 08 October 2018, 23:46:22 UTC
a4a8d07 Merge pull request #10123 from jingyih/cherry-pick-of-#10109-origin-release-3.2 etcdctl: cherry pick of #10109 to release-3.2 26 September 2018, 02:55:07 UTC
affd468 etcdctl: cherry pick of #10109 to release-3.2 Add snapshot file integrity verification when querying snapshot status. 26 September 2018, 00:07:44 UTC
9452e5c Merge pull request #10042 from wenjiaswe/automated-cherry-pick-of-#9997-upstream-release-3.2 Automated cherry pick of #9997 04 September 2018, 19:54:58 UTC
e2dfe0f etcdserver/api/rafthttp: add v3 snapshot send/receive metrics Distribution would be: 0.1 second or more ... 25.6 seconds or more 51.2 seconds or more etcd_network_snapshot_send_success etcd_network_snapshot_send_failures etcd_network_snapshot_send_total_duration_seconds etcd_network_snapshot_receive_success etcd_network_snapshot_receive_failures etcd_network_snapshot_receive_total_duration_seconds Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:51:31 UTC
9d7242e etcdserver: add "etcd_server_id" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:49:26 UTC
95afd1f etcdserver: clarify read index wait timeout warnings Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:38:43 UTC
7f337ef rafthttp: clarify "became inactive" warning Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:33:46 UTC
8f1d366 etcdserver/api/snap: add v3 snapshot fsync metrics etcd_snap_db_fsync_duration_seconds_count etcd_snap_db_save_total_duration_seconds_bucket Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 28 August 2018, 21:03:12 UTC
b3fa36e Merge pull request #10032 from gyuho/init-metrics-3.2 etcdserver/api/v3rpc: display all registered gRPC metrics at start (v3.2) 25 August 2018, 01:52:34 UTC
4928558 etcdserver/api/v3rpc: display all registered gRPC metrics at start Previously, only display the one that has been requested at least once. Now it shows all metrics, as we do in v3.3 and v3.4+. grpc_server_started_total{grpc_method="Alarm",grpc_service="etcdserverpb.Maintenance",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="AuthDisable",grpc_service="etcdserverpb.Auth",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="AuthEnable",grpc_service="etcdserverpb.Auth",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="Authenticate",grpc_service="etcdserverpb.Auth",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="Compact",grpc_service="etcdserverpb.KV",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="Defragment",grpc_service="etcdserverpb.Maintenance",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="DeleteRange",grpc_service="etcdserverpb.KV",grpc_type="unary"} 0 Should help document metrics. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 23 August 2018, 02:12:58 UTC
73b1a2b Merge pull request #10025 from jingyih/automated-cherry-pick-of-#9990-origin-release-3.2-1534373481 etcdserver: cherry pick of #9990 to release-3.2 20 August 2018, 19:48:14 UTC
ae0f433 etcdserver: add grpc interceptor to log info on incoming request to etcdserver. To improve debuggability of etcd v3. Added a grpc interceptor to log info on incoming requests to etcd server. The log output includes remote client info, request content (with value field redacted), request handling latency, response size, etc. Dependency on zap logger and grpc_middleware is removed during backporting. Added checking in logging interceptor. If debug level is disabled, skip logUnaryRequestStats() to avoid potential performance degradation. (PR #10021) 18 August 2018, 00:06:13 UTC
5a3cbe4 version: bump up to 3.2.24+git 24 July 2018, 17:29:31 UTC
420a452 version: bump up to 3.2.24 24 July 2018, 17:24:31 UTC
348edfe etcdserver: add "etcd_server_go_version" metric Currently, one has to look at server logs manually, to see what Go version was used to build etcd server. Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 July 2018, 23:38:52 UTC
0d5497a clientv3: fix keepalive send interval when response queue is full client should update next keepalive send time even when lease keepalive response queue becomes full. Otherwise, client sends keepalive request every 500ms regardless of TTL when the send is only expected to happen with the interval of TTL / 3 at minimum. Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 July 2018, 15:50:44 UTC
87418c3 Merge pull request #9942 from wenjiaswe/automated-cherry-pick-of-#9761-upstream-release-3.2 Automated cherry pick of #9761 20 July 2018, 21:26:13 UTC
8c9fd1b remove hashRevDurations 20 July 2018, 20:48:35 UTC
a3c0a99 remove hashRevDurations 20 July 2018, 20:45:33 UTC
b3ab14c remove HashByRev 20 July 2018, 20:44:15 UTC
8798c5c etcdserver: rename to "heartbeat_send_failures_total" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 16:58:32 UTC
4e08898 mvcc: add "etcd_mvcc_hash_(rev)_duration_seconds" etcd_mvcc_hash_duration_seconds etcd_mvcc_hash_rev_duration_seconds Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 16:57:47 UTC
8ac6c88 mvcc/backend: fix defrag duration scale Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 16:52:46 UTC
aca5c8f mvcc/backend: add "etcd_disk_backend_defrag_duration_seconds" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 16:52:46 UTC
3535f7a mvcc/backend: document metrics ExponentialBuckets Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 16:44:15 UTC
fae9b6f mvcc/backend: clean up mutex, logging Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 16:44:15 UTC
66d8194 etcdserver: add "etcd_server_slow_apply_total" {"level":"warn","ts":1527101858.6985068,"caller":"etcdserver/util.go:115","msg":"apply request took too long","took":0.114101529,"expected-duration":0.1,"prefix":"","request":"header:<ID:1029181977902852337> put:<key:\"\\000\\000... Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 16:42:52 UTC
2f0e3fd etcdserver: add "etcd_server_heartbeat_failures_total" {"level":"warn","ts":1527101858.4149103,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.025771662} {"level":"warn","ts":1527101858.4149644,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.034015766} Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 20 July 2018, 16:37:04 UTC
cad3cf7 mvcc/backend: avoid unnecessary metrics update https://github.com/coreos/etcd/pull/9300 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 21:52:16 UTC
bedba66 mvcc: add "etcd_mvcc_db_total_size_in_use_in_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 21:32:56 UTC
9bc1e15 mvcc: add "etcd_mvcc_db_total_size_in_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 21:24:56 UTC
6e0131e etcdserver: add "etcd_server_quota_backend_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 20:27:15 UTC
c0e9e14 etcdserver: add "etcd_server_slow_read_indexes_total" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 19:59:53 UTC
b763b50 etcdserver: clarify read index warnings Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 19:54:42 UTC
d22ee84 Merge pull request #9894 from xmudrii/3.2-grpcproxy-tls etcdmain: backport support for different certs for etcd-gRPC proxy 02 July 2018, 17:57:39 UTC
e5531a4 etcdmain/grpc-proxy: add 'metrics-addr' option Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com> 02 July 2018, 10:06:25 UTC
8dabfe1 etcdmain: cleanup grpcproxy; support different certs for proxy/etcd Enables TLS termination in grpcproxy. 02 July 2018, 09:20:14 UTC
360484a tests: update test scripts Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 18 June 2018, 21:14:15 UTC
f8af50a version: bump up to 3.2.23+git 15 June 2018, 16:45:59 UTC
c9504f6 version: bump up to 3.2.23 15 June 2018, 16:40:41 UTC
75c159b clientv3: backoff on reestablishing watches when Unavailable errors are encountered 14 June 2018, 17:52:52 UTC
41ece2c e2e: do not test cipher suite in release-3.2 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 June 2018, 23:04:21 UTC
5e6adfa Merge pull request #9845 from wenjiaswe/automated-cherry-pick-of-#8960-upstream-release-3.2 Automated cherry pick of #8960 13 June 2018, 23:02:48 UTC
b163084 metrics: Add server_version metric 13 June 2018, 22:03:10 UTC
ad7db2b tests/semaphore.test.bash: update Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 June 2018, 21:41:17 UTC
b5dc226 Makefile: update Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 June 2018, 21:40:42 UTC
ba23379 Merge pull request #9821 from jpbetz/automated-cherry-pick-of-#9288-origin-release-3.2 Automated cherry pick of detailed "took too long" warnings to release-3.2 12 June 2018, 19:51:18 UTC
0ce2ef1 etcdserver: Fix txn request 'took too long' warnings to use loggable request stringer 12 June 2018, 19:31:38 UTC
4db8b94 etcdserver: Add response byte size and range response count to took too long warning 11 June 2018, 23:23:31 UTC
734e4cf etcdserver: Replace value contents with value_size in request took too long warning 11 June 2018, 22:58:03 UTC
dcf30b1 etcdserver: not print password in the warning message of expensive request Fix https://github.com/coreos/etcd/issues/9635 11 June 2018, 22:50:55 UTC
065053d etcdserver: Fix to backport of #9288 for pre-RequestV2 code 07 June 2018, 18:02:00 UTC
1935a66 etcdserver: improve request took too long warning 07 June 2018, 17:29:29 UTC
2c7eb87 version: bump up to 3.2.22+git 06 June 2018, 17:48:55 UTC
1674e68 version: 3.2.22 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 02:53:43 UTC
7c47afd e2e: test client-side cipher suites with curl Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 02:53:43 UTC
3e0cc1e etcdmain: add "--cipher-suites" flag Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 02:53:43 UTC
6fa95eb embed: support custom cipher suites Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 02:53:43 UTC
ba4a7e0 integration: test client-side TLS cipher suites Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 02:53:43 UTC
4bd81d0 pkg/transport: add "TLSInfo.CipherSuites" field Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 02:53:43 UTC
f690f3a pkg/tlsutil: add "GetCipherSuite" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 02:53:40 UTC
af6f459 version: bump up to 3.2.21+git 31 May 2018, 19:50:14 UTC
3ac81f3 version: bump up to 3.2.21 31 May 2018, 19:43:49 UTC
4ace7c7 mvcc: fix panic by allowing future revision watcher from restore operation This also happens without gRPC proxy. Fix panic when gRPC proxy leader watcher is restored: ``` go test -v -tags cluster_proxy -cpu 4 -race -run TestV3WatchRestoreSnapshotUnsync === RUN TestV3WatchRestoreSnapshotUnsync panic: watcher minimum revision 9223372036854775805 should not exceed current revision 16 goroutine 156 [running]: github.com/coreos/etcd/mvcc.(*watcherGroup).chooseAll(0xc4202b8720, 0x10, 0xffffffffffffffff, 0x1) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:242 +0x3b5 github.com/coreos/etcd/mvcc.(*watcherGroup).choose(0xc4202b8720, 0x200, 0x10, 0xffffffffffffffff, 0xc420253378, 0xc420253378) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:225 +0x289 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchers(0xc4202b86e0, 0x0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:340 +0x237 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchersLoop(0xc4202b86e0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:214 +0x280 created by github.com/coreos/etcd/mvcc.newWatchableStore /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:90 +0x477 exit status 2 FAIL github.com/coreos/etcd/integration 2.551s ``` gRPC proxy spawns a watcher with a key "proxy-namespace__lostleader" and watch revision "int64(math.MaxInt64 - 2)" to detect leader loss. But, when the partitioned node restores, this watcher triggers panic with "watcher minimum revision ... should not exceed current ...". This check was added a long time ago, by my PR, when there was no gRPC proxy: https://github.com/coreos/etcd/pull/4043#discussion_r48457145 > we can remove this checking actually. it is impossible for a unsynced watching to have a future rev. or we should just panic here. However, now it's possible that a unsynced watcher has a future revision, when it was moved from a synced watcher group through restore operation. This PR adds "restore" flag to indicate that a watcher was moved from the synced watcher group with restore operation. Otherwise, the watcher with future revision in an unsynced watcher group would still panic. Example logs with future revision watcher from restore operation: ``` {"level":"info","ts":1527196358.9057755,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} {"level":"info","ts":1527196358.910349,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} ``` Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 31 May 2018, 18:42:50 UTC
a09874b auth: Fix simpleToken to respect disabled state for assign 23 May 2018, 22:45:34 UTC
a5437f2 version: bump up to 3.2.20+git 09 May 2018, 17:19:54 UTC
f272557 version: bump up to 3.2.20 09 May 2018, 17:03:42 UTC
71eba35 Merge pull request #9694 from mohitsoni/release-3.2 Cherry-picking PR 7967 to release-3.2 04 May 2018, 19:16:09 UTC
557eee8 etcdserver: purge old snap.db files Lots of garbage db files in #7957. Should purge. 04 May 2018, 17:51:59 UTC
b71df1f version: bump up to 3.2.19+git 24 April 2018, 21:25:10 UTC
8a9b3d5 version: bump up to 3.2.19 24 April 2018, 21:15:36 UTC
4e7af27 etcdmain: fix "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 18:09:46 UTC
8ba6bf4 etcdserver: log skipping initial election tick Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:58:11 UTC
d549256 etcdmain: add "--initial-election-tick-advance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:57:47 UTC
40aee7b embed: add "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:56:03 UTC
7de2064 integration: set InitialElectionTickAdvance to true by default Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:53:49 UTC
0d2fe21 etcdserver: add "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:53:33 UTC
d45053c etcdserver: add is_leader prometheus metric that is 1 on the leader. Before this change, we had now way to find a leader using /metrics endpoint. This commit adds a metric to do that. 19 April 2018, 21:59:53 UTC
dfcdaa5 integration: fix peer TLS tests Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 17 April 2018, 22:15:02 UTC
f9d58d2 integration: re-overwrite "httptest.Server" TLS.Certificates Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 17 April 2018, 13:16:52 UTC
7f1225a pkg/transport: don't set certificates on tls config 17 April 2018, 13:16:15 UTC
21e7a30 functional/tester: remove Txn stresser in 3.2 Nested Txn is not supported Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 April 2018, 02:42:33 UTC
4e11cea functional: disable auto TLS Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 April 2018, 02:13:50 UTC
8f59849 vendor: add "gogo/protobuf/gogoproto" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 April 2018, 02:00:01 UTC
3b770ee test: set up gopath in 3.2 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 April 2018, 01:26:15 UTC
71a5f77 functional: create symlinks for build Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 23:05:13 UTC
14ce0ea travis: run "build" tests for "functional" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 22:57:15 UTC
7b1d090 functional/rpcpb: remove "InsecureSkipVerify" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 22:55:20 UTC
back to top