bdd97d5 | Gyuho Lee | 17 September 2019, 20:32:44 UTC | version: 3.2.27 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 17 September 2019, 20:32:44 UTC |
b7fab55 | Gyuho Lee | 17 September 2019, 18:10:58 UTC | Merge pull request #11157 from gyuho/release-3.2-patch etcdctl/ctlv3: do not modify db file on "restore" | 17 September 2019, 18:10:58 UTC |
c7e4e50 | Gyuho Lee | 17 September 2019, 05:53:44 UTC | scripts: remove "ACI" builds Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 17 September 2019, 05:53:44 UTC |
4e37549 | zhesi.huang | 03 November 2017, 13:01:06 UTC | etcdctl/ctlv3: do not modify db file on "restore" | 17 September 2019, 05:43:25 UTC |
c074e5c | Jingyi Hu | 07 September 2019, 07:03:52 UTC | Merge pull request #11135 from jingyih/automated-cherry-pick-of-#11126-origin-release-3.2 Automated cherry pick of #11126 on release-3.2 | 07 September 2019, 07:03:52 UTC |
948c284 | Jingyi Hu | 05 September 2019, 22:40:06 UTC | mvcc: add store revision metrics Add experimental metrics etcd_debugging_mvcc_current_revision and etcd_debugging_mvcc_compact_revision. | 07 September 2019, 00:22:45 UTC |
8501507 | Gyuho Lee | 05 June 2019, 21:40:04 UTC | Merge pull request #10794 from jingyih/automated-cherry-pick-of-#10788-origin-release-3.2 Automated cherry pick of #10788 on release-3.2 | 05 June 2019, 21:40:04 UTC |
6dd1e91 | Jingyi Hu | 04 June 2019, 22:52:29 UTC | ctlv3: add missing newline in EndpointHealth To make the output consistent with the output before #9540. | 05 June 2019, 21:37:59 UTC |
4a1ffd8 | Gyuho Lee | 04 June 2019, 16:52:32 UTC | Merge pull request #10783 from jingyih/cherrypick_9540_to_release3p2 ctlv3: cherry pick of #9540 to release 3.2 | 04 June 2019, 16:52:32 UTC |
64d53ad | Gyuho Lee | 06 April 2018, 18:31:00 UTC | ctlv3: support "write-out" for "endpoint health" command Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 04 June 2019, 00:30:31 UTC |
29d42fa | Luc Perkins | 30 April 2019, 21:02:44 UTC | Documentation metadata for 3.2 branch (#10695) * Add documentation metadata and remove v2 docs Signed-off-by: lucperkins <lucperkins@gmail.com> * Add upgrade _index.md Signed-off-by: lucperkins <lucperkins@gmail.com> | 30 April 2019, 21:02:44 UTC |
42f7d25 | Joe Betz | 18 April 2019, 21:10:05 UTC | Merge pull request #10657 from jpbetz/automated-cherry-pick-of-#10646-release-3.2 Automated cherry pick of #10646 | 18 April 2019, 21:10:05 UTC |
bcbe6db | Yingnan Zhang | 15 April 2019, 06:44:55 UTC | mvcc: fix db_compaction_total_duration_milliseconds | 17 April 2019, 23:32:46 UTC |
e06761e | Joe Betz | 06 February 2019, 17:59:10 UTC | Merge pull request #10452 from jpbetz/automated-cherry-pick-of-#10443-origin-release-3.2 Automated cherry pick of #10443 to release 3.2 | 06 February 2019, 17:59:10 UTC |
1d80d5f | Iskander Sharipov | 01 February 2019, 23:39:27 UTC | etcdctl: fix strings.HasPrefix args order Signed-off-by: Iskander Sharipov <quasilyte@gmail.com> | 05 February 2019, 21:17:54 UTC |
06cec40 | Gyuho Lee | 11 January 2019, 18:04:58 UTC | version: 3.2.26 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 11 January 2019, 18:04:58 UTC |
ab4693d | Gyuho Lee | 11 January 2019, 18:01:12 UTC | Merge pull request #10386 from hexfusion/release-3.2 [Cherry-pick 3.2] auth: disable CommonName auth for gRPC-gateway | 11 January 2019, 18:01:12 UTC |
a2b420c | Sam Batschelet | 02 January 2019, 20:54:40 UTC | auth: disable CommonName auth for gRPC-gateway Signed-off-by: Sam Batschelet <sbatsche@redhat.com> | 08 January 2019, 21:09:07 UTC |
dfd8fe9 | Gyuho Lee | 18 December 2018, 04:35:23 UTC | Merge pull request #10334 from gyuho/patch-grpc-proxy [Cherry-pick 3.2] grpcproxy: fix memory leak | 18 December 2018, 04:35:23 UTC |
ada4af3 | Igor German | 15 December 2018, 12:35:11 UTC | grpcproxy: fix memory leak use set instead of slice as interval value fixes #10326 | 18 December 2018, 02:58:04 UTC |
2e27fef | Joe Betz | 10 October 2018, 18:13:42 UTC | version: bump up to 3.2.25+git | 10 October 2018, 18:13:42 UTC |
182de1a | Joe Betz | 10 October 2018, 17:53:11 UTC | version: bump up to 3.2.25 | 10 October 2018, 17:53:11 UTC |
6e15f11 | Gyuho Lee | 10 October 2018, 01:21:06 UTC | etcdserver: add "etcd_server_read_indexes_failed_total" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 10 October 2018, 01:21:41 UTC |
b6d1101 | Gyuho Lee | 10 October 2018, 01:16:08 UTC | rafthttp: probe all raft transports This PR adds another probing routine to monitor the connection for Raft message transports. Previously, we only monitored snapshot transports. In our production cluster, we found one TCP connection had >8-sec latencies to a remote peer, but "etcd_network_peer_round_trip_time_seconds" metrics shows <1-sec latency distribution, which means etcd server was not sampling enough while such latency spikes happen outside of snapshot pipeline connection. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 10 October 2018, 01:17:16 UTC |
86fdbdc | Gyuho Lee | 10 October 2018, 01:04:40 UTC | etcdserver: add "etcd_server_health_success/failures" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 10 October 2018, 01:04:40 UTC |
afa5bed | Jingyi Hu | 09 October 2018, 01:38:02 UTC | Merge pull request #10162 from jingyih/automated-cherry-pick-of-#10153-origin-release-3.2 clientv3: automated cherry pick of #10153 to release-3.2 | 09 October 2018, 01:38:02 UTC |
26cce20 | yura | 05 October 2018, 09:47:00 UTC | clientv3: concurrency.Mutex.Lock() - preserve invariant Convenient invariant: - if werr == nil then lock is supposed to be locked at the moment. While we could not be confident in stronger invariant ('is exactly locked'), it were inconvenient that previous code could return `werr == nil` after Mutex.Unlock. It could happen when ctx is canceled/timeouted exactly after waitDeletes successfully returned werr == nil and before `<-ctx.Done()` checked. While such situation is very rare, it is still possible. fixes #10111 | 08 October 2018, 23:46:22 UTC |
a4a8d07 | Gyuho Lee | 26 September 2018, 02:55:07 UTC | Merge pull request #10123 from jingyih/cherry-pick-of-#10109-origin-release-3.2 etcdctl: cherry pick of #10109 to release-3.2 | 26 September 2018, 02:55:07 UTC |
affd468 | Jingyi Hu | 26 September 2018, 00:07:44 UTC | etcdctl: cherry pick of #10109 to release-3.2 Add snapshot file integrity verification when querying snapshot status. | 26 September 2018, 00:07:44 UTC |
9452e5c | Wenjia | 04 September 2018, 19:54:58 UTC | Merge pull request #10042 from wenjiaswe/automated-cherry-pick-of-#9997-upstream-release-3.2 Automated cherry pick of #9997 | 04 September 2018, 19:54:58 UTC |
e2dfe0f | Gyuho Lee | 12 August 2018, 04:47:38 UTC | etcdserver/api/rafthttp: add v3 snapshot send/receive metrics Distribution would be: 0.1 second or more ... 25.6 seconds or more 51.2 seconds or more etcd_network_snapshot_send_success etcd_network_snapshot_send_failures etcd_network_snapshot_send_total_duration_seconds etcd_network_snapshot_receive_success etcd_network_snapshot_receive_failures etcd_network_snapshot_receive_total_duration_seconds Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 29 August 2018, 21:51:31 UTC |
9d7242e | Gyuho Lee | 29 August 2018, 21:49:01 UTC | etcdserver: add "etcd_server_id" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 29 August 2018, 21:49:26 UTC |
95afd1f | Gyuho Lee | 29 August 2018, 21:38:22 UTC | etcdserver: clarify read index wait timeout warnings Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 29 August 2018, 21:38:43 UTC |
7f337ef | Gyuho Lee | 29 August 2018, 21:33:17 UTC | rafthttp: clarify "became inactive" warning Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 29 August 2018, 21:33:46 UTC |
8f1d366 | Gyuho Lee | 12 August 2018, 04:08:35 UTC | etcdserver/api/snap: add v3 snapshot fsync metrics etcd_snap_db_fsync_duration_seconds_count etcd_snap_db_save_total_duration_seconds_bucket Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 28 August 2018, 21:03:12 UTC |
b3fa36e | Xiang Li | 25 August 2018, 01:52:34 UTC | Merge pull request #10032 from gyuho/init-metrics-3.2 etcdserver/api/v3rpc: display all registered gRPC metrics at start (v3.2) | 25 August 2018, 01:52:34 UTC |
4928558 | Gyuho Lee | 23 August 2018, 02:12:58 UTC | etcdserver/api/v3rpc: display all registered gRPC metrics at start Previously, only display the one that has been requested at least once. Now it shows all metrics, as we do in v3.3 and v3.4+. grpc_server_started_total{grpc_method="Alarm",grpc_service="etcdserverpb.Maintenance",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="AuthDisable",grpc_service="etcdserverpb.Auth",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="AuthEnable",grpc_service="etcdserverpb.Auth",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="Authenticate",grpc_service="etcdserverpb.Auth",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="Compact",grpc_service="etcdserverpb.KV",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="Defragment",grpc_service="etcdserverpb.Maintenance",grpc_type="unary"} 0 grpc_server_started_total{grpc_method="DeleteRange",grpc_service="etcdserverpb.KV",grpc_type="unary"} 0 Should help document metrics. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 23 August 2018, 02:12:58 UTC |
73b1a2b | Joe Betz | 20 August 2018, 19:48:14 UTC | Merge pull request #10025 from jingyih/automated-cherry-pick-of-#9990-origin-release-3.2-1534373481 etcdserver: cherry pick of #9990 to release-3.2 | 20 August 2018, 19:48:14 UTC |
ae0f433 | Jingyi Hu | 18 August 2018, 00:06:13 UTC | etcdserver: add grpc interceptor to log info on incoming request to etcdserver. To improve debuggability of etcd v3. Added a grpc interceptor to log info on incoming requests to etcd server. The log output includes remote client info, request content (with value field redacted), request handling latency, response size, etc. Dependency on zap logger and grpc_middleware is removed during backporting. Added checking in logging interceptor. If debug level is disabled, skip logUnaryRequestStats() to avoid potential performance degradation. (PR #10021) | 18 August 2018, 00:06:13 UTC |
5a3cbe4 | Joe Betz | 24 July 2018, 17:29:31 UTC | version: bump up to 3.2.24+git | 24 July 2018, 17:29:31 UTC |
420a452 | Joe Betz | 24 July 2018, 17:24:31 UTC | version: bump up to 3.2.24 | 24 July 2018, 17:24:31 UTC |
348edfe | Gyuho Lee | 23 July 2018, 16:15:22 UTC | etcdserver: add "etcd_server_go_version" metric Currently, one has to look at server logs manually, to see what Go version was used to build etcd server. Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 23 July 2018, 23:38:52 UTC |
0d5497a | Gyuho Lee | 22 July 2018, 20:12:37 UTC | clientv3: fix keepalive send interval when response queue is full client should update next keepalive send time even when lease keepalive response queue becomes full. Otherwise, client sends keepalive request every 500ms regardless of TTL when the send is only expected to happen with the interval of TTL / 3 at minimum. Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 23 July 2018, 15:50:44 UTC |
87418c3 | Gyuho Lee | 20 July 2018, 21:26:13 UTC | Merge pull request #9942 from wenjiaswe/automated-cherry-pick-of-#9761-upstream-release-3.2 Automated cherry pick of #9761 | 20 July 2018, 21:26:13 UTC |
8c9fd1b | Wenjia | 20 July 2018, 20:48:35 UTC | remove hashRevDurations | 20 July 2018, 20:48:35 UTC |
a3c0a99 | Wenjia | 20 July 2018, 20:45:33 UTC | remove hashRevDurations | 20 July 2018, 20:45:33 UTC |
b3ab14c | Wenjia | 20 July 2018, 20:44:15 UTC | remove HashByRev | 20 July 2018, 20:44:15 UTC |
8798c5c | Gyuho Lee | 23 May 2018, 20:09:31 UTC | etcdserver: rename to "heartbeat_send_failures_total" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 20 July 2018, 16:58:32 UTC |
4e08898 | Gyuho Lee | 23 May 2018, 19:34:09 UTC | mvcc: add "etcd_mvcc_hash_(rev)_duration_seconds" etcd_mvcc_hash_duration_seconds etcd_mvcc_hash_rev_duration_seconds Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 20 July 2018, 16:57:47 UTC |
8ac6c88 | Gyuho Lee | 23 May 2018, 19:33:58 UTC | mvcc/backend: fix defrag duration scale Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 20 July 2018, 16:52:46 UTC |
aca5c8f | Gyuho Lee | 23 May 2018, 19:21:57 UTC | mvcc/backend: add "etcd_disk_backend_defrag_duration_seconds" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 20 July 2018, 16:52:46 UTC |
3535f7a | Gyuho Lee | 23 May 2018, 19:14:43 UTC | mvcc/backend: document metrics ExponentialBuckets Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 20 July 2018, 16:44:15 UTC |
fae9b6f | Gyuho Lee | 23 May 2018, 19:09:03 UTC | mvcc/backend: clean up mutex, logging Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 20 July 2018, 16:44:15 UTC |
66d8194 | Gyuho Lee | 23 May 2018, 19:01:38 UTC | etcdserver: add "etcd_server_slow_apply_total" {"level":"warn","ts":1527101858.6985068,"caller":"etcdserver/util.go:115","msg":"apply request took too long","took":0.114101529,"expected-duration":0.1,"prefix":"","request":"header:<ID:1029181977902852337> put:<key:\"\\000\\000... Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 20 July 2018, 16:42:52 UTC |
2f0e3fd | Gyuho Lee | 23 May 2018, 18:53:40 UTC | etcdserver: add "etcd_server_heartbeat_failures_total" {"level":"warn","ts":1527101858.4149103,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.025771662} {"level":"warn","ts":1527101858.4149644,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.034015766} Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 20 July 2018, 16:37:04 UTC |
cad3cf7 | Gyuho Lee | 03 July 2018, 21:52:16 UTC | mvcc/backend: avoid unnecessary metrics update https://github.com/coreos/etcd/pull/9300 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 03 July 2018, 21:52:16 UTC |
bedba66 | Gyuho Lee | 03 July 2018, 21:21:11 UTC | mvcc: add "etcd_mvcc_db_total_size_in_use_in_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 03 July 2018, 21:32:56 UTC |
9bc1e15 | Gyuho Lee | 03 July 2018, 21:24:56 UTC | mvcc: add "etcd_mvcc_db_total_size_in_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 03 July 2018, 21:24:56 UTC |
6e0131e | Gyuho Lee | 07 June 2018, 17:44:51 UTC | etcdserver: add "etcd_server_quota_backend_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 03 July 2018, 20:27:15 UTC |
c0e9e14 | Gyuho Lee | 02 July 2018, 19:53:01 UTC | etcdserver: add "etcd_server_slow_read_indexes_total" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 03 July 2018, 19:59:53 UTC |
b763b50 | Gyuho Lee | 02 July 2018, 19:38:50 UTC | etcdserver: clarify read index warnings Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 03 July 2018, 19:54:42 UTC |
d22ee84 | Gyuho Lee | 02 July 2018, 17:57:39 UTC | Merge pull request #9894 from xmudrii/3.2-grpcproxy-tls etcdmain: backport support for different certs for etcd-gRPC proxy | 02 July 2018, 17:57:39 UTC |
e5531a4 | Gyu-Ho Lee | 12 July 2017, 17:06:58 UTC | etcdmain/grpc-proxy: add 'metrics-addr' option Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com> | 02 July 2018, 10:06:25 UTC |
8dabfe1 | Anthony Romano | 17 July 2017, 22:36:19 UTC | etcdmain: cleanup grpcproxy; support different certs for proxy/etcd Enables TLS termination in grpcproxy. | 02 July 2018, 09:20:14 UTC |
360484a | Gyuho Lee | 18 June 2018, 21:14:15 UTC | tests: update test scripts Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 18 June 2018, 21:14:15 UTC |
f8af50a | Joe Betz | 15 June 2018, 16:45:59 UTC | version: bump up to 3.2.23+git | 15 June 2018, 16:45:59 UTC |
c9504f6 | Joe Betz | 15 June 2018, 16:40:41 UTC | version: bump up to 3.2.23 | 15 June 2018, 16:40:41 UTC |
75c159b | Jordan Liggitt | 13 June 2018, 04:54:22 UTC | clientv3: backoff on reestablishing watches when Unavailable errors are encountered | 14 June 2018, 17:52:52 UTC |
41ece2c | Gyuho Lee | 13 June 2018, 23:04:21 UTC | e2e: do not test cipher suite in release-3.2 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 13 June 2018, 23:04:21 UTC |
5e6adfa | Gyuho Lee | 13 June 2018, 23:02:48 UTC | Merge pull request #9845 from wenjiaswe/automated-cherry-pick-of-#8960-upstream-release-3.2 Automated cherry pick of #8960 | 13 June 2018, 23:02:48 UTC |
b163084 | Joe Betz | 01 December 2017, 23:13:21 UTC | metrics: Add server_version metric | 13 June 2018, 22:03:10 UTC |
ad7db2b | Gyuho Lee | 13 June 2018, 21:41:17 UTC | tests/semaphore.test.bash: update Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 13 June 2018, 21:41:17 UTC |
b5dc226 | Gyuho Lee | 13 June 2018, 21:40:42 UTC | Makefile: update Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 13 June 2018, 21:40:42 UTC |
ba23379 | Gyuho Lee | 12 June 2018, 19:51:18 UTC | Merge pull request #9821 from jpbetz/automated-cherry-pick-of-#9288-origin-release-3.2 Automated cherry pick of detailed "took too long" warnings to release-3.2 | 12 June 2018, 19:51:18 UTC |
0ce2ef1 | Joe Betz | 11 June 2018, 23:58:48 UTC | etcdserver: Fix txn request 'took too long' warnings to use loggable request stringer | 12 June 2018, 19:31:38 UTC |
4db8b94 | Joe Betz | 08 June 2018, 05:44:46 UTC | etcdserver: Add response byte size and range response count to took too long warning | 11 June 2018, 23:23:31 UTC |
734e4cf | Joe Betz | 07 June 2018, 21:48:37 UTC | etcdserver: Replace value contents with value_size in request took too long warning | 11 June 2018, 22:58:03 UTC |
dcf30b1 | Hitoshi Mitake | 26 April 2018, 07:16:36 UTC | etcdserver: not print password in the warning message of expensive request Fix https://github.com/coreos/etcd/issues/9635 | 11 June 2018, 22:50:55 UTC |
065053d | Joe Betz | 07 June 2018, 18:02:00 UTC | etcdserver: Fix to backport of #9288 for pre-RequestV2 code | 07 June 2018, 18:02:00 UTC |
1935a66 | Xiang | 06 February 2018, 20:15:52 UTC | etcdserver: improve request took too long warning | 07 June 2018, 17:29:29 UTC |
2c7eb87 | Joe Betz | 06 June 2018, 17:48:55 UTC | version: bump up to 3.2.22+git | 06 June 2018, 17:48:55 UTC |
1674e68 | Gyuho Lee | 06 June 2018, 01:48:38 UTC | version: 3.2.22 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 06 June 2018, 02:53:43 UTC |
7c47afd | Gyuho Lee | 06 June 2018, 01:48:17 UTC | e2e: test client-side cipher suites with curl Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 06 June 2018, 02:53:43 UTC |
3e0cc1e | Gyuho Lee | 06 June 2018, 01:25:20 UTC | etcdmain: add "--cipher-suites" flag Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 06 June 2018, 02:53:43 UTC |
6fa95eb | Gyuho Lee | 04 June 2018, 15:45:16 UTC | embed: support custom cipher suites Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 06 June 2018, 02:53:43 UTC |
ba4a7e0 | Gyuho Lee | 04 June 2018, 15:15:11 UTC | integration: test client-side TLS cipher suites Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 06 June 2018, 02:53:43 UTC |
4bd81d0 | Gyuho Lee | 04 June 2018, 13:47:33 UTC | pkg/transport: add "TLSInfo.CipherSuites" field Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 06 June 2018, 02:53:43 UTC |
f690f3a | Gyuho Lee | 04 June 2018, 13:41:42 UTC | pkg/tlsutil: add "GetCipherSuite" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 06 June 2018, 02:53:40 UTC |
af6f459 | Joe Betz | 31 May 2018, 19:50:14 UTC | version: bump up to 3.2.21+git | 31 May 2018, 19:50:14 UTC |
3ac81f3 | Joe Betz | 31 May 2018, 19:43:49 UTC | version: bump up to 3.2.21 | 31 May 2018, 19:43:49 UTC |
4ace7c7 | Gyuho Lee | 25 May 2018, 17:04:54 UTC | mvcc: fix panic by allowing future revision watcher from restore operation This also happens without gRPC proxy. Fix panic when gRPC proxy leader watcher is restored: ``` go test -v -tags cluster_proxy -cpu 4 -race -run TestV3WatchRestoreSnapshotUnsync === RUN TestV3WatchRestoreSnapshotUnsync panic: watcher minimum revision 9223372036854775805 should not exceed current revision 16 goroutine 156 [running]: github.com/coreos/etcd/mvcc.(*watcherGroup).chooseAll(0xc4202b8720, 0x10, 0xffffffffffffffff, 0x1) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:242 +0x3b5 github.com/coreos/etcd/mvcc.(*watcherGroup).choose(0xc4202b8720, 0x200, 0x10, 0xffffffffffffffff, 0xc420253378, 0xc420253378) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:225 +0x289 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchers(0xc4202b86e0, 0x0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:340 +0x237 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchersLoop(0xc4202b86e0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:214 +0x280 created by github.com/coreos/etcd/mvcc.newWatchableStore /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:90 +0x477 exit status 2 FAIL github.com/coreos/etcd/integration 2.551s ``` gRPC proxy spawns a watcher with a key "proxy-namespace__lostleader" and watch revision "int64(math.MaxInt64 - 2)" to detect leader loss. But, when the partitioned node restores, this watcher triggers panic with "watcher minimum revision ... should not exceed current ...". This check was added a long time ago, by my PR, when there was no gRPC proxy: https://github.com/coreos/etcd/pull/4043#discussion_r48457145 > we can remove this checking actually. it is impossible for a unsynced watching to have a future rev. or we should just panic here. However, now it's possible that a unsynced watcher has a future revision, when it was moved from a synced watcher group through restore operation. This PR adds "restore" flag to indicate that a watcher was moved from the synced watcher group with restore operation. Otherwise, the watcher with future revision in an unsynced watcher group would still panic. Example logs with future revision watcher from restore operation: ``` {"level":"info","ts":1527196358.9057755,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} {"level":"info","ts":1527196358.910349,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} ``` Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 31 May 2018, 18:42:50 UTC |
a09874b | Joe Betz | 13 October 2017, 21:38:41 UTC | auth: Fix simpleToken to respect disabled state for assign | 23 May 2018, 22:45:34 UTC |
a5437f2 | Joe Betz | 09 May 2018, 17:19:54 UTC | version: bump up to 3.2.20+git | 09 May 2018, 17:19:54 UTC |
f272557 | Joe Betz | 09 May 2018, 17:03:42 UTC | version: bump up to 3.2.20 | 09 May 2018, 17:03:42 UTC |
71eba35 | Gyuho Lee | 04 May 2018, 19:16:09 UTC | Merge pull request #9694 from mohitsoni/release-3.2 Cherry-picking PR 7967 to release-3.2 | 04 May 2018, 19:16:09 UTC |
557eee8 | Anthony Romano | 22 May 2017, 22:44:21 UTC | etcdserver: purge old snap.db files Lots of garbage db files in #7957. Should purge. | 04 May 2018, 17:51:59 UTC |
b71df1f | Joe Betz | 24 April 2018, 21:25:10 UTC | version: bump up to 3.2.19+git | 24 April 2018, 21:25:10 UTC |
8a9b3d5 | Joe Betz | 24 April 2018, 21:15:36 UTC | version: bump up to 3.2.19 | 24 April 2018, 21:15:36 UTC |
4e7af27 | Gyuho Lee | 23 April 2018, 18:09:46 UTC | etcdmain: fix "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 23 April 2018, 18:09:46 UTC |
8ba6bf4 | Gyuho Lee | 23 April 2018, 17:32:13 UTC | etcdserver: log skipping initial election tick Signed-off-by: Gyuho Lee <gyuhox@gmail.com> | 23 April 2018, 17:58:11 UTC |