https://github.com/etcd-io/etcd

sort by:
Revision Author Date Message Commit Date
932c3c0 version: 3.3.6 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 31 May 2018, 18:41:42 UTC
41888dd mvcc: fix panic by allowing future revision watcher from restore operation This also happens without gRPC proxy. Fix panic when gRPC proxy leader watcher is restored: ``` go test -v -tags cluster_proxy -cpu 4 -race -run TestV3WatchRestoreSnapshotUnsync === RUN TestV3WatchRestoreSnapshotUnsync panic: watcher minimum revision 9223372036854775805 should not exceed current revision 16 goroutine 156 [running]: github.com/coreos/etcd/mvcc.(*watcherGroup).chooseAll(0xc4202b8720, 0x10, 0xffffffffffffffff, 0x1) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:242 +0x3b5 github.com/coreos/etcd/mvcc.(*watcherGroup).choose(0xc4202b8720, 0x200, 0x10, 0xffffffffffffffff, 0xc420253378, 0xc420253378) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:225 +0x289 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchers(0xc4202b86e0, 0x0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:340 +0x237 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchersLoop(0xc4202b86e0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:214 +0x280 created by github.com/coreos/etcd/mvcc.newWatchableStore /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:90 +0x477 exit status 2 FAIL github.com/coreos/etcd/integration 2.551s ``` gRPC proxy spawns a watcher with a key "proxy-namespace__lostleader" and watch revision "int64(math.MaxInt64 - 2)" to detect leader loss. But, when the partitioned node restores, this watcher triggers panic with "watcher minimum revision ... should not exceed current ...". This check was added a long time ago, by my PR, when there was no gRPC proxy: https://github.com/coreos/etcd/pull/4043#discussion_r48457145 > we can remove this checking actually. it is impossible for a unsynced watching to have a future rev. or we should just panic here. However, now it's possible that a unsynced watcher has a future revision, when it was moved from a synced watcher group through restore operation. This PR adds "restore" flag to indicate that a watcher was moved from the synced watcher group with restore operation. Otherwise, the watcher with future revision in an unsynced watcher group would still panic. Example logs with future revision watcher from restore operation: ``` {"level":"info","ts":1527196358.9057755,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} {"level":"info","ts":1527196358.910349,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} ``` Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 31 May 2018, 18:41:34 UTC
7292963 auth: fix panic using WithRoot and improve JWT coverage Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 24 May 2018, 06:45:24 UTC
37767bc auth: a new auth token provider nop This commit adds a new auth token provider named nop. The nop provider refuses every Authenticate() request so CN based authentication can only be allowed. If the tokenOpts parameter of auth.NewTokenProvider() is empty, the provider will be used. 23 May 2018, 22:48:39 UTC
d659771 scripts: Fix remote tag check, gcloud login and umask in release script 09 May 2018, 18:08:23 UTC
39d01e7 version: 3.3.5+git Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 09 May 2018, 18:07:52 UTC
70c8726 version: 3.3.5 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 09 May 2018, 16:23:59 UTC
aaca01a tests/e2e: separate coverage tests for exec commands Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 04 May 2018, 01:48:16 UTC
bc2d400 etcdctl/ctlv3: fix watch with exec commands Following command was failing because the parser incorrectly picks up the second "watch" string in exec command, thus passing wrong exec commands. ``` ETCDCTL_API=3 ./bin/etcdctl watch aaa -- echo watch event received panic: runtime error: slice bounds out of range goroutine 1 [running]: github.com/coreos/etcd/etcdctl/ctlv3/command.parseWatchArgs(0xc42002e080, 0x8, 0x8, 0xc420206a20, 0x5, 0x6, 0x0, 0x0, 0x0, 0x0, ...) /home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/command/watch_command.go:303 +0xbed github.com/coreos/etcd/etcdctl/ctlv3/command.watchCommandFunc(0xc4202a7180, 0xc420206a20, 0x5, 0x6) /home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/command/watch_command.go:73 +0x11d github.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).execute(0xc4202a7180, 0xc420206960, 0x6, 0x6, 0xc4202a7180, 0xc420206960) /home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:766 +0x2c1 github.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1363de0, 0xc420128638, 0xc420185e01, 0xc420185ee8) /home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:852 +0x30a github.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).Execute(0x1363de0, 0x0, 0x0) /home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:800 +0x2b github.com/coreos/etcd/etcdctl/ctlv3.Start() /home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/ctl_nocov.go:25 +0x8e main.main() /home/gyuho/go/src/github.com/coreos/etcd/etcdctl/main.go:40 +0x17b ``` Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 04 May 2018, 01:48:08 UTC
913a985 tests: use Go 1.9.6 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 01 May 2018, 17:22:04 UTC
3f888b8 functional/tester: handle retries in "caseUntilSnapshot" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 30 April 2018, 21:37:20 UTC
c15c8c6 functional.yaml: use lower ports Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 30 April 2018, 20:36:36 UTC
f535bb6 scripts: Fix a few etcd release script bugs and make it reenterant. 25 April 2018, 17:04:43 UTC
f01d690 etcdmain: document peer-cert-allowed-cn flag 24 April 2018, 20:57:51 UTC
d09fa9c version: 3.3.4+git Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 24 April 2018, 20:56:13 UTC
fdde870 version: 3.3.4 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 24 April 2018, 19:05:29 UTC
600b2d1 scripts: Add scripts/release that performs 'etcd-release-runbook' (https://goo.gl/Gxwysq) style release workflow 24 April 2018, 19:05:18 UTC
870138a etcdserver: log skipping initial election tick Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:59:01 UTC
758203b etcdmain: add "--initial-election-tick-advance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:58:57 UTC
8886a63 embed: add "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:26:48 UTC
ea82961 integration: set InitialElectionTickAdvance to true by default Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:22:16 UTC
b923c74 etcdserver: add "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:21:51 UTC
7cbc2f1 etcdserver: add is_leader prometheus metric that is 1 on the leader. Before this change, we had now way to find a leader using /metrics endpoint. This commit adds a metric to do that. 19 April 2018, 21:59:31 UTC
7810915 integration: re-overwrite "httptest.Server" TLS.Certificates Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 17 April 2018, 13:17:46 UTC
08dc184 pkg/transport: don't set certificates on tls config 17 April 2018, 13:17:38 UTC
48f4ee9 functional: create symlinks for build Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 23:05:36 UTC
07a34aa travis: run build tests for "functional" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 22:56:30 UTC
2cabb82 snapshot: remove tests Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 22:24:02 UTC
56a9778 functional: initial commit (copied from master) Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 20:19:22 UTC
5abe521 snapshot: initial commit (for functional tests) Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 20:19:19 UTC
3c4ace2 test: simplify Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 April 2018, 18:09:25 UTC
095fc0b etcdserver/stats: make all fields guarded by mutex. 12 April 2018, 02:49:00 UTC
d40abbb etcdserver/stats: fix stats data race. 12 April 2018, 02:49:00 UTC
c19be73 test: remove build flag "-a" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 April 2018, 17:17:31 UTC
99e4a5f cmd/vendor: add "go.uber.org/zap" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 April 2018, 06:46:00 UTC
3736a12 pkg/proxy: move from "pkg/transport" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 April 2018, 06:43:23 UTC
074e417 tools: remove Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 April 2018, 06:43:16 UTC
dd9f055 travis: update Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 April 2018, 06:34:27 UTC
a28cf17 test/*: clean up semaphore scripts Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 April 2018, 06:33:50 UTC
cdbb8ff etcdserver: fix "lease_expired_total" metrics Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 April 2018, 00:57:35 UTC
68ba797 tests: move test scripts Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 09 April 2018, 18:33:23 UTC
5d97bcc semaphore.sh: update Go version Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 29 March 2018, 16:20:26 UTC
e5ec25f travis: use Go 1.9.5 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 29 March 2018, 16:07:35 UTC
c522f60 version: 3.3.3+git Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 29 March 2018, 16:07:10 UTC
e348b1a version: 3.3.3 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 28 March 2018, 20:00:06 UTC
4355d91 Documentation/upgrades: backport all upgrade guides Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 27 March 2018, 17:32:43 UTC
ce7b86b compactor: simplify interval logic on periodic compactor Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 26 March 2018, 12:37:31 UTC
d70a218 compactor: adjust interval for period <1-hour 26 March 2018, 12:37:24 UTC
e029de3 compactor: clean up Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 22 March 2018, 18:03:22 UTC
863a56a rafthttp: add missing "peer_sent_failures_total" metrics call Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 14 March 2018, 16:44:38 UTC
3282d90 etcdserver: adjust election ticks on restart Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 March 2018, 04:05:56 UTC
b2d5c6c etcdserver: make "advanceTicks" method Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 March 2018, 04:05:50 UTC
6fe7316 rafthttp: add "ActivePeers" to "Transport" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 11 March 2018, 04:05:35 UTC
40e0225 version: 3.3.2+git Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 08 March 2018, 22:49:14 UTC
c9d46ab version: 3.3.2 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 08 March 2018, 20:57:09 UTC
d1da202 clientv3/integration: test "rpctypes.ErrLeaseTTLTooLarge" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 08 March 2018, 18:34:34 UTC
eaa0050 *: enforce max lease TTL with 9,000,000,000 seconds math.MaxInt64 / time.Second is 9,223,372,036. 9,000,000,000 is easier to remember/document. 08 March 2018, 18:34:12 UTC
99a1266 *: remove unused env vars Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 08 March 2018, 09:35:36 UTC
e6d44fa hack/scripts-dev: fix indentation in run.sh Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 07 March 2018, 22:32:27 UTC
43caf2b hack/scripts-dev: sync with master branch Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 07 March 2018, 22:18:58 UTC
bfb7a15 travis: update Go version string Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 07 March 2018, 22:04:14 UTC
f76ef3c e2e: fix missing "apiPrefix" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 07 March 2018, 08:03:02 UTC
462ba8b embed: fix wrong compactor imports Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 07 March 2018, 07:26:45 UTC
146ed08 Documentation/op-guide: highlight defrag operation "--endpoints" flag Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 05 March 2018, 19:15:05 UTC
1bc974d etcdctl: highlight "defrag" command caveats Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 05 March 2018, 19:15:02 UTC
3e3468d e2e: add "Election" grpc-gateway test cases Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 02 March 2018, 18:40:50 UTC
207f193 e2e: add "spawnWithExpectLines" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 02 March 2018, 18:40:41 UTC
bb8a537 api/v3election: error on missing "leader" field Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 02 March 2018, 18:40:34 UTC
8291e16 Documentation: make "Consul" section more objective Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 02 March 2018, 18:40:22 UTC
a5b3108 etcdserver: enable "CheckQuorum" when starting with "ForceNewCluster" We enable "raft.Config.CheckQuorum" by default in other Raft initial starts. So should start with "ForceNewCluster". Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 02 March 2018, 18:40:08 UTC
cec79dd httpproxy: cancel requests when client closes a connection 02 March 2018, 18:39:46 UTC
3641af8 semaphore: release test version 27 February 2018, 19:29:58 UTC
240fda5 embed: fix revision-based compaction with default value Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 21 February 2018, 17:35:00 UTC
d627301 embed: document/validate compaction mode Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 21 February 2018, 17:34:59 UTC
534c31b version: 3.3.1+git Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 February 2018, 22:36:11 UTC
28f3f26 version: 3.3.1 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 February 2018, 17:29:11 UTC
4737f3a hack/scripts-dev: Makefile with Go 1.9.4, 1.8.7 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 February 2018, 17:28:56 UTC
bc6e235 travis: use Go 1.9.4 with TARGET_GO_VERSION Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 February 2018, 17:28:56 UTC
13c5ced semaphore: use Go 1.9.4, update release upgrade test version Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 12 February 2018, 17:28:55 UTC
9942f90 etcdserver: improve request took too long warning 07 February 2018, 00:58:04 UTC
eaf7d63 mvcc: restore unsynced watchers In case syncWatchersLoop() starts before Restore() is called, watchers already added by that moment are moved to s.synced by the loop. However, there is a broken logic that moves watchers from s.synced to s.uncyned without setting keyWatchers of the watcherGroup. Eventually syncWatchers() fails to pickup those watchers from s.unsynced and no events are sent to the watchers, because newWatcherBatch() called in the function uses wg.watcherSetByKey() internally that requires a proper keyWatchers value. 06 February 2018, 19:34:46 UTC
21a1a28 hack: sync with etcd master Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:07:01 UTC
c932e9e tools/functional-tester: update README for local docker testing Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:06:35 UTC
cf96d8a Dockerfile-functional-tester: initial commit Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:06:25 UTC
a3ec84e gitignore: add ".Dockerfile-functional-tester" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:06:12 UTC
29aca65 test: configure advertise ports in functional_pass Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:04:42 UTC
bbfd007 etcd-tester: set advertise ports, delay w/ network faults Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:04:33 UTC
18df077 etcd-agent: use "pkg/transport.Proxy" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:04:10 UTC
56178a8 test: remove "use-root" in functional_pass Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:03:58 UTC
a9a616a etcd-agent: remove "use-root" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:03:41 UTC
abdfa87 functional-tester: remove old assets Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:03:29 UTC
a4cbba8 pkg/transport: implement "Proxy" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:02:34 UTC
0bc06d7 pkg/transport: add "fixtures" for TLS tests Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 February 2018, 18:02:25 UTC
a1fbed5 *: Remove 8GiB quota limitation from documents Also mention that in v3.3 change log. Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 02 February 2018, 22:28:26 UTC
665fb01 version: 3.3.0+git Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 01 February 2018, 22:14:07 UTC
c236067 version: 3.3.0 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 01 February 2018, 18:03:36 UTC
afa01aa etcdmain: define "defaultGRPCMaxCallSendMsgSize" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 30 January 2018, 17:50:27 UTC
d20e5a6 Documentation/op-guide: highlight defragment operation Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 30 January 2018, 17:42:37 UTC
6931dd8 Documentation/op-guide: revert "--discovery-srv-name" doc changes Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 30 January 2018, 17:41:42 UTC
f320348 Documentation: sync with etcd master Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 30 January 2018, 17:37:57 UTC
back to top