e76fa74 | Thai Duong | 13 July 2018, 21:55:12 UTC | Note that C++ and Obj-C are also ready for production, also adding Haris and Charles to list of maintainers. PiperOrigin-RevId: 204533189 GitOrigin-RevId: 9ae90e72ca30baa3e6efa9783ab8f3b7d14ec690 | 13 July 2018, 21:57:08 UTC |
e68edc7 | Charles Lee | 13 July 2018, 21:30:44 UTC | Update version references to 1.2.0-rc2. Also, remove stale references to v1.1.0 in TinkConfig.register() documentation. PiperOrigin-RevId: 204529434 GitOrigin-RevId: a99dbe6bb14b02c1411e7baa6ef017ec72d89baf | 13 July 2018, 21:56:57 UTC |
d9d164a | Thai Duong | 13 July 2018, 20:02:00 UTC | Fixing Wycheproof ECDH tests. There's no bug, the tests are incorrect. First, background and history: In Java, an ECDH public key can be encoded as a SubjectPublicKeyInfo spec [1]. This spec contains the public point, and a named curve or curve parameters [2]. To test ECDH libraries, Wycheproof generates public key specs with modified curve parameters, and checks that the libraries must reject them [3]. Android M and N (and possibly other versions) do not reject said public keys specs. Given a spec Android just takes the field ID, and derives the rest of the parameters. This leads to a somewhat interesting situation: not only Android accepts Wycheproof's modified public key specs, but it also computes the shared secrets correctly and securely. So we changed Wycheproof to accept Android's behavior, and added to each test case the expected shared secret, had the public key spec not been modified. What went wrong: The expected shared secrets for "modified prime" and "public key of order 3" test are incorrect. I found that the public key specs (the "public" field in the ecdh_test.json) don't contain the same public point as in other tests. I'm not sure this is intentional, but because the public point is different the expected shared secret must be different too. Let's look at test case #336. Its expected shared secret is the same as test case #335. Yet two test cases contain two different public points, as shown below ( the public point is the last BIT STRING, it starts with 04): # Test case 335 0 304: SEQUENCE { 4 233: SEQUENCE { 7 7: OBJECT IDENTIFIER '1 2 840 10045 2 1' 16 221: SEQUENCE { 19 1: INTEGER 1 22 44: SEQUENCE { 24 7: OBJECT IDENTIFIER '1 2 840 10045 1 1' 33 33: INTEGER : 00 FF FF FF FF 00 00 00 01 00 00 00 00 00 00 00 : 00 00 00 00 00 FF FF FF FF FF FF FF FF FF FF FF : FF : } 68 68: SEQUENCE { 70 32: OCTET STRING : FF FF FF FF 00 00 00 01 00 00 00 00 00 00 00 00 : 00 00 00 00 FF FF FF FF FF FF FF FF FF FF FF FC 104 32: OCTET STRING : 5A C6 35 D8 AA 3A 93 E7 B3 EB BD 55 76 98 86 BC : 65 1D 06 B0 CC 53 B0 F6 3B CE 3C 3E 27 D2 60 4B : } 138 65: OCTET STRING : 04 6B 17 D1 F2 E1 2C 42 47 F8 BC E6 E5 63 A4 40 : F2 77 03 7D 81 2D EB 33 A0 F4 A1 39 45 D8 98 C2 : 96 4F E3 42 E2 FE 1A 7F 9B 8E E7 EB 4A 7C 0F 9E : 16 2B CE 33 57 6B 31 5E CE CB B6 40 68 37 BF 51 : F5 205 33: INTEGER : 00 FF FF FF FF 00 00 00 00 FF FF FF FF FF FF FF : FF BC E6 FA AD A7 17 9E 84 F3 B9 CA C2 FC 63 25 : 51 : } : } 240 66: BIT STRING : 04 15 10 26 4C 18 9C 3D 52 3F F9 91 6A BD 70 69 : EF A6 96 8D 8D C7 DD B6 45 7D 78 69 B5 3E A6 0C : DC FA FB 7E D4 78 6D A1 5D 29 EE 59 25 6F 53 6D : A3 57 5A 48 88 C1 BB 0A 95 B2 56 F4 A7 E9 FD 76 : 4A : } # Test case 336: 0 307: SEQUENCE { 4 236: SEQUENCE { 7 7: OBJECT IDENTIFIER '1 2 840 10045 2 1' 16 224: SEQUENCE { 19 1: INTEGER 1 22 44: SEQUENCE { 24 7: OBJECT IDENTIFIER '1 2 840 10045 1 1' 33 33: INTEGER : 00 FD 09 10 59 A6 89 36 35 F9 00 E9 44 9D 63 F5 : 72 B2 AE BC 4C FF 7B 4E 5E 33 F1 B2 00 E8 BB C1 : 45 : } 68 68: SEQUENCE { 70 32: OCTET STRING : 02 F6 EF A5 59 76 C9 CB 06 FF 16 BB 62 9C 0A 8D : 4D 51 43 B4 00 84 B1 A1 CC 0E 4D FF 17 44 3E B7 104 32: OCTET STRING : 5A C6 35 D8 AA 3A 93 E7 B3 EB BD 55 76 98 86 BC : 65 1D 06 B0 CC 53 B0 F6 3B CE 3C 3E 27 D2 60 4B : } 138 65: OCTET STRING : 04 00 00 00 00 00 00 00 00 00 00 06 59 7F A9 4B : 1F D9 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : 02 1B 8C 7D D7 7F 9A 95 62 79 22 EC EE FE A7 3F : 02 8F 1E C9 5B A9 B8 FA 95 A3 AD 24 BD F9 FF F4 : 14 205 33: INTEGER : 00 FF FF FF FF 00 00 00 00 FF FF FF FF FF FF FF : FF BC E6 FA AD A7 17 9E 84 F3 B9 CA C2 FC 63 25 : 51 240 1: INTEGER 1 : } : } 243 66: BIT STRING : 04 00 00 00 00 00 00 00 00 00 00 06 59 7F A9 4B : 1F D9 00 00 00 00 00 00 00 00 00 00 00 00 00 00 : 02 1B 8C 7D D7 7F 9A 95 62 79 22 EC EE FE A7 3F : 02 8F 1E C9 5B A9 B8 FA 95 A3 AD 24 BD F9 FF F4 : 14 : } [1] https://tools.ietf.org/html/rfc5280#section-4.1.2.7. [2] https://tools.ietf.org/html/rfc3279#section-2.3.5 [3] Many libraries don't, and usually that leads to vulnerabilities that leak the private key. PiperOrigin-RevId: 204515375 GitOrigin-RevId: 6a5a122b80d9664fa19f5497a2a5260f02c7ee5a | 13 July 2018, 20:44:43 UTC |
c0f8be5 | Bartosz Przydatek | 13 July 2018, 15:59:44 UTC | Fixing a merge error in BUILD-file. PiperOrigin-RevId: 204478709 GitOrigin-RevId: 945a523d16fbe1b784174e2aedb488d7a89ba643 | 13 July 2018, 16:26:43 UTC |
3fc5742 | Bartosz Przydatek | 13 July 2018, 15:47:30 UTC | Reducing size of libtink.so by removing dead code. PiperOrigin-RevId: 204477406 GitOrigin-RevId: 46569424ee4847c93bd6f82c28611bc0b00a1834 | 13 July 2018, 16:26:30 UTC |
0c0f60f | Rafael Lerm | 13 July 2018, 14:34:33 UTC | Update boringssl version to the latest on the master-with-bazel branch. This is necessary to use some newer functions in the upcoming RsaSignBoringSsl class. PiperOrigin-RevId: 204469656 GitOrigin-RevId: ad1183ca8adc93ce12d15e9eb655aeba5fa4b700 | 13 July 2018, 16:26:17 UTC |
809f78f | Bartosz Przydatek | 13 July 2018, 14:28:07 UTC | Removing deprecated C++ Tink APIs. PiperOrigin-RevId: 204468964 GitOrigin-RevId: 0a4a28740dbdfd6b20872792de5adb78a2fbe676 | 13 July 2018, 16:26:05 UTC |
e3521ea | Haris Andrianakis | 13 July 2018, 00:21:12 UTC | objc: Upgrade protobuf, add ios_static_framework rule for Bazel, update docs. PiperOrigin-RevId: 204394015 GitOrigin-RevId: d0fa0c36798ffbed7b3381909d88631ef1743318 | 13 July 2018, 16:25:51 UTC |
34b3c07 | Thai Duong | 13 July 2018, 00:06:35 UTC | Fixing typo. PiperOrigin-RevId: 204391980 GitOrigin-RevId: ba9666fbf61c6a39d68c6fa323fed282d2a5a60f | 13 July 2018, 00:11:54 UTC |
687fbd5 | Thai Duong | 13 July 2018, 00:01:28 UTC | Update installation instructions. PiperOrigin-RevId: 204390951 GitOrigin-RevId: a7c70b188581a9983f20b290fffd33835b6349c2 | 13 July 2018, 00:02:34 UTC |
b3f143a | Haris Andrianakis | 12 July 2018, 23:28:50 UTC | objc: Set version to 1.2.0-rc2. PiperOrigin-RevId: 204385896 GitOrigin-RevId: 9db2e408d0142df477fb2afbfbf55fd6b5d7ee46 | 13 July 2018, 00:02:23 UTC |
0eabd5c | Thai Duong | 12 July 2018, 22:09:19 UTC | Cleaning up discrepancies between Java and C++, preparing for 1.2.0 release. PiperOrigin-RevId: 204372552 GitOrigin-RevId: d2fdca75407b5694f6c94463697ce277e13997c4 | 12 July 2018, 22:19:54 UTC |
0ee8fee | Haris Andrianakis | 12 July 2018, 18:10:39 UTC | objc: Update documentation with new config API. PiperOrigin-RevId: 204329983 GitOrigin-RevId: a859145a0d30c28729ab0476af994869d727a841 | 12 July 2018, 22:19:43 UTC |
1dafd52 | Haris Andrianakis | 12 July 2018, 17:55:27 UTC | Adding Obj-C default config registration. PiperOrigin-RevId: 204327044 GitOrigin-RevId: 770ada770bb494b8abb9184b7c5f48d89bb0484a | 12 July 2018, 22:19:31 UTC |
53a9f82 | Bartosz Przydatek | 12 July 2018, 08:02:14 UTC | Adding C++ default config registration. PiperOrigin-RevId: 204257158 GitOrigin-RevId: 641a21a941f733511ef7d31ab39e53959d34bac4 | 12 July 2018, 22:19:20 UTC |
0d03d04 | Quan Nguyen | 12 July 2018, 02:43:34 UTC | Add enum RsaSignatureEncoding PiperOrigin-RevId: 204232671 GitOrigin-RevId: 33ca66ee5ff8124dd3951ea390c5c8572b058d6c | 12 July 2018, 22:19:08 UTC |
1f31da9 | Quan Nguyen | 12 July 2018, 00:47:24 UTC | Rsa signature protocol buffer PiperOrigin-RevId: 204222206 GitOrigin-RevId: 64222a64dd73ee8d87634c2ab2a4accd8afc5d62 | 12 July 2018, 22:18:58 UTC |
fb7ed28 | Haris Andrianakis | 11 July 2018, 22:12:53 UTC | objc: Implement keychain write support. PiperOrigin-RevId: 204198082 GitOrigin-RevId: c5905c66b71934a2de24ec4c41a2c87409ca78a8 | 11 July 2018, 22:42:47 UTC |
a7c0b6f | Haris Andrianakis | 11 July 2018, 14:58:16 UTC | Move TestUtil::GetKeyset, TestUtil::GetKeysetHandle to a separate class so they are usable by Obj-C code (not just tests). PiperOrigin-RevId: 204124489 GitOrigin-RevId: 5df6f3544e3b7da83dde0a2c08ea0e8e8e4bfe38 | 11 July 2018, 22:42:34 UTC |
81cdb2a | Haris Andrianakis | 10 July 2018, 21:36:08 UTC | objc: Add installation instructions in the documentation, update CHANGELOG. PiperOrigin-RevId: 204014431 GitOrigin-RevId: 5a7bc7f10967d27f6bb3c94d559701f6988a80e4 | 11 July 2018, 22:42:22 UTC |
ac9510c | Tink Team | 10 July 2018, 20:05:14 UTC | Fix infinite recursion on Tink Status to google3 conversion. PiperOrigin-RevId: 203997496 GitOrigin-RevId: fe5e319a26c21acf591583e9910ab5c203d562d1 | 11 July 2018, 22:42:09 UTC |
ab670ff | Haris Andrianakis | 10 July 2018, 18:06:37 UTC | Update cc/util/status to not depend on google3 status for Apple builds. PiperOrigin-RevId: 203977901 GitOrigin-RevId: 857fff7af8b58c2476bd1c83598d5f3d1c54ba78 | 11 July 2018, 22:41:57 UTC |
f17b7ee | Charles Lee | 10 July 2018, 18:02:45 UTC | Update to latest release of bazelbuild/rules_apple. Using the latest rules_apple release fixes the previous continuous integration build failure. This is due to the inclusion of the following commit: https://github.com/bazelbuild/rules_apple/commit/d24f9791e62ba3edcad69114fe4944e063681b39 Which is required due to a change in bazel 0.15.0. From https://github.com/bazelbuild/bazel/releases/tag/0.15.0: "non_propagated_deps has been removed from objc_library and apple_binary." PiperOrigin-RevId: 203977097 GitOrigin-RevId: 791887c15d86d72d8e21fcf3bc82ac14378f8084 | 11 July 2018, 22:41:44 UTC |
a0d09b8 | Haris Andrianakis | 09 July 2018, 23:02:48 UTC | objc: Remove unit test host from bazel rules, it errs with Bazel 0.15.0 PiperOrigin-RevId: 203847430 GitOrigin-RevId: bb0cc72b12bb592df09df8ddf06ddedb85a03a82 | 11 July 2018, 22:41:32 UTC |
c0091a9 | Haris Andrianakis | 09 July 2018, 21:13:15 UTC | objc: Add iOS Keychain support. - Adds the ability to load a keyset from the iOS keychain. Note 1: The part for writing a keyset to the keychain is missing because I need to make some changes to the C++ code. Note 2: The keychain tests don't work with Bazel. I haven't figured why yet. PiperOrigin-RevId: 203827136 GitOrigin-RevId: 95172f475455fec991b2c1e90475bc8292085a99 | 11 July 2018, 22:41:19 UTC |
eeadc54 | Bartosz Przydatek | 09 July 2018, 20:08:49 UTC | Removing the redundant typeUrl-argument from Registry.registerKeyManager()-methods. PiperOrigin-RevId: 203816425 GitOrigin-RevId: c9b34b7ee5eeb761d96baa0c8976722f9d2125ba | 11 July 2018, 22:41:06 UTC |
46df1b5 | Bartosz Przydatek | 06 July 2018, 14:49:52 UTC | Removing an obsolete BUILD-file for JSONCPP. PiperOrigin-RevId: 203476862 GitOrigin-RevId: a7196177749c98be51eab8641ce4f336b5559ccb | 06 July 2018, 21:21:10 UTC |
466cac8 | Tink Team | 06 July 2018, 11:55:56 UTC | Format .bzl files with buildifier This is a part of a large-scale change: go/lsc-format-bzl-files . All .bzl files are being formatted with buildifier. To format a file manually run `buildifier path/to/file.bzl`. Integration with `g4 fix` will be available later, but you can try using `g4 fix --format=bzl`. Tested: tap_presubmit Some tests failed; test failures are believed to be unrelated to this CL BEGIN_PUBLIC Format .bzl files with buildifier END_PUBLIC PiperOrigin-RevId: 203461813 GitOrigin-RevId: e90458471907298780465ab84c5e94add72d7dcd | 06 July 2018, 21:20:58 UTC |
6426e7d | Thai Duong | 05 July 2018, 16:37:06 UTC | Add shims to convert Tink Status/StatusOr to google3. PiperOrigin-RevId: 203384667 GitOrigin-RevId: be4aa4ef88d1b6bba81a4a63a2c40d038b014854 | 06 July 2018, 21:20:46 UTC |
423dfa9 | Daniel Bleichenbacher | 05 July 2018, 15:19:17 UTC | Adding AES-EAX version using the AES-NI instruction set. PiperOrigin-RevId: 203378951 GitOrigin-RevId: 62fd8b1b82187a7758e7bbf66de363288305e3d2 | 06 July 2018, 21:20:33 UTC |
44b8960 | Veronika Slivova | 04 July 2018, 15:24:16 UTC | Registry::RegisterKeyManager - new key allowed can be changed to more restrictive PiperOrigin-RevId: 203283070 GitOrigin-RevId: 058f0b9a347ec73ba0ae1ee38679c0739a8eec89 | 06 July 2018, 21:20:21 UTC |
57c0a72 | Haris Andrianakis | 03 July 2018, 17:33:56 UTC | objc: Update the Obj-C documentation. - Added installation instructions - Fixed typos in examples - Updated the import paths PiperOrigin-RevId: 203145324 GitOrigin-RevId: 64de4d74dea83d8d5a3205322a09db3bea90930f | 03 July 2018, 18:23:51 UTC |
571a726 | Thai Duong | 03 July 2018, 15:24:16 UTC | Always use the latest Tink configs during registration. Instead of Config.register(AeadConfig.TINK_1_1_0); We'd do AeadConfig.register(); I kept the static init blocks in AeadConfig, but it's only for backward compatibility. We'd always require users calling the init function. This gives us consistency across all languages. I also deprecated TINK_1_1_0 and introduced LATEST which contains the configs of the latest version. Advanced users can always do Config.register(myCustomConfig); PiperOrigin-RevId: 203125864 GitOrigin-RevId: cd138962f88ff693e9c13cef3399f956f6d6513e | 03 July 2018, 18:23:42 UTC |
dc91bb3 | Veronika Slivova | 03 July 2018, 08:32:50 UTC | Registering key manager with not supported key type should not be allowed. PiperOrigin-RevId: 203082603 GitOrigin-RevId: 610b190732a8c98bfbed8f0625a2688d8c748a67 | 03 July 2018, 18:23:33 UTC |
b353409 | Charles Lee | 03 July 2018, 03:14:47 UTC | Add 'com.' prefix to espresso. PiperOrigin-RevId: 203055704 GitOrigin-RevId: 5bb1e21274576c66342da888f75f05375fb1e815 | 03 July 2018, 18:23:21 UTC |
8f77de2 | Haris Andrianakis | 02 July 2018, 18:10:18 UTC | Removed unused dependencies, converted everything to proto-lite. Pruned dependencies that weren't used: - //util/gtl:node_hash_map - //util/gtl:singleton PiperOrigin-RevId: 202981225 GitOrigin-RevId: cbde29fc20fcdc180b4c6262ac9b6dafe67cfef2 | 03 July 2018, 18:23:10 UTC |
19b36d2 | Charles Lee | 02 July 2018, 16:54:59 UTC | Fix typo in package name PiperOrigin-RevId: 202967034 GitOrigin-RevId: 3f494fe6e4c18c2209aa46ef5836415ffa1c4628 | 03 July 2018, 18:22:58 UTC |
4826f9c | Charles Lee | 02 July 2018, 16:24:13 UTC | Switch example Android app back to android.support.test. PiperOrigin-RevId: 202962201 GitOrigin-RevId: 0a1f5bab18d33e650dc6d192e622a68acbd743a7 | 03 July 2018, 18:22:48 UTC |
87444c4 | Veronika Slivova | 02 July 2018, 08:11:19 UTC | Removing inconsistency between Java and C++. PiperOrigin-RevId: 202909592 GitOrigin-RevId: 957b0b9dbfe3db55df010accf7147ab5a9ebe01d | 03 July 2018, 18:22:36 UTC |
3d24ad1 | Tink Team | 30 June 2018, 20:27:01 UTC | Replace references to android.support.test with androidx.test. The Android Test Support Library is being renamed to AndroidX Test, with its root java namespace changing from android.support.test to androidx.test. And code location changing from tp/android/android_test_support to tp/android/androidx_test. More information: go/jetpack-test-lsc TAP global presubmit: https://test.corp.google.com/ui#id=OCL:202779348:BASE:202785125:1530379068287:f0eca0a1 BUG: 79205333 PiperOrigin-RevId: 202796842 GitOrigin-RevId: 47c1bdb517ffda5279d9dcde00b6cd9f950d87f3 | 03 July 2018, 18:22:25 UTC |
128aef8 | Thai Duong | 28 June 2018, 20:21:18 UTC | Removing protobuf JSON util dependency. PiperOrigin-RevId: 202532619 GitOrigin-RevId: 3df1d9e5f73bcf81ad5df241ced9b316f03a7956 | 03 July 2018, 18:22:14 UTC |
71a0c06 | Thai Duong | 28 June 2018, 20:20:09 UTC | Update the road map to move 1.2.0 release date to July 2018. PiperOrigin-RevId: 202532440 GitOrigin-RevId: 4f1cb4f4207e09212ea7102b7513d6e32bbc0ead | 03 July 2018, 18:22:03 UTC |
b6dc884 | Bartosz Przydatek | 28 June 2018, 20:02:03 UTC | Moving C++ to proto lite, and changing from JSONCPP to RapidJSON. (based on cl/196889713 and cl/197018177) PiperOrigin-RevId: 202529544 GitOrigin-RevId: f290535f5a57642982d30c43b113cdae6fd7a385 | 03 July 2018, 18:21:52 UTC |
14cbefe | Haris Andrianakis | 27 June 2018, 21:24:41 UTC | objc: Remove Obj-C Protobuf dependency. - Remove read and readEncrypted methods from all keyset readers. - Remove KeyManager it's not used/needed. - Cleanup util:strings and move some methods to util:test_helpers. - Remove initWithKeyTemplateProto from KeysetHandle. PiperOrigin-RevId: 202369048 GitOrigin-RevId: af70b827900fa100485ecd408fa8ce8170ad3dc7 | 03 July 2018, 18:21:40 UTC |
78c3ebf | Thai Duong | 27 June 2018, 20:15:21 UTC | Fail early when entries in a primitive set are not of the correct type. PiperOrigin-RevId: 202357885 GitOrigin-RevId: 16186f381ed5c454ae7e54d689f7e438b46a6425 | 03 July 2018, 18:21:28 UTC |
5b70c79 | Thai Duong | 27 June 2018, 18:34:31 UTC | Update Wycheproof dependency. PiperOrigin-RevId: 202342774 GitOrigin-RevId: 06955a217ab921cdbfeee16de712bf10c2904065 | 27 June 2018, 19:03:52 UTC |
bafb345 | Quan Nguyen | 27 June 2018, 01:48:16 UTC | Add Wycheproof test for subtle_util_boringssl_test. Fix Wycheproof ecdh BUILD to include ecdh_secp256r1_test.json PiperOrigin-RevId: 202234443 GitOrigin-RevId: 91bf697675c5962c4dcf3f424518fbb9df69b2a6 | 27 June 2018, 19:03:43 UTC |
1cc3e08 | Haris Andrianakis | 26 June 2018, 14:44:36 UTC | objc: Convert public header imports to relative paths. This is needed so they will work correctly in the cocoapod. PiperOrigin-RevId: 202126990 GitOrigin-RevId: 5d31b269a155d9859e016dfa054814ab614aba19 | 27 June 2018, 19:03:34 UTC |
507da6a | Quan Nguyen | 25 June 2018, 23:56:37 UTC | Add tests for ec_util Remove ComputeSharedEcdh function because: + It's moved to subtle_util_boringssl + It's not used any more and it's not carefully tested. PiperOrigin-RevId: 202044794 GitOrigin-RevId: 2248584d3263c9382471b3f5028a5de506e1d6ff | 27 June 2018, 19:03:26 UTC |
250cb6a | Haris Andrianakis | 25 June 2018, 22:12:23 UTC | objc: In Aead mark AdditionalData as nullable, this is needed in Swift when a parameter is optional. PiperOrigin-RevId: 202027341 GitOrigin-RevId: da718624eb3c1fcb86efca303c85ddb3459ad8fd | 27 June 2018, 19:03:17 UTC |
300a24d | Quan Nguyen | 25 June 2018, 21:59:11 UTC | Eax --> Gcm (copy/paste fail) PiperOrigin-RevId: 202024825 GitOrigin-RevId: 4ec63135e438d93dcd1780362f46cd2afbeaed63 | 27 June 2018, 19:03:08 UTC |
30e008f | Quan Nguyen | 25 June 2018, 21:32:21 UTC | Wycheproof test for Tink C++ AesGcmBoringSSL PiperOrigin-RevId: 202020445 GitOrigin-RevId: 13efa4e5f61ba413967f1fec1efbef9decd3cf48 | 27 June 2018, 19:02:57 UTC |
6539ec8 | Bartosz Przydatek | 22 June 2018, 21:08:09 UTC | Adding a genrule to build a C++ binary snapshot. PiperOrigin-RevId: 201738733 GitOrigin-RevId: 0a8ebc6357e27a68a2934db12ba75109ff18b573 | 27 June 2018, 19:02:48 UTC |
29eeebe | Haris Andrianakis | 21 June 2018, 23:22:23 UTC | objc: Add support for AES-EAX. PiperOrigin-RevId: 201606493 GitOrigin-RevId: 8d941e6d4ef4596183bcdcd973f7081d9e4952c0 | 27 June 2018, 19:02:40 UTC |
3c51e7f | Bartosz Przydatek | 21 June 2018, 09:45:26 UTC | Adding cross-language tests for AES-EAX-AEAD. PiperOrigin-RevId: 201496730 GitOrigin-RevId: b8354a808c64e97a93cef426fa9afefa56b38fbd | 27 June 2018, 19:02:31 UTC |
b50bbcd | Bartosz Przydatek | 21 June 2018, 07:53:28 UTC | Adding C++ interface for KMS client. PiperOrigin-RevId: 201484172 GitOrigin-RevId: 1ce45f8dc4e4fbdcf1b866c5571e918abf6fd69a | 27 June 2018, 19:02:22 UTC |
0cdd942 | Bartosz Przydatek | 21 June 2018, 07:48:45 UTC | Adding C++ AesEaxKeymanger. PiperOrigin-RevId: 201483815 GitOrigin-RevId: b6d76588fc877e84c0699e642ad2300b3b5f8d2c | 27 June 2018, 19:02:13 UTC |
dd39e29 | Daniel Bleichenbacher | 19 June 2018, 15:11:25 UTC | Adding a version of AES-EAX using boringssl as underlying library. Things not done: Things to check: - The code does not use EVP. There are plans to just add code in assembly. Hence this is kind of backup code for the case where AES instructions are not available. Hence it is unclear whether using that horrible EVP interface makes sense. - depot/google3/security/util/crypt/ contains a version of AES_EAX using EVP. The main problem with this implementation is that it is not thread safe. - The code needs unaligned big-endian load and store. I have not been able to find a function that achieves this efficiently. Compilers can sometimes (but not always) optimize the load or stores. PiperOrigin-RevId: 201177778 GitOrigin-RevId: 2601a0d6eb42804747718f283761774922cdf8f5 | 27 June 2018, 19:02:02 UTC |
c17cf29 | Charles Lee | 14 June 2018, 18:20:44 UTC | Remove quotes in the git arguments array. Each space-delimited argument should be it's own array element. PiperOrigin-RevId: 200588214 GitOrigin-RevId: 06f935023158eb482e3e92a9c31bc4931c4ff107 | 27 June 2018, 19:01:52 UTC |
b6b6036 | Tink Team | 14 June 2018, 08:17:26 UTC | Validate HMAC key should validate size of HMAC key. PiperOrigin-RevId: 200519180 GitOrigin-RevId: 4b11835ad9925c2635acb4814f840678fae23d67 | 27 June 2018, 19:01:44 UTC |
7c814aa | Charles Lee | 14 June 2018, 00:26:38 UTC | Remove stray parentheses. PiperOrigin-RevId: 200482021 GitOrigin-RevId: 9f7e6c9861174b3e62bdf7e7372dba108f7aacef | 27 June 2018, 19:01:35 UTC |
8fcab53 | Charles Lee | 13 June 2018, 23:41:58 UTC | Don't update the global git config, instead use command line arguments. Also, clean up the script to align with go/shellstyle. PiperOrigin-RevId: 200475771 GitOrigin-RevId: e1e278f0be4acfe6f31055d826855f0da4cb4f7e | 27 June 2018, 19:01:26 UTC |
61a707f | Haris Andrianakis | 12 June 2018, 20:53:19 UTC | objc: Convert C++ string to std::string in .mm files, it's needed by bazel. PiperOrigin-RevId: 200274708 GitOrigin-RevId: 0d230a3b391715038392e5037eac1b9e41123f5a | 27 June 2018, 19:01:17 UTC |
d3edaea | Haris Andrianakis | 12 June 2018, 18:57:58 UTC | objc: Implement the signature primitive. - Protocols for PublicKeySign and PublicKeyVerify - Factories for both primitives - Signature config and key templates - Unit tests PiperOrigin-RevId: 200255071 GitOrigin-RevId: fc16218762a4ea2b1b2c9c548ca3a35ab0d8efe6 | 27 June 2018, 19:01:08 UTC |
ced22c1 | Haris Andrianakis | 11 June 2018, 20:16:17 UTC | objc: Update KeysetReader so it can only be read/used once. PiperOrigin-RevId: 200100930 GitOrigin-RevId: d2c8e2db477d5e171cdf6442fecd661fe61e0dd0 | 27 June 2018, 19:00:54 UTC |
6625fcf | Tink Team | 11 June 2018, 10:29:06 UTC | Correcting typos PiperOrigin-RevId: 200027939 GitOrigin-RevId: b75376f8434bf4b5192faf8efb3338c6393df363 | 27 June 2018, 19:00:46 UTC |
67cfe03 | kreuzerk | 09 June 2018, 02:53:43 UTC | Update version references throughout the documenation. Fixes https://github.com/google/tink/pull/95 Merge a8a6b95b797d70e2acf27fc49df4e4cd631a73d8 into 9a4df389cb5f88ab49e8b36e089fd734aaae4dfc PiperOrigin-RevId: 199884795 GitOrigin-RevId: ba029538be7f53380c72c27a515a0f07ca517426 | 09 June 2018, 03:16:55 UTC |
9a4df38 | Thai Duong | 08 June 2018, 23:01:07 UTC | Fixing Gradle build of the hello world example. See https://github.com/facebook/react-native/issues/19485#issuecomment-395882343 and https://stackoverflow.com/questions/50563338/could-not-find-runtime-jar-android-arch-lifecycleruntime1-0-0/50565155#50565155 PiperOrigin-RevId: 199865197 GitOrigin-RevId: fb3a6d90ed7293cd62b2ccd1bafb76845847c0f0 | 08 June 2018, 23:28:47 UTC |
b46e5e9 | Charles Lee | 08 June 2018, 22:57:21 UTC | Make all Copybara transformations reversible. Git-on-Borg Code Review: https://ise-crypto-internal-review.git.corp.google.com/c/cloudcryptosdk/+/12320 Expected changes in the Piper->Git export: * protobuf_helper.c * objc comments that we're previously needlessly transformed Also, use github_pr_origin as the origin for the github_pr_to_piper workflow with the use_merge flag enabled. Currently, the github_pr_to_piper workflow results in CLs with a huge amount of spurious diffs. These changes facilitate clean imports of pull requests. PiperOrigin-RevId: 199864728 GitOrigin-RevId: d4277d33aa70b6a3d1868834cf9e9881b7a83c9b | 08 June 2018, 23:23:02 UTC |
d575b42 | Haris Andrianakis | 07 June 2018, 23:18:57 UTC | objc: Implement MacKeyTemplate. PiperOrigin-RevId: 199714804 GitOrigin-RevId: da360437a835c0d3690926af6e480c8b3ce42443 | 08 June 2018, 21:49:34 UTC |
80647a0 | Daniel Bleichenbacher | 07 June 2018, 15:43:02 UTC | Ignoring test vectors that cause exceptions that are not related to tink. PiperOrigin-RevId: 199640605 GitOrigin-RevId: edbadccec7f04d3b8f9b41611e167b2dfc2a1bad | 08 June 2018, 21:49:26 UTC |
b2b6617 | Bartosz Przydatek | 05 June 2018, 17:42:07 UTC | Adding checks for proper handling of absl::string_view as an empty string. PiperOrigin-RevId: 199320855 GitOrigin-RevId: d86b69be46b93db70948fb4f5b3c0dce927e2fb2 | 06 June 2018, 17:24:56 UTC |
062bdaf | Bartosz Przydatek | 05 June 2018, 17:34:08 UTC | Adding instructions for non-Bazel build on MacOS. PiperOrigin-RevId: 199319408 GitOrigin-RevId: 9277e93fe5277b9beb1c62e39adad6bdd3ddb53f | 06 June 2018, 17:24:48 UTC |
85ca63f | Bartosz Przydatek | 01 June 2018, 08:23:07 UTC | Minor fixes to C++ documentation. PiperOrigin-RevId: 198841818 GitOrigin-RevId: 9d6b3859e704b9b781b6312f30c900e8c98ffcda | 06 June 2018, 17:24:39 UTC |
d0b2367 | Haris Andrianakis | 30 May 2018, 21:15:23 UTC | objc: Merge all BUILD rules into the main BUILD file. Move public headers to the main folder. PiperOrigin-RevId: 198617522 GitOrigin-RevId: 17ff35555f133f18557aa4c271663599c5e1f852 | 06 June 2018, 17:24:30 UTC |
068112c | Charles Lee | 25 May 2018, 16:32:23 UTC | Additional documentation cleanup. PiperOrigin-RevId: 198059513 GitOrigin-RevId: b0d86b91c0a596d6e87d36bdc1e1876b77a23b7f | 25 May 2018, 22:28:42 UTC |
d8691d3 | Bartosz Przydatek | 24 May 2018, 19:33:33 UTC | Adding C++ implementation of KeysetHandle::GenerateNew(KeyTemplate). PiperOrigin-RevId: 197935510 GitOrigin-RevId: 4d9358b99e0d8815c7e656b9ce0805c4a34b5201 | 25 May 2018, 22:28:33 UTC |
b00087e | Bartosz Przydatek | 24 May 2018, 14:33:04 UTC | Fixing C++ installation instructions. PiperOrigin-RevId: 197889804 GitOrigin-RevId: 9c3a38ad86da03f0180fc87082bf7107c6d537fd | 24 May 2018, 14:38:50 UTC |
28c9ebb | Bartosz Przydatek | 24 May 2018, 13:20:48 UTC | Adding instructions for building/using C++ Tink, with and without Bazel. PiperOrigin-RevId: 197881855 GitOrigin-RevId: 63d09a42757fedd361b92933e8fe5c45acb188dd | 24 May 2018, 13:33:02 UTC |
8fa13a6 | Bartosz Przydatek | 24 May 2018, 12:27:36 UTC | Automated g4 rollback of changelist 197862984. *** Reason for rollback *** Fixing the reason for breaking the tests. *** Original change description *** Automated g4 rollback of changelist 197860731. *** Reason for rollback *** TAP has detected that 100 or more targets failed to build at cl/197860731. If this is an error, please file a bug at go/autorollback-bug. TAP double-checked a few of the targets built at cl/197860730: https://sponge.corp.google.com/invocations?searchFor=label%3Atap+label%3Apostsubmit+label%3AAutoRollback+cl%3A197860730 but failed to build at cl/197860731. Sponge link for all broken targets: https://sponge.corp.google.co... *** PiperOrigin-RevId: 197877227 GitOrigin-RevId: a089063c3b449d59a7e90e4295c233b4e3b26520 | 24 May 2018, 13:32:49 UTC |
2c9ebd8 | Tink Team | 24 May 2018, 09:49:16 UTC | Automated g4 rollback of changelist 197860731. *** Reason for rollback *** TAP has detected that 100 or more targets failed to build at cl/197860731. If this is an error, please file a bug at go/autorollback-bug. TAP double-checked a few of the targets built at cl/197860730: https://sponge.corp.google.com/invocations?searchFor=label%3Atap+label%3Apostsubmit+label%3AAutoRollback+cl%3A197860730 but failed to build at cl/197860731. Sponge link for all broken targets: https://sponge.corp.google.com/invocations?searchFor=label%3Atap+label%3Apostsubmit+label%3AAutoRollback+cl%3A197860731+status%3Afailed_to_build To see all targets that ran, along with their final status, visit: http://test/197860731 Questions? Comments? See the URL. go/autorollback *** Original change description *** Hiding C++ KeysetHandle::get_keyset() method. *** PiperOrigin-RevId: 197862984 GitOrigin-RevId: cce43c7029c7d5725390bb8f51f8ac7a90e61768 | 24 May 2018, 13:32:36 UTC |
f5cdf37 | Bartosz Przydatek | 24 May 2018, 09:25:58 UTC | Hiding C++ KeysetHandle::get_keyset() method. PiperOrigin-RevId: 197860731 GitOrigin-RevId: e67cdc709f253d56df35fed540e34550cf7ed3ab | 24 May 2018, 13:32:22 UTC |
f1007e7 | Charles Lee | 22 May 2018, 22:58:26 UTC | Actually rename the documentation directory. Previous change only updated links within *.md files. PiperOrigin-RevId: 197638622 GitOrigin-RevId: d8dfc70ea101688291c388503dd8b1fabfd3c496 | 24 May 2018, 13:32:09 UTC |
ab98116 | Charles Lee | 22 May 2018, 19:38:47 UTC | Fix relative documentation links. PiperOrigin-RevId: 197606373 GitOrigin-RevId: b665864856efce15ac5498ed4ec5c4845f966905 | 24 May 2018, 13:31:56 UTC |
f068bf1 | Charles Lee | 22 May 2018, 15:08:37 UTC | Fix CONTRIBUTING.md in the g3doc context. Currently, CONTRIBUTING.md is not rendered by g3doc due to being in an unsupported location: https://g3doc.corp.google.com/third_party/tink/CONTRIBUTING.md?cl=head This fixes that problem and still works in the github context: "To help your project contributors do good work, you can add a file with contribution guidelines to your project repository's root, docs, or .github folder." https://help.github.com/articles/setting-guidelines-for-repository-contributors/ PiperOrigin-RevId: 197563787 GitOrigin-RevId: ac25aa8817f5e8c8cca9dcd2f64ab8891bd98bda | 24 May 2018, 13:31:43 UTC |
a80d9f9 | Charles Lee | 22 May 2018, 15:00:30 UTC | Rename "doc" directory to "docs". This will align the repository with Github's guidelines: https://help.github.com/articles/setting-guidelines-for-repository-contributors/ Also, fix a bunch of broken/inconsistent links. PiperOrigin-RevId: 197562610 GitOrigin-RevId: 21fc894ae8c806d24eae0dd20fe67140acb31b56 | 24 May 2018, 13:31:30 UTC |
24a8f87 | Tink Team | 22 May 2018, 15:00:09 UTC | Fix a bug that AesGcmBoringSsl::Decrypt always fails when additional_data is absl::string_view(). PiperOrigin-RevId: 197562584 GitOrigin-RevId: 7a6cee671c5e79c23b1a151e97396eadd5e7da82 | 24 May 2018, 13:31:18 UTC |
f707905 | Haris Andrianakis | 17 May 2018, 22:35:38 UTC | objc: Remove unused tulsiproj. It's not needed anymore. PiperOrigin-RevId: 197062882 GitOrigin-RevId: 98b347af1a1207828560ec9701fa901de232adc8 | 24 May 2018, 13:31:06 UTC |
937293a | Haris Andrianakis | 17 May 2018, 18:28:37 UTC | objc: Update TINKAeadKeyTemplate to use TINKKeyTemplate. PiperOrigin-RevId: 197023823 GitOrigin-RevId: 165a2fe66d39cc5f315643dca626ec4bd90a007f | 24 May 2018, 13:30:53 UTC |
fc94c85 | Haris Andrianakis | 16 May 2018, 20:38:43 UTC | objc: Implementation of hybrid key templates. PiperOrigin-RevId: 196880687 GitOrigin-RevId: 2dcc7441d189d63b6ea1763fbdfdc267357af67b | 24 May 2018, 13:30:40 UTC |
8274c37 | Thai Duong | 16 May 2018, 01:03:42 UTC | Another attempt to fix https://github.com/google/tink/issues/94. * Listing Guava as an explicit dependency and excluding it in all other dependencies. * Reinstalling maven-enforcer-plugin in helloworld's pom.xml because it helps detect dependency conflicts. * Fixing a typo in test-snapshot.sh and making it executable. PiperOrigin-RevId: 196761172 GitOrigin-RevId: ab5097eeef801671426f26fe90e9c77cd0c5928d | 16 May 2018, 01:09:12 UTC |
3f657b6 | Thai Duong | 12 May 2018, 01:46:14 UTC | Fixing https://github.com/google/tink/issues/94. I don't actually know how Maven works, but the error message indicates that we actually need Gauva. Also I added a test to prevent this bug from happening, but I forgot to make it run =). PiperOrigin-RevId: 196337621 GitOrigin-RevId: 3cdbc775903204bf11762c80a296c1876a9bda3f | 16 May 2018, 01:09:01 UTC |
92c541b | Thai Duong | 11 May 2018, 16:47:40 UTC | Golang: cleaning up, following https://github.com/google/tink/issues/93. 1/ Replacing tink.Registry().Blah() with tink.Blah(). 2/ Updating the APIs and code structure, following latest Java APIs. The Golang implementation was developed following Java 1.0.0, but many things have changed since then. Next: * Adding missing APIs such as KeysetReader, KeysetWriter. * Removing tink.CleartextKeysetHandle(). * Adding RegistryConfig. * Adding missing primitives such as envelope encryption, hybrid encryption, etc. PiperOrigin-RevId: 196266656 GitOrigin-RevId: f4fe243c4501017922eaed1b464da70d3936c7ac | 16 May 2018, 01:08:53 UTC |
1fc1582 | Haris Andrianakis | 10 May 2018, 19:30:45 UTC | tink-objc: Configuration for Cocoapods. PiperOrigin-RevId: 196154901 GitOrigin-RevId: 8df5e4e030d9b4cc854b385f2100b37748542444 | 10 May 2018, 21:56:42 UTC |
0de63de | Haris Andrianakis | 09 May 2018, 22:01:45 UTC | Update copybara to fix import paths for obj-c md docs. PiperOrigin-RevId: 196035052 GitOrigin-RevId: 691793e830caf9b52e77d2ed010c55271404eabb | 10 May 2018, 21:56:33 UTC |
df63c8c | Haris Andrianakis | 08 May 2018, 21:16:51 UTC | tink-objc: Add TINKJSONKeysetReader PiperOrigin-RevId: 195874639 GitOrigin-RevId: 5e8911b5e1b21611d06a9e7355260a449cce9c65 | 10 May 2018, 21:56:24 UTC |
eb6673a | Thai Duong | 07 May 2018, 23:08:55 UTC | ObjC: removing unnecessary protobuf dependencies. While I'm here, refactoring hybrid factory tests. PiperOrigin-RevId: 195738591 GitOrigin-RevId: d5719f8a243cc65213571019ff701d1a754022ea | 07 May 2018, 23:43:16 UTC |
211d6fd | Haris Andrianakis | 07 May 2018, 22:32:02 UTC | tink: Fix bazel v13 builds. It updates rules_apple to version 4.0. PiperOrigin-RevId: 195732837 GitOrigin-RevId: 5c60f66c260706021ae6186b499c667978496098 | 07 May 2018, 23:43:04 UTC |
f5e62be | Haris Andrianakis | 01 May 2018, 00:24:03 UTC | tink-objc: Update TINKMac to be on-par with the other primitives. PiperOrigin-RevId: 194872230 GitOrigin-RevId: 3975640de97ec4b4774d59696b9d8a5036e8551e | 07 May 2018, 23:42:53 UTC |
06d48c2 | Saras Gupta | 28 April 2018, 08:05:22 UTC | Adding capability to just sign (and not encrypt) the message for ECv2SigningOnly protocol version. Doc: https://docs.google.com/document/d/1-2zhISCbvQ0kt82w3cBpKRPB6ln17ORQNCOZi9Uy3mA/edit?usp=sharing PiperOrigin-RevId: 194640671 GitOrigin-RevId: e6bb697ae43c0e2c11d616697c13ea63c55f35f5 | 28 April 2018, 15:52:52 UTC |