4b23960 | Mike Perham | 12 April 2019, 16:37:30 UTC | bump, release | 12 April 2019, 16:37:30 UTC |
c650e9b | Mike Perham | 12 April 2019, 01:33:59 UTC | Explicitly signal that we handled an exception with a retry, fixes #4138 (#4141) Under just the right conditions, we could lose a job: - Job raises an error - Retry subsystem catches error and tries to create a retry in Redis but this raises a "Redis down" exception - Processor catches Redis exception and thinks a retry was created - Redis comes back online just in time for the job to be acknowledged and lost That's a very specific and rare set of steps but it can happen. Instead have the Retry subsystem raise a specific error signaling that it created a retry. There will be three common cases: 1. Job is successful: job is acknowledged. 2. Job fails, retry is created, Processor rescues specific error: job is acknowledged. 3. Sidekiq::Shutdown is raised: job is not acknowledged Now there is another case: 4. Job fails, retry fails, Processor rescues Exception: job is NOT acknowledged. Sidekiq Pro's super_fetch will rescue the orphaned job at some point in the future. | 12 April 2019, 01:33:59 UTC |
2f37600 | Nicolas CARPi | 01 April 2019, 15:37:15 UTC | Minor fixes to COMM-LICENSE (#4135) * Replace "Right single quote" characters with apostrophes * Remove double space and spaces at end of line * Fix typo on "version" | 01 April 2019, 15:37:15 UTC |
ca8d3a6 | Mike Perham | 27 March 2019, 22:31:51 UTC | bump jruby to fix issue running test suite | 27 March 2019, 22:31:51 UTC |
ea30e97 | Mike Perham | 27 March 2019, 17:30:10 UTC | Fix broken build due to rails/rails#35611 | 27 March 2019, 17:30:52 UTC |
91d7680 | Mike Perham | 05 March 2019, 16:34:03 UTC | release | 05 March 2019, 16:34:03 UTC |
33aedf6 | Mike Perham | 04 March 2019, 19:16:58 UTC | Allow Sidekiq::Worker#set to be chained | 04 March 2019, 19:16:58 UTC |
e1b392d | Eyüp Atiş | 02 March 2019, 17:15:10 UTC | Fix heroku wait time, change it to 30 from 10 (#4117) | 02 March 2019, 17:15:10 UTC |
edbefc4 | Mike Perham | 01 March 2019, 21:27:28 UTC | flush redis so status is predictable | 01 March 2019, 21:27:28 UTC |
4d88319 | Mike Perham | 28 February 2019, 22:36:40 UTC | Refactor sidekiqctl so it can be tested easily | 28 February 2019, 22:36:40 UTC |
20f4cdb | Mike Perham | 28 February 2019, 22:07:27 UTC | Fix various flaky tests due to process-wide data changes | 28 February 2019, 22:12:08 UTC |
cfe53e5 | Mike Perham | 28 February 2019, 22:05:45 UTC | Allow tests to override enqueued_at | 28 February 2019, 22:05:45 UTC |
4f057c9 | Mike Perham | 28 February 2019, 20:57:29 UTC | oops | 28 February 2019, 20:57:29 UTC |
85a1be3 | Mike Perham | 28 February 2019, 20:43:50 UTC | Switch all tests to use Minitest::Spec for consistency | 28 February 2019, 20:43:50 UTC |
870516f | Josh Loewen | 28 February 2019, 18:06:41 UTC | Format latency (#4111) * Format latency time * format latency when 0 * only show human-readable time if 60s or more * memoize to reduce repetitive Redis calls * removing use of seconds.ago due to no ActiveSupport in Sidekiq | 28 February 2019, 18:06:41 UTC |
ac1d36b | Mike Perham | 28 February 2019, 17:02:09 UTC | ent change | 28 February 2019, 17:02:09 UTC |
567e68c | Mike Perham | 24 February 2019, 18:08:05 UTC | Merge branch 'master' of github.com:mperham/sidekiq | 24 February 2019, 18:08:05 UTC |
771671e | Edward Rudd | 22 February 2019, 17:12:04 UTC | add back the dropdown css (#4103) | 22 February 2019, 17:12:04 UTC |
5dce7be | Mike Perham | 14 February 2019, 14:42:06 UTC | ES locale | 14 February 2019, 14:42:06 UTC |
e8ad1a1 | Mike Perham | 08 February 2019, 17:24:23 UTC | releases | 08 February 2019, 17:24:23 UTC |
731b5d6 | Mike Perham | 08 February 2019, 16:53:50 UTC | cleanup | 08 February 2019, 16:53:50 UTC |
d911036 | Mike Perham | 08 February 2019, 16:53:23 UTC | Better handling of malformed job arguments in payload, fixes #4095 | 08 February 2019, 16:53:23 UTC |
f72d68f | Mike Perham | 05 February 2019, 19:44:49 UTC | adapt to rails 5.2.2's draconian sqlite3 version requirement | 05 February 2019, 19:44:49 UTC |
d67e824 | Mike Perham | 05 February 2019, 19:10:56 UTC | remove things which complicate the test suite | 05 February 2019, 19:10:56 UTC |
06d6e5c | Mike Perham | 05 February 2019, 18:45:37 UTC | no longer necessary | 05 February 2019, 18:45:37 UTC |
f64e2d0 | Mike Perham | 05 February 2019, 18:44:11 UTC | Simplify, prep for 6.0 | 05 February 2019, 18:44:11 UTC |
d392ebb | Mike Perham | 05 February 2019, 18:23:18 UTC | super fetch latency | 05 February 2019, 18:23:18 UTC |
47028ef | Mike Perham | 31 January 2019, 19:27:58 UTC | cleanup, #4089 | 31 January 2019, 19:27:58 UTC |
23e6a5f | Brian Sewell | 31 January 2019, 19:25:00 UTC | Rescue StandardErrors raised from exception's message (#4089) * Rescue standard errors raised from exception's message * Set a default message value if it raises an error * Update default message value * Add comments for exception_message | 31 January 2019, 19:25:00 UTC |
3d8147c | Mike Perham | 24 January 2019, 04:07:27 UTC | organization license -> limited license | 24 January 2019, 04:07:27 UTC |
cdae000 | Mike Perham | 24 January 2019, 04:04:12 UTC | Add clause for the Enterprise site license | 24 January 2019, 04:04:12 UTC |
844f5a7 | Mike Perham | 10 January 2019, 20:19:48 UTC | changes | 10 January 2019, 20:19:48 UTC |
4769187 | Mike Perham | 10 January 2019, 02:39:12 UTC | add default queue latency | 10 January 2019, 02:39:12 UTC |
c2e8197 | Mike Perham | 08 January 2019, 17:23:09 UTC | bump, changes | 08 January 2019, 17:23:09 UTC |
a281aa4 | Andrew Babichev | 08 January 2019, 17:20:59 UTC | Consider Default Required Path on Config File Search (#4077) * Consider default required path on config file search * Fix bundler at ci | 08 January 2019, 17:20:59 UTC |
d3fc295 | Mike Perham | 08 January 2019, 00:30:27 UTC | modern terminology | 08 January 2019, 00:30:27 UTC |
1daa32d | Mike Perham | 07 January 2019, 17:31:22 UTC | bump, release | 07 January 2019, 17:31:22 UTC |
c1e8fc3 | Mike Perham | 07 January 2019, 17:26:06 UTC | Redis bump warning, link to issue for more detail | 07 January 2019, 17:26:06 UTC |
432a800 | Mike Perham | 06 January 2019, 17:28:14 UTC | remove ruby 2.2 | 06 January 2019, 17:28:14 UTC |
9c825f4 | Masato Ohba | 06 January 2019, 17:27:06 UTC | Run tests against 2.6.0 (#4070) ref https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/ | 06 January 2019, 17:27:06 UTC |
be28fc6 | Mike Perham | 02 January 2019, 17:37:37 UTC | switch to jruby so we auto-move to new versions | 02 January 2019, 17:37:37 UTC |
d0887a0 | Mike Perham | 02 January 2019, 17:23:41 UTC | release | 02 January 2019, 17:23:41 UTC |
d744250 | Mike Perham | 02 January 2019, 17:23:34 UTC | fix require check | 02 January 2019, 17:23:34 UTC |
1d83555 | Andrew Babichev | 13 December 2018, 16:30:29 UTC | Check Config File Existence (#4054) * Check config file existence * Eager config file check * Parse expanded path to default sidekiq.yml config file in Rails app * Cleanup | 13 December 2018, 16:30:29 UTC |
6a7bf2d | Mike Perham | 11 December 2018, 17:58:50 UTC | #4053 | 11 December 2018, 17:58:50 UTC |
3f5b1c5 | Mike Perham | 07 December 2018, 21:02:04 UTC | deprecate args, #4045 | 07 December 2018, 21:02:04 UTC |
29a972a | Mike Perham | 07 December 2018, 17:04:20 UTC | changes, #4039 | 07 December 2018, 17:04:20 UTC |
ea9b34a | Andrew Babichev | 07 December 2018, 16:59:42 UTC | Add CLI Run Test - Write Pid, System Boot, Print Banner (#4039) * Add appraisal * Test CLI run (write pid, system boot, print banner) * Cleanup test helper * Set REDIS_URL to use non-default host in test env * Move mintiest-focus to test bundle group | 07 December 2018, 16:59:42 UTC |
547b2de | Mike Perham | 07 December 2018, 15:00:55 UTC | pro change: | 07 December 2018, 15:00:55 UTC |
4eb5496 | Ryan Ong | 06 December 2018, 14:10:48 UTC | fix syntax highlighting in documentation for Sidekiq::Worker (#4042) | 06 December 2018, 14:10:48 UTC |
30bbd13 | Mike Perham | 03 December 2018, 22:09:26 UTC | Update tests so they all run standalone successfully, like so: for i in test/test_* ; do ruby $i; done | 03 December 2018, 22:09:26 UTC |
ddb0c8b | Andrew Babichev | 03 December 2018, 21:24:37 UTC | Cleanup CLI (#4026) * Refactor CLI test Extracted 3 main parts: - parse - run - signal handling * Move demonization and pid write from parse to run phase * Move queues default from validate to setup options phase * Add pry-byebug gem * Drop Sidekiq::Test * Require launcher in CLI * Remove TODOs | 03 December 2018, 21:24:37 UTC |
78f3b68 | Geoff Harcourt | 28 November 2018, 19:46:07 UTC | Add unsafe-inline to allow bucket graph to display (#4031) The current CSP policy for Sidekiq Web appears to block the inline script that renders the bucket charts for limits. This change updates the script CSP rules to match the style CSP rules to allow the chart to successfully render. In our application this change made the bucket charts successfully render. cc: #3913, #4030 | 28 November 2018, 19:46:07 UTC |
d1b2d00 | Andrew Babichev | 19 November 2018, 22:11:48 UTC | Cleanup gem spec (#4023) | 19 November 2018, 22:11:48 UTC |
2d0106e | Mike Perham | 14 November 2018, 21:52:30 UTC | pt locales | 14 November 2018, 21:52:30 UTC |
8bdd1d8 | Mike Perham | 13 November 2018, 18:02:37 UTC | remove old broken example, fixes #4016 | 13 November 2018, 18:02:37 UTC |
0e3ff21 | Mike Perham | 13 November 2018, 17:59:51 UTC | add notes about translations | 13 November 2018, 17:59:51 UTC |
c149d52 | Mike Perham | 06 November 2018, 17:00:26 UTC | bump, release | 06 November 2018, 17:00:26 UTC |
be74269 | Mike Perham | 06 November 2018, 16:56:56 UTC | Merge branch 'master' of github.com:mperham/sidekiq | 06 November 2018, 16:56:56 UTC |
df788c6 | Mike Perham | 06 November 2018, 16:56:50 UTC | Warning for upcoming breakage | 06 November 2018, 16:56:50 UTC |
1c44ab6 | Matt Duszynski | 29 October 2018, 19:04:19 UTC | sidekiqctl status (#4003) * Add status output for sidekiqctl * A little cleanup * Refactor to Sidekiqctl::Status * Error handling for section argument * Rename workers to processes * Clean up how the queue table is printed * Refactoring, added tests * Improve error handling * Comma-separate values in overview * Add changelog entry | 29 October 2018, 19:04:19 UTC |
a8329b7 | Karthik M A M | 29 October 2018, 16:58:56 UTC | Fix RealTime Graphs Reset on Window Height Change (#4008) * fix graphs reset on height change * move debounce method * add semi-colon | 29 October 2018, 16:58:56 UTC |
c1a9802 | Gerrit Riessen | 19 October 2018, 15:33:51 UTC | Update _nav.erb (#4002) Localize the "Back to App" string | 19 October 2018, 15:33:51 UTC |
8d06669 | Mike Perham | 19 October 2018, 02:28:47 UTC | ent changes, fixes #4000 | 19 October 2018, 02:28:47 UTC |
003e581 | Mike Perham | 18 October 2018, 21:35:10 UTC | Fix test suite | 18 October 2018, 21:35:10 UTC |
f0d6cec | Mike Perham | 18 October 2018, 20:53:30 UTC | ent changes | 18 October 2018, 20:53:30 UTC |
aa9745e | Mike Perham | 18 October 2018, 20:51:58 UTC | Switch elapsed time calcs to use monotonic clock, fixes #3999 | 18 October 2018, 20:51:58 UTC |
27de964 | Mike Perham | 18 October 2018, 15:29:10 UTC | changes | 18 October 2018, 15:29:10 UTC |
64dfc28 | Matt Books | 18 October 2018, 15:27:45 UTC | Synchronize code that reads/undefines methods in class attrs (#3997) Fixes #3659 and #2302 The problem is that when two classes are accessed from separate threads they can race to undef/read these methods. | 18 October 2018, 15:27:45 UTC |
b5cad42 | Mike Perham | 05 October 2018, 15:58:45 UTC | #3951 | 05 October 2018, 15:58:45 UTC |
b532249 | Mike Perham | 28 September 2018, 18:22:17 UTC | Minimize logging in the retry subsystem, fixes #3979 | 28 September 2018, 18:22:17 UTC |
f638246 | Mike Perham | 27 September 2018, 19:07:45 UTC | #3974 | 27 September 2018, 19:07:45 UTC |
361a8f7 | Mike Perham | 27 September 2018, 15:49:58 UTC | changes | 27 September 2018, 15:49:58 UTC |
4359161 | Benjamin Dobell | 27 September 2018, 15:39:13 UTC | Ensure death_handlers are called on jobs with retry: false (#3980) | 27 September 2018, 15:39:13 UTC |
24d12dd | Mike Perham | 20 September 2018, 20:08:15 UTC | changes, bump | 20 September 2018, 20:08:15 UTC |
debe8ec | Mike Perham | 20 September 2018, 20:06:46 UTC | move config to proper place | 20 September 2018, 20:06:46 UTC |
c342476 | Navied Shoushtarian | 20 September 2018, 20:06:18 UTC | Fixed mobile navigation. (#3973) * Fixed mobile navigation. * Remove unused toggle. * Small css changes for mobile + ipad * Fixes to double navbar * remove leftover css * fixed double btn two line issue | 20 September 2018, 20:06:18 UTC |
fd23e2f | Mike Perham | 17 September 2018, 19:07:15 UTC | Revert "changelog" This reverts commit d997b751c6df53cb5a1c9ee8497449602d53bf84. | 17 September 2018, 19:07:15 UTC |
d997b75 | Mike Perham | 17 September 2018, 19:06:51 UTC | changelog | 17 September 2018, 19:06:51 UTC |
4076577 | Mike Perham | 17 September 2018, 17:10:27 UTC | Update default concurrency per 5.2 changes | 17 September 2018, 17:10:27 UTC |
10342b6 | Mike Perham | 17 September 2018, 16:08:33 UTC | release | 17 September 2018, 16:08:33 UTC |
3553a5a | Mike Perham | 12 September 2018, 21:06:36 UTC | bump | 12 September 2018, 21:06:36 UTC |
927680c | Matt Books | 11 September 2018, 16:53:52 UTC | Use a mutex to synchronize access to shared WORKER_STATE hash (#3959) On jruby, the Hash implementation is not threadsafe, and leads to jobs not being deleted from the busy list. See #3958 | 11 September 2018, 16:53:52 UTC |
da3fbed | Tobias Bühlmann | 09 September 2018, 13:11:37 UTC | Use redis' default driver (#3956) Redis stores its loaded drivers in `Redis::Connection.drivers` and uses the last one of them when initializing a new client. Sidekiq always uses `'ruby'` (or `Redis::Connection::Ruby`) per default, though. With this commit we are following redis' default by passing the last loaded driver per default (or a given `:driver`). | 09 September 2018, 13:11:37 UTC |
78344b6 | Mike Perham | 06 September 2018, 15:51:42 UTC | Other languages should fall back to EN when there is no native translation, fixes #3950 | 06 September 2018, 15:51:42 UTC |
9fdbdba | Mike Perham | 03 September 2018, 15:13:19 UTC | pro 4.0.4 | 03 September 2018, 15:13:19 UTC |
1cd40bd | Mike Perham | 31 August 2018, 15:38:06 UTC | add tags | 31 August 2018, 15:38:06 UTC |
305ab8e | Morad Edwar | 25 August 2018, 14:42:01 UTC | Add Kill All button to the retries page (#3938) | 25 August 2018, 14:42:01 UTC |
e822718 | Chad Schroeder | 24 August 2018, 18:35:07 UTC | Raise error for duplicate queue names in config, fixes #3911 (#3936) * Raise error for duplicate queue names in config, fixes #3911 * Add note to change log | 24 August 2018, 18:35:07 UTC |
6386c65 | Alexandros | 19 August 2018, 20:21:11 UTC | absolute path for bundle in sidekiq.service for rbenv (#3931) | 19 August 2018, 20:21:11 UTC |
43e86db | Mike Perham | 17 August 2018, 19:04:49 UTC | Merge branch 'master' of github.com:mperham/sidekiq | 17 August 2018, 19:04:49 UTC |
e252999 | Mike Perham | 17 August 2018, 19:04:43 UTC | note | 17 August 2018, 19:04:43 UTC |
6e18326 | Laurent Arnoud | 13 August 2018, 22:13:51 UTC | Add queue size to web show page (#3896) * Add queue size to web show page * Use bootstrap badge for queue size on show Thanks-to: @thegorgon * Use @total_size to avoid a network trip | 13 August 2018, 22:13:51 UTC |
99922ca | Mike Perham | 10 August 2018, 12:57:56 UTC | dup hash to avoid concurrent modification, fixes #3921 | 10 August 2018, 12:57:56 UTC |
b075660 | Mike Perham | 09 August 2018, 20:46:54 UTC | release | 09 August 2018, 20:46:54 UTC |
b1bdaa7 | Mike Perham | 07 August 2018, 15:17:59 UTC | Verify connection pool sizing, fixes #3917 | 07 August 2018, 15:17:59 UTC |
03e63b8 | Óscar de Arriba | 06 August 2018, 17:46:00 UTC | Add TTL for stats keys This change adds a 5 years TTL on redis keys containing daily stats. See #3905 for more details | 06 August 2018, 17:57:28 UTC |
e339d23 | Jesse Reiss | 05 August 2018, 19:31:37 UTC | Add CSP header to web admin to ensure it matches needs (#3913) | 05 August 2018, 19:31:37 UTC |
778b9cf | Mike Perham | 05 August 2018, 18:01:04 UTC | changes | 05 August 2018, 18:01:04 UTC |
35cdf82 | Mike Perham | 03 August 2018, 23:02:51 UTC | Merge branch 'master' of github.com:mperham/sidekiq | 03 August 2018, 23:02:51 UTC |