| 7f6b2ef | Mike Perham | 20 January 2022, 18:47:00 UTC | Bump minor as there are significant changes | 20 January 2022, 18:47:00 UTC |
| 7785ac1 | Mike Perham | 20 January 2022, 18:42:26 UTC | Validate `days` parameter to avoid possible DoS in Web UI Thank you to Sergey Shpakov of http://tutum.space for reporting. | 20 January 2022, 18:42:26 UTC |
| 0a4de94 | Nathan Le Ray | 18 January 2022, 15:55:31 UTC | Add keyword arguments support in extensions (#5120) * Add keyword arguments support in extensions * Check that keywords arguments are passed * Test perform calls with keyword arguments * Fix kwargs forwarding on Ruby 2.6 | 18 January 2022, 15:55:31 UTC |
| b3c99ca | Brandon Hilkert | 18 January 2022, 01:16:10 UTC | Dashboard CSS tweaks for consistency/improvements (#5123) | 18 January 2022, 01:16:10 UTC |
| 8f7bc48 | OskarEichler | 17 January 2022, 18:41:56 UTC | Dark Mode Improvements (#5122) * Dark Mode Improvements * Add Important Button Color * Update application-dark.css Further improvements | 17 January 2022, 18:41:56 UTC |
| 07acfad | Mike Perham | 10 January 2022, 22:51:30 UTC | Bring back redis-namespace onto a gem release Was running master because Ruby 3.0 wasn't working in 1.8.0 | 10 January 2022, 22:51:30 UTC |
| d58a0a1 | Mike Perham | 10 January 2022, 17:15:23 UTC | Update build for Ruby 3.1, fixes #5115 We need to remove Ruby 2.5 because the new net-smtp gem is required for the mail gem on Ruby 3.1 but it does not work on <=2.5. https://github.com/mikel/mail/pull/1439 Also remove an anon struct test which now breaks with safe YAML loading on 3.1. | 10 January 2022, 17:15:23 UTC |
| 63f6e68 | Mike Perham | 06 January 2022, 05:01:32 UTC | standard formatting | 06 January 2022, 05:01:32 UTC |
| 96816c3 | Mike Perham | 06 January 2022, 03:59:32 UTC | fix ruby 3.0 build | 06 January 2022, 03:59:32 UTC |
| 96ac8e7 | Mike Perham | 06 January 2022, 03:56:04 UTC | bump | 06 January 2022, 03:56:04 UTC |
| cea266a | Mike Perham | 06 January 2022, 03:54:12 UTC | Better method naming, #5071 | 06 January 2022, 03:54:12 UTC |
| 9818c34 | Mike Perham | 06 January 2022, 03:43:53 UTC | Wording and formatting, no significant changes | 06 January 2022, 03:43:53 UTC |
| 4d00845 | Ben Bodenmiller | 23 December 2021, 14:38:35 UTC | Fix YouTube capitalization (#5103) | 23 December 2021, 14:38:35 UTC |
| f7e1fc8 | Mike Perham | 14 December 2021, 19:53:00 UTC | Pause hard shutdown to give time for `ensure` cleanup, fixes #5095 If we raised Sidekiq::Shutdown in job threads, sleep for a while so they have time to run `ensure` blocks. Right now we immediately return from hard_shutdown and call `exit` which immediately raises SystemExit on every thread which can stop ensure blocks. | 14 December 2021, 19:53:00 UTC |
| 35eee4b | Mike Perham | 11 December 2021, 18:13:15 UTC | change | 11 December 2021, 18:13:15 UTC |
| c92a521 | Mike Perham | 09 December 2021, 21:13:05 UTC | Merge new attributes if existing attributes, fixes #5090 | 09 December 2021, 21:14:59 UTC |
| 615393d | Mike Perham | 09 December 2021, 21:06:29 UTC | RDoc improvements | 09 December 2021, 21:06:29 UTC |
| bd4493f | Mike Perham | 07 December 2021, 22:06:49 UTC | Add note about arg checking | 07 December 2021, 22:06:49 UTC |
| 41493f2 | Mike Perham | 07 December 2021, 22:02:59 UTC | Stringify perform_bulk's option hash, fixes #5081 | 07 December 2021, 22:02:59 UTC |
| b0fd83f | Mike Perham | 07 December 2021, 21:58:04 UTC | Rejigger complex argument handling, #5071 Add job class name to arg message | 07 December 2021, 21:58:04 UTC |
| fde53a5 | Kelly Sutton | 07 December 2021, 21:20:20 UTC | Implement strict argument checking (#5071) * Add the outline of failing tests * Implement argument checking * Move argument checking into Sidekiq::JobUtil#validate * Refactor acceptable class definition into a constant to cut down on array allocations * Improve error message, match raise call formatting to other errors in the class * Address feedback in the Pull Request to use the JSON round-trip method of confirming the safety of job argument payloads. Cleanup commented-out code from a few years back. Co-authored-by: Eda Zhou <eda.zhou@gusto.com> * Swap out JSON.load for JSON.parse per the security CI check Co-authored-by: Eda Zhou <eda.zhou@gusto.com> * Add a few more tests cases to build up confidence around our JSON.parse/dump approach and deep structures Co-authored-by: Eda Zhou <eda.zhou@gusto.com> * Improve test case description * Warn when job arguments do not serialize safely and point folks toward how to enable strict_mode and the best practice * Reconfigure the options-hash based approach to a global Sidekiq.strict_mode! method * Add a note in the raised error on how to disable the error * Let the error message breathe a little bit * Toggle strict_mode! off to suss out a test flake * Capitalize the start of a sentence * Rename job_is_json_safe to json_safe? Co-authored-by: Eda Zhou <eda.zhou@gusto.com> * Refactor a few tests to test a single argument at a time Co-authored-by: Eda Zhou <eda.zhou@gusto.com> * Break out test cases to exercise each individual intersting case instead of all at once Co-authored-by: Eda Zhou <eda.zhou@gusto.com> * Change formatting to be more consistent, tighter when arguments are simple Co-authored-by: Eda Zhou <eda.zhou@gusto.com> * Add a flag to disable the warning message for development warning messages Co-authored-by: Eda Zhou <eda.zhou@gusto.com> Co-authored-by: Eda Zhou <eda.zhou@gusto.com> | 07 December 2021, 21:20:20 UTC |
| 6877e7c | Mike Perham | 06 December 2021, 18:04:28 UTC | Warn about upcoming removal, #5076 | 06 December 2021, 18:04:28 UTC |
| 2890f81 | Jordan Brough | 01 December 2021, 15:00:03 UTC | Fix "Statsd.options" example (#5075) | 01 December 2021, 15:00:03 UTC |
| e093c1b | Heinrich Lee Yu | 23 November 2021, 17:13:20 UTC | Fix deprecation warning when using redis-namespace (#5066) We need to call the `script` command on the raw redis connection because passthrough for administrative commands has been deprecated and will be removed in redis-namespace 2.0 Co-authored-by: Heinrich Lee Yu <heinrich@gitlab.com> | 23 November 2021, 17:13:20 UTC |
| 837745a | Marc-Antoine Leblond | 22 November 2021, 17:48:30 UTC | Fix stack level too deep when Sidekiq.logger == Rails.logger (#5065) | 22 November 2021, 17:48:30 UTC |
| 25ae4c4 | Mike Perham | 19 November 2021, 16:59:19 UTC | note | 19 November 2021, 16:59:19 UTC |
| 4e626a0 | Mike Perham | 17 November 2021, 16:37:24 UTC | note 5055 | 17 November 2021, 16:37:24 UTC |
| 6b15877 | Marcelo Lauxen | 17 November 2021, 16:35:18 UTC | Replace worker generator with job generator (#5055) | 17 November 2021, 16:35:18 UTC |
| 2ed5af0 | Mike Perham | 16 November 2021, 18:40:20 UTC | notes on #5061 | 16 November 2021, 18:40:20 UTC |
| 283d231 | Mike Perham | 16 November 2021, 18:19:50 UTC | Merge branch 'hasan-ally-feat_sidekiq_perform_inline' | 16 November 2021, 18:19:50 UTC |
| 6ae5b02 | Mike Perham | 16 November 2021, 18:15:14 UTC | Extract client's job utility methods, use them for `perform_inline`. Sidekiq::Client is Redis-only, no inline support. | 16 November 2021, 18:15:14 UTC |
| e96ab69 | Kelly Sutton | 16 November 2021, 16:54:35 UTC | Make `.perform_bulk` immediately evaluate lazy enumerators. (#5060) * Create failing tests to capture the cases we care about Co-authored-by: Noa Elad <noa.elad@zenpayroll.com> * Call .force on args if they are a lazy enumerator to evaluate them immediately Co-authored-by: Noa Elad <noa.elad@zenpayroll.com> * Change implementation of `.perform_bulk` to lazily pull values from a lazy enumerator. This prevents us from loading the entire contents of a lazy enumerator into memory while providing the "unsurprising" behavior of enqueueing jobs when `.perform_bulk` is called. Note: We'll still load all JIDs into memory. Co-authored-by: Noa Elad <noa.elad@zenpayroll.com> Co-authored-by: Eda Zhou <eda.zhou@gusto.com> Co-authored-by: Noa Elad <noa.elad@zenpayroll.com> Co-authored-by: Eda Zhou <eda.zhou@gusto.com> | 16 November 2021, 16:54:35 UTC |
| 6bef015 | Sam Bostock | 16 November 2021, 05:08:27 UTC | Make `__FILE__` and `__dir__` behave as expected in ERB configs (#5062) * Add tests for existing ERB config __FILE & __dir__ * Allow expected usage of __FILE__ in ERB config | 16 November 2021, 05:08:27 UTC |
| c950470 | Hasan Kumar | 15 November 2021, 21:40:38 UTC | chore: move perform_inline to Sidekiq::Client to avoid unncessary set({}) | 15 November 2021, 21:40:38 UTC |
| 2898a71 | Hasan Kumar | 15 November 2021, 10:27:48 UTC | feat: adds support for `.perform_inline` which processes the job inline after passing through available client and server middlewares | 15 November 2021, 10:27:56 UTC |
| a486ffa | Heinrich Lee Yu | 11 November 2021, 00:18:50 UTC | Continue scheduling jobs when backlog jobs exist (#5056) When there are scheduled jobs that are due, the scheduler thread will keep going instead of waiting for the next poll. Co-authored-by: Heinrich Lee Yu <heinrich@gitlab.com> | 11 November 2021, 00:18:50 UTC |
| acaee69 | Mike Perham | 07 November 2021, 18:52:14 UTC | release | 07 November 2021, 18:52:14 UTC |
| ace6e66 | Mike Perham | 07 November 2021, 01:14:58 UTC | update gem.lock | 07 November 2021, 01:14:58 UTC |
| 26f5f33 | Mike Perham | 07 November 2021, 01:12:09 UTC | Fix keyword args issue on Ruby 3.0 | 07 November 2021, 01:12:09 UTC |
| 0723abd | Mike Perham | 07 November 2021, 01:07:02 UTC | Failing test on 3.0 | 07 November 2021, 01:07:02 UTC |
| 62efdd1 | Mike Perham | 06 November 2021, 17:52:37 UTC | release | 06 November 2021, 17:52:37 UTC |
| ed2307e | Mike Perham | 05 November 2021, 16:21:53 UTC | changes | 05 November 2021, 16:21:53 UTC |
| c42d941 | Heinrich Lee Yu | 05 November 2021, 16:19:25 UTC | Change scheduler to use Lua-based script (#5044) This allows us to pop jobs atomically so that we remove redundant ZREMs from multiple processes trying to process the same job. Co-authored-by: Heinrich Lee Yu <heinrich@gitlab.com> | 05 November 2021, 16:19:25 UTC |
| be80d62 | Mike Perham | 05 November 2021, 16:03:37 UTC | Add sample code | 05 November 2021, 16:03:37 UTC |
| 93226b7 | Mike Perham | 05 November 2021, 16:03:26 UTC | Add explanatory text for Delete button, #2981 | 05 November 2021, 16:03:26 UTC |
| 0f3cda1 | Mike Perham | 02 November 2021, 22:11:35 UTC | change | 02 November 2021, 22:11:35 UTC |
| ea017d8 | Mike Perham | 02 November 2021, 19:56:08 UTC | CSS tweaks - remove unused(?) rickshaw_annotation_* - further enhancements to dark mode readability | 02 November 2021, 19:56:08 UTC |
| cf8618f | Mike Perham | 02 November 2021, 19:44:45 UTC | Note jQuery removal | 02 November 2021, 19:44:45 UTC |
| 8fb370d | Mike Perham | 02 November 2021, 17:04:43 UTC | too unreliable, noisy | 02 November 2021, 17:04:43 UTC |
| 9eeaed2 | Mike Perham | 02 November 2021, 16:57:21 UTC | Trim | 02 November 2021, 16:57:21 UTC |
| 4a04326 | Kelly Sutton | 02 November 2021, 16:54:44 UTC | Implement `Sidekiq::Worker.perform_bulk` (#5042) * Sketch out some failing tests to capture the behavior Co-authored-by: jeffcarbs <jeff.carbonella@gmail.com> * Implement Sidekiq::Client.perform_bulk Co-authored-by: jeffcarbs <jeff.carbonella@gmail.com> * Allow .perform_bulk to operate on different batch sizes Co-authored-by: jeffcarbs <jeff.carbonella@gmail.com> * Write a failing test to capture the Sidekiq::Worker::Setter.perform_bulk behavior Co-authored-by: jeffcarbs <jeff.carbonella@gmail.com> * Implement Sidekiq::Worker::Setter.perform_bulk Co-authored-by: jeffcarbs <jeff.carbonella@gmail.com> * Write a small comment for to document the method Co-authored-by: jeffcarbs <jeff.carbonella@gmail.com> * Add a Changes.md entry Co-authored-by: jeffcarbs <jeff.carbonella@gmail.com> | 02 November 2021, 16:54:44 UTC |
| fd76471 | Heinrich Lee Yu | 02 November 2021, 14:49:34 UTC | Use Redis.pipelined instead of Redis.multi (#5043) We don't need the commands here to be atomic so we use pipelined instead to save us some overhead from MULTI Co-authored-by: Heinrich Lee Yu <heinrich@gitlab.com> | 02 November 2021, 14:49:34 UTC |
| 8cc43f7 | Mike Perham | 01 November 2021, 17:46:23 UTC | merge | 01 November 2021, 17:46:23 UTC |
| ba2fa2d | Mike Perham | 01 November 2021, 17:44:26 UTC | Extract constant | 01 November 2021, 17:44:26 UTC |
| 21ab89b | Mike Perham | 01 November 2021, 17:44:14 UTC | Add constrast to make beacon pulse a little more obvious | 01 November 2021, 17:44:14 UTC |
| 9352de0 | Mike Perham | 01 November 2021, 17:43:22 UTC | Move global near its usage | 01 November 2021, 17:43:22 UTC |
| 4d30390 | Mike Perham | 01 November 2021, 16:55:17 UTC | Refresh javascripts (#5036) Refactor Web UI javascripts: - Remove jQuery - Remove dropdown.js, unused - Update app JS to use vanilla JS | 01 November 2021, 16:55:17 UTC |
| 343b090 | Mike Perham | 31 October 2021, 21:23:07 UTC | Add context and discussion place for RTT warning | 31 October 2021, 21:23:07 UTC |
| b4e3355 | Brandon Hilkert | 30 October 2021, 22:13:32 UTC | Fix pulseBeach for vanilla JS | 30 October 2021, 22:13:32 UTC |
| 3f7e3df | Mike Perham | 30 October 2021, 05:06:03 UTC | Remove jQuery from Dashboard TODO: beacon pulse | 30 October 2021, 05:06:03 UTC |
| 75b4701 | Mike Perham | 30 October 2021, 00:26:23 UTC | changes | 30 October 2021, 00:26:23 UTC |
| 5e295b0 | Mike Perham | 27 October 2021, 23:38:53 UTC | Restore logic to avoid live poll on pages that don't have the button | 27 October 2021, 23:38:53 UTC |
| 7672171 | Mike Perham | 27 October 2021, 23:21:15 UTC | Refactor Web UI javascripts - Remove jQuery - Remove dropdown.js, unused - Update app JS to use vanilla JS | 27 October 2021, 23:21:15 UTC |
| 3e97c0d | Mike Perham | 27 October 2021, 16:26:19 UTC | Latest | 27 October 2021, 16:26:19 UTC |
| bd3f200 | Mike Perham | 21 October 2021, 18:39:12 UTC | Remove multithreaded writes to the same Array when using JRuby, fixes #5031 | 21 October 2021, 18:39:12 UTC |
| 1f05bd6 | Ivy Evans | 13 October 2021, 00:14:55 UTC | Fix `Uncaught exception: can't dump IO` (#5022) | 13 October 2021, 00:14:55 UTC |
| 06d43cb | Mike Perham | 12 October 2021, 20:33:14 UTC | standard styling | 12 October 2021, 20:33:14 UTC |
| 90535ab | Mike Perham | 12 October 2021, 20:28:41 UTC | Integrate Sidekiq.logger into Rails.logger, closes #5021 Any use of Rails.logger in jobs will now go to the Sidekiq logger. | 12 October 2021, 20:28:41 UTC |
| 717e7fd | Mike Perham | 12 October 2021, 14:49:36 UTC | Rename master branch to main | 12 October 2021, 14:49:36 UTC |
| f7182aa | cuilei | 12 October 2021, 14:45:53 UTC | Fix examples/web-ui.png broken link (#5020) | 12 October 2021, 14:45:53 UTC |
| 5267e3b | Igor Victor | 09 October 2021, 16:18:47 UTC | Update ci.yml (#5015) | 09 October 2021, 16:18:47 UTC |
| 3b233c5 | Mike Perham | 05 October 2021, 21:03:53 UTC | Add support for AJ's :wait option | 05 October 2021, 21:04:04 UTC |
| 305c386 | Mike Perham | 05 October 2021, 21:01:58 UTC | standard formatting | 05 October 2021, 21:04:04 UTC |
| 908c249 | Olle Jonsson | 05 October 2021, 13:59:11 UTC | CI: Avoid double bundle install (#5012) | 05 October 2021, 13:59:11 UTC |
| 46f4c6b | Mike Perham | 30 September 2021, 19:09:15 UTC | Stringify queue name to handle symbols from YAML cfg, fixes #5006 | 30 September 2021, 19:09:15 UTC |
| 2b2390d | Mike Perham | 28 September 2021, 18:24:17 UTC | Support ActiveJob’s wait_until (#5003) * Implement support for `set(wait_until: <interval>)` * Implement `queue_as`, docs * Rollback implementing `perform_later`, it's a footgun * changes | 28 September 2021, 18:24:17 UTC |
| 051555e | Michael Hauser-Raspe | 27 September 2021, 15:43:15 UTC | Preserve behaviour of fetch_stats! returning stats. (#5001) | 27 September 2021, 15:43:15 UTC |
| e9d16db | Cameron McCord | 21 September 2021, 00:56:07 UTC | updated Sidekiq::Client.push_bulk to support ActiveSupport::Duration in the at argument (#4996) | 21 September 2021, 00:56:07 UTC |
| a3b4faf | Mike Perham | 13 September 2021, 16:33:57 UTC | polish #4991 | 13 September 2021, 16:33:57 UTC |
| 582b57a | John Bachir | 13 September 2021, 16:30:05 UTC | coexist with other signal handlers (#4991) * coexist with other signal handlers * don't allow error from old handler to disrupt sidekiq signal handling * changelog | 13 September 2021, 16:30:05 UTC |
| ab90830 | Mike Perham | 08 September 2021, 22:44:54 UTC | bump | 08 September 2021, 22:44:54 UTC |
| 86493a0 | Mike Perham | 08 September 2021, 22:42:22 UTC | Pull in Sidekiq::Job by default | 08 September 2021, 22:42:22 UTC |
| d5c2bf8 | Mike Perham | 08 September 2021, 22:30:40 UTC | latest changes | 08 September 2021, 22:30:40 UTC |
| 23d4d16 | Mike Perham | 08 September 2021, 22:30:32 UTC | bump | 08 September 2021, 22:30:32 UTC |
| 9c46df0 | Mike Perham | 08 September 2021, 22:24:41 UTC | Helper middleware to preserve implicit context? (#4982) * Add support for round-tripping AS::CurrentAttributes * Add tests | 08 September 2021, 22:24:41 UTC |
| 237c70f | Franz Liedke | 07 September 2021, 22:04:01 UTC | Reconnect on "UNBLOCKED force unblock" errors (#4985) These errors can occur during Sidekiq's long-running job fetching command. This uses Redis' blocking BRPOP primitive. On failover in a cluster setup, these commands are interrupted by the server. This error causes the worker threads to be restarted, but as they are bubbled up to the top, they cause a lot of spam in our error logging systems. As related errors from other commands are being handled (see | 07 September 2021, 22:04:01 UTC |
| 0bdec6f | Teo Ljungberg | 01 September 2021, 18:07:19 UTC | Fix faulty environment variable value (#4981) | 01 September 2021, 18:07:19 UTC |
| 1daed42 | Teo Ljungberg | 01 September 2021, 14:04:09 UTC | Disable new minitest parallelism (#4980) | 01 September 2021, 14:04:09 UTC |
| bed54b4 | Mike Perham | 31 August 2021, 14:46:58 UTC | 5.2.4 | 31 August 2021, 15:38:46 UTC |
| 60000cb | Mike Perham | 27 August 2021, 18:20:01 UTC | #4975 | 31 August 2021, 15:38:46 UTC |
| 84dd20d | Stephen Humphries | 30 August 2021, 19:31:41 UTC | Persist live poll status in browser localStorage (#4976) * Persist live poll status in browser localStorage * Prefix localStorage variables with 'sidekiq' * Minor fix for default handling in localStorage timeInterval parsing | 30 August 2021, 19:31:41 UTC |
| 8e36432 | Mike Perham | 20 August 2021, 18:06:00 UTC | Add optional Sidekiq::Job alias, see #4955 | 20 August 2021, 18:06:00 UTC |
| f1b24da | Mike Perham | 19 August 2021, 20:07:47 UTC | Rename `Sidekiq::Job`, reserve for future use | 20 August 2021, 17:43:55 UTC |
| 69b2aec | Matt Duszynski | 19 August 2021, 17:52:24 UTC | Use TIMEOUT constant instead of hardcoded 2 second sleep (#4952) * Use TIMEOUT constant instead of hardcoded 2 second sleep * Add a test | 19 August 2021, 17:52:24 UTC |
| d69e3c6 | Mike Perham | 19 August 2021, 17:51:42 UTC | Bump, prepare for release | 19 August 2021, 17:51:42 UTC |
| 13e2b56 | Shaun Bennett | 14 August 2021, 16:46:15 UTC | Add private to Sidekiq Web UI Cache-Control to prevent request collapsing (#4967) | 14 August 2021, 16:46:15 UTC |
| 20f4bab | Shaun Bennett | 14 August 2021, 16:12:04 UTC | Use no-store for web UI to prevent intermediate caching (#4966) | 14 August 2021, 16:12:04 UTC |
| 3575ccb | Mike Perham | 09 August 2021, 17:48:16 UTC | Reduce retry jitter, add jitter to `sidekiq_retry_in`, closes #4957 | 09 August 2021, 17:48:16 UTC |
| e8df351 | Mohamad Alhaj Rahmoun | 17 July 2021, 23:42:33 UTC | Add missing Arabic translations (#4945) | 17 July 2021, 23:42:33 UTC |
| 9a44071 | Narath Carlile | 08 July 2021, 14:44:43 UTC | Update Sidekiq.service as a user service (#4938) You recommend the use of capistrano-sidekiq. This uses a user service (which is likely a good idea for most users from a security perspective). In order to get it to work, changes need to be made to the Sidekiq.service file (and location) | 08 July 2021, 14:44:43 UTC |
