Skip to main content

Browse the archive

https://github.com/mperham/sidekiq
05 April 2024, 20:48:44 UTC
sort by:
Revision Author Date Message Commit Date
2f1fd1e Mike Perham 22 August 2022, 17:23:20 UTC changes, release 22 August 2022, 17:23:20 UTC
ed612aa Thodoris Kalatzis 17 August 2022, 21:35:21 UTC Sync & Improve greek translations (#5474) 17 August 2022, 21:35:21 UTC
81eb606 Mike Perham 17 August 2022, 17:59:18 UTC tweak 17 August 2022, 17:59:18 UTC
6491c56 Mike Perham 17 August 2022, 17:15:45 UTC fix missing rfc3339 method 17 August 2022, 17:15:45 UTC
f625d8e Mike Perham 17 August 2022, 17:09:47 UTC remove unused code 17 August 2022, 17:09:47 UTC
0b3751b Adam McCrea 16 August 2022, 17:56:36 UTC Histogram chart for job-specific metrics (#5473) * Refactor job query * First attempt at a histogram chart * Explore a box plot chart * Show 3 chart variations * Outline boxes instead of solid boxes * Remove box plot chart * Use linear y-axis This matches the axis for the metrics overview page, and it clarifies the data. * Data tables for job metrics * Add histogram totals chart * Move things around * Tooltip for histogram chart * Fix deploy tooltip * Extract marks query * Extract chart base class * Renaming * Ensure a min radius for histogram bubbles High job counts can result in a very small multiplier, which was making some of the bubbles too small to be visible. * Round everything to two decimals for consistency * styling for metrics headers * Show emdash when timing info is n/a * No job results found message * No need for metrics header 16 August 2022, 17:56:36 UTC
ff7e419 Adam McCrea 13 August 2022, 16:45:56 UTC Improve chart colors for dark mode (#5475) 13 August 2022, 16:45:56 UTC
a2708ea Mike Perham 12 August 2022, 18:09:22 UTC bump 12 August 2022, 18:09:22 UTC
6f34717 Adam McCrea 12 August 2022, 16:53:00 UTC [WIP] Improve metrics UI with charts (#5467) * Add multi-line chart for total execution time by job * Fiddling with the UX * Refactor metrics `top_jobs` query * debugging * revert debugging * revert debugging * Add failed and avg time, just one data table * Add color swatch in data table * Measure in seconds * Fix duplicate color * standard style * Rename for clarity * Bring back empty metrics test * Execution time is not consistent, assert processed counts instead * Only include top 5 in chart, change swatch element to checkbox * Wire up the checkboxes to show/hide each job class on the chart * The checkboxes should not appear disabled * Ensure seconds for y-axis to match table and UX improvements - All data shown on metrics page is now in seconds - Tooltip now includes "UTC" with the time - Tooltip rounds the number of seconds and includes "seconds" * Show deploy marks in metrics chart * Fix annotation position when updating datasets * Remove deploy labels on chart We shouldn't assume the first word of the label is the git SHA, and the label annotations were hacky anyway. * tweaks Co-authored-by: Mike Perham <mperham@gmail.com> 12 August 2022, 16:53:00 UTC
6b627f6 Mike Perham 11 August 2022, 20:56:03 UTC rack 11 August 2022, 20:56:03 UTC
f97d16a Mike Perham 11 August 2022, 14:22:29 UTC Rack 2/3 compat: header keys must be lower-case 11 August 2022, 14:22:29 UTC
9d5a6d7 Mike Perham 10 August 2022, 20:40:25 UTC require sidekiq/component, fixes #5462 10 August 2022, 20:40:25 UTC
7003aeb Mike Perham 05 August 2022, 19:11:16 UTC change 05 August 2022, 19:11:16 UTC
acdaa85 Mike Perham 05 August 2022, 18:29:37 UTC rejigger logic for ruby 2.5 05 August 2022, 18:29:37 UTC
c763b42 Mike Perham 05 August 2022, 18:21:37 UTC See if ruby 2.5 works in github 05 August 2022, 18:21:37 UTC
e464c09 Mike Perham 05 August 2022, 17:54:54 UTC Remove another usage of API within server code 05 August 2022, 17:54:54 UTC
77fc95a Mike Perham 05 August 2022, 17:50:01 UTC Remove unnecessary code, bump 05 August 2022, 17:50:01 UTC
345ba00 Mike Perham 05 August 2022, 15:41:16 UTC Sidekiq server should never require sidekiq/api 05 August 2022, 15:41:16 UTC
c61f21f Mike Perham 04 August 2022, 23:17:47 UTC Fix api 04 August 2022, 23:17:47 UTC
0d5cc88 Mike Perham 04 August 2022, 22:11:56 UTC oops 04 August 2022, 22:11:56 UTC
44c2e7a Mike Perham 04 August 2022, 22:09:53 UTC Dont require any metrics code without opt-in, fixes #5456 04 August 2022, 22:09:53 UTC
e320961 Mike Perham 04 August 2022, 20:21:59 UTC ready for release 04 August 2022, 20:21:59 UTC
25754d1 Mike Perham 02 August 2022, 15:19:23 UTC 5.5.2 02 August 2022, 15:19:23 UTC
6ab5810 Mike Perham 01 August 2022, 15:16:49 UTC re-enable current attributes 01 August 2022, 15:16:49 UTC
dcdfde8 Mike Perham 29 July 2022, 21:25:03 UTC minor fixes 29 July 2022, 21:25:03 UTC
c74cf00 Mike Perham 29 July 2022, 20:34:58 UTC Use dig to help with incomplete data 29 July 2022, 20:34:58 UTC
7edf82f Mike Perham 29 July 2022, 15:19:47 UTC safe_load our language files 29 July 2022, 15:19:47 UTC
f6e552d Mike Perham 29 July 2022, 15:04:52 UTC changes 29 July 2022, 15:04:52 UTC
c8a4b83 Mike Perham 28 July 2022, 22:54:56 UTC Optimization: do not create cattr unless it has contents 28 July 2022, 22:54:56 UTC
f220897 Mike Perham 28 July 2022, 19:21:42 UTC Per-job execution metrics (#5384) * New execution stats data format, #5283 We store time and counts per-queue, per-class and totals, daily. * break metrics into separate jobs and queues hashes * tweak * Move metrics tracking to middleware, start work on Query API * Add support for labeled points in time * Add fetch method for deploy marks * rejigger metrics file layout * fix tests * Remove per-queue metrics, adds a lot of complexity with little value IMO * store per-minute histograms * Keep basic stats hardwired as is The idea being that metrics are optional middleware as they have significantly more overhead in CPU time and Redis space. * Implement top N metrics dashboard * Add topN and job-specific metric pages * Supply histogram data to job metrics page * cant use local time as CI is in a different tz * Add basic metrics graph, refactor dashboard JS to make Rickshaw reuseable * prepare for public beta 28 July 2022, 19:21:42 UTC
dcd6d32 Sam 19 July 2022, 21:11:06 UTC Create a timeout that happens before cleanup (#5438) * Create a timeout that happens before cleanup * Remove unnecessary code * Move a redis call into the method that is running redis: * Add timelock to beginning of cleanup 19 July 2022, 21:11:06 UTC
cc61161 Matthew Bender 14 July 2022, 23:12:55 UTC define DEFAULT_ERROR_HANDLER (#5395) - this will allow the default error handler to be easily removed if needed via `error_handlers.delete(DEFAULT_ERROR_HANDLER)` without having to depend on an internal implementation detail 14 July 2022, 23:12:55 UTC
6efebec Mike Perham 14 July 2022, 23:05:25 UTC fix broken tests 14 July 2022, 23:05:25 UTC
a80a6d0 Mike Perham 14 July 2022, 23:01:45 UTC latest changes 14 July 2022, 23:01:45 UTC
0676a52 Mike Perham 14 July 2022, 22:56:58 UTC Enable `sidekiq_retry_in` to signal :kill or :discard dynamically, fixes #5406 (#5432) 14 July 2022, 22:56:58 UTC
f9f976a Mike Perham 14 July 2022, 22:56:22 UTC remove jobstr from the exception context, it adds a lot of noise to the log output and is redundant with :job 14 July 2022, 22:56:22 UTC
b9d9bfe Kevin Bongart 14 July 2022, 19:46:52 UTC Sort processes in UI (#5398) * Sort processes in UI using natural sort order * Rename variable for consistency * Fix natural sort algorithm and add more test examples * Don't sort processes unless all process have a hostname * Object#present? is a Rails method, not a Ruby method * Flush Redis database before each helper test 14 July 2022, 19:46:52 UTC
638d075 Jon Frisby 13 July 2022, 20:24:00 UTC Fix broken hamburger toggle. (#5428) * Remove assumption of `_full` being a suffix on toggle target ID. * Correct ID of hamburger menu toggle target. 13 July 2022, 20:24:00 UTC
adb88a0 Mike Perham 12 July 2022, 21:25:52 UTC bump 12 July 2022, 21:25:52 UTC
4c52187 Mike Perham 12 July 2022, 21:25:16 UTC bump redis 12 July 2022, 21:25:16 UTC
1573d50 Mike Perham 12 July 2022, 21:18:17 UTC Require redis-rb 4.5.0, fixes #5394 12 July 2022, 21:18:17 UTC
b739940 Mike Perham 12 July 2022, 20:35:39 UTC formatting 12 July 2022, 20:35:39 UTC
db18d3c Sam 12 July 2022, 20:26:10 UTC Merge pull request #5388 from mperham/api_rdoc Better rdoc for public APIs 12 July 2022, 20:26:10 UTC
cdb1eac Mike Perham 12 July 2022, 20:23:35 UTC cleanup stats yard 12 July 2022, 20:23:35 UTC
ec589de Mike Perham 12 July 2022, 20:15:10 UTC better yard for middleware 12 July 2022, 20:15:10 UTC
43ff395 Takuya Kato 03 July 2022, 03:55:31 UTC fix typo (#5411) 03 July 2022, 03:55:31 UTC
1e7ace6 dependabot[bot] 21 June 2022, 04:29:08 UTC Bump actions/dependency-review-action from 1 to 2 (#5399) Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 1 to 2. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](https://github.com/actions/dependency-review-action/compare/v1...v2) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 21 June 2022, 04:29:08 UTC
64a1f8e SamArdrey 20 June 2022, 22:06:49 UTC Hide endpoints tagged as private from build 20 June 2022, 22:06:49 UTC
e830ecd Jason Lee 16 June 2022, 03:25:25 UTC Delete .DS_Store (#5392) 16 June 2022, 03:25:25 UTC
9d33caf Mike Perham 15 June 2022, 17:08:20 UTC comm notes 15 June 2022, 17:08:20 UTC
8559fc1 SamArdrey 15 June 2022, 17:06:37 UTC Get opts working: 15 June 2022, 17:06:37 UTC
f57c1a4 Mike Perham 15 June 2022, 17:05:14 UTC bump 15 June 2022, 17:05:14 UTC
8e3dd2e Mike Perham 15 June 2022, 17:02:49 UTC fix missing component usage 15 June 2022, 17:02:49 UTC
311bee5 Mike Perham 15 June 2022, 15:15:22 UTC polish 15 June 2022, 15:15:22 UTC
67283ce SamArdrey 15 June 2022, 00:26:58 UTC Add yarddoc files to gitignore, remove yardoc from rake tasks, update api file 15 June 2022, 00:26:58 UTC
2a24d54 SamArdrey 14 June 2022, 16:25:04 UTC Include changelog, comment out unnecessary code 14 June 2022, 16:25:04 UTC
272a1ba SamArdrey 14 June 2022, 16:22:08 UTC Redirect readme to menu.md 14 June 2022, 16:22:08 UTC
be7b305 SamArdrey 14 June 2022, 16:15:56 UTC Make sidekiq api module public, so the classes show up 14 June 2022, 16:15:56 UTC
dd1cf09 SamArdrey 14 June 2022, 16:11:20 UTC Add yardopts file 14 June 2022, 16:11:20 UTC
16b51f3 Mike Perham 13 June 2022, 22:22:26 UTC switch from rdoc to yard 13 June 2022, 22:22:26 UTC
4508477 Mike Perham 13 June 2022, 17:43:52 UTC more doc 13 June 2022, 17:43:52 UTC
9102c38 Mike Perham 13 June 2022, 17:03:12 UTC Better rdoc for public APIs 13 June 2022, 17:03:12 UTC
2b58b74 Jean byroot Boussier 13 June 2022, 13:27:57 UTC redis-client: Fix `ZADD` compatibility (#5387) 13 June 2022, 13:27:57 UTC
8269205 Mike Perham 10 June 2022, 18:35:59 UTC notes 10 June 2022, 18:35:59 UTC
4026085 Mike Perham 09 June 2022, 20:52:17 UTC standardize 09 June 2022, 20:52:17 UTC
87b2c47 Mike Perham 08 June 2022, 20:15:57 UTC Merge branch 'main' into SamArdrey-add_api_documentation 08 June 2022, 20:15:57 UTC
f8c7579 Mike Perham 08 June 2022, 20:02:24 UTC rdoc'ing 08 June 2022, 20:02:24 UTC
7f3f6ac Mike Perham 08 June 2022, 19:31:13 UTC note 08 June 2022, 19:31:25 UTC
2d5536c Mike Perham 07 June 2022, 16:49:24 UTC remove 7.0 doc ref 08 June 2022, 19:31:25 UTC
16debb0 Mike Perham 07 June 2022, 15:56:24 UTC notes 08 June 2022, 19:31:25 UTC
d985aa3 Mike Perham 06 June 2022, 19:07:51 UTC Adjust middleware, fixes #5371 Middleware now has access to the `config` object so we can provide local helper methods. 08 June 2022, 19:31:25 UTC
5ed5919 Mike Perham 08 June 2022, 19:31:13 UTC note 08 June 2022, 19:31:13 UTC
ab3c8ea SamArdrey 08 June 2022, 19:31:00 UTC remove DS Store 08 June 2022, 19:31:00 UTC
48d022e SamArdrey 08 June 2022, 19:29:23 UTC Add newline at end of file 08 June 2022, 19:29:23 UTC
dda6e2f SamArdrey 08 June 2022, 19:27:27 UTC Remove html files and add ds_store to gitignore 08 June 2022, 19:27:27 UTC
6eadad8 SamArdrey 08 June 2022, 19:26:06 UTC Add a bit of documentation, install yard 08 June 2022, 19:26:06 UTC
fb71eed Mike Perham 07 June 2022, 16:49:24 UTC remove 7.0 doc ref 07 June 2022, 16:49:24 UTC
9065016 Mike Perham 07 June 2022, 15:56:24 UTC notes 07 June 2022, 15:56:24 UTC
5698216 Mike Perham 06 June 2022, 19:07:51 UTC Adjust middleware, fixes #5371 Middleware now has access to the `config` object so we can provide local helper methods. 06 June 2022, 19:08:05 UTC
c76be23 Sam 05 June 2022, 16:21:58 UTC Update contributing doc (#5368) * Update contributing doc * Use better command 05 June 2022, 16:21:58 UTC
602a847 Mike Perham 05 June 2022, 14:52:11 UTC fix links 05 June 2022, 14:52:11 UTC
f17c30c Mike Perham 05 June 2022, 14:50:03 UTC docs 05 June 2022, 14:50:03 UTC
55ced28 Mike Perham 05 June 2022, 14:44:52 UTC Update standard rules (#5360) * update standard rules and run standard:fix * Fix more standard errors * standardize 05 June 2022, 14:44:52 UTC
2d743d7 dependabot[bot] 03 June 2022, 02:32:18 UTC Bump actions/checkout from 2 to 3 (#5366) Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 03 June 2022, 02:32:18 UTC
85a76cb Naveen 03 June 2022, 02:30:43 UTC chore: Included githubactions in the dependabot config (#5365) This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure. Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com> 03 June 2022, 02:30:43 UTC
7f47daa Naveen 03 June 2022, 02:28:25 UTC chore(deps): Included dependency review (#5364) > Dependency Review GitHub Action in your repository to enforce dependency > reviews on your pull requests. > The action scans for vulnerable versions of dependencies introduced by package version > changes in pull requests, > and warns you about the associated security vulnerabilities. > This gives you better visibility of what's changing in a pull request, > and helps prevent vulnerabilities being added to your repository. https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review#dependency-review-enforcement Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com> 03 June 2022, 02:28:25 UTC
0724848 Sam 02 June 2022, 17:31:42 UTC Update last of spec files to use it and describe, instead od minitest (#5357) 02 June 2022, 17:31:42 UTC
3ed9600 Naveen 02 June 2022, 15:24:59 UTC chore: Set permissions for GitHub actions (#5354) Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much. - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs [Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com> 02 June 2022, 15:24:59 UTC
2c5872f Mike Perham 02 June 2022, 14:44:15 UTC Add setters for upcoming Config move 02 June 2022, 14:44:15 UTC
277ea18 Mike Perham 31 May 2022, 20:41:37 UTC Fix #5336 31 May 2022, 20:41:37 UTC
67daa7a Mike Perham 31 May 2022, 20:37:31 UTC Prepare for upcoming Sidekiq::Config redesign (#5340) * Prepare for upcoming Sidekiq::Config redesign Adjust the server internals to use a config object rather than refering directly to the Sidekiq module. 31 May 2022, 20:37:31 UTC
eddc11b Dominik Sander 31 May 2022, 15:33:36 UTC Fix drain_all infinite loop after clearing worker with symbolized queue (#5352) `jobs_by_queue` saves the queue name of enqueued jobs as strings. When `clear` is called for a worker that has it's queue name defined as a symbol `clear` calls `Queues.clear_for` using a symbol. As a result `jobs_by_queue` is not cleared, while `jobs_by_class` is. Calling `drain_all` then runs into an infinite loop because of the mismatch of the two state hashes. 31 May 2022, 15:33:36 UTC
b201ce5 Adam Niedzielski 18 May 2022, 21:41:14 UTC Require TransactionAwareClient (#5335) 18 May 2022, 21:41:14 UTC
da9198a Mike Perham 17 May 2022, 19:58:50 UTC Fixed in Rails 6.0.5, #4216 17 May 2022, 19:58:50 UTC
f38cf30 Mike Perham 10 May 2022, 19:52:43 UTC Refactor redis client adapter to be standalone and remove unnecessary namespacing 10 May 2022, 19:52:43 UTC
aaac999 Jean byroot Boussier 10 May 2022, 19:25:04 UTC Add a compatibility layer for `redis-client` (#5298) * Add a compatibility layer for `redis-client` As discussed in https://github.com/mperham/sidekiq/pull/5253 Switching entirely to redis-client is deemed risky, so instead we can support both. All is needed is a small translation layer, and some very minimal adjustments in the callers. Co-authored-by: Jean Boussier <jean.boussier@gmail.com> Co-authored-by: Mike Perham <mperham@gmail.com> 10 May 2022, 19:25:04 UTC
f58cd04 Mike Perham 06 May 2022, 21:15:19 UTC wording 06 May 2022, 21:15:19 UTC
994a4fa Mike Perham 06 May 2022, 20:55:22 UTC wording 06 May 2022, 20:55:22 UTC
fdfb7a5 Mike Perham 06 May 2022, 20:52:38 UTC A bit more polish for the API, #5291 06 May 2022, 20:52:38 UTC
c03680f Adam Niedzielski 06 May 2022, 17:10:36 UTC Add transaction-aware client (#5291) * Add transaction-aware client * Trigger CI build 06 May 2022, 17:10:36 UTC
back to top