| 2a8c279 | Matt Caswell | 12 June 2015, 15:20:59 UTC | Prepare for 1.0.1o release Reviewed-by: Richard Levitte <levitte@openssl.org> | 12 June 2015, 15:20:59 UTC |
| 2ad310f | Matt Caswell | 12 June 2015, 14:56:51 UTC | Updated CHANGES and NEWS entries for new release Reviewed-by: Richard Levitte <levitte@openssl.org> | 12 June 2015, 15:02:04 UTC |
| 6cbc789 | Adam Langley | 12 June 2015, 07:05:49 UTC | Allow a zero length extension block It is valid for an extension block to be present in a ClientHello, but to be of zero length. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> | 12 June 2015, 14:45:17 UTC |
| fffcf87 | Matt Caswell | 12 June 2015, 12:08:04 UTC | Fix ABI break with HMAC Recent HMAC changes broke ABI compatibility due to a new field in HMAC_CTX. This backs that change out, and does it a different way. Thanks to Timo Teras for the concept. Conflicts: crypto/hmac/hmac.c Reviewed-by: Richard Levitte <levitte@openssl.org> | 12 June 2015, 13:43:23 UTC |
| 3adca97 | Matt Caswell | 11 June 2015, 14:08:34 UTC | Prepare for 1.0.1o-dev Reviewed-by: Stephen Henson <steve@openssl.org> | 11 June 2015, 14:08:34 UTC |
| 517899e | Matt Caswell | 11 June 2015, 14:05:11 UTC | Prepare for 1.0.1n release Reviewed-by: Stephen Henson <steve@openssl.org> | 11 June 2015, 14:05:11 UTC |
| f61bbf8 | Andy Polyakov | 10 June 2015, 22:18:01 UTC | bn/bn_gf2m.c: avoid infinite loop wich malformed ECParamters. CVE-2015-1788 Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 4924b37ee01f71ae19c94a8934b80eeb2f677932) | 11 June 2015, 14:02:21 UTC |
| 1f31458 | Matt Caswell | 10 June 2015, 10:49:31 UTC | Update CHANGES and NEWS Updates to CHANGES and NEWS to take account of the latest security fixes. Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 June 2015, 14:02:21 UTC |
| 5fbc59c | Emilia Kasper | 12 May 2015, 17:00:30 UTC | PKCS#7: Fix NULL dereference with missing EncryptedContent. CVE-2015-1790 Reviewed-by: Rich Salz <rsalz@openssl.org> | 11 June 2015, 14:02:21 UTC |
| 370ac32 | Emilia Kasper | 08 April 2015, 14:56:43 UTC | Fix length checks in X509_cmp_time to avoid out-of-bounds reads. Also tighten X509_cmp_time to reject more than three fractional seconds in the time; and to reject trailing garbage after the offset. CVE-2015-1789 Reviewed-by: Viktor Dukhovni <viktor@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> | 11 June 2015, 14:02:21 UTC |
| dd90a91 | Dr. Stephen Henson | 05 June 2015, 11:11:25 UTC | Fix infinite loop in CMS Fix loop in do_free_upto if cmsbio is NULL: this will happen when attempting to verify and a digest is not recognised. Reported by Johannes Bauer. CVE-2015-1792 Reviewed-by: Matt Caswell <matt@openssl.org> | 11 June 2015, 14:02:21 UTC |
| 176b59d | Richard Levitte | 11 June 2015, 13:41:25 UTC | Correction of make depend merge error $(PROGS) was mistakenly removed, adding it back. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 5ef5b9ffa91ad6061c42291564a1dc786300ebdd) | 11 June 2015, 13:52:29 UTC |
| 907f04a | Matt Caswell | 11 June 2015, 00:30:06 UTC | More ssl_session_dup fixes Fix error handling in ssl_session_dup, as well as incorrect setting up of the session ticket. Follow on from CVE-2015-1791. Thanks to LibreSSL project for reporting these issues. Conflicts: ssl/ssl_sess.c Reviewed-by: Tim Hudson <tjh@openssl.org> | 11 June 2015, 09:08:18 UTC |
| f3b355f | Kurt Roeckx | 18 April 2015, 17:15:48 UTC | Only allow a temporary rsa key exchange when they key is larger than 512. Reviewed-by: Rich Salz <rsalz@openssl.org> MR #838 (cherry picked from commit 57e477b9ec66542afc8c9c13ae7c4271209fb88f) | 10 June 2015, 22:10:24 UTC |
| c4ce107 | Kurt Roeckx | 06 June 2015, 11:42:34 UTC | Properly check certificate in case of export ciphers. Reviewed-by: Rich Salz <rsalz@openssl.org> MR #838 (cherry picked from commit 39a298a1c0e7a76e301b9f2ebe8d33d90ad0a3b4) | 10 June 2015, 22:10:02 UTC |
| d46de4c | Matt Caswell | 01 June 2015, 16:25:29 UTC | DTLS handshake message fragments musn't span packets It should not be possible for DTLS message fragments to span multiple packets. However previously if the message header fitted exactly into one packet, and the fragment body was in the next packet then this would work. Obviously this would fail if packets get re-ordered mid-flight. Reviewed-by: Tim Hudson <tjh@openssl.org> | 10 June 2015, 11:12:57 UTC |
| 418df5e | Matt Caswell | 08 June 2015, 08:29:56 UTC | Fix leak in HMAC error path In the event of an error in the HMAC function, leaks can occur because the HMAC_CTX does not get cleaned up. Thanks to the BoringSSL project for reporting this issue. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit e43a13c807e42688c72c4f3d001112bf0a110464) | 10 June 2015, 10:08:51 UTC |
| d163a2c | Matt Caswell | 04 June 2015, 13:22:00 UTC | EC_POINT_is_on_curve does not return a boolean The function EC_POINT_is_on_curve does not return a boolean value. It returns 1 if the point is on the curve, 0 if it is not, and -1 on error. Many usages within OpenSSL were incorrectly using this function and therefore not correctly handling error conditions. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by: Kurt Roeckx <kurt@openssl.org> (cherry picked from commit 68886be7e2cd395a759fcd41d2cede461b68843d) | 10 June 2015, 09:51:17 UTC |
| 72df35a | Matt Caswell | 30 April 2015, 14:20:25 UTC | Tighten extension handling This adds additional checks to the processing of extensions in a ClientHello to ensure that either no extensions are present, or if they are then they take up the exact amount of space expected. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by: Stephen Henson <steve@openssl.org> Conflicts: ssl/t1_lib.c | 10 June 2015, 09:32:05 UTC |
| f92b196 | Matt Caswell | 30 April 2015, 13:51:10 UTC | Fix memory leaks in BIO_dup_chain() This fixes a memory leak that can occur whilst duplicating a BIO chain if the call to CRYPTO_dup_ex_data() fails. It also fixes a second memory leak where if a failure occurs after successfully creating the first BIO in the chain, then the beginning of the new chain was not freed. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by: Stephen Henson <steve@openssl.org> Conflicts: crypto/bio/bio_lib.c | 10 June 2015, 09:29:31 UTC |
| e94118a | Matt Caswell | 30 April 2015, 13:04:30 UTC | Replace memset with OPENSSL_cleanse() BUF_MEM_free() attempts to cleanse memory using memset immediately prior to a free. This is at risk of being optimised away by the compiler, so replace with a call to OPENSSL_cleanse() instead. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by: Stephen Henson <steve@openssl.org> | 10 June 2015, 09:29:31 UTC |
| 106a9a5 | Matt Caswell | 10 June 2015, 08:32:34 UTC | Fix Kerberos issue in ssl_session_dup The fix for CVE-2015-1791 introduced an error in ssl_session_dup for Kerberos. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit dcad51bc13c9b716d9a66248bcc4038c071ff158) | 10 June 2015, 09:02:16 UTC |
| cb972a4 | Richard Levitte | 09 June 2015, 21:06:23 UTC | When making libcrypto from apps or test, make sure to include engines For librypto to be complete, the stuff in both crypto/ and engines/ have to be built. Doing 'make test' or 'make apps' from a clean source tree failed to do so. Corrected by using the new 'build_libcrypto' in the top Makefile. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit acaff3b797f50a0a0e17a0be45b7fafad962004e) | 10 June 2015, 00:12:34 UTC |
| ee2d14b | Richard Levitte | 09 June 2015, 23:34:26 UTC | Add and rearrange building of libraries There's a need for a target that will build all of libcrypto, so let's add 'build_libcrypto' that does this. For ortogonality, let's also add 'build_libssl'. Have both also depend on 'libcrypto.pc' and 'libssl.pc' so those get built together with the libraries. This makes 'all' depend on fewer things directly. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 177b5f9c82e1152d6ce20a83556db629697fff65) Conflicts: Makefile.org | 10 June 2015, 00:12:25 UTC |
| 3d2c3fa | Dr. Stephen Henson | 08 June 2015, 12:23:00 UTC | return correct NID for undefined object Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 0fb9990480919163cc375a2b6c0df1d8d901a77b) | 08 June 2015, 20:47:05 UTC |
| ba56936 | Emilia Kasper | 08 June 2015, 13:04:28 UTC | Use CRYPTO_memcmp in s3_cbc.c Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 05627d57e55517eae21c251fe287760bd1137218) | 08 June 2015, 13:05:08 UTC |
| 59b5ab4 | Emilia Kasper | 27 May 2015, 15:12:13 UTC | Use CRYPTO_memcmp when comparing authenticators Pointed out by Victor Vasiliev (vasilvv@mit.edu) via Adam Langley (Google). Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 1e4a355dcabe2f75df5bb8b41b394d37037169d2) (cherry picked from commit ac32a77cd69784568090e934a31622ddfee49ca7) | 08 June 2015, 13:01:47 UTC |
| c22ed55 | Matt Caswell | 04 June 2015, 10:18:55 UTC | Remove misleading comment Remove a comment that suggested further clean up was required. DH_free() performs the necessary cleanup. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit f3d889523ee84f1e87e4da0d59e2702a4bee7907) | 04 June 2015, 11:56:13 UTC |
| 4b6f33a | Matt Caswell | 04 June 2015, 10:16:16 UTC | Clean premaster_secret for GOST Ensure OPENSSL_cleanse() is called on the premaster secret value calculated for GOST. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit b7ee4815f2452c854cc859e8dda88f2673cdddea) Conflicts: ssl/s3_srvr.c | 04 June 2015, 11:56:13 UTC |
| c36d384 | Matt Caswell | 04 June 2015, 10:41:30 UTC | Clean Kerberos pre-master secret Ensure the Kerberos pre-master secret has OPENSSL_cleanse called on it. With thanks to the Open Crypto Audit Project for reporting this issue. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 4e3dbe37ca39fa68b6949fbde62f3ec0f0584f7e) | 04 June 2015, 11:42:51 UTC |
| 05bdebb | Matt Caswell | 19 May 2015, 12:59:47 UTC | Fix off-by-one error in BN_bn2hex A BIGNUM can have the value of -0. The function BN_bn2hex fails to account for this and can allocate a buffer one byte too short in the event of -0 being used, leading to a one byte buffer overrun. All usage within the OpenSSL library is considered safe. Any security risk is considered negligible. With thanks to Mateusz Kocielski (LogicalTrust), Marek Kroemeke and Filip Palian for discovering and reporting this issue. Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit c56353071d9849220714d8a556806703771b9269) Conflicts: crypto/bn/bn_print.c | 04 June 2015, 08:29:13 UTC |
| 32b2ad7 | Annie Yousar | 03 May 2015, 13:05:47 UTC | RT3230: Better test for C identifier objects.pl only looked for a space to see if the name could be used as a C identifier. Improve the test to match the real C rules. Signed-off-by: Rich Salz <rsalz@akamai.com> Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 591b7aef05b22cba09b179e5787a9bf40dfc9508) | 02 June 2015, 21:17:54 UTC |
| 1977240 | Richard Levitte | 31 May 2015, 15:47:31 UTC | Add the macro OPENSSL_SYS_WIN64 This is for consistency. Additionally, have its presence define OPENSSL_SYS_WINDOWS as well. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 3f131556d6678bc3754f1e6d98a9a5bfc24e368c) Conflicts: e_os2.h | 02 June 2015, 16:05:31 UTC |
| 939b496 | Matt Caswell | 18 May 2015, 15:27:48 UTC | Fix race condition in NewSessionTicket If a NewSessionTicket is received by a multi-threaded client when attempting to reuse a previous ticket then a race condition can occur potentially leading to a double free of the ticket data. CVE-2015-1791 This also fixes RT#3808 where a session ID is changed for a session already in the client session cache. Since the session ID is the key to the cache this breaks the cache access. Parts of this patch were inspired by this Akamai change: https://github.com/akamai/openssl/commit/c0bf69a791239ceec64509f9f19fcafb2461b0d3 Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 27c76b9b8010b536687318739c6f631ce4194688) Conflicts: ssl/ssl.h ssl/ssl_err.c | 02 June 2015, 11:44:40 UTC |
| cce3e4a | Matt Caswell | 09 March 2015, 16:09:04 UTC | Clear state in DTLSv1_listen This is a backport of commit e83ee04bb7de800cdb71d522fa562e99328003a3 from the master branch (and this has also been applied to 1.0.2). In 1.0.2 this was CVE-2015-0207. For other branches there is no known security issue, but this is being backported as a precautionary measure. The DTLSv1_listen function is intended to be stateless and processes the initial ClientHello from many peers. It is common for user code to loop over the call to DTLSv1_listen until a valid ClientHello is received with an associated cookie. A defect in the implementation of DTLSv1_listen means that state is preserved in the SSL object from one invokation to the next. Reviewed-by: Richard Levitte <levitte@openssl.org> | 02 June 2015, 08:12:39 UTC |
| f3e85f4 | Matt Caswell | 29 May 2015, 16:05:01 UTC | Check the message type requested is the type received in DTLS dtls1_get_message has an |mt| variable which is the type of the message that is being requested. If it is negative then any message type is allowed. However the value of |mt| is not checked in one of the main code paths, so a peer can send a message of a completely different type and it will be processed as if it was the message type that we were expecting. This has very little practical consequences because the current behaviour will still fail when the format of the message isn't as expected. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 8c2b1d872b25f3ec78e04f5cd2de8f21e853c4a6) | 31 May 2015, 23:33:22 UTC |
| cc74177 | Dr. Stephen Henson | 28 May 2015, 14:44:20 UTC | check for error when creating PKCS#8 structure Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 2849707fa65d2803e6d1c1603fdd3fd1fdc4c6cc) | 28 May 2015, 17:02:19 UTC |
| e2cf18c | Dr. Stephen Henson | 28 May 2015, 14:45:57 UTC | PEM doc fixes Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit f097f81c891bb1f479426d8ac9c9541390334983) | 28 May 2015, 17:02:19 UTC |
| df00b6e | Andy Polyakov | 26 May 2015, 08:36:56 UTC | Housekeeping 'make TABLE' update. Reviewed-by: Matt Caswell <matt@openssl.org> | 26 May 2015, 19:55:57 UTC |
| 1ee85aa | Emilia Kasper | 22 May 2015, 16:35:50 UTC | Fix ssltest to use 1024-bit DHE parameters Also add more ciphersuite test coverage, and a negative test for 512-bit DHE. Reviewed-by: Rich Salz <rsalz@openssl.org> | 26 May 2015, 10:41:51 UTC |
| 029e8f3 | Matt Caswell | 25 May 2015, 23:05:28 UTC | Don't check for a negative SRP extension size The size of the SRP extension can never be negative (the variable |size| is unsigned). Therefore don't check if it is less than zero. RT#3862 Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 9c89d290834f3ed9146eeb8b64fe5de817679a0b) | 26 May 2015, 09:42:10 UTC |
| 28ea6ad | Matt Caswell | 25 May 2015, 23:02:57 UTC | Fix error check in GOST engine The return value of i2d functions can be negative if an error occurs. Therefore don't assign the return value to an unsigned type and *then* check if it is negative. RT#3862 Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 90e7cdff3aa66779486914f88333f6601f0c1cf4) | 26 May 2015, 09:42:10 UTC |
| 4ae1c77 | Matt Caswell | 25 May 2015, 22:57:41 UTC | Handle unsigned struct timeval members The members of struct timeval on OpenVMS are unsigned. The logic for calculating timeouts needs adjusting to deal with this. RT#3862 Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit fc52ac9028b9492fb086ba35a3352ea46e03ecfc) | 26 May 2015, 09:42:10 UTC |
| dbcf8e3 | Andy Polyakov | 26 May 2015, 07:47:16 UTC | Configure: replace -mv8 with -mcpu=v8 in SPARC config lines. RT#3860 Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit aa1e42215b6729c0143fb056e3791e3fcdf7af6a) | 26 May 2015, 08:24:20 UTC |
| 5fcfef4 | Billy Brumley | 22 May 2015, 14:44:49 UTC | fix copy paste error in ec_GF2m function prototypes RT#3858 Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 71f6130b7a96bacbffae4611796ed98c2f724d96) | 26 May 2015, 08:14:56 UTC |
| 8af1319 | Andy Polyakov | 25 May 2015, 08:17:14 UTC | bn/bn_lcl.h: fix MIPS-specific gcc version check. RT#3859 Reviewed-by: Tim Hudson <tjh@openssl.org> (cherry picked from commit 60c268b21ac81cc6b1af5c5470282a613b96f6fd) | 26 May 2015, 08:08:44 UTC |
| 38b7073 | Andy Polyakov | 24 May 2015, 20:51:12 UTC | md32_common.h: backport ICC fix. RT#3843 Reviewed-by: Matt Caswell <matt@openssl.org> | 26 May 2015, 07:58:12 UTC |
| 75077a2 | Matt Caswell | 23 May 2015, 20:51:21 UTC | Don't send an alert if we've just received one If the record received is for a version that we don't support, previously we were sending an alert back. However if the incoming record already looks like an alert then probably we shouldn't do that. So suppress an outgoing alert if it looks like we've got one incoming. Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 25 May 2015, 22:11:02 UTC |
| c62592e | Richard Levitte | 23 May 2015, 04:33:41 UTC | Fix update and depend in engines/ The update: target in engines/ didn't recurse into engines/ccgost. The update: and depend: targets in engines/ccgost needed a fixup. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 8b822d2566853ee5e313c37529f71336209b28ab) | 23 May 2015, 09:22:10 UTC |
| f460f05 | Richard Levitte | 22 May 2015, 17:23:43 UTC | Missed a couple of spots in the update change Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 6f45032f6730622e8d484d92e07c7fce7d1f88ac) Conflicts: apps/Makefile | 23 May 2015, 09:22:10 UTC |
| eb797fd | Richard Levitte | 22 May 2015, 15:54:06 UTC | Fix the update target and remove duplicate file updates We had updates of certain header files in both Makefile.org and the Makefile in the directory the header file lived in. This is error prone and also sometimes generates slightly different results (usually just a comment that differs) depending on which way the update was done. This removes the file update targets from the top level Makefile, adds an update: target in all Makefiles and has it depend on the depend: or local_depend: targets, whichever is appropriate, so we don't get a double run through the whole file tree. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 0f539dc1a2f45580435c39dada44dd276e79cb88) Conflicts: Makefile.org apps/Makefile test/Makefile | 23 May 2015, 09:22:10 UTC |
| b484b04 | Matt Caswell | 19 May 2015, 15:03:02 UTC | Fix off-by-one in BN_rand If BN_rand is called with |bits| set to 1 and |top| set to 1 then a 1 byte buffer overflow can occur. There are no such instances within the OpenSSL at the moment. Thanks to Mateusz Kocielski (LogicalTrust), Marek Kroemeke, Filip Palian for discovering and reporting this issue. Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 22 May 2015, 22:45:33 UTC |
| 726b5e7 | Matt Caswell | 19 May 2015, 14:19:30 UTC | Reject negative shifts for BN_rshift and BN_lshift The functions BN_rshift and BN_lshift shift their arguments to the right or left by a specified number of bits. Unpredicatable results (including crashes) can occur if a negative number is supplied for the shift value. Thanks to Mateusz Kocielski (LogicalTrust), Marek Kroemeke and Filip Palian for discovering and reporting this issue. Reviewed-by: Kurt Roeckx <kurt@openssl.org> (cherry picked from commit 7cc18d8158b5fc2676393d99b51c30c135502107) Conflicts: crypto/bn/bn.h crypto/bn/bn_err.c | 22 May 2015, 22:21:55 UTC |
| 0a9f8e0 | Lubom | 07 May 2015, 13:20:31 UTC | Lost alert in DTLS If a client receives a bad hello request in DTLS then the alert is not sent correctly. RT#2801 Signed-off-by: Matt Caswell <matt@openssl.org> Reviewed-by: Kurt Roeckx <kurt@openssl.org> (cherry picked from commit 4dc1aa0436fdb8af50960db676b739c8ef81f38c) | 22 May 2015, 09:24:49 UTC |
| 1c687ff | Matt Caswell | 27 January 2015, 11:15:15 UTC | Add documentation for the -no_alt_chains option for various apps, as well as the X509_V_FLAG_NO_ALT_CHAINS flag. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Conflicts: doc/apps/cms.pod doc/apps/ocsp.pod doc/apps/s_client.pod doc/apps/s_server.pod doc/apps/smime.pod doc/apps/verify.pod | 20 May 2015, 21:14:25 UTC |
| c6a3904 | Matt Caswell | 27 January 2015, 10:50:38 UTC | Add -no_alt_chains option to apps to implement the new X509_V_FLAG_NO_ALT_CHAINS flag. Using this option means that when building certificate chains, the first chain found will be the one used. Without this flag, if the first chain found is not trusted then we will keep looking to see if we can build an alternative chain instead. Reviewed-by: Dr. Stephen Henson <steve@openssl.org> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Conflicts: apps/cms.c apps/ocsp.c apps/s_client.c apps/s_server.c apps/smime.c apps/verify.c | 20 May 2015, 21:14:25 UTC |
| cf1bf3f | Matt Caswell | 27 January 2015, 10:35:27 UTC | Add flag to inhibit checking for alternate certificate chains. Setting this behaviour will force behaviour as per previous versions of OpenSSL Reviewed-by: Dr. Stephen Henson <steve@openssl.org> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> | 20 May 2015, 21:14:24 UTC |
| f7bf8e0 | Matt Caswell | 27 January 2015, 10:03:29 UTC | In certain situations the server provided certificate chain may no longer be valid. However the issuer of the leaf, or some intermediate cert is in fact in the trust store. When building a trust chain if the first attempt fails, then try to see if alternate chains could be constructed that are trusted. RT3637 RT3621 Reviewed-by: Kurt Roeckx <kurt@roeckx.be> | 20 May 2015, 21:14:24 UTC |
| 3b509e8 | Kurt Roeckx | 18 April 2015, 10:50:25 UTC | Correctly check for export size limit 40 bit ciphers are limited to 512 bit RSA, 56 bit ciphers to 1024 bit. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit ac38115c1a4fb61c66c2a8cd2a9800751828d328) | 20 May 2015, 20:23:28 UTC |
| 6383038 | Emilia Kasper | 19 May 2015, 10:05:22 UTC | client: reject handshakes with DH parameters < 768 bits. Since the client has no way of communicating her supported parameter range to the server, connections to servers that choose weak DH will simply fail. Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 20 May 2015, 13:01:36 UTC |
| ff4de7d | Emilia Kasper | 12 May 2015, 14:10:05 UTC | Update documentation with Diffie-Hellman best practices. - Do not advise generation of DH parameters with dsaparam to save computation time. - Promote use of custom parameters more, and explicitly forbid use of built-in parameters weaker than 2048 bits. - Advise the callback to ignore <keylength> - it is currently called with 1024 bits, but this value can and should be safely ignored by servers. Reviewed-by: Rich Salz <rsalz@openssl.org> | 20 May 2015, 13:01:36 UTC |
| 3372aee | Emilia Kasper | 13 May 2015, 10:05:41 UTC | dhparam: fix documentation The default bitlength is now 2048. Also clarify that either the number of bits or the generator must be present: $ openssl dhparam -2 and $ openssl dhparam 2048 generate parameters but $ openssl dhparam does not. Reviewed-by: Matt Caswell <matt@openssl.org> | 20 May 2015, 13:01:36 UTC |
| 8568170 | Emilia Kasper | 13 May 2015, 09:57:55 UTC | dhparam: set the default to 2048 bits Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Kurt Roeckx <kurt@openssl.org> | 20 May 2015, 13:01:36 UTC |
| f161274 | Emilia Kasper | 12 May 2015, 18:15:46 UTC | s_server: Use 2048-bit DH parameters by default. Reviewed-by: Rich Salz <rsalz@openssl.org> | 20 May 2015, 13:01:36 UTC |
| 5a1f055 | StudioEtrange | 20 May 2015, 08:35:39 UTC | GitHub284: Fix typo in xx-32.pl scripts. Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> | 20 May 2015, 08:35:39 UTC |
| e96de98 | Robert Swiecki | 18 May 2015, 23:08:02 UTC | Don't add write errors into bytecounts Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 00d565cfbe90fab3b157e644caca4eb4a2ebec79) | 19 May 2015, 11:20:38 UTC |
| 2df0ba9 | Andy Polyakov | 15 July 2012, 13:40:04 UTC | mk1mf.pl: replace chop for windows. Backport old patch to make it work in mixture of perls for Windows. Reviewed-by: Richard Levitte <levitte@openssl.org> Cherry-picked from 7bb98eee3c9e4694dfc2217001d5075ce8d2906e (cherry picked from commit 051b41df4105355a5a9c7f1c0bd00cc70b2d324c) | 15 May 2015, 18:19:29 UTC |
| 76b49a8 | Rich Salz | 12 May 2015, 15:49:32 UTC | Add NULL checks from master The big "don't check for NULL" cleanup requires backporting some of the lowest-level functions to actually do nothing if NULL is given. This will make it easier to backport fixes to release branches, where master assumes those lower-level functions are "safe" This commit addresses those tickets: 3798 3799 3801. Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit f34b095fab1569d093b639bfcc9a77d6020148ff) | 13 May 2015, 16:55:23 UTC |
| 5e0ec90 | Hanno Böck | 11 May 2015, 10:33:37 UTC | Call of memcmp with null pointers in obj_cmp() The function obj_cmp() (file crypto/objects/obj_dat.c) can in some situations call memcmp() with a null pointer and a zero length. This is invalid behaviour. When compiling openssl with undefined behaviour sanitizer (add -fsanitize=undefined to compile flags) this can be seen. One example that triggers this behaviour is the pkcs7 command (but there are others, e.g. I've seen it with the timestamp function): apps/openssl pkcs7 -in test/testp7.pem What happens is that obj_cmp takes objects of the type ASN1_OBJECT and passes their ->data pointer to memcmp. Zero-sized ASN1_OBJECT structures can have a null pointer as data. RT#3816 Signed-off-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 2b8dc08b74fc3c6d4c2fc855cc23bac691d985be) | 13 May 2015, 14:32:23 UTC |
| 5c12290 | Matt Caswell | 06 May 2015, 20:31:16 UTC | Don't allow a CCS when expecting a CertificateVerify Currently we set change_cipher_spec_ok to 1 before calling ssl3_get_cert_verify(). This is because this message is optional and if it is not sent then the next thing we would expect to get is the CCS. However, although it is optional, we do actually know whether we should be receiving one in advance. If we have received a client cert then we should expect a CertificateVerify message. By the time we get to this point we will already have bombed out if we didn't get a Certificate when we should have done, so it is safe just to check whether |peer| is NULL or not. If it is we won't get a CertificateVerify, otherwise we will. Therefore we should change the logic so that we only attempt to get the CertificateVerify if we are expecting one, and not allow a CCS in this scenario. Whilst this is good practice for TLS it is even more important for DTLS. In DTLS messages can be lost. Therefore we may be in a situation where a CertificateVerify message does not arrive even though one was sent. In that case the next message the server will receive will be the CCS. This could also happen if messages get re-ordered in-flight. In DTLS if |change_cipher_spec_ok| is not set and a CCS is received it is ignored. However if |change_cipher_spec_ok| *is* set then a CCS arrival will immediately move the server into the next epoch. Any messages arriving for the previous epoch will be ignored. This means that, in this scenario, the handshake can never complete. The client will attempt to retransmit missing messages, but the server will ignore them because they are the wrong epoch. The server meanwhile will still be waiting for the CertificateVerify which is never going to arrive. RT#2958 Reviewed-by: Emilia Käsper <emilia@openssl.org> (cherry picked from commit a0bd6493369d960abef11c2346b9bbb308b4285a) | 13 May 2015, 10:25:10 UTC |
| 1c70c78 | Kurt Cancemi | 07 May 2015, 20:12:33 UTC | Add missing NULL check in X509V3_parse_list() Matt's note: I added a call to X509V3err to Kurt's original patch. RT#3840 Signed-off-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 344c271eb339fc2982e9a3584a94e51112d84584) | 11 May 2015, 11:21:43 UTC |
| 9dff24e | Bjoern D. Rasmussen | 10 May 2015, 05:51:29 UTC | Fix for memcpy() and strcmp() being undefined. clang says: "s_cb.c:958:9: error: implicitly declaring library function 'memcpy'" Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 8f744cceff5bce8cb00a6ddd739c1bbb85c142ea) Conflicts: apps/s_cb.c | 11 May 2015, 11:05:53 UTC |
| 6865dea | Matt Caswell | 09 May 2015, 05:51:25 UTC | Check sk_SSL_CIPHER_new_null return value If sk_SSL_CIPHER_new_null() returns NULL then ssl_bytes_to_cipher_list() should also return NULL. Based on an original patch by mrpre <mrpre@163.com>. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 14def5f5375594830597cc153e11c6017f6adddf) | 11 May 2015, 10:54:10 UTC |
| 76d0c6d | Matt Caswell | 30 April 2015, 10:50:08 UTC | Add more error state transitions (DTLS) Ensure all fatal errors transition into the new error state for DTLS. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit cefc93910c4c0f7fa9f8c1f8f7aad084a7fa87d2) Conflicts: ssl/d1_srvr.c Conflicts: ssl/d1_srvr.c | 05 May 2015, 19:09:14 UTC |
| a329ae2 | Matt Caswell | 30 April 2015, 10:32:35 UTC | Add more error state transitions (client) Ensure all fatal errors transition into the new error state on the client side. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit cc273a93617a5c1e69cb5db6f655e463f8e31806) Conflicts: ssl/s3_clnt.c Conflicts: ssl/s3_clnt.c | 05 May 2015, 19:08:35 UTC |
| f3c4abb | Matt Caswell | 30 April 2015, 10:11:04 UTC | Add more error state transitions Ensure all fatal errors transition into the new error state on the server side. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit cf9b0b6fb253fd40225d7c648a08646686e62d2d) Conflicts: ssl/s3_srvr.c | 05 May 2015, 19:07:48 UTC |
| 189e20c | Matt Caswell | 23 April 2015, 19:01:33 UTC | Add Error state Reusing an SSL object when it has encountered a fatal error can have bad consequences. This is a bug in application code not libssl but libssl should be more forgiving and not crash. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit a89db885e0d8aac3a9df1bbccb0c1ddfd8b2e10a) Conflicts: ssl/s3_srvr.c ssl/ssl_stat.c | 05 May 2015, 19:07:48 UTC |
| 4b77112 | Richard Levitte | 04 May 2015, 15:34:40 UTC | RT2943: Check sizes if -iv and -K arguments RT2943 only complains about the incorrect check of -K argument size, we might as well do the same thing with the -iv argument. Before this, we only checked that the given argument wouldn't give a bitstring larger than EVP_MAX_KEY_LENGTH. we can be more precise and check against the size of the actual cipher used. (cherry picked from commit 8920a7cd04f43b1a090d0b0a8c9e16b94c6898d4) Reviewed-by: Rich Salz <rsalz@openssl.org> | 04 May 2015, 19:18:43 UTC |
| ee827ad | Gilles Khouzam | 02 May 2015, 02:20:42 UTC | RT3820: Don't call GetDesktopWindow() Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit bed2edf1cb73f1fe2c11029acc694086bc14443e) | 02 May 2015, 12:02:06 UTC |
| cd258a8 | Hanno Böck | 02 May 2015, 02:27:20 UTC | Fix uninitialized variable. Signed-off-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Viktor Dukhovni <viktor@openssl.org> (cherry picked from commit 539ed89f686866b82a9ec9a4c3b112878d29cd73) | 02 May 2015, 11:46:09 UTC |
| 017f695 | Matt Caswell | 29 April 2015, 12:22:18 UTC | Fix buffer overrun in RSA signing The problem occurs in EVP_PKEY_sign() when using RSA with X931 padding. It is only triggered if the RSA key size is smaller than the digest length. So with SHA512 you can trigger the overflow with anything less than an RSA 512 bit key. I managed to trigger a 62 byte overflow when using a 16 bit RSA key. This wasn't sufficient to cause a crash, although your mileage may vary. In practice RSA keys of this length are never used and X931 padding is very rare. Even if someone did use an excessively short RSA key, the chances of them combining that with a longer digest and X931 padding is very small. For these reasons I do not believe there is a security implication to this. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 34166d41892643a36ad2d1f53cc0025e2edc2a39) | 30 April 2015, 22:27:07 UTC |
| ee900ed | Matt Caswell | 29 April 2015, 08:58:10 UTC | Add sanity check to print_bin function Add a sanity check to the print_bin function to ensure that the |off| argument is positive. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 3deeeeb61b0c5b9b5f0993a67b7967d2f85186da) | 30 April 2015, 22:27:07 UTC |
| 39b36cb | Matt Caswell | 28 April 2015, 14:28:23 UTC | Add sanity check to ssl_get_prev_session Sanity check the |len| parameter to ensure it is positive. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit cb0f400b0cea2d2943f99b1e89c04ff6ed748cd5) | 30 April 2015, 22:27:07 UTC |
| 2680034 | Matt Caswell | 28 April 2015, 14:19:50 UTC | Sanity check the return from final_finish_mac The return value is checked for 0. This is currently safe but we should really check for <= 0 since -1 is frequently used for error conditions. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit c427570e5098e120cbcb66e799f85c317aac7b91) Conflicts: ssl/ssl_locl.h Conflicts: ssl/ssl_locl.h | 30 April 2015, 22:27:05 UTC |
| 592ac25 | Matt Caswell | 27 April 2015, 14:41:42 UTC | Add sanity check in ssl3_cbc_digest_record For SSLv3 the code assumes that |header_length| > |md_block_size|. Whilst this is true for all SSLv3 ciphersuites, this fact is far from obvious by looking at the code. If this were not the case then an integer overflow would occur, leading to a subsequent buffer overflow. Therefore I have added an explicit sanity check to ensure header_length is always valid. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 29b0a15a480626544dd0c803d5de671552544de6) | 30 April 2015, 22:26:07 UTC |
| d889682 | Matt Caswell | 27 April 2015, 14:41:03 UTC | Clarify logic in BIO_*printf functions The static function dynamically allocates an output buffer if the output grows larger than the static buffer that is normally used. The original logic implied that |currlen| could be greater than |maxlen| which is incorrect (and if so would cause a buffer overrun). Also the original logic would call OPENSSL_malloc to create a dynamic buffer equal to the size of the static buffer, and then immediately call OPENSSL_realloc to make it bigger, rather than just creating a buffer than was big enough in the first place. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 9d9e37744cd5119f9921315864d1cd28717173cd) | 30 April 2015, 22:26:07 UTC |
| 951ede2 | Matt Caswell | 27 April 2015, 10:13:56 UTC | Sanity check EVP_EncodeUpdate buffer len There was already a sanity check to ensure the passed buffer length is not zero. Extend this to ensure that it also not negative. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit b86d7dca69f5c80abd60896c8ed3039fc56210cc) | 30 April 2015, 22:26:07 UTC |
| 974d4d6 | Matt Caswell | 27 April 2015, 10:07:06 UTC | Sanity check EVP_CTRL_AEAD_TLS_AAD The various implementations of EVP_CTRL_AEAD_TLS_AAD expect a buffer of at least 13 bytes long. Add sanity checks to ensure that the length is at least that. Also add a new constant (EVP_AEAD_TLS1_AAD_LEN) to evp.h to represent this length. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit c8269881093324b881b81472be037055571f73f3) Conflicts: ssl/record/ssl3_record.c Conflicts: apps/speed.c crypto/evp/e_aes_cbc_hmac_sha256.c crypto/evp/evp.h | 30 April 2015, 22:26:06 UTC |
| 3be5df2 | Matt Caswell | 27 April 2015, 10:04:56 UTC | Sanity check DES_enc_write buffer length Add a sanity check to DES_enc_write to ensure the buffer length provided is not negative. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 873fb39f20b6763daba226b74e83fb194924c7bf) | 30 April 2015, 22:24:21 UTC |
| 80a0626 | Matt Caswell | 29 April 2015, 15:15:40 UTC | Add length sanity check in SSLv2 n_do_ssl_write() Fortify flagged up a problem in n_do_ssl_write() in SSLv2. Analysing the code I do not believe there is a real problem here. However the logic flows are complicated enough that a sanity check of |len| is probably worthwhile. Thanks to Kevin Wojtysiak (Int3 Solutions) and Paramjot Oberoi (Int3 Solutions) for reporting this issue. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit c5f8cd7bc661f90dc012c9d2bae1808a4281985f) | 29 April 2015, 16:44:02 UTC |
| e3dd33c | Loganaden Velvindron | 22 April 2015, 15:16:30 UTC | Fix CRYPTO_strdup The function CRYPTO_strdup (aka OPENSSL_strdup) fails to check the return value from CRYPTO_malloc to see if it is NULL before attempting to use it. This patch adds a NULL check. RT3786 Signed-off-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 37b0cf936744d9edb99b5dd82cae78a7eac6ad60) Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 20d21389c8b6f5b754573ffb6a4dc4f3986f2ca4) | 22 April 2015, 16:24:47 UTC |
| d695a02 | Emilia Kasper | 21 April 2015, 16:12:58 UTC | Repair EAP-FAST session resumption EAP-FAST session resumption relies on handshake message lookahead to determine server intentions. Commits 980bc1ec6114f5511b20c2e6ca741e61a39b99d6 and 7b3ba508af5c86afe43e28174aa3c53a0a24f4d9 removed the lookahead so broke session resumption. This change partially reverts the commits and brings the lookahead back in reduced capacity for TLS + EAP-FAST only. Since EAP-FAST does not support regular session tickets, the lookahead now only checks for a Finished message. Regular handshakes are unaffected by this change. Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 6e3d015363ed09c4eff5c02ad41153387ffdf5af) | 21 April 2015, 17:37:17 UTC |
| a209623 | Emilia Kasper | 14 April 2015, 15:42:42 UTC | Initialize variable newsig may be used (freed) uninitialized on a malloc error. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 68249414405500660578b337f1c8dd5dd4bb5bcc) | 21 April 2015, 17:32:43 UTC |
| 92caee0 | Emilia Kasper | 16 April 2015, 16:11:56 UTC | make update Reviewed-by: Dr. Stephen Henson <steve@openssl.org> | 21 April 2015, 15:53:36 UTC |
| 0725acd | Richard Levitte | 25 March 2015, 13:41:58 UTC | Initialised 'ok' and redo the logic. The logic with how 'ok' was calculated didn't quite convey what's "ok", so the logic is slightly redone to make it less confusing. Reviewed-by: Andy Polyakov <appro@openssl.org> (cherry picked from commit 06affe3dac65592a341547f5a47e52cedb7b71f8) | 20 April 2015, 23:45:58 UTC |
| 5fa7c10 | Matt Caswell | 13 March 2015, 16:48:01 UTC | Fix return checks in GOST engine Filled in lots of return value checks that were missing the GOST engine, and added appropriate error handling. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 8817e2e0c998757d3bd036d7f45fe8d0a49fbe2d) | 20 April 2015, 22:13:02 UTC |
| 96d9674 | Matt Caswell | 13 March 2015, 15:04:54 UTC | Fix misc NULL derefs in sureware engine Fix miscellaneous NULL pointer derefs in the sureware engine. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 7b611e5fe8eaac9512f72094c460f3ed6040076a) | 20 April 2015, 22:13:01 UTC |
| 32d3b0f | Dr. Stephen Henson | 16 April 2015, 15:43:09 UTC | Fix encoding bug in i2c_ASN1_INTEGER Fix bug where i2c_ASN1_INTEGER mishandles zero if it is marked as negative. Thanks to Huzaifa Sidhpurwala <huzaifas@redhat.com> and Hanno Böck <hanno@hboeck.de> for reporting this issue. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit a0eed48d37a4b7beea0c966caf09ad46f4a92a44) | 18 April 2015, 13:44:17 UTC |
| 31d085c | Emilia Kasper | 15 April 2015, 12:18:55 UTC | Error out immediately on empty ciphers list. A 0-length ciphers list is never permitted. The old code only used to reject an empty ciphers list for connections with a session ID. It would later error out on a NULL structure, so this change just moves the alert closer to the problem source. Reviewed-by: Rich Salz <rsalz@openssl.org> (cherry picked from commit 3ae91cfb327c9ed689b9aaf7bca01a3f5a0657cb) | 17 April 2015, 16:47:25 UTC |
| c70908d | Viktor Dukhovni | 16 April 2015, 06:51:52 UTC | Code style: space after 'if' Reviewed-by: Matt Caswell <gitlab@openssl.org> | 16 April 2015, 17:51:51 UTC |
