| dcfa88b | Matt Caswell | 13 February 2018, 13:48:07 UTC | Prepare for 1.1.1-pre1 release Reviewed-by: Richard Levitte <levitte@openssl.org> | 13 February 2018, 13:59:25 UTC |
| 6738bf1 | Matt Caswell | 13 February 2018, 12:51:29 UTC | Update copyright year Reviewed-by: Richard Levitte <levitte@openssl.org> | 13 February 2018, 13:59:25 UTC |
| abfee34 | Matt Caswell | 13 February 2018, 10:17:18 UTC | OpenSSL 1.1.1 is now in pre release Reviewed-by: Richard Levitte <levitte@openssl.org> | 13 February 2018, 13:59:25 UTC |
| d6d605e | Matt Caswell | 13 February 2018, 10:09:34 UTC | Update last release letter for CHANGES and NEWS Reviewed-by: Richard Levitte <levitte@openssl.org> | 13 February 2018, 13:59:25 UTC |
| 87411f0 | Dr. Matthias St. Pierre | 13 February 2018, 01:04:50 UTC | Fix whitespace issues in CHANGES and NEWS Removed mixed tabs (converted tabs to eight spaces) Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5344) | 13 February 2018, 09:14:00 UTC |
| 53010ea | Dr. Matthias St. Pierre | 13 February 2018, 01:02:22 UTC | Document new random generator in NEWS and CHANGES Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5344) | 13 February 2018, 09:14:00 UTC |
| 1c5b57b | Matt Caswell | 12 February 2018, 15:16:01 UTC | Update NEWS file for new release Updated the NEWS file with the most significant items from CHANGES Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5333) | 12 February 2018, 22:38:13 UTC |
| 034d55c | Matt Caswell | 12 February 2018, 09:39:28 UTC | Some minor tweaks following TLSv1.3 becoming default Fix a typo in INSTALL and update the link in CHANGES Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5329) | 12 February 2018, 14:56:45 UTC |
| ada2259 | Bernd Edlinger | 12 February 2018, 08:28:33 UTC | Remove code that prints "<SPACES/NULS>" in hexdumps when the data block ends with SPACEs or NULs. The problem is, you can't see if the data ends with SPACE or NUL or a combination of both. This can happen for instance with openssl rsautl -decrypt -hexdump Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5328) | 12 February 2018, 14:15:27 UTC |
| af0fcf7 | Andy Polyakov | 11 February 2018, 11:29:47 UTC | sha/asm/sha512-armv8.pl: add hardware-assisted SHA512 subroutine. Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 February 2018, 13:05:05 UTC |
| 77f3612 | Andy Polyakov | 11 February 2018, 11:29:06 UTC | crypto/armcap.c: detect hardware-assisted SHA512 support. Reviewed-by: Rich Salz <rsalz@openssl.org> | 12 February 2018, 13:04:53 UTC |
| 1d0c08b | Matt Caswell | 09 February 2018, 18:03:08 UTC | The function ssl_get_min_max_version() can fail We should always check the return code. This fixes a coverity issue. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5308) | 12 February 2018, 10:06:39 UTC |
| 7e70213 | Matt Caswell | 09 February 2018, 16:39:27 UTC | Don't overestimate the ticket age On the client we calculate the age of the ticket in seconds but the server may work in ms. Due to rounding errors we could overestimate the age by up to 1s. It is better to underestimate it. Otherwise, if the RTT is very short, when the server calculates the age reported by the client it could be bigger than the age calculated on the server - which should never happen. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5306) | 12 February 2018, 10:01:13 UTC |
| c684a2d | Daniël van Eeden | 11 February 2018, 15:55:38 UTC | Fix include in manpage of X509_check_host Fixes Issue #5255 CLA: trivial Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5256) | 11 February 2018, 15:55:38 UTC |
| 6dbe4dc | Rich Salz | 10 February 2018, 18:36:47 UTC | Copy name string in BIO_meth_new Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5318) | 10 February 2018, 18:36:47 UTC |
| 4e07525 | Viktor Dukhovni | 09 February 2018, 23:34:33 UTC | Avoid leaking peername data via accept BIOs Reviewed-by: Rich Salz <rsalz@openssl.org> | 10 February 2018, 02:06:18 UTC |
| ebc20cf | Bernd Edlinger | 09 February 2018, 16:19:50 UTC | Swap the check in ssl3_write_pending to avoid using the possibly indeterminate pointer value in wpend_buf. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5305) | 09 February 2018, 18:52:31 UTC |
| c423eca | Matt Caswell | 09 February 2018, 10:19:14 UTC | Fixes for no-tls1_2 and no-tls1_2-method The no-tls1_2 option does not work properly in conjunction with TLSv1.3 being enabled (which is now the default). This commit fixes the issues. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5301) | 09 February 2018, 17:44:43 UTC |
| 83739b3 | Nick Mathewson | 09 February 2018, 14:03:07 UTC | Run "make update" Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5150) | 09 February 2018, 16:49:07 UTC |
| 41e9afa | Nick Mathewson | 23 January 2018, 15:49:53 UTC | In err_all.c, include the *err.h headers. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5150) | 09 February 2018, 16:49:07 UTC |
| 5773f7b | Nick Mathewson | 23 January 2018, 15:48:35 UTC | Improve #include structure of pem{,2}.h - pem2.h is empty, so pem.h doesn't need to include it. - pem2.h once declared ERR_load_PEM_strings(), so it should now include pemerr.h Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5150) | 09 February 2018, 16:49:07 UTC |
| a5d0d6b | Nick Mathewson | 23 January 2018, 14:46:13 UTC | Remove redundant declarations of ERR_load_*_strings() In commit 52df25cf2e656146cb3b206d8220124f0417d03f, the ERR_load_FOO_strings() functions were moved from their original location in foo.h into new headers called fooerr.h. But they were never removed from their original locations. This duplication causes redundant-declaration warnings on programs that use OpenSSL's headers with such warnings enabled. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5150) | 09 February 2018, 16:49:07 UTC |
| 5d67110 | Matt Caswell | 08 February 2018, 14:48:51 UTC | Don't calculate the Finished MAC twice In <= TLSv1.2 a Finished message always comes immediately after a CCS except in the case of NPN where there is an additional message between the CCS and Finished. Historically we always calculated the Finished MAC when we processed the CCS. However to deal with NPN we also calculated it when we receive the Finished message. Really this should only have been done if we hand negotiated NPN. This simplifies the code to only calculate the MAC when we receive the Finished. In 1.1.1 we need to do it this way anyway because there is no CCS (except in middlebox compat mode) in TLSv1.3. Coincidentally, this commit also fixes the fact that no-nextprotoneg does not currently work in master. Reviewed-by: Andy Polyakov <appro@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5285) | 09 February 2018, 15:27:32 UTC |
| 368297d | Richard Levitte | 08 February 2018, 22:26:22 UTC | Configuration: move the handling of zlib_include to config files It was a bit absurd to have this being specially handled in the build file templates, especially that we have the 'includes' attribute. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5296) | 09 February 2018, 13:27:31 UTC |
| f3ac964 | Richard Levitte | 09 February 2018, 12:45:58 UTC | Turn off printf format checking for BIO_printf et al on Mac OS/X Mac OS/X has a type for %j that doesn't agree with how we define it, which gives incorrect warnings. The easiest way out of that situation is simply to turn off that check on Mac OS/X. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5302) | 09 February 2018, 13:06:41 UTC |
| a699b8e | FdaSilvaYY | 08 February 2018, 23:47:30 UTC | Small simplification in mkerr.pl As suggested in https://github.com/openssl/openssl/pull/5275 Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5288) | 09 February 2018, 12:04:32 UTC |
| 2e8b0ef | Richard Levitte | 09 February 2018, 08:55:36 UTC | VMS: take care of includes Configurations/descrip.mms.tmpl didn't treat the includes config attribute very well. In fact, it didn't treat it at all! Reviewed-by: Andy Polyakov <appro@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5295) | 09 February 2018, 09:31:32 UTC |
| 4cd5877 | Pauli | 08 February 2018, 01:04:30 UTC | Fix glibc version detection. Simplify Posix timer detection. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5279) | 09 February 2018, 09:10:45 UTC |
| fd87700 | Richard Levitte | 09 February 2018, 08:03:05 UTC | Fix check of cpuid_asm_src config attribute The contents of that attribute is C file names, not object file names. This went undetected because quite a lot of systems have assembler implementations anyway, so setting OPENSSL_CPUID_OBJ was correct for them. Reviewed-by: Andy Polyakov <appro@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5291) | 09 February 2018, 09:06:29 UTC |
| a6da6b7 | Richard Levitte | 09 February 2018, 08:12:47 UTC | Revert ".travis.yml: remove osx from build matrix." Recent changes seem to have gotten OS X back on track, so we should be able to run our tests there again. This reverts commit e12e903e9ac675d08f9dd0db1f0c1a2049232c21. Reviewed-by: Andy Polyakov <appro@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5292) | 09 February 2018, 09:03:40 UTC |
| b9ed9ab | Dr. Matthias St. Pierre | 09 February 2018, 07:52:56 UTC | CRYPTO_THREAD_run_once.pod: fix typo and punktuation Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5293) | 09 February 2018, 08:48:40 UTC |
| 71cff96 | Matt Caswell | 08 February 2018, 15:45:35 UTC | Fix no-chacha and no-poly1305 Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5287) | 08 February 2018, 17:20:55 UTC |
| b53fdad | Richard Levitte | 08 February 2018, 11:31:05 UTC | util/mkdef.pl: use better array in search of 'DEPRECATEDIN_' %disabled_algorithms isn't necessarily initialised with the "algos" 'DEPRECATEDIN_1_1_0' etc. However, we know that @known_algorithms has them all, so use that to find them instead. Fixes #5157 (where this was reported) Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5282) | 08 February 2018, 11:33:08 UTC |
| 22626b9 | Richard Levitte | 07 February 2018, 21:40:32 UTC | With nmake, invoking $(MAKE) needs /$(MAKEFLAGS) The slash should be there according to Microsoft documentation, see https://msdn.microsoft.com/en-us/library/7cafx990.aspx Fixes #5277 Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5278) | 08 February 2018, 04:10:46 UTC |
| 4af2697 | Matt Caswell | 07 February 2018, 14:53:31 UTC | Don't run tls13encryptiontest on a shared Windows build tls13encryptiontest is an "internal" test. As with all the other internal tests it should not be run on a shared native Windows build. [extended tests] Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5266) | 07 February 2018, 21:34:18 UTC |
| 04e3bb0 | Matt Caswell | 07 February 2018, 14:20:31 UTC | Fix some undefined behaviour in ossltest engine Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5266) | 07 February 2018, 21:34:18 UTC |
| 0f41dc0 | Matt Caswell | 07 February 2018, 10:55:02 UTC | Fix clienthellotest with TLSv1.3 If TLSv1.3 is enabled and combined with other options that extend the size of the ClientHello, then the clienthello test can sometimes fail because the ClientHello has grown too large. Part of the purpose of the test is to check that the padding extension works properly. This requires the ClientHello size to be kept within certain bounds. By restricting the number of ciphersuites sent we can reduce the size of the ClientHello. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5266) | 07 February 2018, 21:34:18 UTC |
| f518cef | Matt Caswell | 06 February 2018, 17:27:25 UTC | Enable TLSv1.3 by default [extended tests] Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5266) | 07 February 2018, 21:34:18 UTC |
| c517ac4 | Richard Levitte | 07 February 2018, 21:18:44 UTC | Revert "Modify test/afalgtest to fail if the afalg engine couldn't be loaded" It turns out that even if you successfully build the engine, it might not load properly, so we cannot make the test program fail for it. See the message in commit 25b9d11c002e5c71840c2a6733c5009d78f2c9db This reverts commit 227a1e3f45bf06fdb00f2bdfb922f6f0d1f1d1de. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5276) | 07 February 2018, 21:18:44 UTC |
| 048ebcc | Richard Levitte | 07 February 2018, 18:40:19 UTC | make update ERROR_REBUILD=-rebuild Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5275) | 07 February 2018, 21:16:45 UTC |
| cb7b727 | Richard Levitte | 07 February 2018, 18:23:39 UTC | mkerr.pl: When writing internal FOOerr.h, pay attention to disablable modules If a module is disablable (i.e. can be configured with 'no-FOO'), the resulting header file needs to be guarded with a check of the corresponding OPENSSL_NO_FOO. While this seem fairly innocuous, it has an impact on the information in util/*.num, generated by mkdef.pl. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5275) | 07 February 2018, 21:16:44 UTC |
| 3a7141d | Richard Levitte | 07 February 2018, 13:05:20 UTC | Make all private functions in e_afalg.c static Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5270) | 07 February 2018, 15:15:47 UTC |
| 7d3901f | Richard Levitte | 07 February 2018, 13:02:49 UTC | test/recipes/30-test_afalg.t: set OPENSSL_ENGINES correctly The afalg engine was moved down from engines/afalg/ to engines/, but the test wasn't changed accordingly. This was undetected because the test program didn't fail when it couldn't load the engine. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5270) | 07 February 2018, 15:15:47 UTC |
| 227a1e3 | Richard Levitte | 07 February 2018, 13:01:13 UTC | Modify test/afalgtest to fail if the afalg engine couldn't be loaded If you know that there's no afalg engine, don't run this test. test/recipes/30-test_afalg.t checks this correctly. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5270) | 07 February 2018, 15:15:47 UTC |
| bed4afa | Pauli | 07 February 2018, 01:46:15 UTC | Fix glibc specific conditional for Mac OS/X MacOS seems to define __GLIBC__ but not __GLIBC_PREREQ. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5269) | 07 February 2018, 01:46:15 UTC |
| 2b66fd5 | Pauli | 05 February 2018, 21:17:31 UTC | Unify timer code Remove the timer and TSC additional input code and instead provide a single routine that attempts to use the "best" timer/counter available on the system. It attempts to use TSC, then various OS dependent resources and finally several tries to obtain the date. If any of these timer/counters is successful, the rest are skipped. No randomness is credited for this. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/5231) | 07 February 2018, 00:08:15 UTC |
| 360fc9f | Pauli | 05 February 2018, 21:16:26 UTC | Make OPENSSL_rdtsc universally available. If such a timer/counter register is not available, the return value is always zero. This matches the assembly implementations' behaviour. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/5231) | 07 February 2018, 00:08:15 UTC |
| 2ad2281 | Pauli | 05 February 2018, 21:15:53 UTC | Make the OPENSSL_CPUID_OBJ define internal. Patch by @levitte. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/5231) | 07 February 2018, 00:08:15 UTC |
| 7ff3a3b | Richard Levitte | 06 February 2018, 19:01:19 UTC | Code cleanup: remove benchmark code from internal tests Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/5268) | 06 February 2018, 21:54:19 UTC |
| a3a5d1b | Rich Salz | 06 February 2018, 20:27:03 UTC | Remove unused file Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5267) | 06 February 2018, 20:27:26 UTC |
| 5d2a6f4 | Patrick Steuer | 03 February 2018, 16:46:34 UTC | crypto/evp/e_aes.c: add comments to s390x aes gcm implementation Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com> Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5230) | 06 February 2018, 18:41:21 UTC |
| 39f5b06 | Patrick Steuer | 18 January 2018, 09:14:30 UTC | s390x assembly pack: add KMAC code path for aes-ccm Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com> Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5230) | 06 February 2018, 18:39:52 UTC |
| 54f3b7d | Richard Levitte | 24 January 2018, 13:17:39 UTC | util/mkdef.pl: Trust configdata.pm This script kept its own database of disablable algorithms, which is a maintenance problem, as it's not always perfectly in sync with what Configure does. However, we do have all the data in configdata.pm, produced by Configure, so let's use that instead. Also, make sure to parse the *err.h header files, as they contain function declarations that might not be present elsewhere. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5157) | 06 February 2018, 12:31:35 UTC |
| f61f62e | Dr. Matthias St. Pierre | 03 February 2018, 21:33:19 UTC | Use RAND_DRBG_bytes() for RAND_bytes() and RAND_priv_bytes() The functions RAND_bytes() and RAND_priv_bytes() are now both based on a common implementation using RAND_DRBG_bytes() (if the default OpenSSL rand method is active). This not only simplifies the code but also has the advantage that additional input from a high precision timer is added on every generate call if the timer is available. Reviewed-by: Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/5251) | 05 February 2018, 19:05:14 UTC |
| 1648338 | Dr. Matthias St. Pierre | 03 February 2018, 21:32:47 UTC | Fix size limitation of RAND_DRBG_bytes() When comparing the implementations of drbg_bytes() and RAND_DRBG_bytes(), it was noticed that the former split the buffer into chunks when calling RAND_DRBG_generate() to circumvent the size limitation of the buffer to outlen <= drb->max_request. This loop was missing in RAND_DRBG_bytes(), so it was adopted from drbg_bytes(). Reviewed-by: Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/5251) | 05 February 2018, 19:05:14 UTC |
| 58351fb | Dr. Matthias St. Pierre | 03 February 2018, 20:13:19 UTC | drbg_bytes: remove check for DRBG_UNINITIALIZED state This check not only prevented the automatic reinstantiation of the DRBG, which is implemented in RAND_DRBG_generate(), but also prevented an error message from being generated in the case of failure. Reviewed-by: Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/5251) | 05 February 2018, 19:05:14 UTC |
| 1c4b154 | Matt Caswell | 02 February 2018, 10:17:06 UTC | Add MiddleboxCompat option to SSL_CONF_cmd man page Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5244) | 05 February 2018, 10:56:53 UTC |
| 1f5878b | Tatsuhiro Tsujikawa | 21 January 2018, 02:30:36 UTC | Make sure that exporting keying material is allowed Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4944) | 02 February 2018, 23:54:14 UTC |
| b1a51ab | Tatsuhiro Tsujikawa | 18 January 2018, 06:39:45 UTC | Remove generation of exporter master secret on client application traffic Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4944) | 02 February 2018, 23:52:59 UTC |
| 2221ec1 | Tatsuhiro Tsujikawa | 16 December 2017, 07:46:18 UTC | Generate exporter_master_secret after server Finished Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4944) | 02 February 2018, 23:52:59 UTC |
| 50ea9d2 | Richard Levitte | 02 February 2018, 09:33:41 UTC | Have configdata.pm also display the contents of %target Reviewed-by: Andy Polyakov <appro@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5243) | 02 February 2018, 11:43:36 UTC |
| 22da44f | Matt Caswell | 01 February 2018, 17:40:17 UTC | Document SSL_OP_ENABLE_MIDDLEBOX_COMPAT Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5237) | 02 February 2018, 10:05:47 UTC |
| 03cb2cc | Richard Levitte | 01 February 2018, 20:28:59 UTC | Fix of prefix bio filter (bf_prefix.c): rely on the given length The assumption that the received buffer has to be NUL-terminated was faulty. Fault found in #5224 Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5239) | 01 February 2018, 21:09:41 UTC |
| f345b1f | David Benjamin | 31 January 2018, 19:47:41 UTC | Fix timing leak in BN_from_montgomery_word. BN_from_montgomery_word doesn't have a constant memory access pattern. Replace the pointer trick with a constant-time select. There is, of course, still the bn_correct_top leak pervasive in BIGNUM itself. See also https://boringssl-review.googlesource.com/22904 from BoringSSL. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Kurt Roeckx <kurt@roeckx.be> (Merged from https://github.com/openssl/openssl/pull/5228) | 01 February 2018, 20:52:17 UTC |
| 39eeb64 | David Benjamin | 23 January 2018, 18:57:10 UTC | Don't leak the exponent bit width in BN_mod_exp_mont_consttime. The exponent here is one of d, dmp1, or dmq1 for RSA. This value and its bit length are both secret. The only public upper bound is the bit width of the corresponding modulus (RSA n, p, and q, respectively). Although BN_num_bits is constant-time (sort of; see bn_correct_top notes in preceding patch), this does not fix the root problem, which is that the windows are based on the minimal bit width, not the upper bound. We could use BN_num_bits(m), but BN_mod_exp_mont_consttime is public API and may be called with larger exponents. Instead, use all top*BN_BITS2 bits in the BIGNUM. This is still sensitive to the long-standing bn_correct_top leak, but we need to fix that regardless. This may cause us to do a handful of extra multiplications for RSA keys which are just above a whole number of words, but that is not a standard RSA key size. Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5154) | 01 February 2018, 20:44:28 UTC |
| 972c87d | David Benjamin | 23 January 2018, 18:46:53 UTC | Make BN_num_bits_word constant-time. (This patch was written by Andy Polyakov. I only wrote the commit message. Mistakes in the analysis are my fault.) BN_num_bits, by way of BN_num_bits_word, currently leaks the most-significant word of its argument via branching and memory access pattern. BN_num_bits is called on RSA prime factors in various places. These have public bit lengths, but all bits beyond the high bit are secret. This fully resolves those cases. There are a few places where BN_num_bits is called on an input where the bit length is also secret. This does *not* fully resolve those cases as we still only look at the top word. Today, that is guaranteed to be non-zero, but only because of the long-standing bn_correct_top timing leak. Once that is fixed, a constant-time BN_num_bits on such inputs must count bits on each word. Instead, those cases should not call BN_num_bits at all. In particular, BN_mod_exp_mont_consttime uses the exponent bit width to pick windows, but it should be using the maximum bit width. The next patch will fix this. Thanks to Dinghao Wu, Danfeng Zhang, Shuai Wang, Pei Wang, and Xiao Liu for reporting this issue. Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5154) | 01 February 2018, 20:44:18 UTC |
| 3c5a61d | Michael Richardson | 01 February 2018, 18:22:48 UTC | Add OPENSSL_VERSION_AT_LEAST added macro to create version number use the macro to build OPENSSL_VERSION_AT_LEAST(maj,min,fix) so that customers of libssl (such as ruby-openssl) do not need to be so aware of openssl version numbers. includes updates to ssl(7) and OPENSSL_VERSION_NUMBER(3) man page Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5212) | 01 February 2018, 18:22:48 UTC |
| 67c836e | Rich Salz | 01 February 2018, 18:18:32 UTC | Shorten output by a line Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5238) | 01 February 2018, 18:18:32 UTC |
| 3454407 | Richard Levitte | 01 February 2018, 09:35:59 UTC | VMS: MMS wants a space before the target / dependecies separator So as not to be mixed up with a device specification... Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5234) | 01 February 2018, 18:17:27 UTC |
| e43e6b1 | Todd Short | 31 January 2018, 21:36:27 UTC | Fix some minor code nits Reviewed-by: Ben Kaduk <kaduk@mit.edu> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4964) | 01 February 2018, 17:07:56 UTC |
| 658e487 | Todd Short | 31 January 2018, 21:34:20 UTC | Fix doc nits Reviewed-by: Ben Kaduk <kaduk@mit.edu> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4964) | 01 February 2018, 17:07:56 UTC |
| 8883499 | Todd Short | 31 January 2018, 21:20:52 UTC | Free pha_dgst in SSL_clear() Reviewed-by: Ben Kaduk <kaduk@mit.edu> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4964) | 01 February 2018, 17:07:56 UTC |
| 9d75dce | Todd Short | 18 December 2017, 21:52:28 UTC | Add TLSv1.3 post-handshake authentication (PHA) Add SSL_verify_client_post_handshake() for servers to initiate PHA Add SSL_force_post_handshake_auth() for clients that don't have certificates initially configured, but use a certificate callback. Update SSL_CTX_set_verify()/SSL_set_verify() mode: * Add SSL_VERIFY_POST_HANDSHAKE to postpone client authentication until after the initial handshake. * Update SSL_VERIFY_CLIENT_ONCE now only sends out one CertRequest regardless of when the certificate authentication takes place; either initial handshake, re-negotiation, or post-handshake authentication. Add 'RequestPostHandshake' and 'RequirePostHandshake' SSL_CONF options that add the SSL_VERIFY_POST_HANDSHAKE to the 'Request' and 'Require' options Add support to s_client: * Enabled automatically when cert is configured * Can be forced enabled via -force_pha Add support to s_server: * Use 'c' to invoke PHA in s_server * Remove some dead code Update documentation Update unit tests: * Illegal use of PHA extension * TLSv1.3 certificate tests DTLS and TLS behave ever-so-slightly differently. So, when DTLS1.3 is implemented, it's PHA support state machine may need to be different. Add a TODO and a #error Update handshake context to deal with PHA. The handshake context for TLSv1.3 post-handshake auth is up through the ClientFinish message, plus the CertificateRequest message. Subsequent Certificate, CertificateVerify, and Finish messages are based on this handshake context (not the Certificate message per se, but it's included after the hash). KeyUpdate, NewSessionTicket, and prior Certificate Request messages are not included in post-handshake authentication. After the ClientFinished message is processed, save off the digest state for future post-handshake authentication. When post-handshake auth occurs, copy over the saved handshake context into the "main" handshake digest. This effectively discards the any KeyUpdate or NewSessionTicket messages and any prior post-handshake authentication. This, of course, assumes that the ID-22 did not mean to include any previous post-handshake authentication into the new handshake transcript. This is implied by section 4.4.1 that lists messages only up to the first ClientFinished. Reviewed-by: Ben Kaduk <kaduk@mit.edu> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4964) | 01 February 2018, 17:07:56 UTC |
| 633a882 | Todd Short | 19 January 2018, 15:43:19 UTC | Remove bad comments Reviewed-by: Ben Kaduk <kaduk@mit.edu> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4964) | 01 February 2018, 17:07:56 UTC |
| 848a950 | Matt Caswell | 31 January 2018, 09:53:51 UTC | Fix some instances of the wrong alert type being sent In a few places we sent an internal_error alert instead of a decode_error. Fixes #5213 Fixes #5214 Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5219) | 01 February 2018, 10:28:49 UTC |
| 4e525a0 | Richard Levitte | 31 January 2018, 21:08:12 UTC | ocsp.c doesn't free the whole output chain, maybe causing a memory leak Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5224) | 01 February 2018, 06:10:48 UTC |
| 71bb86f | Richard Levitte | 28 January 2018, 08:49:46 UTC | Make sure that apps/openssl prefixes its output with '# ' during tests The reason to do this is that some output might start with an 'ok', which TAP catches and takes for TAP output. The TAP compatible way is to make all output it shouldn't catch look like comments. We do this by setting the environment variable HARNESS_OSSL_PREFIX during tests. When that is set, apps/openssl uses BIO_f_linebuffer and sets its prefix to the content of that environment variable. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5224) | 01 February 2018, 06:10:48 UTC |
| 39556e6 | Richard Levitte | 30 January 2018, 21:03:27 UTC | Add an apps internal BIO filter for prefixing output lines Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5224) | 01 February 2018, 06:10:47 UTC |
| 3cb413d | Richard Levitte | 31 January 2018, 20:49:27 UTC | Add missing \n in some testutil output Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5229) | 31 January 2018, 22:49:21 UTC |
| 0ac9e9f | Richard Levitte | 31 January 2018, 13:18:54 UTC | Make test/uitest depend on the private apps support library This avoids having to enumerate specific modules in apps, or to have to include them in libtestutil.a. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5222) | 31 January 2018, 22:45:12 UTC |
| d6baf09 | Richard Levitte | 31 January 2018, 13:15:52 UTC | Apps: divide the modules in direct command modules, support library and init Most modules are direct implementations of openssl application sub-commands, but some constitute a support library, which can be used by more than one program (and is, incidently, by test/uitest). For practical purposes, we place the support library modules in a private, static library. Finally, there are some modules that don't have direct references in the rest of the apps code, but are still crucial. See them as some kind of extra crt0 or similar for your platform. Inspiration from David von Oheimb Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5222) | 31 January 2018, 22:45:12 UTC |
| dab2cd6 | Richard Levitte | 31 January 2018, 10:13:10 UTC | apps: Don't include progs.h in apps.h Everything in apps includes apps.h, because that one declares apps internal library routines. However, progs.h doesn't declare library routines, but rather the main commands and their options, and there's no reason why the library modules should include it. So, remove the inclusion of progs.h from apps.h and add that inclusion in all command source files. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5222) | 31 January 2018, 22:45:12 UTC |
| 79a0e87 | Andy Polyakov | 23 January 2018, 19:33:36 UTC | test/asn1_time_test.c: fix pre-C90 warning. Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Paul Dale <paul.dale@oracle.com> | 31 January 2018, 21:17:16 UTC |
| 6b6981e | Andy Polyakov | 29 January 2018, 22:44:33 UTC | poly1305/poly1305_ieee754.c: add support for MIPS. Reviewed-by: Rich Salz <rsalz@openssl.org> | 31 January 2018, 21:14:29 UTC |
| adeb4bc | Benjamin Kaduk | 26 January 2018, 15:32:40 UTC | Restore clearing of init_lock after free The behavior of resetting the init_lock value to NULL after freeing it during OPENSSL_cleanup() was added as part of the global lock commits that were just reverted, but there is desire to retain this behavior for clarity. It is unclear that the library would actually remain usable in any form after OPENSSL_cleanup(), since the required re-initialization occurs under a CRYPTO_ONCE check that cannot be reset at cleanup time. That said, a NULL dereference is probably more friendly behavior in these treacherous waters than using freed memory would be. Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/5089) | 31 January 2018, 18:25:28 UTC |
| 63ab5ea | Benjamin Kaduk | 16 January 2018, 15:49:54 UTC | Revert the crypto "global lock" implementation Conceptually, this is a squashed version of: Revert "Address feedback" This reverts commit 75551e07bd2339dfea06ef1d31d69929e13a4495. and Revert "Add CRYPTO_thread_glock_new" This reverts commit ed6b2c7938ec6f07b15745d4183afc276e74c6dd. But there were some intervening commits that made neither revert apply cleanly, so instead do it all as one shot. The crypto global locks were an attempt to cope with the awkward POSIX semantics for pthread_atfork(); its documentation (the "RATIONALE" section) indicates that the expected usage is to have the prefork handler lock all "global" locks, and the parent and child handlers release those locks, to ensure that forking happens with a consistent (lock) state. However, the set of functions available in the child process is limited to async-signal-safe functions, and pthread_mutex_unlock() is not on the list of async-signal-safe functions! The only synchronization primitives that are async-signal-safe are the semaphore primitives, which are not really appropriate for general-purpose usage. However, the state consistency problem that the global locks were attempting to solve is not actually a serious problem, particularly for OpenSSL. That is, we can consider four cases of forking application that might use OpenSSL: (1) Single-threaded, does not call into OpenSSL in the child (e.g., the child calls exec() immediately) For this class of process, no locking is needed at all, since there is only ever a single thread of execution and the only reentrancy is due to signal handlers (which are themselves limited to async-signal-safe operation and should not be doing much work at all). (2) Single-threaded, calls into OpenSSL after fork() The application must ensure that it does not fork() with an unexpected lock held (that is, one that would get unlocked in the parent but accidentally remain locked in the child and cause deadlock). Since OpenSSL does not expose any of its internal locks to the application and the application is single-threaded, the OpenSSL internal locks will be unlocked for the fork(), and the state will be consistent. (OpenSSL will need to reseed its PRNG in the child, but that is an orthogonal issue.) If the application makes use of locks from libcrypto, proper handling for those locks is the responsibility of the application, as for any other locking primitive that is available for application programming. (3) Multi-threaded, does not call into OpenSSL after fork() As for (1), the OpenSSL state is only relevant in the parent, so no particular fork()-related handling is needed. The internal locks are relevant, but there is no interaction with the child to consider. (4) Multi-threaded, calls into OpenSSL after fork() This is the case where the pthread_atfork() hooks to ensure that all global locks are in a known state across fork() would come into play, per the above discussion. However, these "calls into OpenSSL after fork()" are still subject to the restriction to async-signal-safe functions. Since OpenSSL uses all sorts of locking and libc functions that are not on the list of safe functions (e.g., malloc()), this case is not currently usable and is unlikely to ever be usable, independently of the locking situation. So, there is no need to go through contortions to attempt to support this case in the one small area of locking interaction with fork(). In light of the above analysis (thanks @davidben and @achernya), go back to the simpler implementation that does not need to distinguish "library-global" locks or to have complicated atfork handling for locks. Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from https://github.com/openssl/openssl/pull/5089) | 31 January 2018, 18:25:28 UTC |
| 94f1c93 | Richard Levitte | 31 January 2018, 14:24:24 UTC | Remove "dummy" BIO create and destroy functions They aren't needed if all they do is set bio->init = 1 and zero other fields that are already zeroed Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5223) | 31 January 2018, 16:45:11 UTC |
| 7f55808 | Richard Levitte | 31 January 2018, 10:17:32 UTC | BIO: at the end of BIO_new, declare the BIO inited if no create method present Without this, every BIO implementation is forced to have a create method, just to set bio->init = 1. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5223) | 31 January 2018, 16:45:11 UTC |
| 2e230e8 | Dr. Matthias St. Pierre | 30 January 2018, 22:53:57 UTC | crypto/rand/rand_lib.c: fix undefined reference to `clock_gettime' Some older glibc versions require the `-lrt` linker option for resolving the reference to `clock_gettime'. Since it is not desired to add new library dependencies in version 1.1.1, the call to clock_gettime() is replaced by a call to gettimeofday() for the moment. It will be added back in version 1.2. Signed-off-by: Dr. Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from https://github.com/openssl/openssl/pull/5199) | 31 January 2018, 16:16:40 UTC |
| 85d6ad3 | Peter Meerwald-Stadler | 31 January 2018, 00:16:51 UTC | Configure: Fix configdata.pm shorthand for --dump, should be -d INSTALL: Mention 'aria' algorithm for no-<alg> Signed-off-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net> Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Ben Kaduk <kaduk@mit.edu> (Merged from https://github.com/openssl/openssl/pull/5215) | 31 January 2018, 00:16:51 UTC |
| 9be6433 | Richard Levitte | 30 January 2018, 18:13:11 UTC | Fix small typo (parenthesis missing) Fixes #5207 (another PR) Reviewed-by: Ben Kaduk <kaduk@mit.edu> (Merged from https://github.com/openssl/openssl/pull/5210) | 30 January 2018, 18:13:57 UTC |
| 26f0340 | Richard Levitte | 30 January 2018, 16:21:12 UTC | Configure: when checking user input, check both %user and %useradd Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5207) | 30 January 2018, 18:08:49 UTC |
| 6346881 | Richard Levitte | 30 January 2018, 16:16:13 UTC | Configure: add configure command line C flags after the configured C flags Fixes #5203 Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5207) | 30 January 2018, 18:08:49 UTC |
| 3faa07b | Matt Caswell | 29 January 2018, 14:19:52 UTC | Move decisions about whether to accept reneg into the state machine If a server receives an unexpected ClientHello then we may or may not accept it. Make sure all such decisions are made in the state machine and not in the record layer. This also removes a disparity between the TLS and the DTLS code. The TLS code was making this decision in the record layer, while the DTLS code was making it later. Finally it also solves a problem where a warning alert was being sent during tls_setup_handshake() and the function was returning a failure return code. This is problematic because it can be called from a transition function - which we only allow fatal errors to occur in. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5190) | 30 January 2018, 11:28:12 UTC |
| bf01fbb | Richard Levitte | 29 January 2018, 22:17:43 UTC | Add a 'reconfigure' make target Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5197) | 30 January 2018, 11:04:21 UTC |
| 85b8bea | Richard Levitte | 29 January 2018, 21:49:50 UTC | Restore perl variables for ENGINESDIR and OPENSSLDIR For proper escaping, we need the direct perl variable values, not a make variable reference. Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5196) | 29 January 2018, 21:49:50 UTC |
| 1edd899 | Richard Levitte | 29 January 2018, 20:54:52 UTC | Fix typo in Windows makefile template: quotify, not quotiry Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5196) | 29 January 2018, 20:58:56 UTC |
| 7187f0e | Richard Levitte | 29 January 2018, 17:33:32 UTC | To make it less surprising and confusing, leave a message on configdata.pm This message will ONLY be visible in OpenSSL 1.1.1, it will not show in 1.1.1a or any other release or update. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5185) | 29 January 2018, 20:56:48 UTC |
| 2da0130 | Richard Levitte | 29 January 2018, 17:22:33 UTC | Make Travis and Appveyor display the configuration data dump Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5185) | 29 January 2018, 20:56:48 UTC |
| 917a1b2 | Richard Levitte | 29 January 2018, 17:19:36 UTC | Document the use of configdata.pm as a script Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from https://github.com/openssl/openssl/pull/5185) | 29 January 2018, 20:56:48 UTC |
