| 13109fc | Axel Naumann | 19 May 2020, 08:06:52 UTC | "Update ROOT version files to v6.21/02." | 19 May 2020, 08:06:52 UTC |
| 78a5026 | Axel Naumann | 19 May 2020, 07:55:49 UTC | [relnotes] Update date. | 19 May 2020, 07:55:49 UTC |
| 97c62d4 | Axel Naumann | 18 May 2020, 10:20:44 UTC | [io] Protect out-of-bounds access in R__WriteDestructorBody: Fixes assert in roottest/root/meta/MakeProject/runcms310.C ``` /builddir/build/BUILD/gcc-8.3.1-20190223/obj-x86_64-redhat-linux/x86_64-redhat-linux/libstdc++-v3/include/bits/basic_string.h:1067: std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::operator[](std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type) [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::reference = char&; std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::size_type = long unsigned int]: Assertion '__pos <= size()' failed. at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3531 subClasses=0x7fffffff8db0, top=true) at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3772 subClasses=0x7fffffff8db0, extrainfos=0x7fffffff9210) at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TStreamerInfo.cxx:3976 at /mnt/build/wsincrmaster/LABEL/ROOT-fedora29/SPEC/python3/root/io/io/src/TFile.cxx:2843 ``` where ``` (gdb) p inside $1 = std::vector of length 3, capacity 4 = {"std::vector", "std::pair<edm::BranchKey,edm::BranchDescription>", ""} ``` | 18 May 2020, 16:00:37 UTC |
| 46303d6 | Philippe Canal | 18 May 2020, 15:08:10 UTC | Revert "Load dependent libraries as part of AutoLoading." This reverts commit 3845f8a06df8f90e1e5a6efa40969f9074210c4e. | 18 May 2020, 15:08:10 UTC |
| 07d2316 | Philippe Canal | 18 May 2020, 15:07:31 UTC | NFC: white space | 18 May 2020, 15:07:31 UTC |
| 3845f8a | Philippe Canal | 29 April 2020, 00:07:00 UTC | Load dependent libraries as part of AutoLoading. Since the proper creation of the TClass will require the dictionary for all its component let load all the dependent library too. Note that even with explicit linking, the dictionary may not be loaded as part of the 'main' library when the dictionary is a library separate from the classes' code (see ATLAS setup for example) This solves ROOT-10663. | 18 May 2020, 15:05:29 UTC |
| 9709188 | Bertrand Bellenot | 15 May 2020, 11:32:41 UTC | Fix potential startup error messages on Windows Fix the following error messages displayed when starting ROOT compiled with a different version of Visual Studio than the one installed on the system: ``` In file included from input_line_3:38: In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:142:12: error: redefinition of '_CrtEnableIf<true, _Ty>' struct _CrtEnableIf<true, _Ty> ^~~~~~~~~~~~~~~~~~~~~~~ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:142:12: note: previous definition is here struct _CrtEnableIf<true, _Ty> ^ In file included from input_line_3:38: In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:517:16: error: redefinition of '__crt_locale_data_public' typedef struct __crt_locale_data_public ^ C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\crtdefs.h:10:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ In file included from input_line_3:38: In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:524:16: error: redefinition of '__crt_locale_pointers' typedef struct __crt_locale_pointers ^ C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\crtdefs.h:10:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ In file included from input_line_3:38: In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\\include\cassert:9: In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12: C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h:532:16: error: redefinition of '_Mbstatet' typedef struct _Mbstatet ^ C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\crtdefs.h:10:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\assert.h:12:10: note: 'C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\ucrt\corecrt.h' included multiple times, additional include site here ^ ``` | 18 May 2020, 15:01:04 UTC |
| 78c4989 | Bertrand Bellenot | 15 May 2020, 19:44:10 UTC | Filter out non existing library name (there is only a dll) This fixes an issue with ACLiC trying to link against `msvcp140.lib` which doesn't exist (there is only `msvcp140.dll`) | 18 May 2020, 14:58:14 UTC |
| 83502c8 | Lorenzo Moneta | 18 May 2020, 08:23:44 UTC | Add RConfigure preprocessor flag for pymva and rmva (R__HAS_PYMVA) and (R__HAS_RMVA) (#5630) * Add preprocessor flag in RConfigure.h for pymva and rmva * Enable RMVA when R is found and tmva is on * Update CNN and RNN tutorial to work also when ROOT is built without Pymva | 18 May 2020, 08:23:44 UTC |
| 9daf978 | Lorenzo Moneta | 18 May 2020, 08:22:20 UTC | Fix multithread fitting in case of ThnSparse and bin integral fits (#5626) * Fix case when ROOT is running with MT and TVIrtualFitter pointer to last fitter is not present * Fix multithread fitting when computing a bin intengral or re-normalizing by the bin volume (case of Thnsparse fit). The fix is applied for both least-square and binned likelihood fit Improve stressHistoFit test. Add option "-t" to run in multi-thread mode. Add the option X for fitting to make sure chi2 method is run Now all stresshistofit tests pass in multi-thread mode. Note that when computing integral in multi-thread only the GuassIntegrator of mathcore is thread safe for 1D. Also the AdaptiveIntegratorMultiDim, used in the multi-dim case, is thread safe. * Remove non-thread safe access to BinData::BinEdge also in other fitting functions and replace them with the thread safe version | 18 May 2020, 08:22:20 UTC |
| f6d0739 | Philippe Canal | 17 May 2020, 12:50:23 UTC | Merge pull request #5597 from pcanal/ROOT-9535 Avoid streaming a copy of the TPaveStats parent during the TH1 cloning process. | 17 May 2020, 12:50:23 UTC |
| 2bdae46 | Vaibhav | 14 May 2020, 19:36:44 UTC | Make xtimec.h and xthreads.h textual in std_msvc.modulemap | 16 May 2020, 10:45:57 UTC |
| ba383e2 | Massimiliano Galli | 15 May 2020, 12:41:11 UTC | [CMake][Exp PyROOT] Remove cached Python related variables This is needed because doesn't allow incremental builds to work correctly. In the case of multiple python, the second time we would wrongly enter the if(PYTHON_EXECUTABLE) case because PYTHON_EXECUTABLE is cached, but in this case PyROOT would be built only for one version. | 15 May 2020, 20:17:09 UTC |
| a284738 | Massimiliano Galli | 15 May 2020, 10:08:07 UTC | [CMake][Exp PyROOT] Define PYTHON_VERSION_MAJOR_Development_Main and PYTHON_VERSION_MINOR_Development_Main everywhere | 15 May 2020, 20:17:09 UTC |
| cb9628e | Massimiliano Galli | 15 May 2020, 09:49:57 UTC | [CMake][Exp PyROOT] Change PYTHON_VERSION to PYTHON_VERSION_STRING for old CMake | 15 May 2020, 20:17:09 UTC |
| 0cfcbd6 | Massimiliano Galli | 15 May 2020, 08:25:15 UTC | [JupyROOT] Fix CMake Python variables for ROOT C++ kernel | 15 May 2020, 20:17:09 UTC |
| cf769cc | Massimiliano Galli | 15 May 2020, 08:18:05 UTC | [CMake][Exp PyROOT] Fix PYTHON_EXECUTABLE for cmdLineUtils | 15 May 2020, 20:17:09 UTC |
| 3f5ccf2 | Massimiliano Galli | 15 May 2020, 08:03:46 UTC | [CMake][PyROOT] Fix Python varables for old PyROOT | 15 May 2020, 20:17:09 UTC |
| 3598c5f | Massimiliano Galli | 15 May 2020, 07:54:36 UTC | [CMake][Exp PyROOT] Fix PYTHON_EXECUTABLE for pyunittests | 15 May 2020, 20:17:09 UTC |
| d3a6c4a | Massimiliano Galli | 15 May 2020, 07:45:37 UTC | [CMake][Exp PyROOT] Fix Python variables for tutorials | 15 May 2020, 20:17:09 UTC |
| bbaba38 | Massimiliano Galli | 15 May 2020, 07:43:01 UTC | [CMake][Exp PyROOT] Rename variable in info messages | 15 May 2020, 20:17:09 UTC |
| 4baf68e | Omar Zapata | 15 May 2020, 15:03:19 UTC | [ROOT-10755] fixed X11 thread initialization (#5608) | 15 May 2020, 15:03:19 UTC |
| 33007b7 | Jakob Blomer | 14 May 2020, 21:25:01 UTC | [ntuple] fix building of inner field type names | 15 May 2020, 12:07:07 UTC |
| 877c8bf | Jakob Blomer | 14 May 2020, 21:24:36 UTC | [ntuple] minor unit test improvement | 15 May 2020, 12:07:07 UTC |
| 0af445a | Jakob Blomer | 14 May 2020, 13:46:44 UTC | [ntuple] fix parsing of type names with spaces | 15 May 2020, 12:07:07 UTC |
| 7daf36e | Sergey Linev | 15 May 2020, 08:46:37 UTC | [cmake] remove unused windows part in ROOT_LINKER_LIBRARY | 15 May 2020, 10:07:15 UTC |
| 302b5e8 | Bertrand Bellenot | 27 April 2020, 18:45:26 UTC | Fix redirection (`.> blah.txt`) on Windows Fix output redirection (`.> blah.txt`) which is curently freezing the console input on Windows When a file (or console) has been created without the `FILE_SHARE_READ | FILE_SHARE_WRITE` flags, there is no way to change this, but by closing it and re-opening it (or a new one) . And I suspect that a standard console doesn't have those flags, so when redirecting the output to a file with `.> blah.txt`, all the output is going to the file, without any echo on the console, and when typing `.>` to suppress the redirection, the file contains this kind of errors: ``` Error 6 in textinput::TerminalDisplayWin attaching to console output: The handle is invalid. Error 6 in textinput::TerminalDisplayWin attaching / getting console info: The handle is invalid. Error 6 in textinput::TerminalDisplayWin writing to output: The handle is invalid. ``` This patch solves those issues, even if I'm not sure if it is the root of the problem (it might be something else deep in the `MetaSema::actOnRedirectCommand` function). NB I don't know if this can have any side effect, but I didn't see any so far... And for info, one could Enable Console Virtual Terminal Sequences (ANSI escape code) that can control cursor movement, color/font mode, and other operations when written to the output stream by adding the ENABLE_VIRTUAL_TERMINAL_PROCESSING flag, but then it breaks the WRAP_AT_EOL_OUTPUT. With this feature, the escape sequences like `\033[39m` would work in the Windows 10 command prompt as well. This is a known issue, see https://github.com/microsoft/terminal/issues/349 | 15 May 2020, 07:31:59 UTC |
| 673e19b | Axel Naumann | 15 May 2020, 07:24:21 UTC | [githubaction] Switch to Outlook as from/smtp server. | 15 May 2020, 07:24:21 UTC |
| e3f88b3 | Bertrand Bellenot | 14 May 2020, 18:58:05 UTC | Fix potential crash at startup on Windows When starting root.exe on Windows with a version of Visual Studio different than the one used to build ROOT, it mighty crash with the following error: Assertion failed: !isNull() && "Cannot retrieve a NULL type pointer", file C:\build\ws\BUILDTYPE\Debug\LABEL\windows10\V\6-20\root\interpreter\llvm\src\tools\clang\include\clang/AST/Type.h, line 630 This patch fixes the issue. | 15 May 2020, 06:21:13 UTC |
| 05029da | Massimiliano Galli | 13 May 2020, 11:18:13 UTC | [CMake][Exp PyROOT] Split CMake Python variables in ROOT and PyROOT/PyMVA related These changes address the case in which Python 3 has only Interpreter while Python 2 has both Interpreter and Development. In this case, the Python used to build ROOT (which requires only Interpreter) will be 3, but PyROOT (which requires also Development) will be built only for 2. To achieve this, ROOT and PyROOT/PyMVA use now two different sets of variables. Documentation for the whole machinery is also added. It is also worth pointing out that the entire machinery could be much simplified by just requiring the following as a prerequisite for ROOT: - CMake >= 3.12.4 - Python-Development package | 14 May 2020, 18:16:55 UTC |
| fa76d33 | Bertrand Bellenot | 14 May 2020, 12:27:58 UTC | Fix (disable) roofit tests failing on Windows | 14 May 2020, 15:35:30 UTC |
| 6e3cb15 | Vaibhav Garg | 14 May 2020, 14:12:00 UTC | [wincxxmodules] Fix std and libc modules on Windows (#5610) [wincxxmodules] Fix std and libc modules on Windows | 14 May 2020, 14:12:00 UTC |
| f9a3d33 | Mattias Ellert | 14 May 2020, 14:05:11 UTC | Correct broken assert statements (#5159) | 14 May 2020, 14:05:11 UTC |
| 768d598 | Bertrand Bellenot | 14 May 2020, 07:31:12 UTC | Fix dataframe_interface test on Windows (#5612) * Fix dataframe_interface test on Windows * Reduce the amount of ifdef'd code (thanks Enrico for the review) * Fix warning: declaration of type shadows a global declaration | 14 May 2020, 07:31:12 UTC |
| 40673e5 | Axel Naumann | 13 May 2020, 13:12:28 UTC | Also capture SFINAE error counts (ROOT-10754): When doing lookup on templates, instantiation can fail. This can be triggered during templarte instantiation somewhere in clang, autoloading, cling-lookup - and SFINAE errors that occurr in cling-lookup must not bubble up to clang, or else clang will think that there was a problem (where there was none - just e.g. ROOT trying to autoload a bogus template). In this concrete case, a template specialized with a lambda was not found by clang, was tried to be autoloaded, TMetaUtils produced a broken normalized type name, lookup on the broken type name failed with a SFINAE error - and that ended up being swallowed by a clang SFINAETrap by the topmost lookup. Instead, keep SFINAE errors to ourselves. | 13 May 2020, 17:34:19 UTC |
| 20e3b36 | Enrico Guiraud | 13 May 2020, 13:49:37 UTC | Revert "[DF] Work around cling+shared_ptr issues" This reverts commit fdd543f9b3a0f32c93df816dff0de3b5ade7d4d9. | 13 May 2020, 17:34:19 UTC |
| 18141e2 | Enrico Guiraud | 13 May 2020, 13:48:43 UTC | Revert "[DF] More working around cling+shared_ptr issues" This reverts commit b2033ecbef50edd4148da2fc800e630e1d60fe9c. | 13 May 2020, 17:34:19 UTC |
| 89a243e | Sergey Linev | 13 May 2020, 16:12:05 UTC | Release notes about includes optimization Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> | 13 May 2020, 16:12:05 UTC |
| 3cf5f94 | Axel Naumann | 13 May 2020, 09:27:28 UTC | [ghaction] Use gmail SMTP server! | 13 May 2020, 09:27:28 UTC |
| 30ef625 | Axel Naumann | 13 May 2020, 09:14:45 UTC | [ghaction] Use our root-git as from:, through out gmail account. | 13 May 2020, 09:14:45 UTC |
| ab9d7d5 | Massimiliano Galli | 12 May 2020, 11:30:55 UTC | [CMake][Exp PyROOT] Split if(PythonX_Development_FOUND) condition The reason for this split is that Development is not required, hence we can't rely on it being found to set variables which are usually set even if only Interpreter (and NOT Development) is found. The if(PythonX_Development_FOUND) condition is kept for what concern the variables set and used only for the secondary Python version used to biuld PyROOT, since Development is required for PyROOT. In the info messages related to PyROOT, the condition to be printed now requires both PythonX_Interpreter_FOUND and PythonX_Development_FOUND, in order to avoid them to be printed in case Development is found but not Interpreter. | 13 May 2020, 08:27:52 UTC |
| d534c19 | Pratyush Das | 27 April 2020, 13:34:54 UTC | [cling][cpt]Fix tar_required logic If all requirements were satisfied, tar_required would always be false. This commit fixes it. | 13 May 2020, 07:19:14 UTC |
| 12a8d23 | Pratyush Das | 04 May 2020, 12:20:19 UTC | Fix cmake requirement | 13 May 2020, 07:18:56 UTC |
| c074b55 | Pratyush Das | 04 May 2020, 11:34:34 UTC | Fix svn installation | 13 May 2020, 07:18:56 UTC |
| 6cd79cc | Pratyush Das | 04 May 2020, 09:06:37 UTC | Fix distro requirement (and installation of pip) There might be an issue when using conda as default Python for Python3 because conda calls it pip but otherwise it is pip3. | 13 May 2020, 07:18:56 UTC |
| 5711611 | Vaibhav | 11 May 2020, 04:49:22 UTC | [winxxmodules] Create vcruntime.modulemap for use in Windows | 13 May 2020, 05:24:33 UTC |
| 7847502 | Axel Naumann | 12 May 2020, 20:24:33 UTC | Test email commit notification with GH action. | 12 May 2020, 20:24:33 UTC |
| db2a435 | Stephan Hageboeck | 12 May 2020, 09:21:15 UTC | [RF] Code cleanups. In checking for older bugs, some NFC code cleanups were done, and documentation or messages were improved. | 12 May 2020, 18:18:38 UTC |
| 97c72af | Stephan Hageboeck | 12 May 2020, 09:20:10 UTC | [RF] Add tests ROOT-4580 and ROOT-9528. In checking old bug reports, tests for two bugs were written. Although the bugs had been fixed as side effects of modernisations or other bug fixes, having those tests in place won't do harm. | 12 May 2020, 18:18:38 UTC |
| de1bf03 | Lorenzo Moneta | 12 May 2020, 16:13:40 UTC | Fix compilation of cuda with C++14 when normal ROOT is compile with C++17 which has std::string_view (#5598) Fix it by modifying the pre-processor macros defined in RCOnfigure.h when compiling Cuda. A better fix would be to remove the TString dependency in the Cuda compiled code. TString is used when doing I/O of the DeepNet layers to XML. In principle this code could be moved out of Cuda | 12 May 2020, 16:13:40 UTC |
| a6476a9 | Enrico Guiraud | 11 May 2020, 16:29:05 UTC | [DF] Always check that arg types in jitted code are valid Snapshot, Cache, Define and Filter did not check that the types of columns used as arguments in jitted code were valid (in particular, that the type of custom columns was correctly understood by cling). This patch provides a function that performs the validity check, GetValidatedArgTypes, that is used everywhere instead of GetColumnTypes (now unused and therefore deleted) and ColumnName2ColumnTypeName. An exception with a user-friendly error message is thrown in case of error, which fixes ROOT-10458. | 12 May 2020, 15:35:20 UTC |
| fc28573 | Enrico Guiraud | 11 May 2020, 14:04:27 UTC | [DF] Add test for ROOT-10458, "sub-par diagnostics for interpreted types" | 12 May 2020, 15:35:20 UTC |
| 640b345 | Enrico Guiraud | 11 May 2020, 13:53:41 UTC | [DF][NFC] Remove redundant namespace specifier | 12 May 2020, 15:35:20 UTC |
| e29c31b | Axel Naumann | 04 May 2020, 09:52:22 UTC | [treeplayer] Add test against picking up wrong leaf count. | 12 May 2020, 15:14:43 UTC |
| d872cf0 | Axel Naumann | 23 April 2020, 07:20:32 UTC | [treeplayer] Try harder to find leaf count (ROOT-10397): Before, the leaf count was assumed to exist at the same level as the leaf to be read, e.g. a.b.x[n] would look for a.b.n. That fails if n is coming from a "higher level". Now, TUIntOrIntReader also looks for a.n and n, if a.b.n is not found. And add the repro test for this. | 12 May 2020, 15:14:43 UTC |
| 2887019 | Olivier Couet | 12 May 2020, 14:26:32 UTC | Improve SetOptFit doc (#5602) * Improve SetOPtFit doc * 000111 != 1111 | 12 May 2020, 14:26:32 UTC |
| cebff1e | Stefan Wunsch | 11 May 2020, 13:35:57 UTC | [cppyy] Fix name matching of std::initializer_list * Our type system has an implicit std:: in contrast to cppyy, which has the namespace explicitely in the type name * Added a patch file | 12 May 2020, 12:02:59 UTC |
| db69bf6 | Stefan Wunsch | 11 May 2020, 08:12:17 UTC | [cppyy] Port upstream changes to fix inheritance in Python * Fixing inheritance of C++ classes in Python and callbacks to C++ with object created in Python * See upstream issue https://bitbucket.org/wlav/cppyy/issues/229/issue-with-python-class-that-derives-from * Ports following commits of cppyy-backend: 4670bcf0d82d2f1650f739115576a884f51340f6 * Ports following commits of CPyCppyy: 9d0eca19281a0f38c9cd80628279f1c76f5fe71c, 398347bd01b693d0f4e7d2c6cef5c9d30adba2b5, 96de8a868b214eeb4be0f4be4914224ba7de6805 * Related to ROOT-10582 | 12 May 2020, 12:02:59 UTC |
| 2ba4e8b | Oksana Shadura | 12 May 2020, 10:27:07 UTC | Add prefix for Glew builds in Windows Co-authored-by: Bertrand Bellenot <bellenot@users.noreply.github.com> | 12 May 2020, 11:58:05 UTC |
| ec33abe | Oksana Shadura | 11 May 2020, 13:08:32 UTC | Make Glew on MSVC static library while shipping it on other platforms as shared library | 12 May 2020, 11:58:05 UTC |
| ff634af | Oksana Shadura | 08 May 2020, 16:00:17 UTC | Since glew.h is directly used/included in ROOT's public interfaces, the correct way will be to ship it as well with ROOT | 12 May 2020, 11:58:05 UTC |
| cdc074a | Enrico Guiraud | 11 May 2020, 17:48:23 UTC | [TThreadedObject] Fix usage of condition variable in test Setting the flag must be protected by a lock. | 12 May 2020, 08:01:41 UTC |
| 4da5341 | Stephan Hageboeck | 12 May 2020, 06:27:13 UTC | [RF] Fix crash in RooAbsAnaConvPdf. RooAbsAnaConvPdf was carrying around a RooArgSet, which was not used anywhere. This RooArgSet, however, was carrying around a pointer to a variable, which becomes a dangling pointer when one creates copies of the RooAbsAnaConvPdf and deletes the original. Removing this member fixes crashes when invoking copy constructors. | 12 May 2020, 06:27:13 UTC |
| 73a7a10 | Lorenzo Moneta | 11 May 2020, 08:59:01 UTC | Suppress Vc compilation warnings observed in gcc version 10 The warnings are coming when including the Vc/Vc header : warning: ‘V2 Vc_1::Vector<T, Vc_1::VectorAbi::Scalar>::reinterpretCast() const’ is deprecated: use reinterpret_components_cast instead [-Wdeprecated-declarations] Add a pragma to suppress -Wdeprecated-declarations in Types.h | 11 May 2020, 19:48:54 UTC |
| 12c16d6 | Sergey Linev | 11 May 2020, 16:04:20 UTC | Set proper includes path for RLogger.cxx (ROOT-10765) It compiled when c++14 or hight standard is specified and not only with root7=ON | 11 May 2020, 19:43:32 UTC |
| e7e0653 | Stephan Hageboeck | 11 May 2020, 16:43:45 UTC | [RS] Fix ROOT-2558, SPlot cannot deal with ratios. Add the possibility to use ratios as yield parameters in SPlot. Also update the documentation of SPlot, and add a test. | 11 May 2020, 16:43:45 UTC |
| e2c9e16 | Olivier Couet | 11 May 2020, 09:18:06 UTC | Complete BELLE II Style (#5581) * Complete BELLE II Style * Update release notes | 11 May 2020, 09:18:06 UTC |
| 299d4e5 | Massimiliano Galli | 08 May 2020, 12:19:37 UTC | [CMake][Exp PyROOT] Use find_package(PythonX) also in the build with one Python version find_package(Python) seems to have the following unsexpected behavior: if Python_EXECUTABLE is specified to e.g. /usr/bin/python3 and DEVELOPMENT is required but not found, then CMake looks for the development package of python2. If it succeeds, Python_INCLUDE_DIRS and Python_LIBRARIES are set as a consequently. This brings to a mismatch between the variables set, since they refer to different python versions. To avoid this, we use find_package(PythonX) also for the build with one version of Python. | 11 May 2020, 08:25:18 UTC |
| ee4cd90 | Sergey Linev | 08 May 2020, 12:22:06 UTC | [cmake] set 3.9 as required version in tests | 11 May 2020, 06:19:29 UTC |
| 4d026f3 | Sergey Linev | 08 May 2020, 08:23:55 UTC | [cmake] adjust periodic cmake file | 11 May 2020, 06:19:29 UTC |
| 701e961 | Sergey Linev | 07 May 2020, 18:56:38 UTC | [cmake] clarify why find_package(ROOT) still used somewhere | 11 May 2020, 06:19:29 UTC |
| 994454e | Sergey Linev | 07 May 2020, 18:08:59 UTC | [cmake] remove ROOT_INCLUDE_DIRS from tmva tests | 11 May 2020, 06:19:29 UTC |
| 555c9f6 | Sergey Linev | 07 May 2020, 17:31:07 UTC | [cmake] adjust math cmake files for tests Allow to use some of them outside ROOT - genetic/minuit2 In tests for mathcore/mathmore do not use find_package(ROOT) and its variables | 11 May 2020, 06:19:29 UTC |
| f03738c | Sergey Linev | 07 May 2020, 14:35:37 UTC | [cmake] reduce includes usage in test | 11 May 2020, 06:19:29 UTC |
| b4ceffb | Sergey Linev | 07 May 2020, 13:37:03 UTC | [cmake] do not populate source dirs in ROOT_INCLUDE_DIRS When using source bilds, all necessary source includes will be provided via dependencies. When using installed root, anyway ${CMAKE_BINARY_DIR}/include has to be used | 11 May 2020, 06:19:29 UTC |
| 5505e9d | Sergey Linev | 09 May 2020, 15:09:34 UTC | [cmake] set variable in parent scope at very end | 09 May 2020, 19:06:50 UTC |
| 69fc6f8 | Enrico Guiraud | 08 May 2020, 14:18:10 UTC | [TTreeReader][NFC] Add docs for IsValid/GetSetupStatus | 08 May 2020, 22:10:12 UTC |
| 70e68c6 | Enrico Guiraud | 08 May 2020, 14:06:07 UTC | [TTreeReader] Make ESetupStatus values non-ambiguous TTreeReaderValueBase::ESetupStatus contained two enumerators with value -7 and two with value 0. In both cases, one of the ambiguous enumerators was actually unused, and it was changed to have an unambiguous value. | 08 May 2020, 22:10:12 UTC |
| a304ed7 | Martin Ritter | 08 May 2020, 13:35:02 UTC | Add Belle2 style to the list of styles (#5550) | 08 May 2020, 13:35:02 UTC |
| 54c1794 | Lorenzo Moneta | 08 May 2020, 12:38:39 UTC | Fix Multiclass classification for TMVA Deep Learning (#5553) * Fix the multi-class classification for MethodDL by using as default for the outputlayer a width equal to the number of classes. Update multiclass tutorial to use MethodDL * Make sure input file is generated with 2000 events. Use a different name to not mix with other tutorials * Update input file for TMVAMulticlassApplication.C * Update multiclass tutorials to use input file from root.cern.ch as suggested by review comment of Stefan Add also some other small improvements | 08 May 2020, 12:38:39 UTC |
| aef7306 | Olivier Couet | 08 May 2020, 11:53:17 UTC | Computation of fHistogram limits were different in Paint and GetHistogram (#5578) | 08 May 2020, 11:53:17 UTC |
| c1eff61 | Massimiliano Galli | 07 May 2020, 12:45:54 UTC | [CMake][Exp PyROOT] Hardcode PYTHON_EXECUTABLE in python scripts shebang The ROOT command line tools (e.g. rootls, rootmkdir, ...) are configured with a header that tells the script which python to use. In the old approach, what was written in that header was just the name of the Python binary file in ${PYTHON_EXECUTABLE}, while the path was stripped out. This led to an issue with the brew installation on MacOs, since ROOT was built with a python3 installation (3.8 to be more exact) and therefore "python3" was injected in the header of the command line tools. However, the system had another python3 installation (3.7), which was the one executed when just running "python3". This caused that the command line tools ran with a different python installation than the one ROOT was built with, and this led to a crash (ROOT-10720). This commit solves the issue by injecting the full path to the (highest) python ROOT was built with in the header of the command line tools. | 08 May 2020, 07:40:03 UTC |
| 020d9fb | Vassil Vassilev | 07 May 2020, 14:31:34 UTC | Improve modules docs. Add readme entry. | 07 May 2020, 17:52:02 UTC |
| e5a24cd | Stephan Hageboeck | 07 May 2020, 13:16:54 UTC | [RF][Docs] Improve RooAbsPdf::plotOn() documentation. | 07 May 2020, 17:46:16 UTC |
| 310a6b4 | Stephan Hageboeck | 07 May 2020, 09:38:50 UTC | [RF] Enable overriding the default plotting range after a fit. [ROOT-10737] When plotting a PDF after a fit, the PDF is automatically plotted only in the fit range. Although this is usually desired, overriding the plot and normalisation range should be possible. | 07 May 2020, 17:46:16 UTC |
| 46d4d17 | Vassil Vassilev | 07 May 2020, 14:07:18 UTC | [doc] The issues in section current limitations are resolved. | 07 May 2020, 17:08:18 UTC |
| c50560f | Axel Naumann | 07 May 2020, 15:47:49 UTC | Update year in banner. | 07 May 2020, 15:47:56 UTC |
| bd7bf3f | Oksana Shadura | 07 May 2020, 13:00:10 UTC | Add correct target GLEW::GLEW in case of external Glew (not builtin) | 07 May 2020, 14:16:51 UTC |
| 8454ed3 | Vassil Vassilev | 07 May 2020, 13:38:47 UTC | [cling] Even when library has no symbols to offer initialize the filter. This is part of root-project/root#4717 | 07 May 2020, 13:41:42 UTC |
| eea4eec | Sergey Linev | 07 May 2020, 09:46:35 UTC | [ipython] disable key handling in JSROOT While iPythonNotebooks web page typically has scrolling and edit area, keyboard events uses for different operations. Therefore JSROOT should not process there events for zooming or camera moving in 3D | 07 May 2020, 12:16:34 UTC |
| 5d6e0ec | Vassil Vassilev | 07 May 2020, 11:21:18 UTC | Adjust asserts. This is part of root-project/root#4717 | 07 May 2020, 11:51:38 UTC |
| 913291d | Sergey Linev | 07 May 2020, 09:18:24 UTC | jsroot dev 7/05/2020 with RStatBox support Use RDrawableRequest to configure individual zooming ranges and use them in RStatBox for histogram statistic calculations | 07 May 2020, 11:25:02 UTC |
| a957292 | Sergey Linev | 07 May 2020, 09:14:38 UTC | Update several v7 tutorials with RCanvas | 07 May 2020, 11:25:02 UTC |
| e95d23c | Sergey Linev | 07 May 2020, 08:33:27 UTC | [rframe] provide connection id for drawable display context Connection id can be used to provide client-dependent output Also there is always master connection flag. Use connection info in RFrame and RStatBox when processing ranges requests | 07 May 2020, 11:25:02 UTC |
| 5a0acf1 | Sergey Linev | 06 May 2020, 16:06:58 UTC | [rframe] move RUserRange class into RFrame It is central place where it used and applied. Move also Request and Reply classes into correspondent drawables | 07 May 2020, 11:25:02 UTC |
| 5ed714f | Sergey Linev | 06 May 2020, 15:30:20 UTC | [rframe] Change zoom logic in RCanvas RFrame keep track of selected zoom range for each client. Every client sends update when zooming is changed. Statbox request changes when zooming is changed on client side. On server side statbox gets necessary range settings, which was transferred already by frame | 07 May 2020, 11:25:02 UTC |
| 7056cb7 | Sergey Linev | 21 April 2020, 15:43:30 UTC | [rdrawable] provide API to extract current user range in the pad Visible range may depend on different components like RFrame or RHistDrawable. Such range required to calculate statistic for the statbox or implement improved histogram display. | 07 May 2020, 11:25:02 UTC |
| 9e02038 | Sergey Linev | 21 April 2020, 12:16:48 UTC | [rdrawable] introduce RDisplayContext class for RDrawable This object provided to RDrawable::Display() method as argument and give contexts - canvas, sub-pad, primitive index. Same context made available for RDrawableRequest | 07 May 2020, 11:25:02 UTC |
| 7384b51 | Sergey Linev | 21 April 2020, 15:43:30 UTC | [rdrawable] provide API to extract current user range in the pad Visible range may depend on different components like RFrame or RHistDrawable. Such range required to calculate statistic for the statbox or implement improved histogram display. | 07 May 2020, 11:25:02 UTC |
| c4e3e31 | Sergey Linev | 21 April 2020, 12:16:48 UTC | [rdrawable] introduce RDisplayContext class for RDrawable This object provided to RDrawable::Display() method as argument and give contexts - canvas, sub-pad, primitive index. Same context made available for RDrawableRequest | 07 May 2020, 11:25:02 UTC |
