https://github.com/root-project/root

sort by:
Revision Author Date Message Commit Date
3b109bc "Update ROOT version files to v6.23/99." 03 March 2021, 16:55:02 UTC
ce7772b "Update ROOT version files to v6.23/02." 03 March 2021, 16:32:09 UTC
392f621 [build] Adjust RVersion.h location after 3551b7c1f9f0. 03 March 2021, 16:32:09 UTC
36b06a4 'Hide' kOnlyPrepStep as a protected member of TObject. This enum will be removed shortly (functionality moved from TObject::Write to *::Merge) 03 March 2021, 15:39:17 UTC
c9c70ed [NFC] Improve documentation (TTreeCloner, TBufferMerger, TFileMerger) 03 March 2021, 15:39:17 UTC
f2ac153 [NFC] Coding style 03 March 2021, 15:39:17 UTC
30fd4c7 TFileMerger delete directory only if we induced its creation/loading 03 March 2021, 15:39:17 UTC
552e963 TFileMerger: only delete the directory if the merger created it. This is necessary to support the 'fast' incremental merge where the input will continue to be used. 03 March 2021, 15:39:17 UTC
48edbd1 Fix typo in comments 03 March 2021, 15:39:17 UTC
10bb9ca Inline TBufferMerger::GetBuffered 03 March 2021, 15:39:17 UTC
b888718 TIsAProxy: Don't record failed searches (a library might be loaded between now and the next search). 03 March 2021, 15:39:17 UTC
6da190d Sort data member of TIsAProxy 03 March 2021, 15:39:17 UTC
0a35e74 TIsAProxy switch fClass to non-atomic. Since fClass is modified only 'once' at init time of the IsAProxy object, it is actual more efficient to protect the initialization by a lock rather than having fClass being atomic. 03 March 2021, 15:39:17 UTC
fa07ea3 TIsAProxy retain last 8 matches (rather than 1). This allows to significant reduce the number of search through the list of cached result ... That search was a noticeable cause of slow down with an increase of number threads due to the contention on updating the number of readers (used for the local read/write lock mechanism). 03 March 2021, 15:39:17 UTC
52452f3 Skip compression of the top TKeys in the TMemFile by default. To save space, the compression can be re-enabled by TBuffferMerger::SetCompressTemporaryKeys. The TBaskets are still compressed and thus the end result is unchanged. 03 March 2021, 15:39:17 UTC
ef117fa TBufferMerger: Allow to disable explict call to Flush when no tree in file 03 March 2021, 15:39:17 UTC
1c0059f Mark TBufferMerger::fBuffered as atomic 03 March 2021, 15:39:17 UTC
f0a88ff Improve TClass::GetBaseClassOffset parallelism. TClass::GetBaseClassOffset is a 'often' used routine in the I/O. In the fast path (looking up in a cache), rather than taking the global read lock (which is not only global but also 'slower' than a regular mutex), we are now use a instance specific mutex to protect the cache. 03 March 2021, 15:39:17 UTC
59094eb TBufferMergerFile: Call FlushBasket in unlocked thread. Add new enum for TObject::Write: kOnlyPrepStep = BIT(3) ///< Just prepare the objects do not write them (i.e. call TTree::FlushBaskets) 03 March 2021, 15:39:17 UTC
76917ed TTreeCloner: do not clone empty basket 03 March 2021, 15:39:17 UTC
7073b09 AddLastBasket: do not update first basket start entry 03 March 2021, 15:39:17 UTC
aeab20f TBranch::AddBasket allow to replace an empty write basket 03 March 2021, 15:39:17 UTC
146ab17 Tree: micro-optimization 03 March 2021, 15:39:17 UTC
a2890db TFileMerger: Use obj in memory even if it has no key (yet) 03 March 2021, 15:39:17 UTC
a1166f3 Allow TBufferMerger to skip write/read cycle. If TBufferMerger can take the merge lock, then rather than queuing the input file, merge it immediately and skip the Writing the TTree, doing a memcpy, Pushing to the queue then Reading and then deleting parts. 03 March 2021, 15:39:17 UTC
6c10d63 In TFileMerger use obj in memory if available. Currently only in the case where we have a Merge function and a dictionary. 03 March 2021, 15:39:17 UTC
0c0e00b Switch off dubious 'optimization' For iteration over the list of baskets, the existing code try to reduce the range of the iteration to stop as soon as all non-nullptr slot have been seen. However to know the number of non-nullptr slot, the code (has to) call GetEntries which scan the entire array anyway ... 03 March 2021, 15:39:17 UTC
427f543 Use TObjArray::GetEntriesFast to avoid wasting time. TObjArray::GetEntries() counts the number of non-zero slots while TObjArray::GetEntriesFast() return (in most case) the value of a high water mark (the slot over which all remaining slots are empty). In one use case (doing read a TTree and do many TTree cloning (via TBufferMerger), TObjArray::GetEntries was taking 8% of the running time (compression was disabled) Note: TObjArray::IsEmpty use GetEntriesFast rather than GetEntries. 03 March 2021, 15:39:17 UTC
c4d94ef TFileMerger allow to delay the object writes. Limited to TTree and Histogram. 03 March 2021, 15:39:17 UTC
9822c08 Do not call CopyAddresses during TTree::Merge fast cloning operation. We do not apply the same to CloneTree as the addresses copying is a side-effect (no reset at the end) that is relied upon by user code.g 03 March 2021, 15:39:17 UTC
3ae112b Add TBufferMerger::GetBuffered. This can be used to monitor the queue size in bytes rather than number of files 03 March 2021, 15:39:17 UTC
eddc874 Make TBufferMerger::GetQueueSize thread safe. This can now be safely use to avoid overloading the queue. 03 March 2021, 15:39:17 UTC
e91fd1b Add TTree::InPlaceClone. This speeds up the first step of merging (hadd) 03 March 2021, 15:39:17 UTC
f8fc806 TTree::MergeTrees pass options to first Cloning. This allow the fast cloning of the first tree in the list when using TTree::MergeTrees (rare) 03 March 2021, 15:39:17 UTC
9396a98 Speed-up TBranch::GetMother. When fMother is not set, first try to use fParent rather than iterate through the TTree's list of top level branches 03 March 2021, 15:39:17 UTC
d4b36ee Set TBranch::fParent when reading. fParent was already set during the usual branch creation (TTree::Branch and friends) but might still be not set if the user create a hierarchy by hand 03 March 2021, 15:39:17 UTC
14875cb Remove stray duplicate line in TBranch::GetSubBranch 03 March 2021, 15:39:17 UTC
ac862cb Actually give priority to the TFileMergeInfo's feature request ... instead of just always ignoring it 03 March 2021, 15:39:17 UTC
450eafd TFileMerger: don't stop after the first RNTuple 03 March 2021, 15:39:17 UTC
d310b95 Remove the __type_info_node symbol from the exports list Don't export (expose) the '?__type_info_root_node@@3U__type_info_node@@A', this leads to the following error in some cases: MSVCRT.lib(tncleanup.obj) : error LNK2005: "struct __type_info_node __type_info_root_node" (?__type_info_root_node@@3U__type_info_node@@A) already defined in libCling.lib(libCling.dll) 03 March 2021, 10:47:25 UTC
cf3f37e Fix type printing of array template args Apply patch to interpreter/llvm/src/tools/clang/lib/AST/TemplateBase.cpp as suggested here: https://reviews.llvm.org/D36368 03 March 2021, 08:51:16 UTC
236cc68 [gui] do not use static array in TGFSComboBox Instead use std::vector which is much easier to manage 03 March 2021, 08:00:43 UTC
cbff71b [gui] use std::string in TGFSComboBox static variables Prevent memory leak, automatically cleanup at the end 03 March 2021, 08:00:43 UTC
779e1e5 [gui] Cleanup static entries in TGFSComboBox Every time when new instance was created, old dynamic entries were lost 03 March 2021, 08:00:43 UTC
5b06edd Add an info message in the INFO stream with topic Optimization when a new node is processed but an existing node with same name exists 02 March 2021, 22:07:32 UTC
07b358e Add normalization set variables in name of hist pdf that is created a s a cache. This avoids having same names of nodes when nset is present or not. This alone could fix ROOT-8947 but previous commit is a better fix for the genral case 02 March 2021, 22:07:32 UTC
6a8bfcd When calling RooAbsArg::optimizeCacheMode look for already processNodes by pointer using RooLinkedList::FindObject instead of findArg which looks by name. This makes sure that nodes in the computational graph with the same name are not skipped. This happens for the FFTW where 2 caches exist, one for normalized and one for unnormalized pdf. By doing this fixes ROOT-5380 and ROOT-8497 (RooProdPdf which includes a RooFFT) 02 March 2021, 22:07:32 UTC
4e976b0 Uncomment line setting operation mode of partInt components of RooProdPdf using current operation mode. This seems to be needed in order to propagate to the cached intergal component s of the RooProdPdf is operation mode. It fixes issue #7157 where RooProdPdf is used from a RooFFTConv. In this case the RooFFTConv sets AlwaysDirty as operation mode its components, and then the ROoProdPdf needs to propage to its owned parts, otherwise during the FFT computation the RooProdPdf returns always its first evaluation. 02 March 2021, 22:05:59 UTC
2066baa Install the global module index. This should fix the lcg nightlies and cmssw modules IB 02 March 2021, 21:43:09 UTC
1b7f9a9 [doc] Link GitHub as issue tracker (NFC) 02 March 2021, 17:42:45 UTC
c1e5a7d [TMVA] Update Keras tutorials using tensorflow.keras 02 March 2021, 16:31:08 UTC
e0f6c04 [llvm] Prevent static destruction from ending DefaultMMapper too early: On some platforms, SectionMemoryManager::MMapper has uses (during static destruction) that happen after static destruction has ended the lifetime of the DefaultMMapper object. Use of a function-static prevents this, as this guarantees that SectionMemoryManager::DefaultMMapper gets destructed after users, as long as users were constructed after SectionMemoryManager::DefaultMMapper (which is generally the case), rather than a random sequencing. 02 March 2021, 14:46:04 UTC
be2984d Fix computation of diagonal element of covariance matrix. See issue #7319 02 March 2021, 14:21:13 UTC
54b7a66 Fix assertion failure on Windows Fixes the following error on Windows with macros containing Windows line endings (CR/LF): ``` Assertion failed: content[posOpenCurly] == '{' && "No curly at claimed position of opening curly!", file C:\Users\bellenot\git\master\interpreter\cling\lib\MetaProcessor\MetaProcessor.cpp, line 431 ``` 02 March 2021, 14:02:40 UTC
771585b [eve7] repair logic of mouseup handler Was corrupted by previous reorganization of mouse event handlers. Now assign all mouse event handlers only to specific dom element 02 March 2021, 12:00:26 UTC
e00e13b [jsroot] add warning in JSRootCore.js It is deprecated script, which will be deleted soon 02 March 2021, 11:14:09 UTC
85b2257 [reve] also correctly cleanup OrbitControl object 02 March 2021, 11:14:09 UTC
e2eee8e [eve7] let cleanup dom events handler If same GlViewerThree.js should be reused for other drawing, one should correctly remove all handlers assigned before. 02 March 2021, 11:14:09 UTC
a4eb63a [webgui] let reassign main thread id If application runs in special thread, one should call RWebWindowManager::AssignMainThrd() to indicate this 02 March 2021, 11:14:09 UTC
7d4c58d Add capability to pass optimizer option in training string for MethodDL. One can setup for example the options for the ADAM minimizer, ADAM_beta1, ADAM_beta2 and ADAM_eps. Example is provided in the TMVA_Higgs_Classification.C tutorial 02 March 2021, 10:35:08 UTC
b4c0beb Set pyroot_legacy=OFF by default on Windows (#7324) * Disable pyroot_legacy by default on Windows * Set pyroot_legacy=OFF by default on Windows Make the new PyROOT the default also on Windows (was not supported before) 02 March 2021, 08:19:31 UTC
d1b602c [ntuple] Fix compiler warning 02 March 2021, 08:03:55 UTC
ff84158 [ntuple] Fix compiling when IMT is off 02 March 2021, 08:03:55 UTC
2024d8e Fix build time on Windows when nothing changed in the code Without this patch, CMake was always re-generating G__Imt.cxx, the re-buildding Core, and re-generating all the dictionaries, extending the build time from around two minutes to more than 30 minutes when nothing changed in the code. 01 March 2021, 18:29:50 UTC
19b4118 [jsroot] dev 1/03/2021 with zooming fixes When performing zoom of overlayed objects, one should ensure that first object is drawn before next is processed. Also fixing problem with 3D canvas cleanup, used in eve7 01 March 2021, 17:55:32 UTC
abb2851 [eve7] also correctly cleanup jsroot drawings 01 March 2021, 17:55:32 UTC
0dcc28b [eve7] use naming convention for onEveManagerInit Always check if such method exists for the controller 01 March 2021, 17:55:32 UTC
db97cce [eve7] implement cleanup of GLViewer class When drawing different projection via View -> Browse to menu commands, one have to cleanup previosely shown views. 01 March 2021, 17:55:32 UTC
87dc938 [cmake] Prevent `#include <complex.h>` also for GCC <=5. 01 March 2021, 16:31:59 UTC
835a5a2 Make clear THtml is legacy code (#7312) * Make clear THtml is legacy code * Use the special doxygen keyword "\deprecated" * Update html/src/THtml.cxx Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> 01 March 2021, 14:11:47 UTC
24a8a51 Use nullptr in TGraph header and source file 01 March 2021, 11:11:52 UTC
9a883db Fix TGraph copy constructor and assign operator (#7302) Cloned histogram should not be assign to current directory 01 March 2021, 11:11:52 UTC
41c08b6 Timeout parameter added to ExternalProject 01 March 2021, 08:15:46 UTC
1db97d6 [jsroot] dev 26/02/2021 wih TRatioPlot support Also fix tooltips handling for TH1/TGraph error plots, used in TRatioPlot 01 March 2021, 08:03:44 UTC
47d9833 Add TRatioPlot to list of supported classes in TWebCanvas 01 March 2021, 08:03:44 UTC
797ac1f ChangeLabel was not fully implemented on alphanumeric labels. (#7294) 01 March 2021, 07:48:04 UTC
9716857 Revert "[cling] modulemap <string_view> requires C++17." This reverts commit 93c1649bef398ee310b85848bbe4a2f0182c3a76. 28 February 2021, 16:35:46 UTC
f4ea5ad [cxxmodules] Allow submodules to contain headers which may be missing. This allows us to use a single modulemap file across multiple libstdc++ versions and gives us a way forward to deal with deprecated files. This patch will be submitted for a review upstream. It fixes our gcc 4.8 builds where codecvt, cuchar and string_view header files do not exist. 28 February 2021, 16:35:46 UTC
37956b7 [cling] Add the CLANG_INCLUDE_DIRS if we build as part of LLVM. 26 February 2021, 19:47:29 UTC
93c1649 [cling] modulemap <string_view> requires C++17. 26 February 2021, 17:09:00 UTC
3948cc2 The Sema::LookupConstructor is not iteration safe. When looking up a ctor the modules infrasturcture deserializes more ctor candidates in the body of the function causing the internal vector implementation to rellocate and invalidate the pointers. This workaround should address the failures reported by LCG. The real fix is being processed here https://reviews.llvm.org/D91524 and we after being merged we should be able to backport it. 26 February 2021, 16:44:46 UTC
b68af73 Fix for Apple Silicon M1 - gfortran does not accept -m64 26 February 2021, 08:42:33 UTC
43e6682 Add `ACLiC.LinkLibs: 1` in the `.rootrc` files for Windows This fixes re-running tests on Windows. According to [the documentation](https://github.com/root-project/root/blob/master/config/rootrc.in#L384-L390), this is already the default for the other platforms, while the default is 3 for Windows. 25 February 2021, 20:27:47 UTC
337cc57 Complete the llvm upgrade for ROOT. 25 February 2021, 19:40:47 UTC
3cdad1e [tutorials] v7/climate/global_temperatures.C needs Davix. 25 February 2021, 19:40:47 UTC
cbaaa07 [llvm] Work around inconsistency of {std|llvm}::is_trivially_copyable: See https://bugs.chromium.org/p/swiftshader/issues/detail?id=153 I.e. this is expected to be fixed in llvm11. 25 February 2021, 19:40:47 UTC
2c4a756 [cling] Windows needs more symbols to be injected: such as __dllonexit() and _onexit(). Without, static destruction does not happen, as can be seen by roottest/cling/staticinit/execROOT-7775.C failing to call the static destructors. 25 February 2021, 19:40:47 UTC
7aae2e3 [matrix] Move operators into inline namespace TMatrixTAutoloadOps: The llvm9 upgrade triggered a re-ordered symbol lookup, where the operators were needed before symbols from classes were needed (that in turn triggered autoloading). As namespace-scope functions cannot trigger autoloading by default, the operator symbols were missing. This is worked around by moving the operators into an inline namespace, and declaring the namespace to the dictionary and thus rootmap file. Remove useless (since cling) pragma link statements for operators. 25 February 2021, 19:40:47 UTC
7807e94 [dict] Move dict decls to ROOTDict namespace: For inline namespaces, the ROOT namespace nested in the inline namespace and containing the dictionary decls for that inline namespace is ambiguous with the outer ROOT namespace: ``` math/matrix/G__Matrix.cxx:93:14: error: reference to ‘ROOT’ is ambiguous 93 | inline ::ROOT::TGenericClassInfo *GenerateInitInstance(); | ^~ math/matrix/G__Matrix.cxx:92:14: note: candidates are: ‘namespace TMatrixTAutoloadOps::ROOT { }’ 92 | namespace ROOT { | ^~~~ ``` Adjust `NamespaceImp` accordingly. 25 February 2021, 19:40:47 UTC
e507150 DeclExtractor: exit early if there is nothing to do In LLVM 9, the `CompoundStmt::replaceStmts()` call seems to write to an invalid memory location if the body was empty. This may happen after a parse error and might end up corrupting the program state. This patch makes `DeclExtractor` to exit early if there is nothing to do, which solves the aforementioned problem. 25 February 2021, 19:40:47 UTC
b18096e removeRedeclFromChain is a template static. Fixes osx warning. 25 February 2021, 19:40:47 UTC
bf8829d Fix warnings about the ignored quals. 25 February 2021, 19:40:47 UTC
7c14edb Fixed CUDA mode for Clang/LLVM 9 upgrade - fix bug, which was caused by executing a transaction in the device interpreter - fixed warning from the device compiler - update test cases 25 February 2021, 19:40:47 UTC
2acaa30 [metacling] Also fwd decl templt spec args: rootmap needs { decls } entries such as ``` template <> class less<edm::AJet>; ``` to be able to load the right library containing a given specialization. But for this to be parsable, the template arguments of that specialization must also be forward declared. Re-use existing template-arg-fwd-decl code, and hook it into FwdDeclIfTmplSpec. Fixes roottest/cling/dict/fwd-decl-stdless/lessyDict.rootmap in the PCH case, and likely CMS's issue of a similar kind - TBC. 25 February 2021, 19:40:47 UTC
4e7d48a [cling] Improve 67b613517b: unsigned vallues cannot be negative: This fixes ``` math/mathcore/G__MathCore.cxx:450:57: warning: integer literal is too large to be represented in a signed integer type, interpreting as unsigned [-Wimplicitly-unsigned-literal] ::mersenne_twister_engine<ULong64_t,64,312,156,31,13043109905998158313,... ``` The code meant to test whether the highest bit is set. `isNegative` is false for unsigned values; we have to check whether the bit pattern starts with at least one leading one bit. 25 February 2021, 19:40:47 UTC
3dd035e Revert "Bring back the old workaround." This reverts commit b4fcf224a97f385467efde14911349ad9293ac3d. 25 February 2021, 19:40:47 UTC
0d58437 [metacling] Prevent inclusion of complex.h, use raw string literal: complex.h causes havoc, e.g. ``` libcomplexDict.rootmap:2:13: error: declaration of anonymous class must be a definition template <> class complex<float>; ``` running roottest_root_tree_cloning_treeCloneTest, which is caused by `complex` being redefined to _Complex, which is a kind of type annotation and breaks uses of `std::complex`. This means we can now remove `#undef I` (which comes from complex.h). Use cute raw string literals and combine remaining `#undef`s into a single call to `declare()` 25 February 2021, 19:40:47 UTC
76fede2 Fixes Issue #6812. In some scenarios, initialization of variables declared by AutoSynthesizer does not work as expected (more information on the GH issue), e.g. ``` root [2] unsigned int c (unsigned int) 0 root [3] d=c Error in <TRint::HandleTermInput()>: std::runtime_error caught: >>> Interpreter expected relocatable expression ``` This is because the generated VarDecl initializer is missing a LValueToRValue conversion, where required by the C++ standard. 25 February 2021, 19:40:47 UTC
6a05121 Bring back the old workaround. This fixes warning: integer constant is so large that it is unsigned in MathCore dictionary until D77598 lands. 25 February 2021, 19:40:47 UTC
a5486e5 [cling] When unloading, also forget that the decl was emitted. 25 February 2021, 19:40:47 UTC
back to top