e505be3 | Axel Naumann | 14 April 2021, 14:29:02 UTC | "Update ROOT version files to v6.24/00." | 14 April 2021, 14:29:02 UTC |
915eecc | Axel Naumann | 14 April 2021, 14:20:14 UTC | [relnotes] Import fixed issues; style. | 14 April 2021, 14:21:38 UTC |
b821d25 | Axel Naumann | 14 April 2021, 08:40:12 UTC | Update README/ReleaseNotes/v624/index.md | 14 April 2021, 08:40:29 UTC |
614a50e | Axel Naumann | 14 April 2021, 08:40:03 UTC | Update README/ReleaseNotes/v624/index.md | 14 April 2021, 08:40:29 UTC |
eaf48c3 | Axel Naumann | 14 April 2021, 08:39:55 UTC | Update README/ReleaseNotes/v624/index.md | 14 April 2021, 08:40:29 UTC |
bcbd19b | Axel Naumann | 14 April 2021, 08:39:48 UTC | Update README/ReleaseNotes/v624/index.md | 14 April 2021, 08:40:29 UTC |
129ec91 | Axel Naumann | 14 April 2021, 08:39:41 UTC | Update README/ReleaseNotes/v624/index.md | 14 April 2021, 08:40:29 UTC |
52de45f | moneta | 14 April 2021, 08:21:20 UTC | update release notes describing new TF1,TH1::GetRandom feature | 14 April 2021, 08:40:29 UTC |
8ea1797 | moneta | 14 April 2021, 08:01:49 UTC | Update Release notes for 6.24 | 14 April 2021, 08:40:29 UTC |
1bb8f9a | Axel Naumann | 13 April 2021, 14:11:39 UTC | [test] Remove testTBB: we have lots of proper usage now, and it would need to be adapted to current TBB not offering task_scheduler_init anymore. | 13 April 2021, 15:59:51 UTC |
27eeccf | Axel Naumann | 13 April 2021, 15:58:24 UTC | [relnotes] Add some missing features: header cleanups; xrootd5 support; doxygen version selection. | 13 April 2021, 15:58:24 UTC |
b018919 | Axel Naumann | 13 April 2021, 15:02:49 UTC | [relnotes] Style. | 13 April 2021, 15:02:49 UTC |
e322b2e | Axel Naumann | 13 April 2021, 14:44:16 UTC | [relnotes] Style, mention builtin updates of LZ4 and openui5. | 13 April 2021, 14:44:16 UTC |
2aa4dd5 | Axel Naumann | 13 April 2021, 14:35:34 UTC | [relnotes] Use root.cern as canonical domain. | 13 April 2021, 14:35:34 UTC |
e2cbc70 | Olivier Couet | 13 April 2021, 12:40:21 UTC | back port release notes fix | 13 April 2021, 12:44:13 UTC |
de8ae0a | Philippe Canal | 13 April 2021, 01:17:36 UTC | Use 'Write' iterator when intended. This makes a difference for associative containers. For reading the iterator are iterating over the 'TStaging' object rather than the collection. For writing we need to iterated over the collection | 13 April 2021, 04:47:46 UTC |
f53808e | Philippe Canal | 13 April 2021, 00:47:42 UTC | Redo part of 'Correct FullName of the index leaf of a collection' The intent was to prevent the creation of sub branch with 2 consecutives dots and to avoid a dot between the branch name of the collection and the underscore for name of the index leaf. The major problem of the first try is that the name of the top level branch was changed from "t." to "t" making existing code search for the branch by fullname failing. Fix #7281 This effectively ammends/corrects d225f942b59b5b022cf635a16e90f84cad59819d Before v6.23 ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485042 bytes File Size = 177202 * * : : Tree compression factor = 2.74 * ****************************************************************************** *Br 0 :t. : Int_t t._ * *Entries : 10000 : Total Size= 83464 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t..fUniqueID : UInt_t fUniqueID[t._] * *Entries : 10000 : Total Size= 80935 bytes File Size = 12857 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t..fBits : UInt_t fBits[t._] * *Entries : 10000 : Total Size= 80903 bytes File Size = 12879 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t..e : Double_t e[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 65937 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.83 * *............................................................................* *Br 4 :t..t : Double_t t[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 71633 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* After the first try: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 484998 bytes File Size = 177400 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t : Int_t t_ * *Entries : 10000 : Total Size= 83438 bytes File Size = 12838 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.26 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* Now: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485003 bytes File Size = 177402 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t. : Int_t t_ * *Entries : 10000 : Total Size= 83444 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* | 13 April 2021, 04:47:46 UTC |
9860cc4 | Philippe Canal | 12 April 2021, 15:49:03 UTC | Reduce the number of iteration of testInterpreterLock. This test is also 'stressing' the interpreter and in particular the increase in the number of symbols. This leads to a noticeable reduction of the speed of the test (or more exactly the loading/setting up of the test). In addition some of the nightly run on VM which can lead to performance variance (at least on this test) of a factor 4. In a good day on one of 'failing' vm, the 100 iterations takes 400s, during the nightlies it oftens takes 800s to 1000s ... the timeout limit is 1200s, so it is reached from time to time. | 12 April 2021, 21:39:18 UTC |
37922cc | Philippe Canal | 12 April 2021, 14:42:36 UTC | Revert "Fix the action PushDataCache for TClonesArray." This reverts commit 3480394c02a6335d271f95fcf160274811091155. The change is necessary for Issue #7764 but currently has severe negative side effect (crash in cases not using TClonesArray) | 12 April 2021, 21:39:18 UTC |
e44638b | Axel Naumann | 29 March 2021, 12:55:27 UTC | [tmva] Remove unneeded TBB includes in tests. (cherry picked from commit adc4c733b89d7125ca3fcee97c79f6e606a48356) | 12 April 2021, 18:25:30 UTC |
2210ecd | Axel Naumann | 29 March 2021, 12:27:46 UTC | Revert "Supress TBB warnings in ROOT builds" This reverts the non-test part of commit c9d740759115fcd0b9585021f7aa69c04c8c077c. With this, the only remains of SYSTEM include of TBB headers are: tmva/tmva/test/DNN/RNN/CMakeLists.txt tmva/tmva/test/DNN/LSTM/CMakeLists.txt tmva/tmva/test/DNN/GRU/CMakeLists.txt tmva/tmva/test/DNN/CNN/CMakeLists.txt Having TBB as SYSTEM-include and a builtin TBB means that *all* ROOT headers (in include/) become SYSTEM headers. (cherry picked from commit 42bc3435bbfdae35ccf4a831f7d4ef4e791bcdf6) | 12 April 2021, 18:25:30 UTC |
e9e2468 | Olivier Couet | 30 March 2021, 06:04:59 UTC | Fix rel-notes 6.24 syntax (#7733) * Fix rel-notes 6.24 syntax * - Fix bullet lists (cherry picked from commit ffca9cad4c6f35f44affeac14643e7109648a778) | 12 April 2021, 18:16:26 UTC |
bf92d9c | Axel Naumann | 12 April 2021, 09:13:16 UTC | [test] Update location of xrootd test files: The original directory was removed. (cherry picked from commit ca9ab88c7e38046dae309d039b7912e294a5435d) | 12 April 2021, 17:44:55 UTC |
2b7f6d9 | Axel Naumann | 29 March 2021, 15:41:21 UTC | [cmake] Tone down macOS ranlib/CMake FATAL_ERROR to WARNING: We wanted FATAL_ERROR for our Jenkins. That has been running for many months now; switch to WARNING for the release as this still allows users to get a proper ROOT build. (cherry picked from commit 193c3160c0442e099d80e9ec43306efe299f2edc) | 12 April 2021, 16:28:56 UTC |
ab718b0 | Axel Naumann | 31 March 2021, 13:25:08 UTC | [cling] Throw less exceptions on Apple M1: As llvm JIT cannot catch exceptions on Apple M1 (see https://github.com/root-project/root/issues/7541) cling should throw less. This is a hack to reduce the impact a bit. (cherry picked from commit f7a3eeb6b4a9ebf8d6452fc77a1fd1ed75570c41) | 12 April 2021, 16:26:57 UTC |
b92a643 | Enrico Guiraud | 12 April 2021, 10:28:09 UTC | [DF] Remove unused struct | 12 April 2021, 13:22:35 UTC |
aa929d9 | Lorenzo Moneta | 01 April 2021, 10:21:44 UTC | Add an implementatioon of getValV for RooAddPdf to use stored normalization set by default when the pdf is evaluated without passing a set. Disable printing of warning message of evaluating un-normalized RooAddPdf when doing: - Call getVal in constructor of RooRealIntegral (not sure why this is needed) - printValue of any RooAbsPdf, where getVal(0) is also called - RooAbsArg::graphVizTree where also getVal(0) is called when exporting the tree in a graphVizTree This avoids having un-needed warning messages when printing or examing RooWorkspaces or pdf's | 12 April 2021, 08:02:29 UTC |
4e140ba | Sergey Linev | 09 April 2021, 11:34:59 UTC | [qt5web] update Windows compilation instruction One has to use Release mode to avoid complication with external depndencies | 09 April 2021, 12:17:05 UTC |
0eba289 | Sergey Linev | 09 April 2021, 08:21:28 UTC | [qt5web] update tutorial, initialize QWebEngine in the beginning | 09 April 2021, 12:17:05 UTC |
056aa2f | Sergey Linev | 09 April 2021, 08:20:56 UTC | [qt5web] initialize QWebEngine only when create QApplication If application already exists, operation is not legal Provide more comments in the code | 09 April 2021, 12:17:05 UTC |
66757c9 | Sergey Linev | 08 April 2021, 08:55:22 UTC | [qt5web] fix Windows compilation problem On windows widget width() and height() are real values and therefore need to be casted to be used in RCanvas methods | 09 April 2021, 12:17:05 UTC |
2eb0767 | Sergey Linev | 08 April 2021, 08:10:47 UTC | [qt5web] update ExampleWidget.ui file Use proper syntax to include custom widgets | 09 April 2021, 12:17:05 UTC |
531fd0d | Sergey Linev | 08 April 2021, 08:00:44 UTC | [qt5web] provide cmake build for qt5web tutorial It should simplify building on different platforms Plus Qt6 (when appears with WebEngine) supports only cmake | 09 April 2021, 12:17:05 UTC |
643d57f | Jonas Hahnfeld | 09 April 2021, 09:35:56 UTC | [AArch64] Materialize FP constant in code for large code model (#7806) Backport of D99607, commit 6415f424bc. Original commit message: --- When using the large code model with FastISel (for example via clang -O0 which adds the optnone attribute), FP constants could still be materialized using adrp + ldr. Unconditionally enable the existing path for MachO to materialize the constant in code. [...] --- See the discussion in https://github.com/cms-sw/cmssw/issues/31123 for context on the observed crashes. (cherry picked from commit 9e104ac7900ca264066d57aac1655ac1d8daf5f0) | 09 April 2021, 09:35:56 UTC |
80352a2 | Vincenzo Eduardo Padulano | 06 April 2021, 14:53:55 UTC | [DF] Do not support in-memory-only trees in distributed rdf | 08 April 2021, 15:20:09 UTC |
c57b67c | Jonas Rembser | 26 March 2021, 12:21:45 UTC | [RF] Define cov matrix quality for correction strategies in fitTo The code for the covariance matrix determination in RooAbsPdf::fitTo for the case that SumW2Error is enabled was duplicated. This commit moves the duplicated code into a static function to make changes to the SumW2Error logic easier in the future. Previously, the covariance matrix quality stored in the returned result pointer was -1 when SumW2Error was switched on, indicating an extrernally provided covariance matrix. This made it difficult to diagnose fits in the SumW2Error mode. With this commit, the covariance matrix quality will be set to the minimum quality of both covariance matrices involved, i.e. the minimum of the original covariance matrix quality and the quality of the covariance matrix calculated using the squared weights. The code for the covariance matrix determination in RooAbsPdf::fitTo for the asymptotically correct correction was duplicated. This commit moves the duplicated code into a templated function to make changes to the covariance matrix correction logic easier in the future. Previously, the covariance matrix quality stored in the returned result pointer was -1 when the asymptotic correction was switched on, indicating an extrernally provided covariance matrix. This made it difficult to diagnose fits. With this commit, the covariance matrix quality will be set to the quality of the original covariance matrix, as the correction is done via derivatives computed in RooFit whose application doesn't degrade the covariance matrix quality. | 07 April 2021, 23:17:59 UTC |
d68acd7 | Jonas Rembser | 30 March 2021, 13:10:54 UTC | [RF] Add unit test for conditional fit with batch mode | 07 April 2021, 19:55:37 UTC |
5f05c75 | Jonas Rembser | 30 March 2021, 12:22:11 UTC | [RF] Ignore leaves in evaluateSpan that the RooAbsReal doesn't depend on We should not use RooAbsArg::leafNodeServerList to find all leaves, whose values neet to be set in RooAbsReal::evaluateSpan. Sometimes a RooAbsReal sits on top of a leaf in the computation graph, still it doesn't depend on it's values. The example here is a RooRealIntegral, which sets the leaf values itself to integrate over them. That's why we only add the parameters and observables here. | 07 April 2021, 19:55:37 UTC |
b353b74 | Jonas Rembser | 30 March 2021, 10:21:49 UTC | [RF] Use more std::string and unique_ptr in RooAbsReal and RooAbsPdf | 07 April 2021, 19:55:37 UTC |
b46dfa0 | Jonas Rembser | 30 March 2021, 11:45:28 UTC | [RF] Don't report on missing batchmode implementation if batch is scalar Advising to implement the batch interface makes only sense if the batch was not a scalar. Otherwise, there would be no speedup benefit. | 07 April 2021, 19:55:37 UTC |
4187816 | Jonas Rembser | 30 March 2021, 11:37:22 UTC | [RF] Use batch interface also for the integration of integrals In most cases, the integral will be a scalar. But it can still happen that the integral is a vector, for example in a conditional fit where pdf is parametrized by another observable that is also a batch. That's why we have to use the batch interface also for the integral. | 07 April 2021, 19:55:37 UTC |
006a7ca | Christian Tacke | 06 April 2021, 11:34:12 UTC | Release Notes for ROOT_LIBRARY_PATH Add a short description of the new feature to the 6.24 releases notes. | 07 April 2021, 15:17:11 UTC |
97c722b | Christian Tacke | 22 March 2021, 09:03:55 UTC | Use ROOT_LIBRARY_PATH in DynamicPath ROOT's "dynamic path" has some environment variables to control it. Those environment variables have some issues: * They are dependant on the OS (DYLD* on macOS, LD_LIBRARY_PATH on Linux, etc) * LD_LIBRARY_PATH/etc modify the system's search path for dynamic libraries, which can result in all sorts of bad things. We would like to have a dedicated environment variable, that is * OS independant. * does only affect ROOT. Let's name it ROOT_LIBRARY_PATH (suggestion on mattermost.web.cern.ch). It was suggested to put this into `system.rootrc` and/or `.rootrc`. This has some issues: * `.rootrc` is good for a per user solution. We would like to have a package level solution. * `system.rootrc` is usually a place for the local sysadmin to modify. It could be used by a distribution package to put "defaults". But that's not really nice. * Finally, `.rootrc` entries replace `system.rootrc` entries. So any package level configuration would be gone the moment, that the user sets `Unix.*.Root.DynamicPath`. So getting the above mentioned environment variable to work at a package level, means to put it into TUnixSystem.cpp / TWinNTSystem.cxx. Co-Authored-By: Bertrand Bellenot @bellenot | 07 April 2021, 15:17:11 UTC |
e871202 | Enrico Guiraud | 07 April 2021, 09:25:29 UTC | [relnotes] Mention a big reduction in jitting times for RDF | 07 April 2021, 12:16:43 UTC |
33caead | Enrico Guiraud | 23 March 2021, 11:48:54 UTC | [DF] Reduce jitting times in large computation graphs Clang, and therefore cling, doesn't deal well with large amounts of variable instantiations of types with non-trivial destructors in the same function body. In this scenario the list of exception-handling "landing pads" grows to sizes that make compilation times blow up. What takes time specifically is the generation of code that deals with calling the destructors of these variables in case an exception is thrown in the function body. This patch avoids allocating many temporary std::strings and std::vector<std::string>s in jitted code by generating code of the form Jit{Filter,Define}Helper(..., const char*[]{"col1", "col2"}, ...) rather than Jit{Filter,Define}Helper(..., std::vector<std::string>{"col1", "col2"}, ...). | 07 April 2021, 12:16:43 UTC |
82a8e71 | Jonas Hahnfeld | 07 April 2021, 06:40:36 UTC | [cling] Set full target for Apple M1 (#7792) The argument -Xclang -triple=... completely bypasses Clang's Driver logic and only sets the triple in CC1. This suffices for most code generation tasks, but the Driver cannot compute the correct ABI and sets the generic AArch64 "aapcs" instead of the specific "darwinpcs". In turn, this causes integer arguments with less than 32 bits not being sign-extended but being passed directly, which for example manifests as (short)-1 being read as 65535 on the callee side. The new argument --target=arm64-apple-darwin20.3.0 matches what Apple's and LLVM main's clang return for --print-target-triple. Fixes #7090 (cherry picked from commit f75a7c464b8b3f49b4ad1ae0e536d139235863d2) | 07 April 2021, 06:40:36 UTC |
0ae9f99 | Axel Naumann | 01 April 2021, 10:24:13 UTC | [cling] LookupHelper must not unload Transactions: Outer RAIIs might still reference the Transaction, and unload is assuming that it owns the transaction and can delete it / put it into the TransactionPool. This fixes https://github.com/root-project/root/issues/7657 We still need to track ownership as what has happened here (unload of a Transaction held by an RAII) can happen again / elsewhere. This will be addressed by a subsequent PR in master. (cherry picked from commit 0202a4b065b0a9d8116f1c42af9a0eebad570401) | 05 April 2021, 22:02:54 UTC |
3480394 | Philippe Canal | 31 March 2021, 00:36:28 UTC | Fix the action PushDataCache for TClonesArray. It was using the wrong signature leading to the configuration to be mis-read. Fixes #7754 | 03 April 2021, 01:03:55 UTC |
eda4583 | Vincenzo Eduardo Padulano | 01 April 2021, 09:40:50 UTC | [DF] Remove enum from distributed RDataFrame | 01 April 2021, 14:12:36 UTC |
f04cb23 | Vincenzo Eduardo Padulano | 31 March 2021, 21:46:09 UTC | [DF] Lazily import numpy in distributed reduce step. | 01 April 2021, 09:13:33 UTC |
126c9c8 | Vincenzo Eduardo Padulano | 25 March 2021, 16:36:32 UTC | [DF] Add first tutorial for distributed rdf | 31 March 2021, 14:35:36 UTC |
46401b9 | Vincenzo Eduardo Padulano | 26 March 2021, 08:48:34 UTC | Use ImportError for Python2 compatibility | 30 March 2021, 11:51:38 UTC |
2e9e420 | Axel Naumann | 20 November 2020, 17:15:29 UTC | [rootcling] Emit using std after user headers, fixes #6343: `using namespace std` can have detrimental side effects on user headers. For non-ACLiC invocations, assume that user headers are compilable. In those casesm move the using directive after the inclusion of user headers, to not affect them, but only the generated dictionary source code (which is using CINT-compatible std-less type names etc). (cherry picked from commit df98daa3467bb21fe52d5eed5a2ab758a3787f84) | 29 March 2021, 15:43:14 UTC |
3e94c2d | Philippe Canal | 24 March 2021, 21:48:29 UTC | [io] Correct cycle order in file merging for non-mergeable obj. Fixes #7676 | 29 March 2021, 15:12:31 UTC |
0498225 | Philippe Canal | 24 March 2021, 20:02:03 UTC | [io] TFileMerger delay the write of TCollection. Addendum to c4d94efa7a3e44c25f21369807eb2ee59bf43f07: TFileMerger allow to delay the object writes. | 29 March 2021, 15:12:31 UTC |
2b7dd0c | Anirudh | 19 March 2021, 20:09:37 UTC | Add TMVA PyTorch Interface | 29 March 2021, 09:05:38 UTC |
d0878b0 | will buttinger | 25 March 2021, 10:40:58 UTC | Move useful functionality from argset up to collection base class so that RooArgList gets it too | 27 March 2021, 13:16:30 UTC |
f0e5636 | Josh Bendavid | 16 March 2021, 00:03:11 UTC | disable TBB use on Windows | 26 March 2021, 17:24:33 UTC |
20a7862 | Josh Bendavid | 19 February 2021, 19:41:43 UTC | add TBB based RWMutex types to tests, plus a few additional tests | 26 March 2021, 17:24:33 UTC |
5ec5650 | Josh Bendavid | 19 February 2021, 19:41:25 UTC | add TBB based RWMutex classes and use by default when TBB is available | 26 March 2021, 17:24:33 UTC |
f404697 | Josh Bendavid | 19 February 2021, 19:40:14 UTC | add flags for optional TBB dependencies | 26 March 2021, 17:24:33 UTC |
eb68754 | Josh Bendavid | 19 February 2021, 19:39:19 UTC | fix missing/duplicated test | 26 March 2021, 17:24:33 UTC |
78cb977 | Josh Bendavid | 24 March 2021, 23:25:41 UTC | [relnotes] Add lock contention improvements This covers the changes in https://github.com/root-project/root/pull/6857 https://github.com/root-project/root/pull/7105 https://github.com/root-project/root/pull/7260 | 25 March 2021, 13:10:09 UTC |
cedcafd | Josh Bendavid | 24 March 2021, 23:03:39 UTC | add Josh Bendavid to list of contributors | 25 March 2021, 13:10:09 UTC |
7ec6a2e | Stephan Hageboeck | 23 March 2021, 17:34:49 UTC | [Math][Docs] Improve documentation of integrator options. (cherry picked from commit 8d054e43576f50918c0fb4618fb77a39223d6473) | 25 March 2021, 12:29:46 UTC |
f19f5eb | Stephan Hageboeck | 23 March 2021, 17:36:35 UTC | [RF][Docs] Improve documentation of RooBinSamplingPdf. (cherry picked from commit e24ff46183fcc590a24adc586d8b640028944fc0) | 25 March 2021, 12:29:12 UTC |
570b97a | Stephan Hageboeck | 23 March 2021, 17:35:56 UTC | [RF][Docs] Correct in,out tag of function arguments. (cherry picked from commit 64dcbfe8adac9f13db2ab293908abbee77b2331c) | 25 March 2021, 12:29:11 UTC |
931d732 | Enrico Guiraud | 24 March 2021, 10:21:06 UTC | [relnotes] Mention deprecation of SetMaxTasksPerFilePerWorker | 25 March 2021, 11:42:33 UTC |
7c0cfac | Vincenzo Eduardo Padulano | 24 March 2021, 13:42:27 UTC | Add a section about distributed rdf in doxygen page | 24 March 2021, 17:50:44 UTC |
ecb95c1 | Enrico Guiraud | 23 March 2021, 15:00:12 UTC | [relnotes] Mention that we now pick up compiler's default C++ std | 24 March 2021, 10:05:40 UTC |
96410e2 | Jonas Hahnfeld | 19 March 2021, 08:33:29 UTC | Update CREDITS file (cherry picked from commit d03407e19eaea7b02021d9d65ec6bc864bdcab6b) | 24 March 2021, 07:25:39 UTC |
d139d6d | Jonas Hahnfeld | 19 March 2021, 08:30:41 UTC | [RelNotes] Add note about RANLUX++ (cherry picked from commit 46808ecb4b9670fcaa548ce5d73201a458af9cd8) | 24 March 2021, 07:25:39 UTC |
ed79573 | Jonas Hahnfeld | 19 March 2021, 08:26:55 UTC | [RelNotes] Add 2x Jonas (cherry picked from commit c8c18cce7d6ab3e2165f12c72c3e308a1d9f2864) | 24 March 2021, 07:25:39 UTC |
c9323a0 | Sergey Linev | 23 March 2021, 11:22:10 UTC | [jsroot] update 6.24 with many fixes Add new draw options for TGraph/TMultiGraph | 23 March 2021, 12:16:27 UTC |
f9b2882 | Philippe Canal | 19 March 2021, 18:07:02 UTC | Add missing use of ::ROOT to qualify name in dictionary | 22 March 2021, 20:18:35 UTC |
66e8a63 | Vassil Vassilev | 19 March 2021, 22:06:59 UTC | [cmake] Do not bind cling's sysroot to a particular version of osx sdk. The CMAKE_OSX_SYSROOT exports the exact version of the sdk which we build against. However, this means that binary releases become sensitive to minor sdk upgrades (eg. MacOSX11.1.sdk -> MacOSX11.2.sdk). Our infrastructure is relatively resilient to such changes. This patch introduces a workaround to address this issue -- it uses the fact that the current sdk's parent directory has a symlink MacOSX.sdk which points to the current sdk. This should resolve root-project/root#7021. | 22 March 2021, 13:21:15 UTC |
7b96eef | Jonas Hahnfeld | 17 March 2021, 11:56:02 UTC | Fix unwind info relocation with large code model on AArch64 Backport of D27629, commit 18805ea951. Original commit message: --- Makes sure that the unwind info uses 64bits pcrel relocation if a large code model is specified and handle the corresponding relocation in the ExecutionEngine. This can happen with certain kernel configuration (the same as the one in https://reviews.llvm.org/D27609, found at least on the ArchLinux stock kernel and the one used on https://www.packet.net/) using the builtin JIT memory manager. Co-authored-by: Yichao Yu <yyc1992@gmail.com> Co-authored-by: Valentin Churavy <v.churavy@gmail.com> --- Note: The handling in ExecutionEngine was committed in a different revision and is already part of LLVM 9. We need the part about emitting relocations because eh_frame (allocated in a data section) may be more than 4Gb away from the code section it references. See the discussion in https://github.com/cms-sw/cmssw/issues/31123 for context. (cherry picked from commit f481e8fe6df177ec1a50a10b7d76df5fb0b5c2a2) | 19 March 2021, 19:37:57 UTC |
0361339 | Axel Naumann | 17 December 2020, 17:41:51 UTC | [cling] In failed lookup, unload only decls produced, not existing fwd decl: Before, pre-existing fwd decls of specializations got unloaded. OTOH, any decl produced during (failed) template instantiation must also be unloaded; see #6331. Those are easiest identified by unloading the whole (failed) transaction. ``` error: no member named 'value' in 'std::__and_<std::is_copy_assignable<std::__cxx11::basic_string<char> >, std::is_copy_assignable<Inner<int> > >' is_copy_assignable<_T2>>::value, ~~~~~~~~~~~~~~~~~~~~~~~~~~^ ``` which is due to the first decl being invalid (as `Inner<int>` does not have a deinition and a `static_assert` /usr/lib/gcc/x86_64-redhat-linux/10/../../../../include/c++/10/type_traits:1093 being triggered), then not unloaded, and then picked up again where we *do* have the definition for `Inner<int>`. Add test for templt spec lookup vs unloading. | 19 March 2021, 10:11:55 UTC |
3c3de4c | Axel Naumann | 18 December 2020, 16:24:36 UTC | [cling] PushTransactionRAII: do not commit broken transactions: There is no point in emitting a transaction that has been rolled back to CodeGen. To make matters worse, a rolled-back transaction will not show up in the list of transactions. | 19 March 2021, 10:11:55 UTC |
95a439a | Axel Naumann | 18 December 2020, 16:02:55 UTC | [cling] Allow unloading of Transactions that have not been committed: If Lookup fails to instantiate, its transaction should not be committed, as we know it's useless and must be unloaded as it might contain invalid Decls. But that means Lookup needs to unload a non-committed transaction. | 19 March 2021, 10:11:55 UTC |
8a1ff4a | Axel Naumann | 25 November 2020, 17:52:36 UTC | [metacling] Remember which classes were DeepAutoLoad-ed in this AutoLoad: ROOT-10895 suffers from trying to autoload 220 classes, but causing >80k calls to DeepAutoLoadImpl(). Within one call to AutoLoad(), no new information can arrive that would allow later recursions of DeepAutoLoadImpl() to now autoload a class successfully. So whether autoloading a class successfully or not, any class on which DeepAutoLoadImpl() was called does not need to be re-visited within the same AutoLoad() call. To achieve that, remember the class names that have been visited already, bringing the count to (non-early-return) DeepAutoLoadImpl() to the actual number of classes that we should try to autoload. And a perf-opt: do not determine type names if the type is fundamental. And I'm not a big fan of deep code nesting. | 19 March 2021, 10:11:55 UTC |
075c1ad | Axel Naumann | 25 November 2020, 17:52:19 UTC | [metacling] In DeepAutoLoadImpl, use the fact that class name is normalized: Considerably speeds up the deeply nested, hot loops through all members. | 19 March 2021, 10:11:55 UTC |
8a36c14 | Axel Naumann | 26 November 2020, 10:45:11 UTC | [clingutils] KeepNParams: break on first template default args. This is a hot function, getMinRequiredArguments() is far from cheap, and instead of taking the last redecl with default args we now take the first. There should only be one anyway. | 19 March 2021, 10:11:55 UTC |
f976af2 | Axel Naumann | 17 March 2021, 15:06:59 UTC | [cling] Skip non-regular files to find dylibs: To determine the file magic, the file needs to be opened and read. This is done with *each* file in $LD_LIBRARY_PATH, including ./ If one of them is e.g. a FIFO then reading blocks until someone writes into the FIFO, which might cause the process to hang. This was reported a couple of times, such as at https://root-forum.cern.ch/t/compiling-from-source-first-interactive-command-hangs/43997/5 Solution: only check for the file magic of *regular* files. Sadly, llvm::sys::fs::get_file_type never sets file_not_found but returns an unspecific status_error. | 19 March 2021, 10:06:58 UTC |
273e0fc | Sergey Linev | 18 March 2021, 16:41:25 UTC | [eve7] fix memory leak in REveCalo | 19 March 2021, 07:20:31 UTC |
f7e431b | Sergey Linev | 18 March 2021, 07:59:27 UTC | [mathcore] Fix memory leak in GausIntegrator #7556 Do noy clone IntegrandTransform object, which leaked in this case | 18 March 2021, 15:29:21 UTC |
5a33ece | Enrico Guiraud | 17 March 2021, 16:52:52 UTC | [cmake] Add ROOTVecOps to ROOT_LIBRARIES It is a dependency of ROOTDataFrame which is already included in ROOT_LIBRARIES, so we want it there. | 18 March 2021, 14:07:38 UTC |
ae14763 | Enrico Guiraud | 18 March 2021, 10:43:28 UTC | [DF][NFC] Backport major doc improvements to 6.24 | 18 March 2021, 11:29:21 UTC |
105e087 | Sergey Linev | 17 March 2021, 07:51:58 UTC | Fix TLeaf::GetLeafCounter function #7507 Lead name with dot was not properly tested | 18 March 2021, 07:44:36 UTC |
93b046c | Enrico Guiraud | 16 March 2021, 15:17:56 UTC | [DF] Keep SnapshotHelper args alive until jitting Commit 1db2ea4fd6 introduced a bug in lazy jitted Snapshot calls: the constructor arguments of SnapshotHelper[MT] would go out of scope much before jitting time, eventually causing a nullptr dereference in RJittedAction. This fixes #7547. | 17 March 2021, 19:15:47 UTC |
4ebe88c | Enrico Guiraud | 16 March 2021, 16:02:21 UTC | [DF] Add test for lazy jitted Snapshot | 17 March 2021, 19:15:47 UTC |
1143bea | Javier Lopez-Gomez | 16 March 2021, 15:56:44 UTC | Updated v6.24 release notes for Cling. | 16 March 2021, 19:08:58 UTC |
422855e | Emmanouil Michalainas | 15 March 2021, 12:58:23 UTC | [RF] Create README.md for `roofit/batchcompute`. | 16 March 2021, 18:17:15 UTC |
e6f4c34 | Emmanouil | 16 March 2021, 18:08:51 UTC | [RF] Update release notes (RooBatchCompute + evaluateSpan()). | 16 March 2021, 18:17:15 UTC |
ec61446 | Emmanouil | 16 March 2021, 18:05:54 UTC | [RF] Fix typo "evaluatedSpan() -> evaluateSpan()". | 16 March 2021, 18:17:15 UTC |
daa5df9 | Enrico Guiraud | 15 March 2021, 11:57:28 UTC | [relnotes] Mention new behavior of TTreeReader + friend trees | 16 March 2021, 17:45:56 UTC |
c8a16ad | Enrico Guiraud | 15 March 2021, 11:53:55 UTC | [relnotes][DF] Update release notes | 16 March 2021, 17:45:56 UTC |
cd3c91f | Sergey Linev | 16 March 2021, 10:22:30 UTC | Update docu to clearly specify that free() function must be used | 16 March 2021, 16:52:39 UTC |
50e34a6 | Sergey Linev | 16 March 2021, 10:18:23 UTC | Fix memory leak when using TASImage::GetImageBuffer Allocated memory should be cleanup with `free` function. In all three places where it was used it was wrong. Either `delete` or `delete []` or just do nothing. | 16 March 2021, 16:52:39 UTC |
97d0f00 | Sergey Linev | 16 March 2021, 09:53:37 UTC | Fix clang-tidy issues in TASImage Remove unused values, mark _alphaBlend operation as NOLINT | 16 March 2021, 16:52:39 UTC |