| bd580b7 | Brad King | 09 April 2020, 12:33:17 UTC | CMake 3.17.1 | 09 April 2020, 12:33:17 UTC |
| b8b98c9 | Brad King | 09 April 2020, 12:10:52 UTC | Merge topic 'ccmake_incremental_log_display' into release-3.17 60bfaa8fe6 ccmake: Use incremental rendering for the logs e9b36731e9 cmCursesLongMessageForm: Factor out helper to draw message to form Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Robert Maynard <robert.maynard@kitware.com> Merge-request: !4573 | 09 April 2020, 12:12:12 UTC |
| 0f72aba | Brad King | 09 April 2020, 12:10:46 UTC | Merge topic 'apple-arch-sysroots' into release-3.17 84a1e67380 Apple: Fix mapping CMAKE_APPLE_ARCH_SYSROOTS to custom OSX_ARCHITECTURES 45fa9b32ca Apple: Improve handling of missing SDKs in CMAKE_APPLE_ARCH_SYSROOTS Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4583 | 09 April 2020, 12:10:55 UTC |
| 60bfaa8 | Sylvain Joubert | 06 April 2020, 13:42:24 UTC | ccmake: Use incremental rendering for the logs This should avoid an exponential slowdown in the display time for projects with lots of output. This is still slower than cmake due to the ncurses drawing, but it should now be O(L) in total and not O(L^2) wrt to output length. Fixes: #20535 | 08 April 2020, 18:40:09 UTC |
| e9b3673 | Brad King | 08 April 2020, 18:39:46 UTC | cmCursesLongMessageForm: Factor out helper to draw message to form | 08 April 2020, 18:39:46 UTC |
| 84a1e67 | Brad King | 08 April 2020, 15:35:32 UTC | Apple: Fix mapping CMAKE_APPLE_ARCH_SYSROOTS to custom OSX_ARCHITECTURES The `CMAKE_OSX_ARCHITECTURES` value is not used directly by generators. It is used to initialize a per-target `OSX_ARCHITECTURES` property, but that property can also be set explicitly by project code to a subset of the full list of architectures. In order to handle this case, construct a mapping from each `CMAKE_OSX_ARCHITECTURES` entry to the corresponding `CMAKE_APPLE_ARCH_SYSROOTS` entry by name. Use the mapping to find the sysroot for each entry in `OSX_ARCHITECTURES` for a given target. If `CMAKE_APPLE_ARCH_SYSROOTS` does not have the same length as `CMAKE_OSX_ARCHITECTURES`, error out early rather than risking a crash or assertion failure. Fixes: #20534 | 08 April 2020, 17:40:09 UTC |
| 45fa9b3 | Brad King | 08 April 2020, 15:28:30 UTC | Apple: Improve handling of missing SDKs in CMAKE_APPLE_ARCH_SYSROOTS Use `<arch>-SDK-NOTFOUND` instead of an empty string as a placeholder in `CMAKE_APPLE_ARCH_SYSROOTS` for architectures whose SDK is not found. This ensures the length of `CMAKE_APPLE_ARCH_SYSROOTS` matches the length of `CMAKE_OSX_ARCHITECTURES`. It also makes the missing SDKs more visible in the value. Issue: #20534 | 08 April 2020, 15:51:02 UTC |
| 685bfad | Brad King | 08 April 2020, 13:03:13 UTC | Merge topic 'ninja-order-depends' into release-3.17 2f949be4b3 Ninja: Make config uppercase in object order target Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4581 | 08 April 2020, 13:03:23 UTC |
| 2f949be | Kyle Edwards | 07 April 2020, 18:28:35 UTC | Ninja: Make config uppercase in object order target Fixes: #20539 | 07 April 2020, 18:28:35 UTC |
| 3d61ff7 | Brad King | 07 April 2020, 12:00:35 UTC | Merge topic 'llvm-rc-include-path' into release-3.17 35a29ec827 llvm-rc: Restore include path for data after explicit preprocessing Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4570 | 07 April 2020, 12:00:44 UTC |
| 35a29ec | Thomas Bernard | 04 April 2020, 09:59:22 UTC | llvm-rc: Restore include path for data after explicit preprocessing Since commit 1c2d031cbd (Add -E cmake_llvm_rc to preprocess files for llvm-rc, 2020-01-14, v3.17.0-rc1~24^2) with llvm-rc we explicitly preprocess RC source files and then compile separately without -I flags. This broke cases where the RC source references data files adjacent to itself or in the include path. This change adds the expansion of the include paths when calling the llvm-rc in order for the resource files to be picked up correctly by llvm-rc. Since the RC compiled file is first preprocessed, the file being compiled by llvm-rc resides in the build directory. In order for llvm-rc to find the resource data specified relative to the .rc file being compiled, the source file path is preppended in the include list so that the original source path takes priority over all the other includes paths specified. A space was added in the CMAKE_INCLUDE_FLAG_RC to make the include directive work properly for llvm-rc. Checks on the rc.exe showed that the syntax change doesn't affect it's proper operation. Fixes: #20529 | 06 April 2020, 19:19:12 UTC |
| 3db04c1 | Brad King | 06 April 2020, 14:24:28 UTC | Merge topic 'doc-3.15-std-fix' into release-3.17 182a104478 Help: Add 3.15 release note for change in -std= flag for compile features Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4574 | 06 April 2020, 14:24:36 UTC |
| 182a104 | Brad King | 06 April 2020, 13:49:33 UTC | Help: Add 3.15 release note for change in -std= flag for compile features Issue: #19917 | 06 April 2020, 13:54:10 UTC |
| 1a020d9 | Craig Scott | 06 April 2020, 10:34:01 UTC | Merge topic 'docs-CMAKE_FIND_DEBUG_MODE' into release-3.17 477b8b5dfe Help: Improve discoverability of CMAKE_FIND_DEBUG_MODE 218bda9671 Help: Fix CMAKE_FIND_DEBUG_MODE list formatting Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4569 | 06 April 2020, 10:34:15 UTC |
| 477b8b5 | Craig Scott | 04 April 2020, 08:57:50 UTC | Help: Improve discoverability of CMAKE_FIND_DEBUG_MODE | 04 April 2020, 08:59:35 UTC |
| 218bda9 | Craig Scott | 04 April 2020, 07:25:22 UTC | Help: Fix CMAKE_FIND_DEBUG_MODE list formatting | 04 April 2020, 08:59:26 UTC |
| 11998c6 | Brad King | 03 April 2020, 10:58:13 UTC | Merge topic 'ExternalProject-no-extract-bool' into release-3.17 2c4bb705e8 ExternalProject: allow `DOWNLOAD_NO_EXTRACT OFF` Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4562 | 03 April 2020, 10:58:22 UTC |
| a554827 | Brad King | 03 April 2020, 10:55:28 UTC | Merge topic 'rel-linux-openssl' into release-3.17 3a66c7674c Utilities/Release: Update to openssl 1.1.1f Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4563 | 03 April 2020, 10:55:35 UTC |
| 3a66c76 | Brad King | 02 April 2020, 17:06:45 UTC | Utilities/Release: Update to openssl 1.1.1f | 03 April 2020, 10:50:56 UTC |
| d26f15d | Brad King | 02 April 2020, 15:12:42 UTC | Merge topic 'FindPython-fix-VIRTUALENV-eq-FIRST' into release-3.17 81beb28752 FindPython: fix handling when FIND_VIRTUALENV == FIRST Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4557 | 02 April 2020, 15:12:54 UTC |
| 2c4bb70 | Ben Boeckel | 02 April 2020, 12:49:21 UTC | ExternalProject: allow `DOWNLOAD_NO_EXTRACT OFF` Fixes: #20531 | 02 April 2020, 12:55:04 UTC |
| d68794a | Brad King | 01 April 2020, 14:42:31 UTC | Merge topic 'cpack-nsis-version' into release-3.17 aa78a2537c CPack/NSIS: Document and check requirement of at least NSIS 3.0 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4552 | 01 April 2020, 14:43:24 UTC |
| 9b32801 | Brad King | 01 April 2020, 14:42:10 UTC | Merge topic 'xl-cxx14' into release-3.17 46d9006efa XL: Add comment clarifying why we pretend it has full C++11/14 support 4aaa9ea96c XL: C++14 language level flags are only available on Linux Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4551 | 01 April 2020, 14:42:18 UTC |
| 81beb28 | Marc Chevrier | 01 April 2020, 14:15:42 UTC | FindPython: fix handling when FIND_VIRTUALENV == FIRST Fixes: #20525 | 01 April 2020, 14:36:46 UTC |
| 8a0d0cb | Brad King | 31 March 2020, 16:43:31 UTC | Merge topic 'docs_macho_prop_tgt' into release-3.17 01b47293ea Help: Fix inaccuracies and omissions in MACHO_* property docs Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Isuru Fernando <isuruf@gmail.com> Merge-request: !4542 | 31 March 2020, 16:43:41 UTC |
| aa78a25 | Brad King | 31 March 2020, 14:54:31 UTC | CPack/NSIS: Document and check requirement of at least NSIS 3.0 Since commit 9d2816544e (CPack/NSIS: Also preload the "UserInfo.dll" plugin, 2020-01-04, v3.17.0-rc1~204^2) we require NSIS 3.0. Since older versions do not support Windows 8 or above, we can now require at least version 3.0. Fixes: #20514 | 31 March 2020, 14:57:28 UTC |
| 46d9006 | Brad King | 31 March 2020, 14:33:01 UTC | XL: Add comment clarifying why we pretend it has full C++11/14 support Since commit b0f46c48f6 (CompileFeatures: Now able to presume full language level support, 2019-03-06, v3.15.0-rc1~265^2~1) we pretend that the XL compiler has full C++11 and C++14 support so that projects specifying granular features will at least get the corresponding compiler mode. This is a work around for our lack of a full feature check table for this compiler that works in common cases. Add a comment explaining this. Issue: #20521 | 31 March 2020, 14:35:56 UTC |
| 4aaa9ea | Brad King | 31 March 2020, 14:25:49 UTC | XL: C++14 language level flags are only available on Linux Since commit 458ea9d76c (XL: Add C++14 language level flags, 2019-04-15, v3.15.0-rc1~226^2) we use `-qlanglvl=extended1y` for C++14 with XL 16.1. However, that flag is only supported on a Linux host. Issue: #20521 | 31 March 2020, 14:35:56 UTC |
| 69c8bf6 | Brad King | 31 March 2020, 13:19:34 UTC | Merge topic 'link-libs-config-case' into release-3.17 2af18704fd Merge branch 'backport-3.16-link-libs-config-case' 3f976bf201 target_link_libraries: Fix regression in case of $<CONFIG> genex 5a95b5e091 target_link_libraries: Fix regression in case of $<CONFIG> genex Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4544 | 31 March 2020, 13:19:42 UTC |
| 76f08a1 | Brad King | 31 March 2020, 13:17:46 UTC | Merge topic 'aix-ExportImportList-install' into release-3.17 39e5a4da22 AIX: Install ExportImportList script with execute permission Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4545 | 31 March 2020, 13:17:53 UTC |
| 01b4729 | Craig Scott | 29 March 2020, 10:29:17 UTC | Help: Fix inaccuracies and omissions in MACHO_* property docs The VERSION and SOVERSION properties are not true fallbacks for the MACHO_* properties since the MACHO_* properties only affect the embedded version information, but VERSION and SOVERSION also affect other things. | 31 March 2020, 09:08:29 UTC |
| 04d8ed6 | Brad King | 30 March 2020, 17:22:58 UTC | Merge topic 'docs-xcode-gen-scheme-workdir' into release-3.17 6905451e11 Help: Add missing XCODE_SCHEME_WORKING_DIRECTORY 6ff07dac76 Help: Minor typos and formatting for XCODE_SCHEME_WORKING_DIRECTORY Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4543 | 30 March 2020, 17:23:18 UTC |
| 42cefc6 | Brad King | 30 March 2020, 17:21:54 UTC | Merge topic 'llvm_rc_pp' into release-3.17 4bef0e6450 llvm-rc: Enable preprocessing if CMAKE_RC_COMPILER_INIT is an absolute path Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4535 | 30 March 2020, 17:22:02 UTC |
| 39e5a4d | Brad King | 30 March 2020, 15:41:22 UTC | AIX: Install ExportImportList script with execute permission This script was added by commit 0f150b69d3 (AIX: Explicitly compute shared object exports for both XL and GNU, 2019-07-11, v3.16.0-rc1~418^2~2) but does not have a `.sh` extension so our existing install rules neglect to give it execute permission. Our test suite works on AIX in the build tree but the script is broken without execute permission on installation. Fixes: #20520 | 30 March 2020, 15:43:08 UTC |
| 2af1870 | Brad King | 30 March 2020, 15:34:39 UTC | Merge branch 'backport-3.16-link-libs-config-case' | 30 March 2020, 15:34:39 UTC |
| 3f976bf | Brad King | 30 March 2020, 15:08:10 UTC | target_link_libraries: Fix regression in case of $<CONFIG> genex Since commit b8626261e9 (Precompile headers: Add methods to generate PCH sources, 2019-07-13, v3.16.0-rc1~182^2~4) we look up source files for a target using an upper-case configuration even though an original-case name is sufficient. Since commit 36ded610af (PCH: Generate sources during Compute step, 2019-10-05, v3.16.0-rc1~2^2) the source file lookup is the first time we compute many on-demand structures that depend on the configuration name. This caused the `$<CONFIG>` generator expression to evaluate to the upper-case configuration name in some cases where we used original-case before. Fix this by switching the source file lookup to the original-case config name. Add a test covering the symptom that led to the discovery of this problem. Fixes: #20517 | 30 March 2020, 15:33:55 UTC |
| 5a95b5e | Brad King | 30 March 2020, 15:08:10 UTC | target_link_libraries: Fix regression in case of $<CONFIG> genex Since commit b8626261e9 (Precompile headers: Add methods to generate PCH sources, 2019-07-13, v3.16.0-rc1~182^2~4) we look up source files for a target using an upper-case configuration even though an original-case name is sufficient. Since commit 36ded610af (PCH: Generate sources during Compute step, 2019-10-05, v3.16.0-rc1~2^2) the source file lookup is the first time we compute many on-demand structures that depend on the configuration name. This caused the `$<CONFIG>` generator expression to evaluate to the upper-case configuration name in some cases where we used original-case before. Fix this by switching the source file lookup to the original-case config name. Add a test covering the symptom that led to the discovery of this problem. Fixes: #20517 | 30 March 2020, 15:24:27 UTC |
| 6905451 | Craig Scott | 29 March 2020, 11:08:07 UTC | Help: Add missing XCODE_SCHEME_WORKING_DIRECTORY | 29 March 2020, 11:13:56 UTC |
| 6ff07da | Craig Scott | 29 March 2020, 11:13:26 UTC | Help: Minor typos and formatting for XCODE_SCHEME_WORKING_DIRECTORY | 29 March 2020, 11:13:56 UTC |
| e5eb410 | Craig Scott | 28 March 2020, 07:04:58 UTC | Merge topic 'ninja-multi-doc-variable-update' into release-3.17 c8fd26eb57 Help: Move Ninja Multi-Config variable details into their respective pages Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4532 | 28 March 2020, 07:05:10 UTC |
| 4bef0e6 | Lucas Wang | 27 March 2020, 07:46:39 UTC | llvm-rc: Enable preprocessing if CMAKE_RC_COMPILER_INIT is an absolute path `CMAKE_RC_COMPILER_INIT` and `CMAKE_RC_COMPILER` can be set by user, for example `llvm-rc-10` and `D:\LLVM\bin\llvm-rc.exe`. | 27 March 2020, 12:54:58 UTC |
| b835c5d | Brad King | 27 March 2020, 11:45:58 UTC | Merge topic 'ctest-timeout-report' into release-3.17 7fda917fa4 CTest: Fix reported duration on timeout when grindchild keeps pipes open Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4530 | 27 March 2020, 11:46:14 UTC |
| efb2a9f | Brad King | 27 March 2020, 11:44:45 UTC | Merge topic 'vs-clangcl' into release-3.17 f3d7a15010 VS: Fix ClangCL toolset compiler path detection Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4523 | 27 March 2020, 11:45:15 UTC |
| 311848f | Brad King | 27 March 2020, 11:44:05 UTC | Merge topic 'FindPython-variable-spelling-error' into release-3.17 63580668a8 FindPython: fix variable spelling error Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4529 | 27 March 2020, 11:44:12 UTC |
| f6c3820 | Brad King | 27 March 2020, 11:42:33 UTC | Merge topic 'CheckIPOSupported-cleanup-cache' into release-3.17 4b8297721f CheckIPOSupported: Avoid polluting cache with common name 'result' Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Kyle Edwards <kyle.edwards@kitware.com> Merge-request: !4528 | 27 March 2020, 11:43:02 UTC |
| 1915a09 | Brad King | 27 March 2020, 11:41:50 UTC | Merge topic 'nmc-cl-showincludes' into release-3.17 6c7e6b1e49 Ninja Multi-Config: Fix MSVC showincludes prefix detection Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Kyle Edwards <kyle.edwards@kitware.com> Merge-request: !4526 | 27 March 2020, 11:41:57 UTC |
| 2fe8ea5 | Brad King | 27 March 2020, 11:38:36 UTC | Merge topic 'llvm-rc-stderr' into release-3.17 dc93cbb0d8 llvm-rc: Print stderr output when calling tools through cmake_llvm_rc Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4525 | 27 March 2020, 11:39:29 UTC |
| 032df7a | Brad King | 27 March 2020, 11:38:15 UTC | Merge topic 'llvm-rc-depfile' into release-3.17 2c724c3aea llvm-rc: Write depfile to location specified by the generator 4cc876540e llvm-rc: Select preprocessor from active languages Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4524 | 27 March 2020, 11:38:22 UTC |
| 0af3a9b | Brad King | 27 March 2020, 11:35:03 UTC | Merge topic 'make-nested-silent' into release-3.17 d6d9da5178 Makefiles: Fix silencing of nested calls for GNU make 4.3 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4515 | 27 March 2020, 11:35:12 UTC |
| c8fd26e | Kyle Edwards | 26 March 2020, 19:33:48 UTC | Help: Move Ninja Multi-Config variable details into their respective pages | 26 March 2020, 19:33:48 UTC |
| 7fda917 | Brad King | 26 March 2020, 18:25:40 UTC | CTest: Fix reported duration on timeout when grindchild keeps pipes open Since commit d1976cd1f2 (CTest: Fix timeout when grandchild keeps pipes open, 2020-01-13, v3.17.0-rc1~169^2) we no longer hang, but the test duration we report after the timeout is the amount of time the immediate child ran before exiting. Fix the logic to instead report the actual amount of time we spent monitoring the test before the timeout. Fixes: #20509 | 26 March 2020, 18:35:54 UTC |
| 6358066 | Marc Chevrier | 26 March 2020, 17:08:25 UTC | FindPython: fix variable spelling error | 26 March 2020, 17:08:25 UTC |
| 4b82977 | Brad King | 26 March 2020, 16:57:07 UTC | CheckIPOSupported: Avoid polluting cache with common name 'result' Fixes: #20508 | 26 March 2020, 16:57:07 UTC |
| 6c7e6b1 | Brad King | 26 March 2020, 12:47:36 UTC | Ninja Multi-Config: Fix MSVC showincludes prefix detection Activate the detection logic for this generator too. Fixes: #20506 | 26 March 2020, 12:47:36 UTC |
| f3d7a15 | Brad King | 25 March 2020, 19:25:39 UTC | VS: Fix ClangCL toolset compiler path detection Prior to commit 3c125c6de0 (VS: Support Visual Studio Clang Toolkit identification, 2019-12-03, v3.17.0-rc1~341^2) using `-T ClangCL` would work but `CMAKE_{C,CXX}_COMPILER` would be detected as `cl.exe` even though `clang-cl.exe` is the actual compiler. That commit attempted to fix the detection by using `$(ClangClExecutable)` as we do for LLVM-distributed toolsets, but that is not actually defined. Instead, look for `$(CLToolExe)` in the `PATH`. Fixes: #20504 | 26 March 2020, 12:18:25 UTC |
| dc93cbb | Thomas Bernard | 25 March 2020, 22:34:34 UTC | llvm-rc: Print stderr output when calling tools through cmake_llvm_rc The stored error pipe is output if the program fails. Fixes: #20494 | 26 March 2020, 11:59:55 UTC |
| d6d9da5 | Brad King | 23 March 2020, 12:51:15 UTC | Makefiles: Fix silencing of nested calls for GNU make 4.3 Since GNU make 4.3, `.SILENT:` no longer causes nested `$(MAKE)` calls to get `-s` implicitly. Add the `-s` flag explicitly on such calls to suppress messages about Entering/Leaving directories. Fixes: #20487 | 26 March 2020, 11:34:24 UTC |
| 2c724c3 | Thomas Bernard | 25 March 2020, 20:49:37 UTC | llvm-rc: Write depfile to location specified by the generator Move the depfile flags to `CMAKE_DEPFILE_FLAGS_RC` so that they are only usedwith generators that use depfiles. Also switch to using the `<DEPFILE>` placeholder for the location of the depfile so that it goes where the generator expects. Fixes: #20493 | 26 March 2020, 11:26:21 UTC |
| 4cc8765 | Thomas Bernard | 25 March 2020, 20:55:41 UTC | llvm-rc: Select preprocessor from active languages The llvm-rc preprocessor is selected according to the CMAKE_C_COMPILER_ID / CMAKE_CXX_COMPILER_ID which are only defined when the C or CXX language is active. | 26 March 2020, 11:25:33 UTC |
| d14626a | Brad King | 25 March 2020, 12:12:59 UTC | Merge topic 'FindPython-polish' into release-3.17 bf1ecfef7f FindPython: misc. fixes Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4519 | 25 March 2020, 12:13:06 UTC |
| bf1ecfe | Marc Chevrier | 24 March 2020, 17:13:03 UTC | FindPython: misc. fixes Help: Fix errors regardings HINTS. Code: Optimize Python signature cache variable to avoid unecessary searchs. | 24 March 2020, 17:26:16 UTC |
| c1ad4a7 | Brad King | 23 March 2020, 14:54:34 UTC | Merge topic 'doc-typo' into release-3.17 356c7cec2c Help: Fixed typo in CMAKE_INSTALL_RPATH_USE_LINK_PATH.rst Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4516 | 23 March 2020, 14:54:41 UTC |
| 356c7ce | Jaak Ristioja | 23 March 2020, 12:47:28 UTC | Help: Fixed typo in CMAKE_INSTALL_RPATH_USE_LINK_PATH.rst Signed-off-by: Jaak Ristioja <jaak@ristioja.ee> | 23 March 2020, 13:46:08 UTC |
| 170087f | Brad King | 23 March 2020, 13:27:36 UTC | Merge topic 'cmake-gui-open-check' into release-3.17 ecc0086bfc cmake-gui: Fix use-after-free in Open-possible check Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4508 | 23 March 2020, 13:27:43 UTC |
| ecc0086 | Francisco Facioni | 20 March 2020, 11:10:35 UTC | cmake-gui: Fix use-after-free in Open-possible check Fix `QCMake::checkOpenPossible` to copy `toLocal8Bit().data()` before its lifetime expires. | 20 March 2020, 12:38:31 UTC |
| e3185e3 | Brad King | 20 March 2020, 10:26:14 UTC | CMake 3.17.0 | 20 March 2020, 10:26:14 UTC |
| dfca188 | Brad King | 20 March 2020, 10:22:41 UTC | Merge topic 'FindMatlab-r2020' into release-3.17 75331a4578 FindMatlab: Add R2020a=9.8 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4507 | 20 March 2020, 10:22:48 UTC |
| 3ab89b5 | Brad King | 20 March 2020, 10:17:24 UTC | Merge topic 'GetPrerequisites-vcruntime-is-system' into release-3.17 417b765f5a GetPrerequisites: Classify vcruntime libraries as system Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4506 | 20 March 2020, 10:17:49 UTC |
| 119d1da | Brad King | 20 March 2020, 10:16:50 UTC | Merge topic 'export-repeat' into release-3.17 8affe9aa33 export: Fix use-after-free on multiple calls overwriting same FILE Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4494 | 20 March 2020, 10:17:00 UTC |
| 75331a4 | Michael Hirsch, Ph.D | 11 February 2020, 16:41:03 UTC | FindMatlab: Add R2020a=9.8 This allows Matlab R2020a to be recognized as a valid Matlab version. | 19 March 2020, 16:47:10 UTC |
| 417b765 | Err0rC0deX | 14 October 2019, 09:20:34 UTC | GetPrerequisites: Classify vcruntime libraries as system Previously GetPrerequisites classified `vcruntime*.dll` as type "other". They should be classified as type "system". | 19 March 2020, 14:17:40 UTC |
| 8fad32f | Brad King | 19 March 2020, 10:57:44 UTC | Merge topic 'trace-format-json-doc' into release-3.17 1994f950ff cmake: List valid values for --trace-format on the command line e39766d84a Help: Fix documentation of --trace-format parameter Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4500 | 19 March 2020, 10:57:51 UTC |
| 8affe9a | Brad King | 18 March 2020, 13:51:46 UTC | export: Fix use-after-free on multiple calls overwriting same FILE CMake 3.16 and below allow multiple `export()` calls with the same output file even without using `APPEND`. The implementation worked by accident by leaking memory. Refactoring in commit 5444a8095d (cmGlobalGenerator: modernize memrory managemenbt, 2019-12-29, v3.17.0-rc1~239^2) cleaned up that memory leak and converted it to a use-after-free instead. The problem is caused by using the `cmGlobalGenerator::BuildExportSets` map to own `cmExportBuildFileGenerator` instances. It can own only one instance per output FILE name at a time, so repeating use of the same file now frees the old `cmExportBuildFileGenerator` instance and leaves the pointer in the `cmMakefile::ExportBuildFileGenerators` vector dangling. Move ownership of the instances into `cmMakefile`'s vector since its entries are not replaced on a repeat output FILE. In future work we should introduce a policy to error out on this case. For now simply fix the use-after-free to restore CMake <= 3.16 behavior. Fixes: #20469 | 19 March 2020, 10:41:39 UTC |
| 1994f95 | Kyle Edwards | 18 March 2020, 20:16:46 UTC | cmake: List valid values for --trace-format on the command line | 18 March 2020, 20:16:46 UTC |
| e39766d | Kyle Edwards | 18 March 2020, 20:02:04 UTC | Help: Fix documentation of --trace-format parameter | 18 March 2020, 20:02:04 UTC |
| 9abc99e | Brad King | 18 March 2020, 11:54:11 UTC | Merge topic 'FindPython-version-validation-fix' into release-3.17 cc7f116cb4 FindPython: fix regression on version validation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4492 | 18 March 2020, 11:54:23 UTC |
| cc7f116 | Marc Chevrier | 17 March 2020, 13:50:43 UTC | FindPython: fix regression on version validation In commit 3dab4682f6 (FindPython: reduces consumption of resources, 2020-02-10, v3.17.0-rc1~11^2) we accidentally broke the python executable version validation when the "LOCATION" strategy is used with the plain `FindPython` module. Fix the logic and add test cases covering those combinations. Fixes: #20465 | 17 March 2020, 14:08:34 UTC |
| b145196 | Brad King | 17 March 2020, 11:51:17 UTC | Merge topic 'FindThreads-doc' into release-3.17 1502f281dd FindThreads: Improve documentation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4480 | 17 March 2020, 11:51:24 UTC |
| 1502f28 | Rolf Eike Beer | 16 March 2020, 15:29:52 UTC | FindThreads: Improve documentation Issue: #19823 | 16 March 2020, 15:46:38 UTC |
| 02fa6fd | Brad King | 12 March 2020, 16:58:38 UTC | Merge topic 'generated-byproducts-docs' into release-3.17 3eb2b62d21 Help: Expand discussion of GENERATED / BYPRODUCTS 1853c7f571 Help: Add missing word in AUTOGEN_TARGET_DEPENDS.rst Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4472 | 12 March 2020, 16:58:46 UTC |
| 3eb2b62 | FeRD (Frank Dana) | 12 March 2020, 15:29:24 UTC | Help: Expand discussion of GENERATED / BYPRODUCTS - Mention the Makefile Generators' `make clean` removal in the BYPRODUCTS section of add_custom_command and add_custom_target - Expand the GENERATED property docs' description of which files will be marked with the property, and of what it implies (including `make clean` removal) | 12 March 2020, 15:55:10 UTC |
| 1853c7f | FeRD (Frank Dana) | 12 March 2020, 15:19:43 UTC | Help: Add missing word in AUTOGEN_TARGET_DEPENDS.rst | 12 March 2020, 15:55:10 UTC |
| 1ec72e0 | Brad King | 12 March 2020, 13:45:24 UTC | CMake 3.17.0-rc3 | 12 March 2020, 13:45:24 UTC |
| c852c0d | Brad King | 12 March 2020, 13:33:05 UTC | Merge topic 'apple-clang-flags-c++17' into release-3.17 a67f2d00d8 Apple Clang: add flags for C++17 standard Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4468 | 12 March 2020, 13:33:18 UTC |
| d584d01 | Brad King | 12 March 2020, 13:31:54 UTC | Merge topic 'swift-link-line-spaces' into release-3.17 af39d1b993 Swift: Fix quoting of library search paths with spaces Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4469 | 12 March 2020, 13:32:01 UTC |
| af39d1b | Saleem Abdulrasool | 12 March 2020, 03:25:34 UTC | Swift: Fix quoting of library search paths with spaces The library search paths added by commit 2746c61e6d (Swift: Add library search paths for dependencies, 2019-06-09, v3.16.0-rc1~561^2) need to be quoted properly on command lines to handle spaces and such. This was already done by `cmLinkLineComputer::ComputeLinkPath` for non-Swift-specific link directories. | 12 March 2020, 12:46:11 UTC |
| 3cf22df | Brad King | 12 March 2020, 12:19:06 UTC | Merge topic 'ctest-curl-debugfunction' into release-3.17 7a1cce210b CTest: Fix our internal CURL_DEBUGFUNCTION to conform to CURL docs Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4459 | 12 March 2020, 12:19:43 UTC |
| c278b4e | Brad King | 12 March 2020, 12:18:47 UTC | Merge topic 'FindPython-ENV-CMAKE_FRAMEWORK_PATH' into release-3.17 1044776472 FindPython: Convert env CMAKE_FRAMEWORK_PATH to CMake path Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Marc Chevrier <marc.chevrier@gmail.com> Merge-request: !4462 | 12 March 2020, 12:18:54 UTC |
| c5f850d | Brad King | 12 March 2020, 12:17:56 UTC | Merge topic 'swift-rpath' into release-3.17 f481b3a947 Swift: repair RPATH handling for macOS Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4456 | 12 March 2020, 12:18:03 UTC |
| a67f2d0 | Marc Chevrier | 12 March 2020, 09:55:58 UTC | Apple Clang: add flags for C++17 standard | 12 March 2020, 12:09:12 UTC |
| 3d388e5 | Craig Scott | 12 March 2020, 10:52:02 UTC | Merge topic 'rename-macho-version-properties' into release-3.17 14732d3f30 macOS: Rename OSX_*_VERSION properties to MACHO_*_VERSION Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4452 | 12 March 2020, 10:52:11 UTC |
| 14732d3 | Brad King | 10 March 2020, 14:22:54 UTC | macOS: Rename OSX_*_VERSION properties to MACHO_*_VERSION The properties added by commit 4a62e3d97c (macOS: Add OSX_COMPATIBILITY_VERSION and OSX_CURRENT_VERSION properties, 2020-01-24, v3.17.0-rc1~80^2~1) are general-purpose for all platforms using Mach-O formats and not just on OS X. Rename them accordingly. The properties are new to the CMake 3.17 release so we can rename them without compatibility concerns. Fixes: #20442 | 12 March 2020, 10:15:40 UTC |
| 7a1cce2 | Betsy McPhail | 11 March 2020, 15:41:26 UTC | CTest: Fix our internal CURL_DEBUGFUNCTION to conform to CURL docs The curl debug callback function must return ``0``. Fixes: #20449 | 11 March 2020, 17:36:58 UTC |
| 1044776 | Bo Anderson | 11 March 2020, 17:05:32 UTC | FindPython: Convert env CMAKE_FRAMEWORK_PATH to CMake path | 11 March 2020, 17:35:33 UTC |
| dd45b7b | Brad King | 11 March 2020, 12:56:33 UTC | Merge topic 'FindCUDAToolkit-reduce-verbosity' into release-3.17 a7cf574417 CUDAToolkit: Mark find queries as advanced variables Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4455 | 11 March 2020, 12:56:40 UTC |
| f481b3a | Saleem Abdulrasool | 11 March 2020, 01:49:26 UTC | Swift: repair RPATH handling for macOS The configuration previously handled Linux properly but did not function on macOS as `ld64` does not support `:` delimited paths. Account for that by setting it to the empty string which will use multiple invocations of the `-Xlinker -rpath -Xlinker ...` pattern to compute the correct RPATH. | 11 March 2020, 12:45:47 UTC |
| a7cf574 | Robert Maynard | 10 March 2020, 17:10:08 UTC | CUDAToolkit: Mark find queries as advanced variables Fixes #20435 | 10 March 2020, 17:27:16 UTC |
| 7b7170a | Brad King | 10 March 2020, 14:29:11 UTC | Merge topic 'release-notes-minor-cleanups' into release-3.17 d5e6fedd7b Help: Cleanup minor typos and grammar in 3.17 release notes Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4449 | 10 March 2020, 14:30:07 UTC |
| 51c8ac8 | Brad King | 10 March 2020, 14:29:08 UTC | Merge topic 'doc-3.17-relnotes' into release-3.17 6b925d0536 Help: Fix 3.17 release notes for Xcode scheme settings e0409b8bca Help: Fix toctree order of Xcode scheme variable and property Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4447 | 10 March 2020, 14:29:14 UTC |
| 2427bbf | Kyle Edwards | 10 March 2020, 14:16:07 UTC | Merge topic 'swift-ninja-multiconfig' into release-3.17 65b3848de0 Swift: support Ninja Multi-Config Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4440 | 10 March 2020, 14:16:17 UTC |
