566e96d | Brad King | 15 September 2020, 12:34:16 UTC | CMake 3.17.5 | 15 September 2020, 12:34:16 UTC |
2058c7a | Brad King | 15 September 2020, 12:32:26 UTC | Merge branch 'backport-3.17-automoc-path-prefix-off' into release-3.17 | 15 September 2020, 12:32:26 UTC |
3ef992e | Brad King | 15 September 2020, 12:32:11 UTC | Merge branch 'release-3.16' into release-3.17 | 15 September 2020, 12:32:11 UTC |
205d543 | Joerg Bornemann | 06 August 2020, 06:20:16 UTC | Help: Add 3.17.5 release note about AUTOMOC_PATH_PREFIX default change | 15 September 2020, 12:31:35 UTC |
b9bcec4 | Brad King | 15 September 2020, 12:29:12 UTC | Merge branch 'backport-3.16-automoc-path-prefix-off' | 15 September 2020, 12:29:12 UTC |
43ddc64 | Brad King | 15 September 2020, 12:11:59 UTC | CMake 3.16.9 | 15 September 2020, 12:11:59 UTC |
37b669a | Brad King | 15 September 2020, 12:11:45 UTC | Merge branch 'backport-3.16-automoc-path-prefix-off' into release-3.16 | 15 September 2020, 12:11:45 UTC |
52217c3 | Joerg Bornemann | 06 August 2020, 06:20:16 UTC | Help: Add 3.16.9 release note about AUTOMOC_PATH_PREFIX default change | 15 September 2020, 12:10:31 UTC |
30fec0d | Brad King | 31 August 2020, 17:44:44 UTC | Merge branch 'backport-3.17-automoc-depend-project-file' into release-3.17 Merge-request: !5166 | 31 August 2020, 17:44:44 UTC |
6b20bbd | Joerg Bornemann | 26 August 2020, 15:42:52 UTC | AutoMoc: Restore support for re-running after project file changes For Qt >= 5.15.0 and Ninja generators AutoMoc creates a depfile to let Ninja decide when to run AutoMoc. This was introduced by commit aebfbcaa46 (AutoGen: Use depfiles for the XXX_autogen ninja targets, 2020-01-14, v3.17.0-rc1~58^2). However, AutoMoc was not triggered after adding a new moc-able file to the project. This patch adds the project file (and potentially included files) to the dependencies in the depfile. Now, a re-run of AutoMoc is triggered if the project file changes. Fixes: #21127 | 31 August 2020, 17:07:23 UTC |
9fbd3df | Brad King | 27 August 2020, 15:12:51 UTC | Merge branch 'backport-3.17-cmext-vs16-declval' into release-3.17 Merge-request: !4971 | 27 August 2020, 15:13:20 UTC |
d2f8912 | Sumit Bhardwaj | 03 July 2020, 06:36:10 UTC | Implement cm::static_reference_cast by declval Previously, cm::static_reference_cast used invoke_result_t and took the address of O::get. This is not in complete conformance with standard. This MR changes the implementation to use std::declval<O>.get() which is always well-defined. | 27 August 2020, 15:12:25 UTC |
09507da | Brad King | 10 August 2020, 16:21:30 UTC | Merge branch 'backport-3.17-automoc-path-prefix-off' into release-3.17 Merge-request: !5105 | 10 August 2020, 16:21:30 UTC |
521ed96 | Brad King | 10 August 2020, 16:19:09 UTC | Merge branch 'backport-3.16-automoc-path-prefix-off' into release-3.16 Merge-request: !5105 | 10 August 2020, 16:19:09 UTC |
e503fbe | Brad King | 10 August 2020, 14:41:06 UTC | Merge branch 'backport-3.16-automoc-path-prefix-off' | 10 August 2020, 14:41:06 UTC |
4c33b30 | Joerg Bornemann | 06 August 2020, 06:20:16 UTC | Autogen: Turn off moc path prefix generation by default Change the default value of `CMAKE_AUTOMOC_PATH_PREFIX` to `OFF` to restore compatibility with behavior of CMake 3.15 and below. C++ source files that are generated by Qt's meta object compiler (moc) include the header file that was passed as input argument to moc. This is usually a path relative to the source directory, for example #include "../../source/dir/myobject.h" That is problematic for reproducible builds as described in #18815. To cope with that, the target property AUTOMOC_PATH_PREFIX was introduced in CMake 3.16 by commit d018d27c10 (Autogen: Add moc path prefix generation (AUTOMOC_PATH_PREFIX), 2019-09-13, v3.16.0-rc1~94^2~4). The property is default-initialized from the variable `CMAKE_AUTOMOC_PATH_PREFIX`, which defaults to `ON`. If this property is ON, and myobject.h is located in an include directory of the target, moc-generated C++ files include the file without the "path prefix": #include "myobject.h" This behavior, however, can break projects that have equally named header files in different include directories. As "not breaking existing projects" trumps "have reproducible builds by default" we change the default of `CMAKE_AUTOMOC_PATH_PREFIX` to `OFF`. Also, it is now possible to pass `-DCMAKE_AUTOMOC_PATH_PREFIX=ON` on the CMake command line. Before, it was overridden in `CMakeGenericSystem`. Fixes: #20598 Issue: #18815 | 10 August 2020, 14:36:17 UTC |
56510b7 | Brad King | 07 August 2020, 14:51:48 UTC | Merge branch 'backport-test-FindPkgConfig-isolate-env' into release-3.17 Merge-request: !5108 | 07 August 2020, 14:51:48 UTC |
0ccdcd6 | Brad King | 07 August 2020, 14:51:28 UTC | Merge branch 'backport-test-FindPkgConfig-isolate-env' into release-3.16 Merge-request: !5108 | 07 August 2020, 14:51:28 UTC |
4c939b0 | Brad King | 07 August 2020, 14:30:42 UTC | Tests: Isolate RunCMake.FindPkgConfig from caller environment Avoid interference from `CMAKE_PREFIX_PATH` and friends if they happen to be set in the environment from which the tests are run. | 07 August 2020, 14:47:25 UTC |
effc9a1 | Brad King | 03 August 2020, 18:09:53 UTC | Merge branch 'backport-3.17-automoc_timestamp_deps' into release-3.17 Merge-request: !5085 | 05 August 2020, 19:44:14 UTC |
7445c9a | Alexandru Croitor | 03 August 2020, 10:23:07 UTC | AutoGen: Add test to check for correct AutoMoc dependencies When using Qt 5.15.0 or above together with Ninja, check that touching a source file of a dependency does not needlessly re-run AUTOMOC for the dependee target. | 03 August 2020, 17:38:16 UTC |
a79056b | Alexandru Croitor | 31 July 2020, 15:50:37 UTC | AutoGen: Fix over-specified direct dependencies of custom command The AutoMoc timestamp creating custom command explicitly depended on all dependencies of the origin target (associated to the AutoGen target). When an origin target depended on a shared library 'libfoo.so', if it was re-linked, the AutoMoc custom command would touch its output timestamp file, and thus cause needless rebuilding of sources, despite the shared library not having any influence on the AutoMoc generated files. Introduce a new '<target>_autogen_timestamp_deps' utility target, which will serve as an 'order-only' dependency for the custom command. This will prevent needless rebuilding, because touching 'libfoo.so' will not cause the custom command to be re-executed. The new AutoMoc dependency tree looks like: '_autogen_timestamp_deps (serves as order-only dep)' <- '<target_autogen>/timestamp' file ( + moc deps file) <- '<target>_autogen' target. Fixes: #21020 | 03 August 2020, 17:38:11 UTC |
507fecd | Brad King | 03 August 2020, 16:25:10 UTC | Merge branch 'ninja-multi-rsp-remove-path' into release-3.17 Merge-request: !5094 | 03 August 2020, 16:25:10 UTC |
cdb50af | Kyle Edwards | 03 August 2020, 14:45:17 UTC | Ninja: Restore shorter path to response files In commit 99ed39b011 (Ninja Multi-Config: Make link response files per-config, 2020-07-15, v3.17.4~3^2), we added the target directory to the response file under the mistaken assumption that two different targets with the same name could be in different directories. However, this causes the path to the response file to be too long to fit on a command line. Take the path back out, while leaving in the per-config split. Fixes: #21050 | 03 August 2020, 16:14:16 UTC |
103d6fa | Brad King | 30 July 2020, 14:30:07 UTC | CMake 3.17.4 | 30 July 2020, 14:30:07 UTC |
e82bc59 | Brad King | 24 July 2020, 12:59:11 UTC | Merge branch 'bootstrap-intel' into release-3.17 Merge-request: !5057 | 24 July 2020, 12:59:11 UTC |
7964662 | Brad King | 24 July 2020, 12:48:02 UTC | bootstrap: Fix support for Intel compiler with modern GNU system compiler On systems with older GNU system compilers, the Intel C++ compiler does not define `__cplusplus` to any version newer than C++11. This prevented `bootstrap` from detecting that a given C++ standard flag has enabled C++17 mode in the compiler. In commit 033a4b12a5 (bootstrap: Extend C++17 check for our cast functions, 2019-12-14, v3.17.0-rc1~291^2) we added a preprocessor condition to attempt to detect C++17 mode in the Intel compiler on such systems by looking for `__cpp_if_constexpr`. However, on systems with a modern GNU system compiler, that definition is available even in C++11 mode. Switch to using `__cpp_deduction_guides` to detect C++17 mode for the Intel C++ compiler. That seems to be defined exclusively in C++17 mode regardless of the version of the system compiler. Fixes: #21013 | 24 July 2020, 12:53:13 UTC |
e817818 | Brad King | 21 July 2020, 20:35:53 UTC | Merge branch 'backport-3.17-graphviz-restore-per-target' into release-3.17 Merge-request: !5039 | 21 July 2020, 20:35:53 UTC |
f3a6b4a | Stephan Rohmen | 21 July 2020, 17:47:34 UTC | Tests: Cover Graphviz support for per-target dependency graph options Issue: #20928 | 21 July 2020, 18:55:44 UTC |
93549b9 | Stephan Rohmen | 21 July 2020, 17:45:45 UTC | Graphviz: Restore support for per-target dependency graph options The behaviors controlled by options `GRAPHVIZ_GENERATE_PER_TARGET` and `GRAPHVIZ_GENERATE_DEPENDERS` were broken by commit 553658393c (Graphviz: added test suite, fixes, enhancements, 2019-10-08, v3.17.0-rc1~615^2). It had not been covered in the test suite previously, and those changes left out checks for these features from the `default_options` case. Implement the previously-existing behavior in the new graphviz generation engine added by the above-mentioned commit. Fixes: #20928 | 21 July 2020, 18:55:44 UTC |
ffe425f | Brad King | 16 July 2020, 16:02:54 UTC | Merge branch 'ninja-multi-rsp' into release-3.17 Merge-request: !5020 | 16 July 2020, 16:02:54 UTC |
99ed39b | Kyle Edwards | 15 July 2020, 17:12:02 UTC | Ninja Multi-Config: Make link response files per-config Fixes: #20961 | 16 July 2020, 15:57:46 UTC |
5a745cf | Brad King | 08 June 2020, 12:25:59 UTC | Merge branch 'FindOpenSSL-3.0' into release-3.17 Merge-request: !4860 | 08 June 2020, 12:25:59 UTC |
796b447 | Billy Brumley | 06 June 2020, 07:31:59 UTC | FindOpenSSL: Fix OpenSSL 3.0.0 version extraction Fix the regex syntax added by commit 61d746e592 (FindOpenSSL: Detect OpenSSL 3.0.0, 2020-05-27, v3.17.3~1^2). Add missing escapes. Test with `openssl-3.0.0-alpha3`. While at it, also unset a temporary variable after use. | 08 June 2020, 12:24:57 UTC |
37955f8 | Brad King | 03 June 2020, 10:04:11 UTC | Merge topic 'pch-no-Fortran' into release-3.17 10c88c4337 PCH: Do not enable GNU or Intel PCH settings for Fortran Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4843 | 03 June 2020, 10:04:39 UTC |
73086da | Brad King | 03 June 2020, 10:03:37 UTC | Merge topic 'vs-sln-version-16' into release-3.17 b69010b719 VS: Fix .sln support for VS Version Selector with VS 2019 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4844 | 03 June 2020, 10:03:43 UTC |
b69010b | Brad King | 02 June 2020, 14:30:33 UTC | VS: Fix .sln support for VS Version Selector with VS 2019 VS 2019 changed the naming pattern used by 2015 and 2017. Fixes: #20783 | 02 June 2020, 14:30:33 UTC |
10c88c4 | Brad King | 02 June 2020, 12:16:49 UTC | PCH: Do not enable GNU or Intel PCH settings for Fortran The PCH settings are shared by C and CXX languages but do not make sense for Fortran. In particular, `CMAKE_PCH_EXTENSION` should not be set because it can overwrite the value set for C/C++ languages, which may have a different compiler vendor than the Fortran compiler. Fixes: #20752 | 02 June 2020, 12:23:40 UTC |
20ca1c0 | Brad King | 01 June 2020, 13:31:13 UTC | Merge branch 'release-3.16' into release-3.17 | 01 June 2020, 13:31:13 UTC |
39c6ac5 | Brad King | 01 June 2020, 11:56:25 UTC | CMake 3.16.8 | 01 June 2020, 11:56:25 UTC |
f671372 | Brad King | 01 June 2020, 11:44:28 UTC | Merge topic 'pch-fix-bad-ClearSourcesCache' into release-3.17 902858367f Merge branch 'backport-3.16-pch-fix-bad-ClearSourcesCache' fa7b041eca PCH: Fix logic error that incorrectly clears sources during VS generation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4815 | 01 June 2020, 11:44:34 UTC |
70b8a28 | Brad King | 01 June 2020, 11:36:42 UTC | Merge topic 'ninja-multi-export-all-symbols' into release-3.17 6fc4bfa11c Ninja Multi-Config: Fix bug in CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Alex Reinking <alex_reinking@berkeley.edu> Merge-request: !4825 | 01 June 2020, 11:36:49 UTC |
6fc4bfa | Kyle Edwards | 29 May 2020, 19:28:43 UTC | Ninja Multi-Config: Fix bug in CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS Fixes: #20775 | 29 May 2020, 19:28:43 UTC |
1e4aaa3 | Brad King | 29 May 2020, 11:11:49 UTC | Merge topic 'FindSubversion-xcode-removed' into release-3.17 2c0db404d1 FindSubversion: Do not accept macOS stub without Xcode implementation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4813 | 29 May 2020, 11:11:57 UTC |
5ff1a25 | Brad King | 29 May 2020, 10:20:41 UTC | Merge branch 'backport-3.16-pch-fix-bad-ClearSourcesCache' into release-3.16 Merge-request: !4815 | 29 May 2020, 10:20:41 UTC |
9028583 | Brad King | 29 May 2020, 10:12:17 UTC | Merge branch 'backport-3.16-pch-fix-bad-ClearSourcesCache' | 29 May 2020, 10:14:59 UTC |
fa7b041 | Brad King | 28 May 2020, 21:29:31 UTC | PCH: Fix logic error that incorrectly clears sources during VS generation Since commit 729d997f10 (Precompile Headers: Add REUSE_FROM signature, 2019-08-30, v3.16.0-rc1~101^2), `GetPchFileObject` handles the case that it is called first for another target's `REUSE_FROM` by calling `AddSource` to make sure `GetObjectName` can produce the correct object name. However, `AddSource` causes `ClearSourcesCache` to be called, which since commit a9f4f58f0c (cmGeneratorTarget: Clear AllConfigSources in ClearSourcesCache, 2020-05-15, v3.16.7~2^2) now correctly erases the `AllConfigSources` structure. This is okay during `AddPchDependencies`, but there is another code path in which it is problematic. When the Visual Studio generator's `WriteAllSources` method is looping over the sources, the `cmake_pch.cxx` source is encountered first. This causes `OutputSourceSpecificFlags` to call `GetPchCreateCompileOptions`, which calls `GetPchFile`, which under MSVC with `CMAKE_LINK_PCH` calls `GetPchFileObject`. That leads to `ClearSourcesCache` erasing the structure over which `WriteAllSources` is iterating! This bug is caught by our `RunCMake.PrecompileHeaders` test when run with the VS generator as of the commit that exposed it by fixing `ClearSourcesCache`. However, that change was backported to the CMake 3.16 series after testing only with later versions versions that contain commit a55df20499 (Multi-Ninja: Add precompile headers support, 2020-01-10, v3.17.0-rc1~136^2). By adding proper multi-config support for PCH, that commit taught `cmLocalGenerator::AddPchDependencies` to call `GetPchFile` with the real set of configurations instead of just the empty string. This allows the `GetPchFile` cache of PCH sources to be populated up front so that the later calls to it in the `WriteAllSources` loop as described above do not actually call `GetPchFileObject` or `ClearSourcesCache`. That hid the problem. Fix this by re-ordering calls to `AddPchDependencies` to handle `REUSE_FROM` targets only after the targets whose PCH they re-use. Remove the now-unnecessary call to `AddSource` from `GetPchFileObject` so that `ClearSourcesCache` is never called during `WriteAllSources`. Update the PchReuseFrom test case to cover an ordering of targets that causes generators to encounter a `REUSE_FROM` target before the target whose PCH it re-uses. Fixes: #20770 | 29 May 2020, 09:52:03 UTC |
2c0db40 | Brad King | 28 May 2020, 15:33:53 UTC | FindSubversion: Do not accept macOS stub without Xcode implementation Xcode no longer provides a `svn` implementation, but the `/usr/bin/svn` stub may still exist. | 28 May 2020, 15:37:47 UTC |
e647949 | Brad King | 28 May 2020, 10:57:26 UTC | CMake 3.17.3 | 28 May 2020, 10:57:26 UTC |
54eeccb | Brad King | 28 May 2020, 10:50:44 UTC | Merge topic 'openssl-3.0.0' into release-3.17 61d746e592 FindOpenSSL: Detect OpenSSL 3.0.0 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4805 | 28 May 2020, 10:51:52 UTC |
1b8b98a | Brad King | 28 May 2020, 10:50:32 UTC | Merge topic 'fix-cpack-deb-generating-empty-paragraph' into release-3.17 6ba842163c CPack-deb: don't add a line with a dot to pkg desc Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4806 | 28 May 2020, 10:50:40 UTC |
6ba8421 | Jonathan Verner | 27 May 2020, 14:53:06 UTC | CPack-deb: don't add a line with a dot to pkg desc Currently, if the package description ends with a newline (typically if it is read from a file) cpack -deb adds a single line with a dot at the end which leads to a violation of the `extended-description-contains-empty-paragraph` debian policy. This commit fixes the above behaviour. Fixes: #20763 | 27 May 2020, 18:44:28 UTC |
61d746e | Vitezslav Cizek | 27 May 2020, 12:52:17 UTC | FindOpenSSL: Detect OpenSSL 3.0.0 The OpenSSL versioning is changing with the upcoming 3.0.0 release. https://www.openssl.org/blog/blog/2018/11/28/version/ Since 3.0.0, the patch letters are being dropped. The new format is: MAJOR.MINOR.PATCH The OPENSSL_VERSION variable can now be directly derived from the new OPENSSL_VERSION_STR macro. https://www.openssl.org/docs/manmaster/man3/OPENSSL_VERSION_NUMBER.html | 27 May 2020, 13:08:10 UTC |
6fce0cb | Brad King | 27 May 2020, 12:13:48 UTC | Merge topic 'ctest-repeat-notrun' into release-3.17 bbb62dcc72 CTest: Make sure NOT_RUN tests show up in the failed test log c503251997 Tests: Add coverage of ctest_test RETURN_VALUE and REPEAT Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4801 | 27 May 2020, 12:14:21 UTC |
6e1079d | Brad King | 27 May 2020, 12:12:20 UTC | Merge branch 'release-3.16' into release-3.17 | 27 May 2020, 12:12:20 UTC |
bbb62dc | Robert Maynard | 26 May 2020, 15:48:41 UTC | CTest: Make sure NOT_RUN tests show up in the failed test log Issue: #20543 | 27 May 2020, 10:43:01 UTC |
c503251 | Robert Maynard | 26 May 2020, 15:36:05 UTC | Tests: Add coverage of ctest_test RETURN_VALUE and REPEAT | 27 May 2020, 10:39:17 UTC |
e14974a | Brad King | 27 May 2020, 10:13:45 UTC | CMake 3.16.7 | 27 May 2020, 10:13:45 UTC |
15e7259 | Brad King | 25 May 2020, 19:50:10 UTC | Merge topic 'doc-updates' into release-3.17 b3e4fb5144 Help: clarify add_definitions() and add_compile_definitions() behavior Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4786 | 25 May 2020, 19:50:18 UTC |
f0ff991 | Brad King | 25 May 2020, 14:33:17 UTC | Merge topic 'ninja-multi-install' into release-3.17 dddb4f02f7 Ninja Multi-Config: Make "install" targets depend on default configs Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4778 | 25 May 2020, 14:33:26 UTC |
b3e4fb5 | Marc Chevrier | 24 May 2020, 10:47:24 UTC | Help: clarify add_definitions() and add_compile_definitions() behavior Fixes: #20736 | 24 May 2020, 10:47:24 UTC |
dddb4f0 | Kyle Edwards | 22 May 2020, 15:59:17 UTC | Ninja Multi-Config: Make "install" targets depend on default configs And add an "install:all" target. Fixes: #20713 | 22 May 2020, 17:15:50 UTC |
0781540 | Brad King | 22 May 2020, 10:55:22 UTC | Merge topic 'cuda-default-runtime' into release-3.17 e55b21e24e CUDA: Compute CMAKE_CUDA_RUNTIME_LIBRARY default from toolchain 1086e930dc CUDA: Propagate CMAKE_CUDA_RUNTIME_LIBRARY state to try_compile a4ea293153 Help: Correct CMAKE_CUDA_RUNTIME_LIBRARY applicability Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4762 | 22 May 2020, 10:55:37 UTC |
0c557a0 | Brad King | 21 May 2020, 15:36:00 UTC | Merge topic 'FindPython-debug-library-lookup' into release-3.17 71e6854b22 FindPython: use CMAKE specific variables to look-up debug library Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4764 | 21 May 2020, 15:36:08 UTC |
e55b21e | Robert Maynard | 18 May 2020, 19:29:18 UTC | CUDA: Compute CMAKE_CUDA_RUNTIME_LIBRARY default from toolchain Since commit 0d0145138f (CUDA: Add abstraction for cuda runtime selection, 2019-11-29, v3.17.0-rc1~83^2) we add CUDA runtime library selection flags by default. To maintain backwards compatibility the default CUDA runtime library needs to be computed based on what libraries are found on the initial compiler invocation. For example a toolchain could establish initial flags that have all CUDA compilations using the runtime version, and if we don't detect this we will try to link to both the static and shared runtime. Co-Author: Brad King <brad.king@kitware.com> Fixes: #20708 | 21 May 2020, 15:15:03 UTC |
1086e93 | Robert Maynard | 18 May 2020, 14:54:11 UTC | CUDA: Propagate CMAKE_CUDA_RUNTIME_LIBRARY state to try_compile | 20 May 2020, 18:36:55 UTC |
a4ea293 | Robert Maynard | 18 May 2020, 18:34:32 UTC | Help: Correct CMAKE_CUDA_RUNTIME_LIBRARY applicability | 20 May 2020, 18:36:55 UTC |
1174efb | Brad King | 20 May 2020, 13:03:14 UTC | Merge topic 'vs-sln-version' into release-3.17 88ad02f1ec VS: Restore .sln support for VS Version Selector Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4765 | 20 May 2020, 13:03:23 UTC |
041e57a | Brad King | 19 May 2020, 12:39:59 UTC | Merge branch 'vs-sln-version' into release-3.16 Merge-request: !4765 | 19 May 2020, 12:39:59 UTC |
88ad02f | Brad King | 19 May 2020, 12:21:26 UTC | VS: Restore .sln support for VS Version Selector Since commit 3b51343ea1 (VS: Emit UTF-8 BOM for generated solution files, 2019-08-19, v3.16.0-rc1~237^2) the `.sln` file does not work with the VS Version Selector. Add a newline after the BOM to restore support. Fixes: #20725 | 19 May 2020, 12:24:37 UTC |
00949be | Brad King | 18 May 2020, 16:21:57 UTC | Merge topic 'fix-ClearSourcesCache' into release-3.17 a9f4f58f0c cmGeneratorTarget: Clear AllConfigSources in ClearSourcesCache Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4751 | 18 May 2020, 16:23:40 UTC |
71e6854 | Marc Chevrier | 18 May 2020, 13:01:26 UTC | FindPython: use CMAKE specific variables to look-up debug library Fixes: #20714 | 18 May 2020, 13:01:26 UTC |
4d85ad8 | Brad King | 15 May 2020, 14:32:36 UTC | Merge topic 'backport-3.16-FindPkgConfig-isystem' into release-3.17 3719ddd3f3 Help: Add 3.16.7 release note for FindPkgConfig '-isystem' fix Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4752 | 15 May 2020, 14:32:49 UTC |
36599e2 | Brad King | 15 May 2020, 13:53:05 UTC | Merge branch 'fix-ClearSourcesCache' into release-3.16 Merge-request: !4751 | 15 May 2020, 13:53:05 UTC |
481100e | Brad King | 15 May 2020, 13:48:51 UTC | Merge branch 'backport-3.16-FindPkgConfig-isystem' into release-3.16 Merge-request: !4752 | 15 May 2020, 13:48:51 UTC |
3719ddd | Brad King | 14 May 2020, 11:32:19 UTC | Help: Add 3.16.7 release note for FindPkgConfig '-isystem' fix Add a release note for the change in commit 4d446c68d1 (FindPkgConfig: also handle "-isystem" prefixes for include directories, 2020-04-30). | 15 May 2020, 13:46:06 UTC |
e6175e0 | Brad King | 15 May 2020, 13:44:01 UTC | Merge branch 'release-3.16' into release-3.17 | 15 May 2020, 13:44:01 UTC |
784e665 | Brad King | 15 May 2020, 13:14:54 UTC | Merge topic 'objc-env-vars' into release-3.17 13ea190725 Help: Add 3.17.3 release note for Objective C/C++ compiler selection 16bf978e0c Merge branch 'backport-3.16-objc-env-vars' into objc-env-vars 67b9f55d46 Objective C/C++: Honor CC and CXX env vars to select compiler ab9be6662f Help: Document OBJC and OBJCXX env vars for Objective C/C++ compilers Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4746 | 15 May 2020, 13:15:46 UTC |
a9f4f58 | Brad King | 15 May 2020, 12:20:34 UTC | cmGeneratorTarget: Clear AllConfigSources in ClearSourcesCache In commit 40aa6c059c (cmGeneratorTarget: Add method to collect all sources for all configs, 2017-04-10, v3.9.0-rc1~268^2~5) we forgot to update `ClearSourcesCache` to also clear `AllConfigSources`. This leads to subtle cases where code paths like PCH handling that add sources during generation break depending on ordering. Suggested-by: Christian Fersch Fixes: #20712, #20702 | 15 May 2020, 12:26:43 UTC |
b1a3131 | Brad King | 14 May 2020, 11:31:32 UTC | Merge branch 'backport-3.16-objc-env-vars' into release-3.16 | 14 May 2020, 11:31:32 UTC |
13ea190 | Brad King | 14 May 2020, 11:28:46 UTC | Help: Add 3.17.3 release note for Objective C/C++ compiler selection Port the 3.16.7 release note for 3.17.3 too. | 14 May 2020, 11:28:46 UTC |
16bf978 | Brad King | 14 May 2020, 11:27:24 UTC | Merge branch 'backport-3.16-objc-env-vars' into objc-env-vars | 14 May 2020, 11:27:24 UTC |
67b9f55 | Brad King | 14 May 2020, 11:10:09 UTC | Objective C/C++: Honor CC and CXX env vars to select compiler If the `OBJC` or `OBJCXX` environment variable is not set to specify an Objective C or C++ compiler, check `CC` or `CXX` too. Fixes: #20703 | 14 May 2020, 11:17:48 UTC |
ab9be66 | Brad King | 14 May 2020, 11:09:41 UTC | Help: Document OBJC and OBJCXX env vars for Objective C/C++ compilers | 14 May 2020, 11:10:06 UTC |
b07bc05 | Brad King | 13 May 2020, 16:12:12 UTC | Merge topic 'fix-cache-args-file-to-dep-list' into release-3.17 0199dd9f1b ExternalProject: expose _ep_cache_args_script to the caller Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4710 | 13 May 2020, 16:12:28 UTC |
0199dd9 | Ben Boeckel | 05 May 2020, 13:44:54 UTC | ExternalProject: expose _ep_cache_args_script to the caller This is needed so that the caller can add a dependency on the cache file. Fixes: #20668 | 12 May 2020, 14:34:23 UTC |
44ae68d | Brad King | 12 May 2020, 10:52:57 UTC | Merge topic 'vs-pch-compile-opts' into release-3.17 6b2fb4ffd2 VS: Fix using PCH from source with COMPILE_OPTIONS Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4734 | 12 May 2020, 10:53:41 UTC |
91dd23d | Brad King | 12 May 2020, 10:52:14 UTC | Merge topic 'pch-msvc-pragma' into release-3.17 6c2514dabe MSVC: Use 'pragma system_header' in PCH only on cl 19.13 and above Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4736 | 12 May 2020, 10:52:40 UTC |
dc75a07 | Brad King | 12 May 2020, 10:51:24 UTC | Merge topic 'xl-cpp-install' into release-3.17 f7a94cf282 XL: Install our Fortran 'cpp' helper script with execute permission Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4735 | 12 May 2020, 10:51:31 UTC |
4b81040 | Brad King | 11 May 2020, 17:34:25 UTC | Merge branch 'pch-msvc-pragma' into release-3.16 Merge-request: !4736 | 11 May 2020, 17:34:25 UTC |
6c2514d | Brad King | 11 May 2020, 17:29:41 UTC | MSVC: Use 'pragma system_header' in PCH only on cl 19.13 and above VS 2017 15.6 introduced support for this pragma. Older MSVC versions warn that it is unknown. Fixes: #20692 | 11 May 2020, 17:31:15 UTC |
f7a94cf | Brad King | 11 May 2020, 16:11:29 UTC | XL: Install our Fortran 'cpp' helper script with execute permission This script was added by commit 19f267c75e (XL: Add support for Ninja and XL Fortran, 2019-11-21, v3.17.0-rc1~368^2) but does not have a `.sh` extension so our existing install rules neglect to give it execute permission. Our test suite works on XL Fortran in the build tree but the script is broken without execute permission on installation. Fixes: #20695 | 11 May 2020, 16:13:25 UTC |
9cd0523 | Brad King | 11 May 2020, 16:03:45 UTC | Merge branch 'vs-pch-compile-opts' into release-3.16 Merge-request: !4734 | 11 May 2020, 16:03:45 UTC |
6b2fb4f | Brad King | 11 May 2020, 15:56:50 UTC | VS: Fix using PCH from source with COMPILE_OPTIONS If a source file gets per-source flags from both PCH and custom `COMPILE_OPTIONS`, combine them correctly. Fixes: #20694, #20456 | 11 May 2020, 15:58:41 UTC |
4de2cb4 | Brad King | 11 May 2020, 14:12:05 UTC | Merge topic 'FindGTK2-harfbuzz-target' into release-3.17 5ab137b7e9 FindGTK2: Add harfbuzz target for dependency from pango Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4725 | 11 May 2020, 14:12:14 UTC |
68f60c0 | Brad King | 09 May 2020, 10:40:26 UTC | Merge branch 'FindGTK2-harfbuzz-target' into release-3.16 Merge-request: !4725 | 09 May 2020, 10:40:26 UTC |
5ab137b | Brad King | 08 May 2020, 15:28:37 UTC | FindGTK2: Add harfbuzz target for dependency from pango Since commit effafca77e (FindGTK2: Add harfbuzz to GTK2_INCLUDE_DIRS, 2019-10-01, v3.16.0-rc1~22^2), pango's dependency on harfbuzz has been captured, but only for the `GTK2_INCLUDE_DIRS` and `GTK2_LIBRARIES` variables. Add the `GTK2::harfbuzz` imported target and update the `GTK2::pango` target to depend on it. Issue: #19531 | 09 May 2020, 10:38:18 UTC |
ccd604d | Brad King | 08 May 2020, 12:08:22 UTC | Merge branch 'backport-3.17-FindPython-check-specified-version' into release-3.17 Merge-request: !4718 | 08 May 2020, 12:08:22 UTC |
3fa0381 | Brad King | 08 May 2020, 12:03:12 UTC | Merge topic 'pch-reuse-multi' into release-3.17 7a1c7736cb PCH: Fix REUSE_FROM in multi-config generators Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4717 | 08 May 2020, 12:03:44 UTC |
7a1c773 | Andreas Schönle | 07 May 2020, 07:39:07 UTC | PCH: Fix REUSE_FROM in multi-config generators Since commit a55df20499 (Multi-Ninja: Add precompile headers support, 2020-01-10, v3.17.0-rc1~136^2) the re-used PCH file object is added once for each configuration to flags used for all configurations. Put it in the flags for only the corresponding configuration instead. Fixes: #20680 | 07 May 2020, 13:55:04 UTC |