https://github.com/Kitware/CMake

sort by:
Revision Author Date Message Commit Date
040f503 FindBoost: Clarify logic selecting Boost_LIB_PREFIX Also add a comment explaining its purpose. 27 March 2020, 13:32:47 UTC
4b26692 Merge topic 'cleanup-endls-3' 8e3a65d963 Refactor: Avoid `std::endl` where it's not necessary (part 3) Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4517 26 March 2020, 13:19:31 UTC
6a0c172 Merge topic 'cleanup-endls-2' 1e4b5c7d09 Refactor: Avoid `std::endl` where it's not necessary (part 2) Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4514 26 March 2020, 13:18:25 UTC
577fc3e Merge topic 'string-prefix' ec7928ef26 use _s to construct static string_views at several places 94de927cab VS10Generator: avoid many string allocations 8ca2504a4d use string_views to avoid memory allocations 761f1adcae check for a valid URL scheme before starting to do any splitting ef778d77e0 replace std::string::substr() with operations that do not allocate memory 77616f4681 pass cm::string_view to cmVisualStudioSlnParser::ParseTag() ada6a3226f use cm::string_view for language extension lookups 48adc29721 replace "std::string::find(x) == 0" with cmHasPrefix() ... Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4501 26 March 2020, 13:15:41 UTC
607e790 Merge topic 'update-kwsys' 5f8d1668a2 Merge branch 'upstream-KWSys' into update-kwsys 9d3b9ec4ab KWSys 2020-03-25 (4380f1ae) Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4509 26 March 2020, 13:14:41 UTC
6257d43 Merge topic 'compile-commands-collapse-whitespace' e565053bce Ninja: Remove unnecessary newlines in compile commands 5d4bab500e Avoid consecutive whitespace in rules d8622fbd0f Modules: Collapse consecutive whitespace in strings Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4512 26 March 2020, 13:13:45 UTC
4e74a59 Merge topic 'cleanup-CollapseFullPath-calls' 25f48761fa Simplify absolute path conversions using CollapseFullPath full signature 12b39aef75 Remove redundant calls to CollapseFullPath Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4518 26 March 2020, 13:11:47 UTC
545875b Merge topic 'mingw-windres-cross-compile' af4adf6aa9 MinGW: Fix default windres selection when cross-compiling 0251ddadab MinGW: Drop unnecessary windres selection code with Unix Makefiles Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4520 26 March 2020, 13:06:13 UTC
66e0b31 CMake Nightly Date Stamp 26 March 2020, 04:01:10 UTC
ea54f8d Merge topic 'cmake-compilation-no-compiler-extensions' f034b0f663 CMake compilation: do not use compiler extensions Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4477 25 March 2020, 14:34:40 UTC
952fbd9 Merge topic 'cmprop-state' ef408dd232 cmState::GetTargetTypeName: return type is *cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4505 25 March 2020, 13:25:26 UTC
d13d5c1 Merge topic 'cmprop-cache' 0bf0e35e59 cmCacheManager::GetProperty: return cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4503 25 March 2020, 12:39:26 UTC
79415fa Merge topic 'FindRuby-rvm' 905d5667e8 FindRuby: Add support for RVM installations e6699b9b59 FindRuby: Validate Ruby_EXECUTABLE before accepting it Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4386 25 March 2020, 12:16:38 UTC
3202980 Merge branch 'release-3.17' 25 March 2020, 12:13:07 UTC
f2b4576 Merge topic 'FindPython-polish' bf1ecfef7f FindPython: misc. fixes Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4519 25 March 2020, 12:13:07 UTC
d14626a Merge topic 'FindPython-polish' into release-3.17 bf1ecfef7f FindPython: misc. fixes Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4519 25 March 2020, 12:13:06 UTC
5f8d166 Merge branch 'upstream-KWSys' into update-kwsys # By KWSys Upstream * upstream-KWSys: KWSys 2020-03-25 (4380f1ae) 25 March 2020, 11:47:51 UTC
9d3b9ec KWSys 2020-03-25 (4380f1ae) Code extracted from: https://gitlab.kitware.com/utils/kwsys.git at commit 4380f1ae99f3206938251393e94055a3e4120b2c (master). Upstream Shortlog ----------------- Rolf Eike Beer (6): 25b61c12 Directory: make it move constructible and assignable 8b1a29e1 optimize SystemToolsParseRegistryKey() 420c3b04 call std::string::clear() instead of assigning "" bc9a4256 avoid inefficient usage of std::string::substr() e3c051e2 SystemTools: create directories with the right permissions on Un*x 0085096e avoid std::string::find() to check for prefix 25 March 2020, 11:47:51 UTC
af4adf6 MinGW: Fix default windres selection when cross-compiling When cross-compiling to MinGW, select the `windres` tool named with the toolchain's prefix. Fixes: #20500 25 March 2020, 11:21:01 UTC
0251dda MinGW: Drop unnecessary windres selection code with Unix Makefiles Since commit 957c2aac7f (RC: Simplify selection of resource compiler based on C/C++ toolchain, 2015-05-07, v3.3.0-rc1~93^2~5) we select windres as the RC compiler on MinGW via `CMAKE_RC_COMPILER_INIT`. Drop the special case from commit be9afbf453 (Find mingw's windres also when Unix Makefiles are used, 2012-08-27, v2.8.10~152^2). 25 March 2020, 11:21:01 UTC
69e495d CMake Nightly Date Stamp 25 March 2020, 04:01:07 UTC
ec7928e use _s to construct static string_views at several places This should avoid the runtime strlen() call. 24 March 2020, 18:40:44 UTC
bf1ecfe FindPython: misc. fixes Help: Fix errors regardings HINTS. Code: Optimize Python signature cache variable to avoid unecessary searchs. 24 March 2020, 17:26:16 UTC
94de927 VS10Generator: avoid many string allocations 24 March 2020, 16:50:42 UTC
8ca2504 use string_views to avoid memory allocations 24 March 2020, 16:50:37 UTC
25f4876 Simplify absolute path conversions using CollapseFullPath full signature 24 March 2020, 14:10:06 UTC
12b39ae Remove redundant calls to CollapseFullPath Remove calls where it is known the input is already a collapsed full path. 24 March 2020, 14:10:06 UTC
8e3a65d Refactor: Avoid `std::endl` where it's not necessary (part 3) The `std::endl` manipulator, except inserting `\n` character, also performs `os.flush()`, which may lead to undesired effects (like disk I/O in the middle of forming data strings). For the `std::stringstream` it also has no meaning. * replace multiple `operator<<` calls on a string literal w/ the only call and the only (bigger) string literal; * replace one character string literal used in `operator<<` w/ a char literal. 24 March 2020, 13:33:33 UTC
1e4b5c7 Refactor: Avoid `std::endl` where it's not necessary (part 2) The `std::endl` manipulator, except inserting `\n` character, also performs `os.flush()`, which may lead to undesired effects (like disk I/O in the middle of forming data strings). For the `std::stringstream` it also has no meaning. * replace multiple `operator<<` calls on a string literal w/ the only call and the only (bigger) string literal; * replace one character string literal used in `operator<<` w/ a char literal. 24 March 2020, 13:32:05 UTC
c98ec36 CMake Nightly Date Stamp 24 March 2020, 04:01:07 UTC
761f1ad check for a valid URL scheme before starting to do any splitting 23 March 2020, 21:41:44 UTC
ef778d7 replace std::string::substr() with operations that do not allocate memory Modify the original string instead of creating a new copy with substr() when it is not used for anything else afterwards. 23 March 2020, 21:41:44 UTC
77616f4 pass cm::string_view to cmVisualStudioSlnParser::ParseTag() 23 March 2020, 21:41:43 UTC
ada6a32 use cm::string_view for language extension lookups Once the list of extensions is build the set is just a copy of the vector and not modified anymore. Use a string_view for the members of the set, which saves a small amount of memory. It also makes possible to use string_views as lookup keys, so the callers do not need to create copies for the extensions anymore. 23 March 2020, 21:41:43 UTC
48adc29 replace "std::string::find(x) == 0" with cmHasPrefix() 23 March 2020, 21:41:43 UTC
e565053 Ninja: Remove unnecessary newlines in compile commands 23 March 2020, 20:34:19 UTC
5d4bab5 Avoid consecutive whitespace in rules 23 March 2020, 20:34:19 UTC
d8622fb Modules: Collapse consecutive whitespace in strings 23 March 2020, 20:34:17 UTC
bfb69f9 replace "substr(0, xx) ==" with cmHasPrefix() 23 March 2020, 19:19:26 UTC
7df84ff allow cmCTest::CleanString() to skip input characters This entirely avoids that one needs to call std::string::substr() for the input. 23 March 2020, 19:19:26 UTC
d6a4e9f CTest: avoid repeated string compares Only one key can match per iteration, avoid any further compares when one match was already found. While at it entirely avoid that the key and value strings are copied. 23 March 2020, 19:18:02 UTC
d1e6ee6 Mumps coverage: directly pass std::string as argument 23 March 2020, 18:47:47 UTC
dc21177 remove pointless return value from cmCTestTestHandler::CleanTestOutput() 23 March 2020, 18:47:47 UTC
36bfb80 PyCoverage: avoid repeated string splitting, especially for uncovered lines 23 March 2020, 18:47:47 UTC
0415fa3 use std::string::rfind() instead of open coding it While at it avoid creating a new string. 23 March 2020, 18:47:47 UTC
871bf0c CPackWIXGenerator: use cmStrCat for more parts 23 March 2020, 18:47:46 UTC
d6cf89c remove needless check for std::string::substr() Passing npos is legal and means "rest of the string". 23 March 2020, 18:47:46 UTC
a42d2b0 cmcldeps: replace inefficient std::string::substr usage 23 March 2020, 18:47:46 UTC
59d572b replace private startsWith() implementation with cmHasPrefix() 23 March 2020, 18:47:46 UTC
206a65c Merge branch 'release-3.17' 23 March 2020, 14:54:42 UTC
1d9884f Merge topic 'doc-typo' 356c7cec2c Help: Fixed typo in CMAKE_INSTALL_RPATH_USE_LINK_PATH.rst Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4516 23 March 2020, 14:54:42 UTC
c1ad4a7 Merge topic 'doc-typo' into release-3.17 356c7cec2c Help: Fixed typo in CMAKE_INSTALL_RPATH_USE_LINK_PATH.rst Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4516 23 March 2020, 14:54:41 UTC
356c7ce Help: Fixed typo in CMAKE_INSTALL_RPATH_USE_LINK_PATH.rst Signed-off-by: Jaak Ristioja <jaak@ristioja.ee> 23 March 2020, 13:46:08 UTC
aef934f Merge branch 'release-3.17' 23 March 2020, 13:27:44 UTC
a4abf61 Merge topic 'cmake-gui-open-check' ecc0086bfc cmake-gui: Fix use-after-free in Open-possible check Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4508 23 March 2020, 13:27:44 UTC
170087f Merge topic 'cmake-gui-open-check' into release-3.17 ecc0086bfc cmake-gui: Fix use-after-free in Open-possible check Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4508 23 March 2020, 13:27:43 UTC
905d566 FindRuby: Add support for RVM installations 23 March 2020, 12:22:23 UTC
e6699b9 FindRuby: Validate Ruby_EXECUTABLE before accepting it 23 March 2020, 12:21:40 UTC
f034b0f CMake compilation: do not use compiler extensions For now, compiler extensions are no longer activated on CMake sources. However these extensions are still used for various third parties. This MR is a partial answer to the issue #20454. 23 March 2020, 09:29:58 UTC
8638c49 CMake Nightly Date Stamp 23 March 2020, 04:01:05 UTC
7099db5 CMake Nightly Date Stamp 22 March 2020, 04:01:11 UTC
8bef78b CMake Nightly Date Stamp 21 March 2020, 04:01:12 UTC
ecc0086 cmake-gui: Fix use-after-free in Open-possible check Fix `QCMake::checkOpenPossible` to copy `toLocal8Bit().data()` before its lifetime expires. 20 March 2020, 12:38:31 UTC
9c3dddb Merge branch 'release-3.17' 20 March 2020, 11:35:44 UTC
e3185e3 CMake 3.17.0 20 March 2020, 10:26:14 UTC
6bea0b2 Merge branch 'release-3.17' 20 March 2020, 10:22:48 UTC
a2bbc34 Merge topic 'FindMatlab-r2020' 75331a4578 FindMatlab: Add R2020a=9.8 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4507 20 March 2020, 10:22:48 UTC
dfca188 Merge topic 'FindMatlab-r2020' into release-3.17 75331a4578 FindMatlab: Add R2020a=9.8 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4507 20 March 2020, 10:22:48 UTC
bb22f45 Merge branch 'release-3.16' 20 March 2020, 10:21:11 UTC
1294cb3 Merge branch 'release-3.17' 20 March 2020, 10:17:49 UTC
3ab89b5 Merge topic 'GetPrerequisites-vcruntime-is-system' into release-3.17 417b765f5a GetPrerequisites: Classify vcruntime libraries as system Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4506 20 March 2020, 10:17:49 UTC
7c0346e Merge topic 'GetPrerequisites-vcruntime-is-system' 417b765f5a GetPrerequisites: Classify vcruntime libraries as system Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4506 20 March 2020, 10:17:49 UTC
6786d7c Merge branch 'release-3.17' 20 March 2020, 10:17:01 UTC
119d1da Merge topic 'export-repeat' into release-3.17 8affe9aa33 export: Fix use-after-free on multiple calls overwriting same FILE Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4494 20 March 2020, 10:17:00 UTC
94139ac Merge topic 'export-repeat' 8affe9aa33 export: Fix use-after-free on multiple calls overwriting same FILE Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4494 20 March 2020, 10:17:00 UTC
9bbea23 CMake Nightly Date Stamp 20 March 2020, 04:01:11 UTC
75331a4 FindMatlab: Add R2020a=9.8 This allows Matlab R2020a to be recognized as a valid Matlab version. 19 March 2020, 16:47:10 UTC
2a085de Merge branch 'GetPrerequisites-vcruntime-is-system' into release-3.16 Merge-request: !4506 19 March 2020, 14:19:43 UTC
417b765 GetPrerequisites: Classify vcruntime libraries as system Previously GetPrerequisites classified `vcruntime*.dll` as type "other". They should be classified as type "system". 19 March 2020, 14:17:40 UTC
ef408dd cmState::GetTargetTypeName: return type is *cmProp 19 March 2020, 12:55:03 UTC
0bf0e35 cmCacheManager::GetProperty: return cmProp 19 March 2020, 12:18:42 UTC
60db3af Merge topic 'cmprop-state' bd89133543 cmState::GetCacheEntryValue: return cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4493 19 March 2020, 11:18:27 UTC
7bdf84d Merge topic 'target-improve' b915fec56e cmTarget: minor code improvements Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4483 19 March 2020, 11:17:39 UTC
e37f67c Merge topic 'CheckLanguage-private-vars' 36baf1f13c CheckLanguage: hide commonly used variable names Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4497 19 March 2020, 11:17:00 UTC
2154d02 Merge branch 'release-3.17' 19 March 2020, 10:57:52 UTC
0586123 Merge topic 'trace-format-json-doc' 1994f950ff cmake: List valid values for --trace-format on the command line e39766d84a Help: Fix documentation of --trace-format parameter Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4500 19 March 2020, 10:57:52 UTC
8fad32f Merge topic 'trace-format-json-doc' into release-3.17 1994f950ff cmake: List valid values for --trace-format on the command line e39766d84a Help: Fix documentation of --trace-format parameter Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4500 19 March 2020, 10:57:51 UTC
8affe9a export: Fix use-after-free on multiple calls overwriting same FILE CMake 3.16 and below allow multiple `export()` calls with the same output file even without using `APPEND`. The implementation worked by accident by leaking memory. Refactoring in commit 5444a8095d (cmGlobalGenerator: modernize memrory managemenbt, 2019-12-29, v3.17.0-rc1~239^2) cleaned up that memory leak and converted it to a use-after-free instead. The problem is caused by using the `cmGlobalGenerator::BuildExportSets` map to own `cmExportBuildFileGenerator` instances. It can own only one instance per output FILE name at a time, so repeating use of the same file now frees the old `cmExportBuildFileGenerator` instance and leaves the pointer in the `cmMakefile::ExportBuildFileGenerators` vector dangling. Move ownership of the instances into `cmMakefile`'s vector since its entries are not replaced on a repeat output FILE. In future work we should introduce a policy to error out on this case. For now simply fix the use-after-free to restore CMake <= 3.16 behavior. Fixes: #20469 19 March 2020, 10:41:39 UTC
d995be9 CMake Nightly Date Stamp 19 March 2020, 04:01:09 UTC
1994f95 cmake: List valid values for --trace-format on the command line 18 March 2020, 20:16:46 UTC
e39766d Help: Fix documentation of --trace-format parameter 18 March 2020, 20:02:04 UTC
36baf1f CheckLanguage: hide commonly used variable names The check_language sets internal variables with a common name in the caller's scope: `result`, `output` and `content`. They are now prefixed with `_cl_`, inspired by the CheckLibraryExists module. 18 March 2020, 16:47:06 UTC
863b0fa Merge topic 'FindRuby-updates' 46064c8193 FindRuby: Add support for versions up to 2.7 675eaf3bd0 FindRuby: Update MSVC runtime library selection b970e25d98 FindRuby: Remove extra whitespace ecdace4d61 FindRuby: Include FPHSA closer to where it is used f52f496138 FindRuby: Provide Ruby_LIBRARIES result variable b00d736a0b FindRuby: Add dedicated tests Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4481 18 March 2020, 13:09:18 UTC
d9ad001 Merge topic 'FindPkgConfig-broken-pkg-config' 1c99f5df28 FindPkgConfig: Add test for specified pkg-config tool missing b59f36aad8 FindPkgConfig: Unset results when pkg-config is broken Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4451 18 March 2020, 13:08:12 UTC
2d3eeff Merge topic 'bootstrap-version-crlf' 2ec6fbcb9b bootstrap: Tolerate trailing content in CMakeVersion.cmake components Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4491 18 March 2020, 13:07:24 UTC
0d8e2f7 Merge branch 'release-3.17' 18 March 2020, 11:54:23 UTC
3c7774e Merge topic 'FindPython-version-validation-fix' cc7f116cb4 FindPython: fix regression on version validation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4492 18 March 2020, 11:54:23 UTC
9abc99e Merge topic 'FindPython-version-validation-fix' into release-3.17 cc7f116cb4 FindPython: fix regression on version validation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4492 18 March 2020, 11:54:23 UTC
5a8eec4 CMake Nightly Date Stamp 18 March 2020, 04:01:11 UTC
bd89133 cmState::GetCacheEntryValue: return cmProp 17 March 2020, 16:09:20 UTC
back to top