| 3b4838b | Ryan Thornton | 16 March 2020, 20:16:38 UTC | GoogleTest: Add tests for MultiConfig discovery in PRE_TEST mode PRE_TEST makes it possible to properly distinguish between test cases that exist only in certain configurations. In the new test scenario, debug tests are disabled in release builds, and release tests are disabled in debug builds when a multi config generator is used. Note, this is a bit of a hack and *only* works for PRE_TEST mode. POST_BUILD makes no attempt to get this right. It preserves the status quo and you obtain the tests that were last discovered. See further discussion in !4078 Ideally, the POST_BUILD behavior could be fixed by using generator expressions in OUTPUT and BYPRODUCT expressions. Then you could do something like: set(ctest_include_file "${ctest_file_base}_include-$<CONFIG>.cmake") set(ctest_tests_file "${ctest_file_base}_tests-$<CONFIG>.cmake") Once #12877 lands, maybe this can be revisited. Co-authored-by: Ryan Thornton <ThorntonRyan@JohnDeere.com> Co-authored-by: Kevin Puetz <PuetzKevinA@JohnDeere.com> | 27 March 2020, 14:40:40 UTC |
| 1ba4cb5 | Ryan Thornton | 16 March 2020, 19:40:31 UTC | GoogleTest: Parameterize tests to check PRE_TEST/POST_BUILD discovery mode Now, the unit tests are ran twice -- once with POST_BUILD (i.e. default mode) and again with PRE_TEST (i.e. new discovery mode). Both modes of setting gtest discovery mode are also tested: 1. Using the global override (i.e. CMAKE_GTEST_DISCOVER_TESTS_DISCOVERY_MODE) 2. Explicitly passing DISCOVERY_MODE in calls to gtest_discover_tests (in GoogleTestDiscoveryTimeout.cmake) The goal is to show that the new PRE_TEST discovery mode does not break existing behavior (i.e. should not break POST_BUILD mode) and should also pass the same tests in the same way. A few non trivial implementation details worth noting: 1. Refactoring discovery_timeout_test into own project Originally, I tried doing: ``` run_GoogleTest(POST_BUILD) run_GoogleTest(PRE_TEST) ``` Without changing the internal structure of run_GoogleTest. But since discovery_timeout_test is part of the same project as the other tests, and CTest include files always get evaluated and that's where test discovery occurs, this means every other test now notices the timeout problem when running in PRE_TEST mode. As a result, keeping the existing test structure meant that each existing test (and any new test) would need to have its own PRE_TEST / POST_BUILD variant for stderr and stdout in order to handle the case where discovery_timeout_test timed out. This exponential increase in test output files introduced unnecessary complexity and made it more cumbersome to work on test cases. Why should an unrelated test case care about discovery_timeout_test? So, to fix that issue, the tests were broken apart into two main groups: 1. run_GoogleTest_discovery_timeout (the test dealing with discovery_timeout_test) 2. run_GoogleTest (everything else) This isolates the PRE_TEST / POST_BUILD timeout variants to a single test case. And the other test cases remain unchanged -- further driving home the point that DISCOVERY_MODE shouldn't change existing behavior. 2. Different number of PRE_TEST / POST_BUILD file variants On the PRE_TEST path, different build systems / compilers (i.e. MSBuild and ninja/gcc) produces different build output when building discovery_timeout_test, but we don't actually care what it is, just as long as it builds successfully. This the fundamental difference in behavior between POST_BUILD (which would have failed) and PRE_TEST (which doesn't) and is the reason why we don't need a GoogleTest-discovery-build-result.txt or GoogleTest-discovery-build-stdout.txt 3. Fix flaky discovery timeout test The test expects to see: > Output: > timeout > case. But sometimes, the test would only produce: > Output: > timout In certain environments, specifically when built with OpenWatcom 1.4, and while the build server was under heavy load (i.e. running many tests in parallel), std::endl behaves inconsistently and doesn't completely flush std::cout when the program is terminated due to timeout. This results in inconsistent test failures because the actual output doesn't fully match what's expected. At first we tried adding an additional: std::cout << std::flush That didn't work. But using C-style printf() and fflush() appears to do the trick: > This time I managed to get on the machine while it was still busy doing other nightly builds > and could reproduce the problem reliably. With that I was finally able to find a fix. > It turns out my earlier hypothesis that C++ stream flushing was not working on the old compiler was correct, > but even .flush() is not enough. > I changed it to use C-style printf() and fflush() and now the test passes on that build. > -- Brad King <brad.king@kitware.com> Co-authored-by: Ryan Thornton <ThorntonRyan@JohnDeere.com> Co-authored-by: Kevin Puetz <PuetzKevinA@JohnDeere.com> | 27 March 2020, 14:39:47 UTC |
| 75e82a1 | Ryan Thornton | 16 March 2020, 17:04:35 UTC | GoogleTest: Add new DISCOVERY_MODE option to gtest_discover_tests Introducing a new DISCOVERY_MODE mode option, which provides greater control over when gtest_discover_tests perforsm test discovery. It has two supported modes: * POST_BUILD * PRE_TEST POST_BUILD is the default behavior, which adds a POST_BUILD command to perform test discovery after the test has been built. PRE_TEST is a new mode, which delays test discovery until test execution. DISCOVERY_MODE can be controlled in two ways: 1. Setting the DISCOVERY_MODE when calling gtest_discover_tests 2. Setting the global CMAKE_GTEST_DISCOVER_TESTS_DISCOVERY_MODE prior to calling gtest_discover_tests By delaying test discovery until ctest runtime, we can provide better cross compile support, because we're more likely to be in an environment that can run the test executable. This was achieved by moving the command for test discovery into the generated ctest include file. In PRE_TEST mode, the generated include file now has the form: if(EXISTS "path/to/test.exe") if("path/to/test.exe" IS_NEWER_THAN "path/to/ctest_file") // command to discover tests // and generate ctest_file endif() include("path/to/ctest_file") endif() elseif() // test not built endif() Which generates the appropriate CTest files at runtime and regenerates the CTest files when the executable is updated. In the old approach, test discovery was always added as POST_BUILD step and the executable was ran in order to scan for tests. If the test executable failed to run for any reason, this resulted in a link failure. This failure could more commonly occur when cross compiling, because your build environment might not have the appropriate runtime environment dlls required to run the test executable. I also ran into the issue when compiling a Qt application using Qt Creator. Qt Creator manages its build and runtime environments separately and only adds the Qt dlls to the environment during runtime -- not during build. So when gtest_discover_tests ran my test executable, it promptly crashed because the environment wasn't correct, which resulted in a build failure. Setting the DISCOVERY_MODE to PRE_TEST fixed my build failure by delaying test discovery until runtime, because this allowed the test exe to run in the proper environment. A few non-trivial implementation details worth noting: 1. bracket_arguments In the PRE_TEST side, parameters whose contents might contain special characters, need to be handled with great care. To aid in escaping these list arguments, backslashes, and other special characters, and ensuring that they are preserved in the generated file, bracket arguments (i.e. [== <...> ==]) are used. For example: gtest_discover_tests( ... EXTRA_ARGS how now "\"brown\" cow" ) Generates a file with the following call: gtest_discover_tests_impl( ... TEST_EXTRA_ARGS [==[how;now;"brown" cow]==] ) This way the arguments are forwarded correctly. 2. multi-config generators Multi-Config generators (e.g. MSBuild) now work more correctly in PRE_TEST than POST_BUILD. PRE_TEST is more correct because it will generate a unique CTest file for each configuration. It generates a per config file responsible for test discovery: foo[1]_include-Debug.cmake foo[1]_include-MinSizeRel.cmake foo[1]_include-Release.cmake foo[1]_include-RelWithDebInfo.cmake A per config file for containing the google tests: foo[1]_tests-Debug.cmake And an outer ctest file: foo[1]_include-Debug.cmake That is generically written to include the correct configuration file by looking at the value of ${CTEST_CONFIGURATION_TYPE} when CTest runs. POST_BUILD, in contrast, preserves the existing functionality. Tests are disocvered based on the last configuration that was chosen and only a single file is produced: foo[1]_include.cmake foo[1]_tests.cmake But it runs with whatever executable requested by ctest --config, which means it's possible to run the wrong tests if some tests were enabled in one configuration but not another. | 20 March 2020, 15:14:39 UTC |
| 889a714 | Ryan Thornton | 16 March 2020, 16:59:12 UTC | GoogleTestAddTests: Refactor into callable method Move test discovery logic into new gtest_discover_tests_impl method and make GoogleTestAddTests aware of whether it is being launched in CMake's script mode. When launched in script mode, gtest_discover_tests_impl is called passing arguments obtained from the definitions passed into the call to cmake. (i.e. cmake -P GoogleTestAddTests -D <arg1> -D <arg2> ...) This preserves the existing behavior assumed by GoogleTest.cmake. Unit tests are unchanged and still pass. Looking ahead, it also allows GoogleTestAddTests to be included in generated files and call gtest_discover_tests_impl to perform test discovery at test runtime with the new PRE_TEST discovery mode introduced later in this branch. My original approach attempted to call execute_process(cmake -P ...) in the generated file, the same way POST_BUILD is doing, but I ran into difficulties serializing the command arguments correctly. By exposing a way to call gtest_discover_tests_impl directly from our generated file, we remove a layer of shell quoting / parsing that our arguments have to survive, which simplifies the act of producing a generated file that behaves the same as its POST_BUILD counterpart. | 19 March 2020, 16:59:20 UTC |
| 60db3af | Brad King | 19 March 2020, 11:17:31 UTC | Merge topic 'cmprop-state' bd89133543 cmState::GetCacheEntryValue: return cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4493 | 19 March 2020, 11:18:27 UTC |
| 7bdf84d | Brad King | 19 March 2020, 11:17:21 UTC | Merge topic 'target-improve' b915fec56e cmTarget: minor code improvements Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4483 | 19 March 2020, 11:17:39 UTC |
| e37f67c | Brad King | 19 March 2020, 11:16:52 UTC | Merge topic 'CheckLanguage-private-vars' 36baf1f13c CheckLanguage: hide commonly used variable names Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4497 | 19 March 2020, 11:17:00 UTC |
| 2154d02 | Brad King | 19 March 2020, 10:57:44 UTC | Merge branch 'release-3.17' | 19 March 2020, 10:57:52 UTC |
| 0586123 | Brad King | 19 March 2020, 10:57:44 UTC | Merge topic 'trace-format-json-doc' 1994f950ff cmake: List valid values for --trace-format on the command line e39766d84a Help: Fix documentation of --trace-format parameter Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4500 | 19 March 2020, 10:57:52 UTC |
| 8fad32f | Brad King | 19 March 2020, 10:57:44 UTC | Merge topic 'trace-format-json-doc' into release-3.17 1994f950ff cmake: List valid values for --trace-format on the command line e39766d84a Help: Fix documentation of --trace-format parameter Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4500 | 19 March 2020, 10:57:51 UTC |
| d995be9 | Kitware Robot | 19 March 2020, 04:01:09 UTC | CMake Nightly Date Stamp | 19 March 2020, 04:01:09 UTC |
| 1994f95 | Kyle Edwards | 18 March 2020, 20:16:46 UTC | cmake: List valid values for --trace-format on the command line | 18 March 2020, 20:16:46 UTC |
| e39766d | Kyle Edwards | 18 March 2020, 20:02:04 UTC | Help: Fix documentation of --trace-format parameter | 18 March 2020, 20:02:04 UTC |
| 36baf1f | Hannes Vogt | 18 March 2020, 16:47:06 UTC | CheckLanguage: hide commonly used variable names The check_language sets internal variables with a common name in the caller's scope: `result`, `output` and `content`. They are now prefixed with `_cl_`, inspired by the CheckLibraryExists module. | 18 March 2020, 16:47:06 UTC |
| 863b0fa | Brad King | 18 March 2020, 13:09:13 UTC | Merge topic 'FindRuby-updates' 46064c8193 FindRuby: Add support for versions up to 2.7 675eaf3bd0 FindRuby: Update MSVC runtime library selection b970e25d98 FindRuby: Remove extra whitespace ecdace4d61 FindRuby: Include FPHSA closer to where it is used f52f496138 FindRuby: Provide Ruby_LIBRARIES result variable b00d736a0b FindRuby: Add dedicated tests Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4481 | 18 March 2020, 13:09:18 UTC |
| d9ad001 | Brad King | 18 March 2020, 13:08:05 UTC | Merge topic 'FindPkgConfig-broken-pkg-config' 1c99f5df28 FindPkgConfig: Add test for specified pkg-config tool missing b59f36aad8 FindPkgConfig: Unset results when pkg-config is broken Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4451 | 18 March 2020, 13:08:12 UTC |
| 2d3eeff | Brad King | 18 March 2020, 13:07:17 UTC | Merge topic 'bootstrap-version-crlf' 2ec6fbcb9b bootstrap: Tolerate trailing content in CMakeVersion.cmake components Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4491 | 18 March 2020, 13:07:24 UTC |
| 0d8e2f7 | Brad King | 18 March 2020, 11:54:11 UTC | Merge branch 'release-3.17' | 18 March 2020, 11:54:23 UTC |
| 3c7774e | Brad King | 18 March 2020, 11:54:11 UTC | Merge topic 'FindPython-version-validation-fix' cc7f116cb4 FindPython: fix regression on version validation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4492 | 18 March 2020, 11:54:23 UTC |
| 9abc99e | Brad King | 18 March 2020, 11:54:11 UTC | Merge topic 'FindPython-version-validation-fix' into release-3.17 cc7f116cb4 FindPython: fix regression on version validation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4492 | 18 March 2020, 11:54:23 UTC |
| 5a8eec4 | Kitware Robot | 18 March 2020, 04:01:11 UTC | CMake Nightly Date Stamp | 18 March 2020, 04:01:11 UTC |
| bd89133 | Vitaly Stakhovsky | 17 March 2020, 16:00:00 UTC | cmState::GetCacheEntryValue: return cmProp | 17 March 2020, 16:09:20 UTC |
| cc7f116 | Marc Chevrier | 17 March 2020, 13:50:43 UTC | FindPython: fix regression on version validation In commit 3dab4682f6 (FindPython: reduces consumption of resources, 2020-02-10, v3.17.0-rc1~11^2) we accidentally broke the python executable version validation when the "LOCATION" strategy is used with the plain `FindPython` module. Fix the logic and add test cases covering those combinations. Fixes: #20465 | 17 March 2020, 14:08:34 UTC |
| 46064c8 | Julien Marrec | 11 March 2020, 17:37:19 UTC | FindRuby: Add support for versions up to 2.7 Fixes: #20370 | 17 March 2020, 12:43:10 UTC |
| 675eaf3 | Brad King | 17 March 2020, 12:39:06 UTC | FindRuby: Update MSVC runtime library selection Use the `MSVC_TOOLSET_VERSION` variable computed by CMake to get the matching Ruby library name component. Inspired-by: Julien Marrec <julien.marrec@gmail.com> | 17 March 2020, 12:39:06 UTC |
| b915fec | Vitaly Stakhovsky | 17 March 2020, 12:00:00 UTC | cmTarget: minor code improvements | 17 March 2020, 12:33:57 UTC |
| bee0100 | Brad King | 17 March 2020, 12:06:38 UTC | Merge topic 'file-archive' c7e1198a23 file: Add ARCHIVE_{CREATE|EXTRACT} subcommands Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4475 | 17 March 2020, 12:06:57 UTC |
| 97562a2 | Brad King | 17 March 2020, 12:05:21 UTC | Merge topic 'property-computer' fad0ee5404 cmTargetPropertyComputer::GetProperty: return cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4482 | 17 March 2020, 12:06:18 UTC |
| d2e0b8b | Brad King | 17 March 2020, 12:04:59 UTC | Merge topic 'prop_t' 60f57d0dcc cmPropertyMap: Introduce cmProp as return type for GetProperty() functions Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4471 | 17 March 2020, 12:05:29 UTC |
| 2b720f6 | Brad King | 17 March 2020, 12:04:39 UTC | Merge topic 'mf_profiling_json' 897af4c266 cmMakefileProfilingData: Fix ambiguous conversion to Json::Value Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4479 | 17 March 2020, 12:04:46 UTC |
| 1c99f5d | Brad King | 17 March 2020, 12:02:15 UTC | FindPkgConfig: Add test for specified pkg-config tool missing | 17 March 2020, 12:02:15 UTC |
| 7a41bb2 | Brad King | 17 March 2020, 11:51:17 UTC | Merge branch 'release-3.17' | 17 March 2020, 11:51:25 UTC |
| 2e42bcd | Brad King | 17 March 2020, 11:51:17 UTC | Merge topic 'FindThreads-doc' 1502f281dd FindThreads: Improve documentation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4480 | 17 March 2020, 11:51:25 UTC |
| b145196 | Brad King | 17 March 2020, 11:51:17 UTC | Merge topic 'FindThreads-doc' into release-3.17 1502f281dd FindThreads: Improve documentation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4480 | 17 March 2020, 11:51:24 UTC |
| 2ec6fbc | jjYBdx4IL | 16 March 2020, 17:46:16 UTC | bootstrap: Tolerate trailing content in CMakeVersion.cmake components On CYGWIN, tolerate DOS linefeeds in `Source/CMakeVersion.cmake`. | 17 March 2020, 11:20:09 UTC |
| 372f269 | Kitware Robot | 17 March 2020, 04:01:09 UTC | CMake Nightly Date Stamp | 17 March 2020, 04:01:09 UTC |
| b970e25 | Julien Marrec | 11 March 2020, 17:37:19 UTC | FindRuby: Remove extra whitespace | 16 March 2020, 18:07:30 UTC |
| ecdace4 | Brad King | 16 March 2020, 17:48:10 UTC | FindRuby: Include FPHSA closer to where it is used | 16 March 2020, 18:07:30 UTC |
| f52f496 | Brad King | 16 March 2020, 17:47:45 UTC | FindRuby: Provide Ruby_LIBRARIES result variable The `cmake-developer(7)` manual documents that a plural non-cached name should be used for results. | 16 March 2020, 18:05:26 UTC |
| fad0ee5 | Vitaly Stakhovsky | 16 March 2020, 17:45:00 UTC | cmTargetPropertyComputer::GetProperty: return cmProp | 16 March 2020, 17:47:05 UTC |
| b00d736 | Julien Marrec | 21 February 2020, 15:46:24 UTC | FindRuby: Add dedicated tests Issue: #20370 | 16 March 2020, 17:33:27 UTC |
| b59f36a | Brad King | 16 March 2020, 16:25:38 UTC | FindPkgConfig: Unset results when pkg-config is broken Inspired-by: FUJI Goro <goro@fastly.com> | 16 March 2020, 16:27:11 UTC |
| 1502f28 | Rolf Eike Beer | 16 March 2020, 15:29:52 UTC | FindThreads: Improve documentation Issue: #19823 | 16 March 2020, 15:46:38 UTC |
| 6f4b1ba | Brad King | 16 March 2020, 15:40:25 UTC | Merge topic 'define-property' 73d52a862b cmPropertyDefinition: Construct directly in defined state Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4470 | 16 March 2020, 15:40:59 UTC |
| c6def21 | Brad King | 16 March 2020, 15:40:11 UTC | Merge topic 'gtest-parallel-xml' 32bc6aa9b6 GoogleTest: Add release note for XML_OUTPUT_DIR 0001339a6f GoogleTest: Add test case for XML_OUTPUT_DIR e9ab39eb1d GoogleTest: Add XML_OUTPUT_DIR parameter Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4433 | 16 March 2020, 15:40:21 UTC |
| e08af3e | Brad King | 16 March 2020, 15:31:54 UTC | Merge topic 'remove_trailing_whitespace' 67a592583d Source: Remove trailing whitespace from export generation code Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4474 | 16 March 2020, 15:32:14 UTC |
| eea528f | Brad King | 16 March 2020, 15:31:16 UTC | Merge topic 'gnu-as' 9728839b9e ASM: Fix executable link lines with GNU 'as' tool as CMAKE_ASM_COMPILER 5932f0be4f ASM: Fix depfile flags for GNU 'as' tool 0d0aa98c84 ASM: Record vendor-specific output matched to identify assembler ee3ec27465 CMakeDetermineCompilerId: Set locale to C for vendor output match Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4460 | 16 March 2020, 15:31:25 UTC |
| 9ad554a | Brad King | 16 March 2020, 14:07:49 UTC | Merge topic 'FindRuby-typo' ffa08d256f FindRuby: Fix compatibility with upper-case cache variables 50c97e1da0 FindRuby: Fix name of Ruby_LIBRARY variable Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4476 | 16 March 2020, 14:07:56 UTC |
| c7e1198 | Cristian Adam | 13 March 2020, 17:09:14 UTC | file: Add ARCHIVE_{CREATE|EXTRACT} subcommands Fixes: #20443 | 16 March 2020, 13:33:27 UTC |
| 897af4c | Raul Tambre | 15 March 2020, 17:14:11 UTC | cmMakefileProfilingData: Fix ambiguous conversion to Json::Value | 16 March 2020, 12:46:11 UTC |
| eb7e8d1 | Kitware Robot | 16 March 2020, 04:01:07 UTC | CMake Nightly Date Stamp | 16 March 2020, 04:01:07 UTC |
| a6d95f5 | Kitware Robot | 15 March 2020, 04:01:27 UTC | CMake Nightly Date Stamp | 15 March 2020, 04:01:27 UTC |
| 7132540 | Marc Chevrier | 14 March 2020, 11:18:55 UTC | Merge topic 'help-source-developer-guide' a4ca1792f6 Help: Update CMake source developer guide for C++ standard library usage Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de> Merge-request: !4467 | 14 March 2020, 11:19:03 UTC |
| 9f3e885 | Kitware Robot | 14 March 2020, 04:01:09 UTC | CMake Nightly Date Stamp | 14 March 2020, 04:01:09 UTC |
| a4ca179 | Marc Chevrier | 12 March 2020, 09:10:04 UTC | Help: Update CMake source developer guide for C++ standard library usage We now offer many C++14, C++17, C++20, and custom extensions to the C++ standard library that are available even when compiling as C++11. | 14 March 2020, 01:40:13 UTC |
| ffa08d2 | Brad King | 13 March 2020, 18:13:17 UTC | FindRuby: Fix compatibility with upper-case cache variables In commit e672db628b (FindRuby: Rename variables to match case of module name, 2020-03-11) compatibility was provided for result variables but not for the cache entries that scripts might set. | 13 March 2020, 18:13:17 UTC |
| 50c97e1 | Brad King | 13 March 2020, 17:59:17 UTC | FindRuby: Fix name of Ruby_LIBRARY variable Fix a typo in the variable name caused by commit e672db628b (FindRuby: Rename variables to match case of module name, 2020-03-11). | 13 March 2020, 17:59:17 UTC |
| 60f57d0 | Vitaly Stakhovsky | 13 March 2020, 17:30:00 UTC | cmPropertyMap: Introduce cmProp as return type for GetProperty() functions Currently properties are usually stored internally as `std::string`. However, family of GetProperty() functions return them as `const char *` using `c_str()`. The proposed `cmProp`, typedef'ed as `const std::string *` will expose properties more naturally. | 13 March 2020, 17:32:17 UTC |
| 3766633 | Brad King | 13 March 2020, 15:01:49 UTC | Merge topic 'FindRuby-variable-case' e672db628b FindRuby: Rename variables to match case of module name Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Frank Dana <ferdnyc@gmail.com> Merge-request: !4463 | 13 March 2020, 15:01:56 UTC |
| 200bc3b | Brad King | 13 March 2020, 15:00:27 UTC | Merge topic 'swift-implicit-module-include-dir' 2026915f8f Swift: Propagate Swift_MODULE_DIRECTORY as include directory Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4320 | 13 March 2020, 15:00:39 UTC |
| 1b5554e | Brad King | 13 March 2020, 14:58:44 UTC | Merge topic 'profiling' 9aa4640792 cmake: add command line options to output script profiling data Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Ben Boeckel <ben.boeckel@kitware.com> Acked-by: Pavel Solodovnikov <hellyeahdominate@gmail.com> Acked-by: Leonid Pospelov <pospelovlm@yandex.ru> Acked-by: Cristian Adam <cristian.adam@gmail.com> Merge-request: !2760 | 13 March 2020, 14:59:03 UTC |
| 32bc6aa | Alexander Stein | 06 March 2020, 21:36:14 UTC | GoogleTest: Add release note for XML_OUTPUT_DIR | 13 March 2020, 14:47:34 UTC |
| 0001339 | Alexander Stein | 06 March 2020, 21:29:07 UTC | GoogleTest: Add test case for XML_OUTPUT_DIR | 13 March 2020, 14:47:33 UTC |
| e9ab39e | Alexander Stein | 06 March 2020, 12:42:36 UTC | GoogleTest: Add XML_OUTPUT_DIR parameter When executing googltests in parallel using 'ctest -j n' and using '--gtest_output=xml' there is a race condition upon file creation. See googletest issue https://github.com/google/googletest/issues/2506. As all testcases (potentially) can be run in parallel each testcase has to create it's own XML JUnit file. EXTRA_ARGS is not suitable because it is identical per testsuite. So instead a new (opitional) parameter has been introduced to specify the storage location for each test of the testsuite. | 13 March 2020, 14:47:33 UTC |
| c3ab1c2 | Brad King | 13 March 2020, 14:46:11 UTC | Merge topic 'GoogleTest-gtest_discover_tests-failure' 2ba8ac07ed GoogleTest: Fix CTest not failing if gtest_discover_tests fails 2c9680eec5 GoogleTest: Add missing test case for gtest_discover_tests failure Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Steffen Seckler <steffen.seckler@tum.de> Acked-by: Matthew Woehlke <matthew.woehlke@kitware.com> Merge-request: !4466 | 13 March 2020, 14:46:20 UTC |
| ba21659 | Brad King | 13 March 2020, 14:43:49 UTC | Merge topic 'cuda_language' f75bea1071 CUDA: Abstract language flag to compiler modules Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4464 | 13 March 2020, 14:43:57 UTC |
| 67a5925 | Alexandru Croitor | 13 March 2020, 14:29:22 UTC | Source: Remove trailing whitespace from export generation code | 13 March 2020, 14:31:38 UTC |
| 73d52a8 | Vitaly Stakhovsky | 12 March 2020, 12:36:43 UTC | cmPropertyDefinition: Construct directly in defined state Move `cmPropertyDefinitionMap::DefineProperty` functionality directly into the constructor to avoid an intermediate state. | 13 March 2020, 14:24:51 UTC |
| 9728839 | Brad King | 12 March 2020, 13:05:07 UTC | ASM: Fix executable link lines with GNU 'as' tool as CMAKE_ASM_COMPILER The GNU `as` tool does not know how to drive linking like the C compiler does. When using `as` as the compiler, use the linker directly. | 13 March 2020, 13:55:36 UTC |
| 5932f0b | Brad King | 11 March 2020, 15:45:46 UTC | ASM: Fix depfile flags for GNU 'as' tool The GNU `as --help` shows `--MD <file>` as an option to generate depfiles as needed by Ninja. There is no `-MT <target>` flag but fortunately the generated files automatically account for the `-o <obj>` flag. Issue: #20426 | 13 March 2020, 13:55:36 UTC |
| 78fd95f | Kitware Robot | 13 March 2020, 04:01:11 UTC | CMake Nightly Date Stamp | 13 March 2020, 04:01:11 UTC |
| 2181807 | Brad King | 12 March 2020, 16:58:38 UTC | Merge branch 'release-3.17' | 12 March 2020, 16:58:47 UTC |
| 7da0545 | Brad King | 12 March 2020, 16:58:38 UTC | Merge topic 'generated-byproducts-docs' 3eb2b62d21 Help: Expand discussion of GENERATED / BYPRODUCTS 1853c7f571 Help: Add missing word in AUTOGEN_TARGET_DEPENDS.rst Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4472 | 12 March 2020, 16:58:47 UTC |
| 02fa6fd | Brad King | 12 March 2020, 16:58:38 UTC | Merge topic 'generated-byproducts-docs' into release-3.17 3eb2b62d21 Help: Expand discussion of GENERATED / BYPRODUCTS 1853c7f571 Help: Add missing word in AUTOGEN_TARGET_DEPENDS.rst Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4472 | 12 March 2020, 16:58:46 UTC |
| 3eb2b62 | FeRD (Frank Dana) | 12 March 2020, 15:29:24 UTC | Help: Expand discussion of GENERATED / BYPRODUCTS - Mention the Makefile Generators' `make clean` removal in the BYPRODUCTS section of add_custom_command and add_custom_target - Expand the GENERATED property docs' description of which files will be marked with the property, and of what it implies (including `make clean` removal) | 12 March 2020, 15:55:10 UTC |
| 1853c7f | FeRD (Frank Dana) | 12 March 2020, 15:19:43 UTC | Help: Add missing word in AUTOGEN_TARGET_DEPENDS.rst | 12 March 2020, 15:55:10 UTC |
| 2026915 | Saleem Abdulrasool | 04 February 2020, 05:32:51 UTC | Swift: Propagate Swift_MODULE_DIRECTORY as include directory Teach include directory computation for Swift to implicitly propagate the `Swift_MODULE_DIRECTORY` of all linked targets as include directories. This is required to ensure that the swiftmodule of a linked target is accessible to the compiler of the current target. Fixes: #19272 | 12 March 2020, 15:50:43 UTC |
| cb8227e | Brad King | 12 March 2020, 15:06:33 UTC | Merge branch 'release-3.17' | 12 March 2020, 15:06:33 UTC |
| 0d0aa98 | Brad King | 11 March 2020, 15:41:01 UTC | ASM: Record vendor-specific output matched to identify assembler For example, with GNU `as`, we match `GNU assembler`, but with GNU `gcc` as the assembler, we do not match anything. Distinguishing these cases may be useful for constructing assembler command lines. | 12 March 2020, 14:07:30 UTC |
| ee3ec27 | Brad King | 12 March 2020, 13:56:07 UTC | CMakeDetermineCompilerId: Set locale to C for vendor output match Apply the change from commit d751d2d2ed (CMakeDetermineCompilerABI: set locale to C for try_compile(), 2019-01-14, v3.14.0-rc1~108^2~1) to the `CMAKE_DETERMINE_COMPILER_ID_VENDOR` implementation too. | 12 March 2020, 14:07:29 UTC |
| 1ec72e0 | Brad King | 12 March 2020, 13:45:24 UTC | CMake 3.17.0-rc3 | 12 March 2020, 13:45:24 UTC |
| 9116daf | Brad King | 12 March 2020, 13:33:05 UTC | Merge branch 'release-3.17' | 12 March 2020, 13:33:19 UTC |
| 2ca34f0 | Brad King | 12 March 2020, 13:33:05 UTC | Merge topic 'apple-clang-flags-c++17' a67f2d00d8 Apple Clang: add flags for C++17 standard Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4468 | 12 March 2020, 13:33:19 UTC |
| c852c0d | Brad King | 12 March 2020, 13:33:05 UTC | Merge topic 'apple-clang-flags-c++17' into release-3.17 a67f2d00d8 Apple Clang: add flags for C++17 standard Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4468 | 12 March 2020, 13:33:18 UTC |
| 0cf40ee | Brad King | 12 March 2020, 13:32:24 UTC | Merge branch 'release-3.16' | 12 March 2020, 13:32:24 UTC |
| d584d01 | Brad King | 12 March 2020, 13:31:54 UTC | Merge topic 'swift-link-line-spaces' into release-3.17 af39d1b993 Swift: Fix quoting of library search paths with spaces Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4469 | 12 March 2020, 13:32:01 UTC |
| e3e906d | Brad King | 12 March 2020, 13:31:54 UTC | Merge branch 'release-3.17' | 12 March 2020, 13:32:01 UTC |
| 1e3af78 | Brad King | 12 March 2020, 13:31:54 UTC | Merge topic 'swift-link-line-spaces' af39d1b993 Swift: Fix quoting of library search paths with spaces Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4469 | 12 March 2020, 13:32:01 UTC |
| 5a896bb | Brad King | 12 March 2020, 12:49:20 UTC | Merge branch 'swift-link-line-spaces' into release-3.16 Merge-request: !4469 | 12 March 2020, 12:49:20 UTC |
| af39d1b | Saleem Abdulrasool | 12 March 2020, 03:25:34 UTC | Swift: Fix quoting of library search paths with spaces The library search paths added by commit 2746c61e6d (Swift: Add library search paths for dependencies, 2019-06-09, v3.16.0-rc1~561^2) need to be quoted properly on command lines to handle spaces and such. This was already done by `cmLinkLineComputer::ComputeLinkPath` for non-Swift-specific link directories. | 12 March 2020, 12:46:11 UTC |
| f86d800 | Brad King | 12 March 2020, 12:25:21 UTC | Merge topic 'add-cache-definition' 36a5b3d1d1 cmMakefile::AddCacheDefinition: Add overload that accepts std::string value Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4457 | 12 March 2020, 12:26:07 UTC |
| 74954a6 | Brad King | 12 March 2020, 12:25:14 UTC | Merge topic 'modernize-memory-management' f964739ead cmCTestRunTest: modernize memory management Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4454 | 12 March 2020, 12:25:20 UTC |
| 0683f2e | Brad King | 12 March 2020, 12:24:17 UTC | Merge topic 'CMakeFindFrameworks-CMAKE_FRAMEWORK_PATH' c841d43d70 CMakeFindFrameworks: Search CMAKE_FRAMEWORK_PATH Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4461 | 12 March 2020, 12:24:22 UTC |
| 1e0b062 | Brad King | 12 March 2020, 12:19:06 UTC | Merge branch 'release-3.17' | 12 March 2020, 12:19:43 UTC |
| 3cf22df | Brad King | 12 March 2020, 12:19:06 UTC | Merge topic 'ctest-curl-debugfunction' into release-3.17 7a1cce210b CTest: Fix our internal CURL_DEBUGFUNCTION to conform to CURL docs Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4459 | 12 March 2020, 12:19:43 UTC |
| 7ed1d5c | Brad King | 12 March 2020, 12:19:06 UTC | Merge topic 'ctest-curl-debugfunction' 7a1cce210b CTest: Fix our internal CURL_DEBUGFUNCTION to conform to CURL docs Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4459 | 12 March 2020, 12:19:43 UTC |
| 88e921f | Brad King | 12 March 2020, 12:18:47 UTC | Merge branch 'release-3.17' | 12 March 2020, 12:18:55 UTC |
| 3a49ea6 | Brad King | 12 March 2020, 12:18:47 UTC | Merge topic 'FindPython-ENV-CMAKE_FRAMEWORK_PATH' 1044776472 FindPython: Convert env CMAKE_FRAMEWORK_PATH to CMake path Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Marc Chevrier <marc.chevrier@gmail.com> Merge-request: !4462 | 12 March 2020, 12:18:54 UTC |
| c278b4e | Brad King | 12 March 2020, 12:18:47 UTC | Merge topic 'FindPython-ENV-CMAKE_FRAMEWORK_PATH' into release-3.17 1044776472 FindPython: Convert env CMAKE_FRAMEWORK_PATH to CMake path Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Marc Chevrier <marc.chevrier@gmail.com> Merge-request: !4462 | 12 March 2020, 12:18:54 UTC |
| 159da18 | Brad King | 12 March 2020, 12:17:56 UTC | Merge branch 'release-3.17' | 12 March 2020, 12:18:04 UTC |
