| cfa3a23 | Brad King | 30 March 2020, 17:26:20 UTC | Merge topic 'gtest_discover_tests_cross_compile_support' 3b4838b57f GoogleTest: Add tests for MultiConfig discovery in PRE_TEST mode 1ba4cb565e GoogleTest: Parameterize tests to check PRE_TEST/POST_BUILD discovery mode 75e82a13db GoogleTest: Add new DISCOVERY_MODE option to gtest_discover_tests 889a7146ff GoogleTestAddTests: Refactor into callable method Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4078 | 30 March 2020, 17:26:49 UTC |
| e20146b | Brad King | 30 March 2020, 17:24:05 UTC | Merge topic 'FindBoost-lib-prefix-clarify' 040f503d83 FindBoost: Clarify logic selecting Boost_LIB_PREFIX Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4537 | 30 March 2020, 17:24:38 UTC |
| 026083f | Brad King | 30 March 2020, 17:22:58 UTC | Merge branch 'release-3.17' | 30 March 2020, 17:23:19 UTC |
| 0055170 | Brad King | 30 March 2020, 17:22:58 UTC | Merge topic 'docs-xcode-gen-scheme-workdir' 6905451e11 Help: Add missing XCODE_SCHEME_WORKING_DIRECTORY 6ff07dac76 Help: Minor typos and formatting for XCODE_SCHEME_WORKING_DIRECTORY Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4543 | 30 March 2020, 17:23:19 UTC |
| 04d8ed6 | Brad King | 30 March 2020, 17:22:58 UTC | Merge topic 'docs-xcode-gen-scheme-workdir' into release-3.17 6905451e11 Help: Add missing XCODE_SCHEME_WORKING_DIRECTORY 6ff07dac76 Help: Minor typos and formatting for XCODE_SCHEME_WORKING_DIRECTORY Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4543 | 30 March 2020, 17:23:18 UTC |
| 04c7f8f | Brad King | 30 March 2020, 17:21:54 UTC | Merge branch 'release-3.17' | 30 March 2020, 17:22:02 UTC |
| 0188df9 | Brad King | 30 March 2020, 17:21:54 UTC | Merge topic 'llvm_rc_pp' 4bef0e6450 llvm-rc: Enable preprocessing if CMAKE_RC_COMPILER_INIT is an absolute path Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4535 | 30 March 2020, 17:22:02 UTC |
| 42cefc6 | Brad King | 30 March 2020, 17:21:54 UTC | Merge topic 'llvm_rc_pp' into release-3.17 4bef0e6450 llvm-rc: Enable preprocessing if CMAKE_RC_COMPILER_INIT is an absolute path Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4535 | 30 March 2020, 17:22:02 UTC |
| 3c48f4b | Brad King | 30 March 2020, 13:42:27 UTC | Merge topic 'FindPython-use-sysconfig-package' dd0664415a FindPython: use 'sysconfig' as alternate to 'distutils.sysconfig' Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4540 | 30 March 2020, 13:42:35 UTC |
| 887eb6b | Kitware Robot | 30 March 2020, 04:01:13 UTC | CMake Nightly Date Stamp | 30 March 2020, 04:01:13 UTC |
| 6905451 | Craig Scott | 29 March 2020, 11:08:07 UTC | Help: Add missing XCODE_SCHEME_WORKING_DIRECTORY | 29 March 2020, 11:13:56 UTC |
| 6ff07da | Craig Scott | 29 March 2020, 11:13:26 UTC | Help: Minor typos and formatting for XCODE_SCHEME_WORKING_DIRECTORY | 29 March 2020, 11:13:56 UTC |
| 371727c | Kitware Robot | 29 March 2020, 04:01:22 UTC | CMake Nightly Date Stamp | 29 March 2020, 04:01:22 UTC |
| dd06644 | Marc Chevrier | 26 March 2020, 17:01:30 UTC | FindPython: use 'sysconfig' as alternate to 'distutils.sysconfig' To support any python installation, if package 'distutils.sysconfig' is not available, try to use package 'sysconfig'. Fixes: #20502 | 28 March 2020, 09:51:47 UTC |
| 67e2fef | Craig Scott | 28 March 2020, 07:04:58 UTC | Merge branch 'release-3.17' | 28 March 2020, 07:05:11 UTC |
| 655b52a | Craig Scott | 28 March 2020, 07:04:58 UTC | Merge topic 'ninja-multi-doc-variable-update' c8fd26eb57 Help: Move Ninja Multi-Config variable details into their respective pages Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4532 | 28 March 2020, 07:05:10 UTC |
| e5eb410 | Craig Scott | 28 March 2020, 07:04:58 UTC | Merge topic 'ninja-multi-doc-variable-update' into release-3.17 c8fd26eb57 Help: Move Ninja Multi-Config variable details into their respective pages Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4532 | 28 March 2020, 07:05:10 UTC |
| cc86c92 | Kitware Robot | 28 March 2020, 04:01:13 UTC | CMake Nightly Date Stamp | 28 March 2020, 04:01:13 UTC |
| 3b4838b | Ryan Thornton | 16 March 2020, 20:16:38 UTC | GoogleTest: Add tests for MultiConfig discovery in PRE_TEST mode PRE_TEST makes it possible to properly distinguish between test cases that exist only in certain configurations. In the new test scenario, debug tests are disabled in release builds, and release tests are disabled in debug builds when a multi config generator is used. Note, this is a bit of a hack and *only* works for PRE_TEST mode. POST_BUILD makes no attempt to get this right. It preserves the status quo and you obtain the tests that were last discovered. See further discussion in !4078 Ideally, the POST_BUILD behavior could be fixed by using generator expressions in OUTPUT and BYPRODUCT expressions. Then you could do something like: set(ctest_include_file "${ctest_file_base}_include-$<CONFIG>.cmake") set(ctest_tests_file "${ctest_file_base}_tests-$<CONFIG>.cmake") Once #12877 lands, maybe this can be revisited. Co-authored-by: Ryan Thornton <ThorntonRyan@JohnDeere.com> Co-authored-by: Kevin Puetz <PuetzKevinA@JohnDeere.com> | 27 March 2020, 14:40:40 UTC |
| 1ba4cb5 | Ryan Thornton | 16 March 2020, 19:40:31 UTC | GoogleTest: Parameterize tests to check PRE_TEST/POST_BUILD discovery mode Now, the unit tests are ran twice -- once with POST_BUILD (i.e. default mode) and again with PRE_TEST (i.e. new discovery mode). Both modes of setting gtest discovery mode are also tested: 1. Using the global override (i.e. CMAKE_GTEST_DISCOVER_TESTS_DISCOVERY_MODE) 2. Explicitly passing DISCOVERY_MODE in calls to gtest_discover_tests (in GoogleTestDiscoveryTimeout.cmake) The goal is to show that the new PRE_TEST discovery mode does not break existing behavior (i.e. should not break POST_BUILD mode) and should also pass the same tests in the same way. A few non trivial implementation details worth noting: 1. Refactoring discovery_timeout_test into own project Originally, I tried doing: ``` run_GoogleTest(POST_BUILD) run_GoogleTest(PRE_TEST) ``` Without changing the internal structure of run_GoogleTest. But since discovery_timeout_test is part of the same project as the other tests, and CTest include files always get evaluated and that's where test discovery occurs, this means every other test now notices the timeout problem when running in PRE_TEST mode. As a result, keeping the existing test structure meant that each existing test (and any new test) would need to have its own PRE_TEST / POST_BUILD variant for stderr and stdout in order to handle the case where discovery_timeout_test timed out. This exponential increase in test output files introduced unnecessary complexity and made it more cumbersome to work on test cases. Why should an unrelated test case care about discovery_timeout_test? So, to fix that issue, the tests were broken apart into two main groups: 1. run_GoogleTest_discovery_timeout (the test dealing with discovery_timeout_test) 2. run_GoogleTest (everything else) This isolates the PRE_TEST / POST_BUILD timeout variants to a single test case. And the other test cases remain unchanged -- further driving home the point that DISCOVERY_MODE shouldn't change existing behavior. 2. Different number of PRE_TEST / POST_BUILD file variants On the PRE_TEST path, different build systems / compilers (i.e. MSBuild and ninja/gcc) produces different build output when building discovery_timeout_test, but we don't actually care what it is, just as long as it builds successfully. This the fundamental difference in behavior between POST_BUILD (which would have failed) and PRE_TEST (which doesn't) and is the reason why we don't need a GoogleTest-discovery-build-result.txt or GoogleTest-discovery-build-stdout.txt 3. Fix flaky discovery timeout test The test expects to see: > Output: > timeout > case. But sometimes, the test would only produce: > Output: > timout In certain environments, specifically when built with OpenWatcom 1.4, and while the build server was under heavy load (i.e. running many tests in parallel), std::endl behaves inconsistently and doesn't completely flush std::cout when the program is terminated due to timeout. This results in inconsistent test failures because the actual output doesn't fully match what's expected. At first we tried adding an additional: std::cout << std::flush That didn't work. But using C-style printf() and fflush() appears to do the trick: > This time I managed to get on the machine while it was still busy doing other nightly builds > and could reproduce the problem reliably. With that I was finally able to find a fix. > It turns out my earlier hypothesis that C++ stream flushing was not working on the old compiler was correct, > but even .flush() is not enough. > I changed it to use C-style printf() and fflush() and now the test passes on that build. > -- Brad King <brad.king@kitware.com> Co-authored-by: Ryan Thornton <ThorntonRyan@JohnDeere.com> Co-authored-by: Kevin Puetz <PuetzKevinA@JohnDeere.com> | 27 March 2020, 14:39:47 UTC |
| 040f503 | Brad King | 27 March 2020, 12:17:51 UTC | FindBoost: Clarify logic selecting Boost_LIB_PREFIX Also add a comment explaining its purpose. | 27 March 2020, 13:32:47 UTC |
| 4bef0e6 | Lucas Wang | 27 March 2020, 07:46:39 UTC | llvm-rc: Enable preprocessing if CMAKE_RC_COMPILER_INIT is an absolute path `CMAKE_RC_COMPILER_INIT` and `CMAKE_RC_COMPILER` can be set by user, for example `llvm-rc-10` and `D:\LLVM\bin\llvm-rc.exe`. | 27 March 2020, 12:54:58 UTC |
| f670435 | Brad King | 27 March 2020, 12:03:21 UTC | Merge topic 'pch-warn-invalid' 2ce08e5489 PCH: add an option to disable `-Winvalid-pch` Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4499 | 27 March 2020, 12:03:30 UTC |
| cc1d5a4 | Brad King | 27 March 2020, 11:58:33 UTC | Merge topic 'doc-cmake-package-targets' e6344586ee install: Document caveat when EXPORT name matches package name Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4527 | 27 March 2020, 11:58:39 UTC |
| d6119e2 | Brad King | 27 March 2020, 11:49:44 UTC | Merge topic 'cleanup-endls-1' 3fdd8db3aa Refactor: Avoid `std::endl` where it's not necessary (part 1) Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4513 | 27 March 2020, 11:51:27 UTC |
| a661157 | Brad King | 27 March 2020, 11:49:29 UTC | Merge topic 'cmprop-getglobalprop' c84cf42897 cmState::GetGlobalProperty: return cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4521 | 27 March 2020, 11:50:28 UTC |
| 7e3d81b | Brad King | 27 March 2020, 11:49:23 UTC | Merge topic 'cmprop-state' a7f2ff16a4 cmState::GetCacheEntryProperty: return cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4522 | 27 March 2020, 11:49:30 UTC |
| ae96b77 | Brad King | 27 March 2020, 11:48:23 UTC | Merge topic 'export-error-on-multuple-calls' 0cd20e8f62 export(): raise an error on multiple calls with same FILE Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4510 | 27 March 2020, 11:48:30 UTC |
| 767a875 | Brad King | 27 March 2020, 11:45:58 UTC | Merge branch 'release-3.17' | 27 March 2020, 11:46:15 UTC |
| 0613f1b | Brad King | 27 March 2020, 11:45:58 UTC | Merge topic 'ctest-timeout-report' 3503a79639 Merge branch 'backport-ctest-timeout-report' into ctest-timeout-report 7fda917fa4 CTest: Fix reported duration on timeout when grindchild keeps pipes open Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4530 | 27 March 2020, 11:46:15 UTC |
| b835c5d | Brad King | 27 March 2020, 11:45:58 UTC | Merge topic 'ctest-timeout-report' into release-3.17 7fda917fa4 CTest: Fix reported duration on timeout when grindchild keeps pipes open Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4530 | 27 March 2020, 11:46:14 UTC |
| e50c02c | Brad King | 27 March 2020, 11:44:45 UTC | Merge branch 'release-3.17' | 27 March 2020, 11:45:15 UTC |
| 112cb24 | Brad King | 27 March 2020, 11:44:45 UTC | Merge topic 'vs-clangcl' f3d7a15010 VS: Fix ClangCL toolset compiler path detection Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4523 | 27 March 2020, 11:45:15 UTC |
| efb2a9f | Brad King | 27 March 2020, 11:44:45 UTC | Merge topic 'vs-clangcl' into release-3.17 f3d7a15010 VS: Fix ClangCL toolset compiler path detection Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4523 | 27 March 2020, 11:45:15 UTC |
| 311848f | Brad King | 27 March 2020, 11:44:05 UTC | Merge topic 'FindPython-variable-spelling-error' into release-3.17 63580668a8 FindPython: fix variable spelling error Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4529 | 27 March 2020, 11:44:12 UTC |
| 9a585fc | Brad King | 27 March 2020, 11:44:05 UTC | Merge branch 'release-3.17' | 27 March 2020, 11:44:12 UTC |
| 83f5ba0 | Brad King | 27 March 2020, 11:44:05 UTC | Merge topic 'FindPython-variable-spelling-error' 63580668a8 FindPython: fix variable spelling error Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4529 | 27 March 2020, 11:44:12 UTC |
| 7a4cc3b | Brad King | 27 March 2020, 11:42:33 UTC | Merge branch 'release-3.17' | 27 March 2020, 11:43:03 UTC |
| 9df5871 | Brad King | 27 March 2020, 11:42:33 UTC | Merge topic 'CheckIPOSupported-cleanup-cache' 4b8297721f CheckIPOSupported: Avoid polluting cache with common name 'result' Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Kyle Edwards <kyle.edwards@kitware.com> Merge-request: !4528 | 27 March 2020, 11:43:03 UTC |
| f6c3820 | Brad King | 27 March 2020, 11:42:33 UTC | Merge topic 'CheckIPOSupported-cleanup-cache' into release-3.17 4b8297721f CheckIPOSupported: Avoid polluting cache with common name 'result' Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Kyle Edwards <kyle.edwards@kitware.com> Merge-request: !4528 | 27 March 2020, 11:43:02 UTC |
| 7489ac6 | Brad King | 27 March 2020, 11:41:50 UTC | Merge branch 'release-3.17' | 27 March 2020, 11:41:58 UTC |
| 184dd23 | Brad King | 27 March 2020, 11:41:50 UTC | Merge topic 'nmc-cl-showincludes' 6c7e6b1e49 Ninja Multi-Config: Fix MSVC showincludes prefix detection Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Kyle Edwards <kyle.edwards@kitware.com> Merge-request: !4526 | 27 March 2020, 11:41:58 UTC |
| 1915a09 | Brad King | 27 March 2020, 11:41:50 UTC | Merge topic 'nmc-cl-showincludes' into release-3.17 6c7e6b1e49 Ninja Multi-Config: Fix MSVC showincludes prefix detection Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Kyle Edwards <kyle.edwards@kitware.com> Merge-request: !4526 | 27 March 2020, 11:41:57 UTC |
| 3ee4d19 | Brad King | 27 March 2020, 11:38:36 UTC | Merge branch 'release-3.17' | 27 March 2020, 11:39:30 UTC |
| a88b27b | Brad King | 27 March 2020, 11:38:36 UTC | Merge topic 'llvm-rc-stderr' dc93cbb0d8 llvm-rc: Print stderr output when calling tools through cmake_llvm_rc Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4525 | 27 March 2020, 11:39:30 UTC |
| 2fe8ea5 | Brad King | 27 March 2020, 11:38:36 UTC | Merge topic 'llvm-rc-stderr' into release-3.17 dc93cbb0d8 llvm-rc: Print stderr output when calling tools through cmake_llvm_rc Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4525 | 27 March 2020, 11:39:29 UTC |
| 5a79394 | Brad King | 27 March 2020, 11:38:15 UTC | Merge branch 'release-3.17' | 27 March 2020, 11:38:23 UTC |
| 032df7a | Brad King | 27 March 2020, 11:38:15 UTC | Merge topic 'llvm-rc-depfile' into release-3.17 2c724c3aea llvm-rc: Write depfile to location specified by the generator 4cc876540e llvm-rc: Select preprocessor from active languages Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4524 | 27 March 2020, 11:38:22 UTC |
| ab96bbf | Brad King | 27 March 2020, 11:38:15 UTC | Merge topic 'llvm-rc-depfile' 2c724c3aea llvm-rc: Write depfile to location specified by the generator 4cc876540e llvm-rc: Select preprocessor from active languages Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4524 | 27 March 2020, 11:38:22 UTC |
| a0b1463 | Brad King | 27 March 2020, 11:36:35 UTC | Merge branch 'release-3.16' | 27 March 2020, 11:36:35 UTC |
| 0af3a9b | Brad King | 27 March 2020, 11:35:03 UTC | Merge topic 'make-nested-silent' into release-3.17 d6d9da5178 Makefiles: Fix silencing of nested calls for GNU make 4.3 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4515 | 27 March 2020, 11:35:12 UTC |
| 731b390 | Brad King | 27 March 2020, 11:35:03 UTC | Merge branch 'release-3.17' | 27 March 2020, 11:35:12 UTC |
| 610759f | Brad King | 27 March 2020, 11:35:03 UTC | Merge topic 'make-nested-silent' d6d9da5178 Makefiles: Fix silencing of nested calls for GNU make 4.3 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4515 | 27 March 2020, 11:35:12 UTC |
| b83696c | Kitware Robot | 27 March 2020, 04:01:09 UTC | CMake Nightly Date Stamp | 27 March 2020, 04:01:09 UTC |
| c8fd26e | Kyle Edwards | 26 March 2020, 19:33:48 UTC | Help: Move Ninja Multi-Config variable details into their respective pages | 26 March 2020, 19:33:48 UTC |
| 3503a79 | Brad King | 26 March 2020, 18:42:17 UTC | Merge branch 'backport-ctest-timeout-report' into ctest-timeout-report | 26 March 2020, 18:42:17 UTC |
| 7fda917 | Brad King | 26 March 2020, 18:25:40 UTC | CTest: Fix reported duration on timeout when grindchild keeps pipes open Since commit d1976cd1f2 (CTest: Fix timeout when grandchild keeps pipes open, 2020-01-13, v3.17.0-rc1~169^2) we no longer hang, but the test duration we report after the timeout is the amount of time the immediate child ran before exiting. Fix the logic to instead report the actual amount of time we spent monitoring the test before the timeout. Fixes: #20509 | 26 March 2020, 18:35:54 UTC |
| 6358066 | Marc Chevrier | 26 March 2020, 17:08:25 UTC | FindPython: fix variable spelling error | 26 March 2020, 17:08:25 UTC |
| 4b82977 | Brad King | 26 March 2020, 16:57:07 UTC | CheckIPOSupported: Avoid polluting cache with common name 'result' Fixes: #20508 | 26 March 2020, 16:57:07 UTC |
| e634458 | Brad King | 26 March 2020, 13:34:23 UTC | install: Document caveat when EXPORT name matches package name Fixes: #20427 | 26 March 2020, 13:34:23 UTC |
| 2ce08e5 | Cristian Adam | 18 March 2020, 18:21:08 UTC | PCH: add an option to disable `-Winvalid-pch` Fixes: #20295 | 26 March 2020, 13:24:46 UTC |
| 4b26692 | Brad King | 26 March 2020, 13:18:24 UTC | Merge topic 'cleanup-endls-3' 8e3a65d963 Refactor: Avoid `std::endl` where it's not necessary (part 3) Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4517 | 26 March 2020, 13:19:31 UTC |
| 6a0c172 | Brad King | 26 March 2020, 13:18:17 UTC | Merge topic 'cleanup-endls-2' 1e4b5c7d09 Refactor: Avoid `std::endl` where it's not necessary (part 2) Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4514 | 26 March 2020, 13:18:25 UTC |
| 577fc3e | Brad King | 26 March 2020, 13:15:02 UTC | Merge topic 'string-prefix' ec7928ef26 use _s to construct static string_views at several places 94de927cab VS10Generator: avoid many string allocations 8ca2504a4d use string_views to avoid memory allocations 761f1adcae check for a valid URL scheme before starting to do any splitting ef778d77e0 replace std::string::substr() with operations that do not allocate memory 77616f4681 pass cm::string_view to cmVisualStudioSlnParser::ParseTag() ada6a3226f use cm::string_view for language extension lookups 48adc29721 replace "std::string::find(x) == 0" with cmHasPrefix() ... Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4501 | 26 March 2020, 13:15:41 UTC |
| 607e790 | Brad King | 26 March 2020, 13:14:05 UTC | Merge topic 'update-kwsys' 5f8d1668a2 Merge branch 'upstream-KWSys' into update-kwsys 9d3b9ec4ab KWSys 2020-03-25 (4380f1ae) Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4509 | 26 March 2020, 13:14:41 UTC |
| 6257d43 | Brad King | 26 March 2020, 13:13:37 UTC | Merge topic 'compile-commands-collapse-whitespace' e565053bce Ninja: Remove unnecessary newlines in compile commands 5d4bab500e Avoid consecutive whitespace in rules d8622fbd0f Modules: Collapse consecutive whitespace in strings Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4512 | 26 March 2020, 13:13:45 UTC |
| 4e74a59 | Brad King | 26 March 2020, 13:11:41 UTC | Merge topic 'cleanup-CollapseFullPath-calls' 25f48761fa Simplify absolute path conversions using CollapseFullPath full signature 12b39aef75 Remove redundant calls to CollapseFullPath Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4518 | 26 March 2020, 13:11:47 UTC |
| 545875b | Brad King | 26 March 2020, 13:06:04 UTC | Merge topic 'mingw-windres-cross-compile' af4adf6aa9 MinGW: Fix default windres selection when cross-compiling 0251ddadab MinGW: Drop unnecessary windres selection code with Unix Makefiles Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4520 | 26 March 2020, 13:06:13 UTC |
| 6c7e6b1 | Brad King | 26 March 2020, 12:47:36 UTC | Ninja Multi-Config: Fix MSVC showincludes prefix detection Activate the detection logic for this generator too. Fixes: #20506 | 26 March 2020, 12:47:36 UTC |
| 0cd20e8 | Marc Chevrier | 20 March 2020, 14:21:32 UTC | export(): raise an error on multiple calls with same FILE Fixes: 20472 | 26 March 2020, 12:20:45 UTC |
| f3d7a15 | Brad King | 25 March 2020, 19:25:39 UTC | VS: Fix ClangCL toolset compiler path detection Prior to commit 3c125c6de0 (VS: Support Visual Studio Clang Toolkit identification, 2019-12-03, v3.17.0-rc1~341^2) using `-T ClangCL` would work but `CMAKE_{C,CXX}_COMPILER` would be detected as `cl.exe` even though `clang-cl.exe` is the actual compiler. That commit attempted to fix the detection by using `$(ClangClExecutable)` as we do for LLVM-distributed toolsets, but that is not actually defined. Instead, look for `$(CLToolExe)` in the `PATH`. Fixes: #20504 | 26 March 2020, 12:18:25 UTC |
| dc93cbb | Thomas Bernard | 25 March 2020, 22:34:34 UTC | llvm-rc: Print stderr output when calling tools through cmake_llvm_rc The stored error pipe is output if the program fails. Fixes: #20494 | 26 March 2020, 11:59:55 UTC |
| 6fdf05d | Brad King | 26 March 2020, 11:37:06 UTC | Merge branch 'make-nested-silent' into release-3.16 Merge-request: !4515 | 26 March 2020, 11:37:06 UTC |
| d6d9da5 | Brad King | 23 March 2020, 12:51:15 UTC | Makefiles: Fix silencing of nested calls for GNU make 4.3 Since GNU make 4.3, `.SILENT:` no longer causes nested `$(MAKE)` calls to get `-s` implicitly. Add the `-s` flag explicitly on such calls to suppress messages about Entering/Leaving directories. Fixes: #20487 | 26 March 2020, 11:34:24 UTC |
| 2c724c3 | Thomas Bernard | 25 March 2020, 20:49:37 UTC | llvm-rc: Write depfile to location specified by the generator Move the depfile flags to `CMAKE_DEPFILE_FLAGS_RC` so that they are only usedwith generators that use depfiles. Also switch to using the `<DEPFILE>` placeholder for the location of the depfile so that it goes where the generator expects. Fixes: #20493 | 26 March 2020, 11:26:21 UTC |
| 4cc8765 | Thomas Bernard | 25 March 2020, 20:55:41 UTC | llvm-rc: Select preprocessor from active languages The llvm-rc preprocessor is selected according to the CMAKE_C_COMPILER_ID / CMAKE_CXX_COMPILER_ID which are only defined when the C or CXX language is active. | 26 March 2020, 11:25:33 UTC |
| 66e0b31 | Kitware Robot | 26 March 2020, 04:01:10 UTC | CMake Nightly Date Stamp | 26 March 2020, 04:01:10 UTC |
| 3fdd8db | Alex Turbov | 22 March 2020, 13:54:31 UTC | Refactor: Avoid `std::endl` where it's not necessary (part 1) The `std::endl` manupulator, except inserting `\n` character, also performs `os.flush()`, which may leads to undesired effects (like disk I/O in the middle of forming data strings). For the `std::stringstream` it also has no meaning. | 26 March 2020, 03:36:57 UTC |
| a7f2ff1 | Vitaly Stakhovsky | 25 March 2020, 18:00:00 UTC | cmState::GetCacheEntryProperty: return cmProp | 25 March 2020, 18:46:52 UTC |
| ea54f8d | Brad King | 25 March 2020, 14:34:29 UTC | Merge topic 'cmake-compilation-no-compiler-extensions' f034b0f663 CMake compilation: do not use compiler extensions Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4477 | 25 March 2020, 14:34:40 UTC |
| 952fbd9 | Brad King | 25 March 2020, 13:25:13 UTC | Merge topic 'cmprop-state' ef408dd232 cmState::GetTargetTypeName: return type is *cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4505 | 25 March 2020, 13:25:26 UTC |
| c84cf42 | Vitaly Stakhovsky | 22 March 2020, 07:00:00 UTC | cmState::GetGlobalProperty: return cmProp | 25 March 2020, 13:10:46 UTC |
| d13d5c1 | Brad King | 25 March 2020, 12:39:19 UTC | Merge topic 'cmprop-cache' 0bf0e35e59 cmCacheManager::GetProperty: return cmProp Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4503 | 25 March 2020, 12:39:26 UTC |
| 79415fa | Brad King | 25 March 2020, 12:16:26 UTC | Merge topic 'FindRuby-rvm' 905d5667e8 FindRuby: Add support for RVM installations e6699b9b59 FindRuby: Validate Ruby_EXECUTABLE before accepting it Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4386 | 25 March 2020, 12:16:38 UTC |
| 3202980 | Brad King | 25 March 2020, 12:12:59 UTC | Merge branch 'release-3.17' | 25 March 2020, 12:13:07 UTC |
| f2b4576 | Brad King | 25 March 2020, 12:12:59 UTC | Merge topic 'FindPython-polish' bf1ecfef7f FindPython: misc. fixes Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4519 | 25 March 2020, 12:13:07 UTC |
| d14626a | Brad King | 25 March 2020, 12:12:59 UTC | Merge topic 'FindPython-polish' into release-3.17 bf1ecfef7f FindPython: misc. fixes Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4519 | 25 March 2020, 12:13:06 UTC |
| 5f8d166 | Brad King | 25 March 2020, 11:47:51 UTC | Merge branch 'upstream-KWSys' into update-kwsys # By KWSys Upstream * upstream-KWSys: KWSys 2020-03-25 (4380f1ae) | 25 March 2020, 11:47:51 UTC |
| 9d3b9ec | KWSys Upstream | 25 March 2020, 11:47:00 UTC | KWSys 2020-03-25 (4380f1ae) Code extracted from: https://gitlab.kitware.com/utils/kwsys.git at commit 4380f1ae99f3206938251393e94055a3e4120b2c (master). Upstream Shortlog ----------------- Rolf Eike Beer (6): 25b61c12 Directory: make it move constructible and assignable 8b1a29e1 optimize SystemToolsParseRegistryKey() 420c3b04 call std::string::clear() instead of assigning "" bc9a4256 avoid inefficient usage of std::string::substr() e3c051e2 SystemTools: create directories with the right permissions on Un*x 0085096e avoid std::string::find() to check for prefix | 25 March 2020, 11:47:51 UTC |
| af4adf6 | Brad King | 25 March 2020, 11:18:08 UTC | MinGW: Fix default windres selection when cross-compiling When cross-compiling to MinGW, select the `windres` tool named with the toolchain's prefix. Fixes: #20500 | 25 March 2020, 11:21:01 UTC |
| 0251dda | Brad King | 25 March 2020, 11:14:42 UTC | MinGW: Drop unnecessary windres selection code with Unix Makefiles Since commit 957c2aac7f (RC: Simplify selection of resource compiler based on C/C++ toolchain, 2015-05-07, v3.3.0-rc1~93^2~5) we select windres as the RC compiler on MinGW via `CMAKE_RC_COMPILER_INIT`. Drop the special case from commit be9afbf453 (Find mingw's windres also when Unix Makefiles are used, 2012-08-27, v2.8.10~152^2). | 25 March 2020, 11:21:01 UTC |
| 69e495d | Kitware Robot | 25 March 2020, 04:01:07 UTC | CMake Nightly Date Stamp | 25 March 2020, 04:01:07 UTC |
| ec7928e | Rolf Eike Beer | 24 March 2020, 16:51:39 UTC | use _s to construct static string_views at several places This should avoid the runtime strlen() call. | 24 March 2020, 18:40:44 UTC |
| bf1ecfe | Marc Chevrier | 24 March 2020, 17:13:03 UTC | FindPython: misc. fixes Help: Fix errors regardings HINTS. Code: Optimize Python signature cache variable to avoid unecessary searchs. | 24 March 2020, 17:26:16 UTC |
| 94de927 | Rolf Eike Beer | 13 March 2020, 20:44:15 UTC | VS10Generator: avoid many string allocations | 24 March 2020, 16:50:42 UTC |
| 8ca2504 | Rolf Eike Beer | 21 March 2020, 11:57:29 UTC | use string_views to avoid memory allocations | 24 March 2020, 16:50:37 UTC |
| 25f4876 | Brad King | 18 March 2020, 18:22:11 UTC | Simplify absolute path conversions using CollapseFullPath full signature | 24 March 2020, 14:10:06 UTC |
| 12b39ae | Brad King | 18 March 2020, 18:20:46 UTC | Remove redundant calls to CollapseFullPath Remove calls where it is known the input is already a collapsed full path. | 24 March 2020, 14:10:06 UTC |
| 8e3a65d | Alex Turbov | 24 March 2020, 04:19:36 UTC | Refactor: Avoid `std::endl` where it's not necessary (part 3) The `std::endl` manipulator, except inserting `\n` character, also performs `os.flush()`, which may lead to undesired effects (like disk I/O in the middle of forming data strings). For the `std::stringstream` it also has no meaning. * replace multiple `operator<<` calls on a string literal w/ the only call and the only (bigger) string literal; * replace one character string literal used in `operator<<` w/ a char literal. | 24 March 2020, 13:33:33 UTC |
| 1e4b5c7 | Alex Turbov | 22 March 2020, 14:29:43 UTC | Refactor: Avoid `std::endl` where it's not necessary (part 2) The `std::endl` manipulator, except inserting `\n` character, also performs `os.flush()`, which may lead to undesired effects (like disk I/O in the middle of forming data strings). For the `std::stringstream` it also has no meaning. * replace multiple `operator<<` calls on a string literal w/ the only call and the only (bigger) string literal; * replace one character string literal used in `operator<<` w/ a char literal. | 24 March 2020, 13:32:05 UTC |
