| 78bfc83 | Nir Soffer | 24 August 2024, 23:02:44 UTC | Test also with go 1.23 (#2182) | 24 August 2024, 23:02:44 UTC |
| 511af59 | Nir Soffer | 24 August 2024, 11:05:26 UTC | Replace deprecated ioutil usage (#2181) Fixing golangci-lint errors[1]: Error: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck) [1] https://github.com/spf13/cobra/actions/runs/10535452454/job/29194442289?pr=2180 | 24 August 2024, 11:05:26 UTC |
| 756ba6d | Gabe Cook | 28 July 2024, 16:18:07 UTC | fix(completions): Complete map flags multiple times (#2174) | 28 July 2024, 16:18:07 UTC |
| 371ae25 | Sebastiaan van Stijn | 16 July 2024, 23:36:29 UTC | Fix deprecation comment for Command.SetOutput (#2172) Deprecation comments should be at the start of a paragraph [1], and because of that have a whitespace above them [2]; > To signal that an identifier should not be used, add a paragraph to its > doc comment that begins with Deprecated: followed by some information > about the deprecation (...) With the whitespace missing, some tools, including pkg.go.dev [3] don't detect it to be deprecated. [1]: https://go.dev/wiki/Deprecated [2]: https://go.dev/doc/comment#paragraphs [3]: https://pkg.go.dev/github.com/spf13/cobra@v1.8.1#Command.SetOutput Signed-off-by: Sebastiaan van Stijn <github@gone.nl> | 16 July 2024, 23:36:29 UTC |
| e94f6d0 | Ville Skyttä | 01 June 2024, 10:31:11 UTC | Address golangci-lint deprecation warnings, enable some more linters (#2152) * Address golangci-lint linter deprecation warnings 1.59.0 outputs: WARN [lintersdb] The name "gas" is deprecated. The linter has been renamed to: gosec. WARN [lintersdb] The linter named "megacheck" is deprecated. It has been split into: gosimple, staticcheck, unused. * Enable some more linters, address finding | 01 June 2024, 10:31:11 UTC |
| 8003b74 | Nir Soffer | 19 May 2024, 02:12:02 UTC | Remove fully inactivated linters (#2148) * Remove fully inactivated linters Currently golangci-lint fails with these errors: ERRO [linters_context] golint: This linter is fully inactivated: it will not produce any reports. ERRO [linters_context] interfacer: This linter is fully inactivated: it will not produce any reports. ERRO [linters_context] maligned: This linter is fully inactivated: it will not produce any reports. I could not find any docs explaining what "fully inactivated" mean, but based this PR[1] it seems that these linters do nothing now. Removing the linters fixes this issue without changing linting, as they did not produce any report. Looking in the linters docs[2] I did not find a replacement for "interfacer" and "malinged" linters. "stylecheck" seems to be a replacement for "golint", but we need to fix the code to enable it. [1] https://github.com/golangci/golangci-lint/pull/4436 [2] https://golangci-lint.run/usage/linters/ * Add stylecheck linter, replacement for golint This revealed 2 capitalized error messages. https://golangci-lint.run/usage/linters/#stylecheck | 19 May 2024, 02:12:02 UTC |
| 5c2c1d6 | Nir Soffer | 18 May 2024, 13:41:31 UTC | Consistent annotation names (#2140) Add `Annotation` suffix to the private annotations to allow nicer code using the constants. For example one can use the current annotation names as a temporary variable instead of unclear shortcut. Instead of this: rag := flagsFromAnnotation(c, f, requiredAsGroup) me := flagsFromAnnotation(c, f, mutuallyExclusive) or := flagsFromAnnotation(c, f, oneRequired) We can use now: requiredAsGrop := flagsFromAnnotation(c, f, requiredAsGroupAnnotation) mutuallyExclusive := flagsFromAnnotation(c, f, mutuallyExclusiveAnnotation) oneRequired := flagsFromAnnotation(c, f, oneRequiredAnnotation) Example taken from #2105. | 18 May 2024, 13:41:31 UTC |
| 5a1acea | dependabot[bot] | 13 April 2024, 02:21:03 UTC | build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.3 to 2.0.4 (#2127) | 13 April 2024, 02:21:03 UTC |
| 0fc86c2 | Xinwei Xiong | 08 April 2024, 10:47:35 UTC | docs: update user guide (#2128) | 08 April 2024, 10:47:35 UTC |
| 6b5f577 | Ville Skyttä | 01 April 2024, 12:42:08 UTC | More linting (#2099) * Address gocritic findings, enable it * Enable gosimple, no new findings to address | 01 April 2024, 12:42:08 UTC |
| bd914e5 | Pedro Mota | 12 March 2024, 10:42:46 UTC | fix: remove deprecated io/ioutils package (#2120) ioutils.ReadAll is deprecated since Go 1.16. This commit replaces it with io.ReadAll. See https://pkg.go.dev/io/ioutil\#ReadAll for reference Issue #2119 | 12 March 2024, 10:42:46 UTC |
| 1f80fa2 | racerole | 12 March 2024, 10:40:19 UTC | chore: remove repetitive words (#2122) Signed-off-by: racerole <jiangyifeng@outlook.com> | 12 March 2024, 10:40:19 UTC |
| c69ae4c | damas | 12 March 2024, 10:40:01 UTC | ci: test golang 1.22 (#2113) | 12 March 2024, 10:40:01 UTC |
| a30cee5 | dependabot[bot] | 12 March 2024, 01:36:37 UTC | build(deps): bump actions/cache from 3 to 4 (#2102) Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> | 12 March 2024, 01:36:37 UTC |
| f34069c | dependabot[bot] | 12 March 2024, 01:35:05 UTC | build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 (#2108) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.7.0 to 4.0.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/v3.7.0...v4.0.0) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> | 12 March 2024, 01:35:05 UTC |
| bd2655e | montag451 | 08 March 2024, 00:36:58 UTC | Add Incus to the list of projects using Cobra (#2118) | 08 March 2024, 00:36:58 UTC |
| bcfcff7 | Radek Smid | 15 January 2024, 13:38:50 UTC | Add Taikun CloudWorks to list of projects (#2098) | 15 January 2024, 13:38:50 UTC |
| 4fb0a66 | Dmytro Milinevskyi | 06 January 2024, 21:49:13 UTC | flags: clarify documentation that LocalFlags related function do not modify the state (#2064) | 06 January 2024, 21:49:13 UTC |
| 0dec88e | Denis | 30 December 2023, 13:40:15 UTC | Add tests for funcs in cobra.go (#2094) | 30 December 2023, 13:40:15 UTC |
| cbcf75e | Case Wylie | 28 December 2023, 02:16:29 UTC | [chore]: update projects using cobra (#2093) Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com> | 28 December 2023, 02:16:29 UTC |
| 199b7ab | dependabot[bot] | 23 December 2023, 19:52:45 UTC | build(deps): bump actions/labeler from 4 to 5 (#2086) * build(deps): bump actions/labeler from 4 to 5 Bumps [actions/labeler](https://github.com/actions/labeler) from 4 to 5. - [Release notes](https://github.com/actions/labeler/releases) - [Commits](https://github.com/actions/labeler/compare/v4...v5) --- updated-dependencies: - dependency-name: actions/labeler dependency-type: direct:production update-type: version-update:semver-major ... * Update labeler configuration for v5 Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marc Khouzam <marc.khouzam@gmail.com> | 23 December 2023, 19:52:45 UTC |
| 531ce79 | Marc Khouzam | 23 December 2023, 15:11:53 UTC | Remove extra actions/checkout Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> | 23 December 2023, 18:49:43 UTC |
| c054701 | dependabot[bot] | 11 December 2023, 10:06:36 UTC | build(deps): bump actions/setup-go from 4 to 5 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> | 23 December 2023, 18:49:43 UTC |
| 4122785 | Nir Soffer | 12 November 2023, 13:55:40 UTC | Document how to create a plugin Using the new CommandDisplayNameAnnotation annotation introduced in Cobra 1.8.0. | 18 December 2023, 00:58:57 UTC |
| a73b9c3 | Nir Soffer | 12 November 2023, 18:07:59 UTC | Fix help text for runnable plugin command When creating a plugin without sub commands, the help text included the command name (kubectl-plugin) instead of the display name (kubectl plugin): Usage: kubectl-plugin [flags] The issue is that the usage line for this case does not use the command path but the raw `Use` string, and this case was not tested. Add a test for this case and fix UsageLine() to replace the command name with the display name. Tested using https://github.com/nirs/kubernetes/tree/sample-cli-plugin-help | 18 December 2023, 00:58:57 UTC |
| df547f5 | Nir Soffer | 12 November 2023, 15:20:47 UTC | Fix help text for plugins When using `CommandDisplayNameAnnotation` we want to use it instead of the command name in `--help` message or in the default help command. With current code we get the wrong text in the --help usage text: Flags: -h, --help help for kubectl-plugin And in the long description of the default help command: $ kubectl cobraplugin help -h Help provides help for any command in the application. Simply type kubectl-plugin help [path to command] for full details. The issue was hidden since the test checked only the Usage line. Fixed by extracting a displayName() function and use it when creating FlagSet and when formatting the default help flag usage and the help command long description. Enhance the TestPlugin to check all the lines including the command name. | 18 December 2023, 00:58:57 UTC |
| e63925d | Ville Skyttä | 17 December 2023, 18:50:59 UTC | Add env variable to suppress completion descriptions on create (#1938) COBRA_COMPLETION_DESCRIPTIONS=0 or <PROGRAM>_COMPLETION_DESCRIPTIONS=0 can now be used to disable shell completion descriptions. | 17 December 2023, 18:50:59 UTC |
| 236f3c0 | Marcus Kohlberg | 12 December 2023, 16:26:29 UTC | Update projects_using_cobra.md (#2089) Add Encore to the list of projects using Cobra | 12 December 2023, 16:26:29 UTC |
| 3d8ac43 | Ville Skyttä | 23 November 2023, 17:24:33 UTC | Micro-optimizations (#1957) * Avoid redundant string splits There likely isn't actually more than once to split in the source strings in these cases, but avoid doing so anyway as we're only interested in the first. * Avoid redundant completion output target evaluations The target is not to be changed while outputting completions, so resolve it only once. * Avoid redundant active help enablement evaluations The enablement state is not to be changed during completion output, so evaluate it only once. * Preallocate some slices and maps with known size * Avoid some unnecessary looping * Use strings.Builder to construct suggestions | 23 November 2023, 17:24:33 UTC |
| 283e32d | SwagPack | 13 November 2023, 16:55:06 UTC | Add LXC to the list of projects using cobra (#2071) | 13 November 2023, 16:55:06 UTC |
| a0a6ae0 | Marc Khouzam | 02 November 2023, 15:23:08 UTC | Improve API to get flag completion function (#2063) The new API is simpler and matches the `c.RegisterFlagCompletionFunc()` API. By removing the global function `GetFlagCompletion()` we are more future proof if we ever move from a global map of flag completion functions to something associated with the command. The commit also makes this API work with persistent flags by using `c.Flag(flagName)` instead of `c.Flags().Lookup(flagName)`. The commit also adds unit tests. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> | 02 November 2023, 15:23:08 UTC |
| 890302a | Nir Soffer | 02 November 2023, 12:15:26 UTC | Support usage as plugin for tools like kubectl (#2018) In this case the executable is `kubectl-plugin`, but we run it as: kubectl plugin And the help text should reflect the actual usage of the command. To create a plugin, add the cobra.CommandDisplayNameAnnotation: rootCmd := &cobra.Command{ Use: "plugin", Annotations: map[string]string{ cobra.CommandDisplayNameAnnotation: "kubectl plugin", } } Internally this change modifies CommandPath() for the root command to return the command display name instead of the command name. This is used for error messages, help text generation, and completions. CommandPath() is expected to have spaces and code using it already handle spaces (e.g replacing with _), so hopefully this does not break anything. Fixes: #2017 Signed-off-by: Nir Soffer <nsoffer@redhat.com> | 02 November 2023, 12:15:26 UTC |
| 48cea5c | dependabot[bot] | 30 October 2023, 10:21:48 UTC | build(deps): bump actions/checkout from 3 to 4 (#2028) | 30 October 2023, 10:21:48 UTC |
| 22953d8 | Ville Skyttä | 29 October 2023, 18:06:51 UTC | Replace all non-alphanumerics in active help env var program prefix (#1940) * Replace all non-alphanumerics in active help env var program prefix There are other characters besides the dash that are fine in program names, but are problematic in environment variable names. These include (but are not limited to) period, space, and non-ASCII letters. * Another change in docs to mention non-ASCII-alphanumeric instead of just dash | 29 October 2023, 18:06:51 UTC |
| 00b68a1 | Marc Khouzam | 28 October 2023, 20:11:59 UTC | Add tests for flag completion registration (#2053) Different problems have been reported about flag completion registration. These two tests are the cases that were not being verified but had been mentioned as problematic. Ref: - https://github.com/spf13/cobra/issues/1320 - https://github.com/spf13/cobra/pull/1438#issuecomment-872928669 Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> | 28 October 2023, 20:11:59 UTC |
| b711e87 | Marc Khouzam | 28 October 2023, 20:10:06 UTC | Don't complete --help flag when flag parsing disabled (#2061) Fixes #2060 When a command sets `DisableFlagParsing = true` it requests the responsibility of doing all the flag parsing. Therefore even the `--help/-f/--version/-v` flags should not be automatically completed by Cobra in such a case. Without this change the `--help/-h/--version/-v` flags can end up being completed twice for plugins: one time from cobra and one time from the plugin (which has set `DisableFlagParsing = true`). Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> | 28 October 2023, 20:10:06 UTC |
| 8b1eba4 | Marc Khouzam | 27 October 2023, 10:23:45 UTC | Fix linter errors (#2052) When using golangci-lint v1.55.0 some new errors were being reported. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> | 27 October 2023, 10:23:45 UTC |
| 4cafa37 | vkhoroz | 22 October 2023, 00:36:12 UTC | Allow running persistent run hooks of all parents (#2044) Currently, only one of the persistent pre-runs and post-runs is executed. It is always the first one found in the parents chain, starting at this command. Expected behavior is to execute all parents' persistent pre-runs and post-runs. Dependent projects implemented various workarounds for this: - manually building persistent hook chains (in every hook). - applying some kind of monkey-patching on top of Cobra. This change eliminates the necessity for such workarounds by allowing to set a global variable EnableTraverseRunHooks. Tickets: - https://github.com/spf13/cobra/issues/216 - https://github.com/spf13/cobra/issues/252 Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io> | 22 October 2023, 00:36:12 UTC |
| 5c962a2 | dependabot[bot] | 16 October 2023, 10:50:33 UTC | build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.2 to 2.0.3 (#2047) | 16 October 2023, 10:50:33 UTC |
| efe8fa3 | dependabot[bot] | 15 October 2023, 11:16:50 UTC | build(deps): bump actions/setup-go from 3 to 4 (#1934) | 15 October 2023, 11:16:50 UTC |
| 95d8a1e | Haoming Meng | 09 October 2023, 12:50:40 UTC | Add notes to doc on preRun and postRun condition (#2041) | 09 October 2023, 12:50:40 UTC |
| bd4d165 | Alexandru-Claudius Virtopeanu | 26 September 2023, 00:04:25 UTC | feat: add getters for flag completions (#1943) | 26 September 2023, 00:04:25 UTC |
| 0c72800 | Souma | 08 September 2023, 17:29:06 UTC | Customizable error message prefix (#2023) | 08 September 2023, 17:29:06 UTC |
| c5dacb3 | Nuno Adrego | 08 September 2023, 00:30:51 UTC | ci: test golang 1.21 (#2024) | 08 September 2023, 00:30:51 UTC |
| 285460d | Unai Martinez-Corral | 29 August 2023, 14:04:59 UTC | command: temporarily disable G602 due to securego/gosec#1005 (#2022) | 29 August 2023, 14:04:59 UTC |
| 4955da7 | dependabot[bot] | 28 August 2023, 18:53:34 UTC | build(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#2021) | 28 August 2023, 18:53:34 UTC |
| fd865a4 | Jun Nishimura | 23 July 2023, 11:31:55 UTC | minor corrections to unit tests (#2003) | 23 July 2023, 11:31:55 UTC |
| 60d056d | gocurr | 20 July 2023, 15:27:44 UTC | doc: fix typo, Deperecated -> Deprecated (#2000) | 20 July 2023, 15:27:44 UTC |
| 66b215b | Unai Martinez-Corral | 18 July 2023, 13:51:36 UTC | golangci: enable 'unused' and disable deprecated replaced by it (#1983) | 18 July 2023, 13:51:36 UTC |
| c81c46a | Martijn Evers | 16 July 2023, 16:38:22 UTC | Add 'one required flag' group (#1952) | 16 July 2023, 16:38:22 UTC |
| dcb405a | Unai Martinez-Corral | 20 June 2023, 21:15:36 UTC | Move documentation sources to site/content (#1428) | 20 June 2023, 21:15:36 UTC |
| cbe4865 | dependabot[bot] | 20 June 2023, 20:46:35 UTC | build(deps): bump golangci/golangci-lint-action from 3.5.0 to 3.6.0 (#1976) | 20 June 2023, 20:46:35 UTC |
| fdee73b | Paul Holzinger | 19 June 2023, 16:16:18 UTC | powershell: escape variable with curly brackets (#1960) This fixes an issue with program names that include a dot, in our case `podman.exe`. This was caused by the change in commit 6ba7ebbc. Fixes #1853 Signed-off-by: Paul Holzinger <pholzing@redhat.com> | 19 June 2023, 16:16:18 UTC |
| 988bd76 | Branch Vincent | 16 June 2023, 14:25:30 UTC | test: make fish_completions_test more robust (#1980) Use temporary files instead of assuming the current directory is writable. Also, if creating a temporary file still returns an error, prevent the test from failing silently by replacing `log.Fatal` with `t.Fatal`. | 16 June 2023, 14:25:30 UTC |
| 2246fa8 | Taavi Väänänen | 13 June 2023, 15:12:49 UTC | Fix grammar: 'allows to' (#1978) The use in generated bash completion files is getting flagged by Lintian (the Debian package linting tool). Signed-off-by: Taavi Väänänen <hi@taavi.wtf> | 13 June 2023, 15:12:49 UTC |
| 0e3a0bf | dependabot[bot] | 12 June 2023, 02:39:30 UTC | build(deps): bump golangci/golangci-lint-action from 3.4.0 to 3.5.0 (#1971) | 12 June 2023, 02:39:30 UTC |
| 284f410 | Tom Payne | 08 April 2023, 04:47:33 UTC | Fix typo in fish completions (#1945) | 08 April 2023, 04:47:33 UTC |
| 4dd4b25 | Marc Khouzam | 22 March 2023, 22:41:51 UTC | Update main image to better handle dark background (#1883) Fixes #1880 Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> Co-authored-by: Deleplace <deleplace2015@gmail.com> | 22 March 2023, 22:41:51 UTC |
| 45360a5 | Marc Khouzam | 22 March 2023, 22:41:05 UTC | Allow sourcing zsh completion script (#1917) Although it is not the recommended approach, sourcing a completion script is the simplest way to get people to try using shell completion. Not allowing it for zsh has turned out to complicate shell completion adoption. Further, many tools modify the zsh script to allow sourcing. This commit allows sourcing of the zsh completion script. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> | 22 March 2023, 22:41:05 UTC |
| c8a20a1 | Luiz Carvalho | 17 March 2023, 01:03:29 UTC | Document suggested layout for subcommands (#1930) Signed-off-by: Luiz Carvalho <lucarval@redhat.com> | 17 March 2023, 01:03:29 UTC |
| b197a24 | Florent Poinsard | 14 March 2023, 12:28:50 UTC | Update projects_using_cobra.md (#1932) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> | 14 March 2023, 12:28:50 UTC |
| 9e6b58a | Unai Martinez-Corral | 06 March 2023, 02:28:31 UTC | update copyright year (#1927) | 06 March 2023, 02:28:31 UTC |
| fb36524 | Unai Martinez-Corral | 06 March 2023, 02:11:33 UTC | ci: test Golang 1.20 (#1925) | 06 March 2023, 02:11:33 UTC |
| c7300f0 | Unai Martinez-Corral | 06 March 2023, 02:07:19 UTC | ci: deprecate go 1.16 (#1926) | 06 March 2023, 02:07:19 UTC |
| 567ea8e | Oldřich Jedlička | 25 February 2023, 21:30:37 UTC | Add support for PowerShell 7.2+ (#1916) PowerShell 7.2 has changed the way arguments are passed to executables. This was originally an experimental feature in 7.2, but as of 7.3 it is built-in. A simple "" is now sufficient for passing empty arguments, no back-tick escaping is required. Fixes #1849 Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com> Co-authored-by: Oldřich Jedlička <oldrich.jedlicka@rohlik.cz> | 25 February 2023, 21:30:37 UTC |
| 3daa4b9 | Gyanendra Mishra | 25 February 2023, 20:57:12 UTC | Add keeporder to shell completion (#1903) This allows programs to request the shell to maintain the order of completions that was returned by the program | 25 February 2023, 20:57:12 UTC |
| a516d41 | John McBride | 14 February 2023, 03:49:03 UTC | Removes stale bot from GitHub action (#1908) Signed-off-by: John McBride <jpmmcbride@gmail.com> | 14 February 2023, 03:49:03 UTC |
| e839bb3 | dependabot[bot] | 12 February 2023, 01:27:13 UTC | build(deps): bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1902) | 12 February 2023, 01:27:13 UTC |
| 87ebcd8 | Ggg6542 | 09 February 2023, 02:11:53 UTC | Update shell_completions.md (#1907) align documentation with the code : completions.go:452 | 09 February 2023, 02:11:53 UTC |
| 8b8ee87 | janhn | 06 February 2023, 11:15:40 UTC | Improve MarkFlagsMutuallyExclusive example in User Guide (#1904) | 06 February 2023, 11:15:40 UTC |
| d022c0f | Shihta Kuan | 30 January 2023, 17:58:20 UTC | Add documentation about disabling completion descriptions (#1901) | 30 January 2023, 17:58:20 UTC |
| 4fa4fdf | dependabot[bot] | 03 January 2023, 02:43:06 UTC | build(deps): bump github.com/inconshreveable/mousetrap (#1872) | 03 January 2023, 02:43:06 UTC |
| b4f979a | Dominik Roos | 03 January 2023, 00:58:36 UTC | completions: do not detect arguments with dash as 2nd char as flag (#1817) Fixes #1816 Previously, arguments with a dash as the second character (e.g., 1-ff00:0:1) were detected as a flag by mistake. This resulted in auto completion misbehaving if such an argument was last in the argument list during invocation. | 03 January 2023, 00:58:36 UTC |
| bf11ab6 | Yash Ladha | 25 December 2022, 20:08:39 UTC | fix: func name in doc strings (#1885) Corrected the function name at the start of doc strings, as per the convention outlined in official go documentation: https://go.dev/blog/godoc | 25 December 2022, 20:08:39 UTC |
| fdffa5a | Seonghyeon Cho | 23 December 2022, 20:54:16 UTC | Update badge route (#1884) Based on https://github.com/badges/shields/issues/8671 | 23 December 2022, 20:54:16 UTC |
| f25a3c6 | Yash Ladha | 15 December 2022, 10:39:50 UTC | fix: conflict import name with variable (#1879) `template` is an import in `cobra.go` file and also used as a variable name, which masks the library in the scope of that function. | 15 December 2022, 10:39:50 UTC |
| 9235920 | Unai Martinez-Corral | 09 December 2022, 21:57:19 UTC | ci: deprecate go 1.15 (#1866) Remove testing for go 1.15 to allow CI to pass, but don't force projects to upgrade. | 09 December 2022, 21:57:19 UTC |
| a6f198b | David Wertenteil | 06 December 2022, 13:20:58 UTC | Update kubescape org (#1874) Signed-off-by: David Wertenteil <dwertent@armosec.io> | 06 December 2022, 13:20:58 UTC |
| 7bb1440 | dependabot[bot] | 26 November 2022, 13:18:05 UTC | build(deps): bump golangci/golangci-lint-action from 3.2.0 to 3.3.1 (#1851) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.2.0 to 3.3.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/v3.2.0...v3.3.1) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> | 26 November 2022, 13:18:05 UTC |
| 6200c8e | Unai Martinez-Corral | 25 November 2022, 20:55:09 UTC | Makefile: add target richtest (#1865) Don't require contributors to install richgo but keep it as an option and for CI | 25 November 2022, 20:55:09 UTC |
| c6b9971 | Norman Dankert | 25 November 2022, 20:47:20 UTC | fix: force ForEach-Object to return array in pwsh completion (#1850) Fixes #1847 | 25 November 2022, 20:47:20 UTC |
| 4305498 | Enrico Candino | 22 November 2022, 02:04:26 UTC | Update stale.yml (#1863) | 22 November 2022, 02:04:26 UTC |
| ad6db7f | Brian Pursley | 15 November 2022, 02:46:57 UTC | Create unit test illustrating unknown flag bug (#1854) Created a unit test that tests the unknown flag error message when the unknown flag is located in different arg positions. | 15 November 2022, 02:46:57 UTC |
| 6b0bd30 | Brian Pursley | 08 November 2022, 04:12:02 UTC | fix: don't remove flag value that matches subcommand name (#1781) When the command searches args to find the arg matching a particular subcommand name, it needs to ignore flag values, as it is possible that the value for a flag might match the name of the sub command. This change improves argsMinusFirstX() to ignore flag values when it searches for the X to exclude from the result. | 08 November 2022, 04:12:02 UTC |
| cc7e235 | mike76-dev | 01 November 2022, 13:15:28 UTC | Add Sia to projects using Cobra (#1844) | 01 November 2022, 13:15:28 UTC |
| 10cf7be | Marc Khouzam | 24 October 2022, 15:11:57 UTC | Check for group presence after full initialization (#1839) Fixes #1831 By moving the check for help group existence to "ExecuteC()" we no longer need groups to be added before AddCommand() is called. This provides more flexibility to developers and works better with the use of "init()" for command creation. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> | 24 October 2022, 15:11:57 UTC |
| 4b9d00d | doniacld | 20 October 2022, 20:33:37 UTC | Replace deprecated ExactValidArgs with MatchAll in user_guide and shell_completions example (#1836) | 20 October 2022, 20:33:37 UTC |
| badcce1 | Ville Skyttä | 17 October 2022, 19:24:27 UTC | style(bash-v2): various cleanups (#1702) * use arithmetic evaluation in numeric context * remove unnecessary $ from array index variables * [[ ]] over [ ], == over =, remove unnecessary quoting * use ${foo-} rather than ${foo:-} in emptiness check The result of the expansion is null no matter if the variable is unset or null in both cases; the former form is arguably easier on the eye. * remove unnecessary trailing linefeed removal No longer needed as of f464d6c82e9af74b7a46301a775163984af32cd1, saves a subshell. * use herestring in activehelp extraction Herestrings read cleaner than process substitutions, and work in posix mode (but we do and will have some process substitutions so this doesn't matter much). Both approaches may end up using temporary files. | 17 October 2022, 19:24:27 UTC |
| 1424b7b | Fabian Kammel | 13 October 2022, 13:47:58 UTC | Add Constellation to projects using cobra. (#1829) | 13 October 2022, 13:47:58 UTC |
| 8607918 | Gustavo Bazan | 10 October 2022, 23:06:30 UTC | feat: make InitDefaultCompletionCmd public (#1467) * feat: make InitDefaultCompletionCmd public * PR comments * Update man_docs_test.go * Update README.md | 10 October 2022, 23:06:30 UTC |
| 2169adb | aawsome | 10 October 2022, 20:59:11 UTC | Add groups for commands in help (#1003) * Add tests for grouping commands * Adds Additional Command section in help Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> Co-authored-by: Marc Khouzam <marc.khouzam@gmail.com> | 10 October 2022, 20:59:11 UTC |
| 212ea40 | Marc Khouzam | 04 October 2022, 22:41:30 UTC | Include --help and --version flag in completion (#1813) Fixes #1786 The --help, -h, --version and -v flags are normally added when the `execute()` function is called on a command. When doing completion we don't call `execute()` so we need to add these flags explicitly to the command being completed. Also, we disable all further completions if the 'help' or 'version' flags are present on the command-line. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> | 04 October 2022, 22:41:30 UTC |
| d4040ad | Marc Khouzam | 03 October 2022, 17:06:04 UTC | Allow user to add completion for powershell alias (#1621) When a user has an alias in powershell, she will need to register that alias for completion. To make that possible, we store the completion logic into a scriptblock variable which can easily be accessed by the user to register aliases. For example, if the user defines an alias for `helm`: PS> sal h helm she will need to register the alias like so: PS> Register-ArgumentCompleter -CommandName 'h' -ScriptBlock $__helmCompleterBlock Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca> | 03 October 2022, 17:06:04 UTC |
| 23fc5e0 | Varun Sharma | 03 October 2022, 14:53:12 UTC | ci: add minimum GitHub token permissions for workflows (#1792) Signed-off-by: Varun Sharma <varunsh@stepsecurity.io> | 03 October 2022, 14:53:12 UTC |
| 93d1913 | Yann Soubeyrand | 03 October 2022, 14:52:50 UTC | Add OnFinalize method (#1788) This method is the OnInitialize counterpart. Like OnInitialize which allows loading the configuration before each command is executed, OnFinalize allows saving the configuration after each command has been executed. | 03 October 2022, 14:52:50 UTC |
| 07034fe | dependabot[bot] | 03 October 2022, 14:52:25 UTC | build(deps): bump actions/stale from 5 to 6 (#1815) Bumps [actions/stale](https://github.com/actions/stale) from 5 to 6. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/stale/compare/v5...v6) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> | 03 October 2022, 14:52:25 UTC |
| 3dc9761 | Dima Brusilovsky | 03 October 2022, 14:52:01 UTC | Add allero to list of projects using cobra (#1819) | 03 October 2022, 14:52:01 UTC |
| 7039e1f | Francis Nickels III | 30 September 2022, 18:26:05 UTC | Add '--version' flag to Help output (#1707) | 30 September 2022, 18:26:05 UTC |
| fce8d8a | Skeet WU | 27 September 2022, 10:27:48 UTC | Expose ValidateRequiredFlags and ValidateFlagGroups (#1760) | 27 September 2022, 10:27:48 UTC |
| a281c8b | Marc Khouzam | 16 September 2022, 20:44:28 UTC | Document option to hide the default completion cmd (#1779) Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> | 16 September 2022, 20:44:28 UTC |
