https://github.com/torvalds/linux
Revision 0191944282e84931f92915b5f06b348a92dac7e1 authored by Tejun Heo on 28 April 2009, 03:38:33 UTC, committed by Jens Axboe on 28 April 2009, 18:24:20 UTC
hd dance around local irq and HD_IRQ enable without achieving much.
It ends up transferring data from irq handler with both local irq and
HD_IRQ disabled.  The only place it actually does something is while
transferring the first block of a request which it does with HD_IRQ
disabled but local irq enabled.

Unfortunately, the dancing is horribly broken from locking POV.  IRQ
and timeout handlers access block queue without grabbing the queue
lock and running the driver in SMP configuration crashes the whole
machine pretty quickly.

Remove meaningless irq enable/disable dancing and add proper locking
in issue, irq and timeout paths.

Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent 0d9f346
History
Tip revision: 0191944282e84931f92915b5f06b348a92dac7e1 authored by Tejun Heo on 28 April 2009, 03:38:33 UTC
hd: fix locking
Tip revision: 0191944
File Mode Size
Documentation
arch
block
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
usr
virt
.gitignore -rw-r--r-- 885 bytes
.mailmap -rw-r--r-- 3.9 KB
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 91.6 KB
Kbuild -rw-r--r-- 2.4 KB
MAINTAINERS -rw-r--r-- 144.1 KB
Makefile -rw-r--r-- 53.7 KB
README -rw-r--r-- 16.7 KB
REPORTING-BUGS -rw-r--r-- 3.1 KB

README

back to top