https://github.com/torvalds/linux
Revision 01cfaf0d12ae5fa092cc916ca4066ee1598e857d authored by Dirk Eibach on 27 August 2006, 08:23:36 UTC, committed by Linus Torvalds on 27 August 2006, 18:01:29 UTC
While testing Moxa C218T/PCI on PowerPC 405EP I found that loading firmware using the linux kernel driver fails because calculation of the checksum is not endianess independent in the original code. After I fixed this I found that uploading firmware in a system with multiple cards causes a kernel oops. I had a look in the recent moxa sources and found that they do some kind of locking there. Applying this lock fixed the problem. Alan sayeth: Checksum changes are clearly correct. Other changes is an improvement but not I think enough to handle malicious firmware attacks. That said such an attacker has CAP_SYS_RAWIO anyway so that part is irrelevant except for neatness. [akpm@osdl.org: cleanups] Signed-off-by: Dirk Eibach <eibach@gdsys.de> Acked-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent a0cc621
Tip revision: 01cfaf0d12ae5fa092cc916ca4066ee1598e857d authored by Dirk Eibach on 27 August 2006, 08:23:36 UTC
[PATCH] char/moxa.c: fix endianess and multiple-card issues
[PATCH] char/moxa.c: fix endianess and multiple-card issues
Tip revision: 01cfaf0
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 10.5 KB |
| Makefile | -rw-r--r-- | 1.1 KB |
| aes.c | -rw-r--r-- | 11.6 KB |
| anubis.c | -rw-r--r-- | 27.8 KB |
| api.c | -rw-r--r-- | 6.4 KB |
| arc4.c | -rw-r--r-- | 2.1 KB |
| blowfish.c | -rw-r--r-- | 17.5 KB |
| cast5.c | -rw-r--r-- | 34.2 KB |
| cast6.c | -rw-r--r-- | 21.5 KB |
| cipher.c | -rw-r--r-- | 11.1 KB |
| compress.c | -rw-r--r-- | 1.5 KB |
| crc32c.c | -rw-r--r-- | 2.5 KB |
| crypto_null.c | -rw-r--r-- | 3.3 KB |
| deflate.c | -rw-r--r-- | 5.4 KB |
| des.c | -rw-r--r-- | 35.4 KB |
| digest.c | -rw-r--r-- | 2.8 KB |
| hmac.c | -rw-r--r-- | 3.1 KB |
| internal.h | -rw-r--r-- | 2.8 KB |
| khazad.c | -rw-r--r-- | 51.9 KB |
| md4.c | -rw-r--r-- | 6.2 KB |
| md5.c | -rw-r--r-- | 7.2 KB |
| michael_mic.c | -rw-r--r-- | 3.5 KB |
| proc.c | -rw-r--r-- | 2.8 KB |
| scatterwalk.c | -rw-r--r-- | 2.8 KB |
| scatterwalk.h | -rw-r--r-- | 2.0 KB |
| serpent.c | -rw-r--r-- | 20.0 KB |
| sha1.c | -rw-r--r-- | 3.1 KB |
| sha256.c | -rw-r--r-- | 11.0 KB |
| sha512.c | -rw-r--r-- | 10.3 KB |
| tcrypt.c | -rw-r--r-- | 34.3 KB |
| tcrypt.h | -rw-r--r-- | 103.9 KB |
| tea.c | -rw-r--r-- | 7.3 KB |
| tgr192.c | -rw-r--r-- | 31.1 KB |
| twofish.c | -rw-r--r-- | 45.0 KB |
| wp512.c | -rw-r--r-- | 60.3 KB |
Computing file changes ...
