https://github.com/Kitware/CMake
Revision 03454b0d0d5083530f87e3b2f4ed4fe93b182112 authored by Brad King on 31 October 2018, 14:10:40 UTC, committed by Brad King on 31 October 2018, 14:24:01 UTC
Protobuf headers have dependencies on threads. On UNIX platforms this requires linking to a threads library. We've long done this in the `Protobuf_LIBRARIES` result variable. However, the imported targets added by commit v3.9.0-rc1~81^2~2 (FindProtobuf: add targets, 2017-05-17) and commit v3.9.0-rc1~68^2 (FindProtobuf: Rename imported targets to match upstream names, 2017-05-22) were missing a dependency on threads. Add the dependency to the imported targets, and to the variables `Protobuf_LITE_LIBRARIES` and `Protobuf_PROTOC_LIBRARIES`. While this did not seem to matter in practice for a long time, protobuf 3.6 throws exceptions in some cases when threads are missing. Fixes: #18533
1 parent 44cc305
Tip revision: 03454b0d0d5083530f87e3b2f4ed4fe93b182112 authored by Brad King on 31 October 2018, 14:10:40 UTC
FindProtobuf: Add missing link dependencies on threads
FindProtobuf: Add missing link dependencies on threads
Tip revision: 03454b0
| File | Mode | Size |
|---|---|---|
| .github | ||
| Auxiliary | ||
| Help | ||
| Licenses | ||
| Modules | ||
| Packaging | ||
| Source | ||
| Templates | ||
| Tests | ||
| Utilities | ||
| .clang-format | -rw-r--r-- | 551 bytes |
| .clang-tidy | -rw-r--r-- | 969 bytes |
| .gitattributes | -rw-r--r-- | 1.1 KB |
| .gitignore | -rw-r--r-- | 132 bytes |
| .hooks-config | -rw-r--r-- | 418 bytes |
| CMakeCPack.cmake | -rw-r--r-- | 9.8 KB |
| CMakeCPackOptions.cmake.in | -rw-r--r-- | 12.4 KB |
| CMakeGraphVizOptions.cmake | -rw-r--r-- | 153 bytes |
| CMakeLists.txt | -rw-r--r-- | 30.7 KB |
| CMakeLogo.gif | -rw-r--r-- | 4.4 KB |
| CONTRIBUTING.rst | -rw-r--r-- | 2.9 KB |
| CTestConfig.cmake | -rw-r--r-- | 440 bytes |
| CTestCustom.cmake.in | -rw-r--r-- | 6.4 KB |
| CompileFlags.cmake | -rw-r--r-- | 3.6 KB |
| Copyright.txt | -rw-r--r-- | 5.0 KB |
| DartConfig.cmake | -rw-r--r-- | 374 bytes |
| README.rst | -rw-r--r-- | 3.1 KB |
| bootstrap | -rwxr-xr-x | 48.8 KB |
| cmake_uninstall.cmake.in | -rw-r--r-- | 790 bytes |
| configure | -rwxr-xr-x | 99 bytes |
| doxygen.config | -rw-r--r-- | 27.4 KB |
Computing file changes ...
