Skip to main content

Browse the archive

Revision 03598e505d3e3cd46ce992b3d6f358791125b04f authored by Ben Wells on 27 March 2018, 05:42:26 UTC, committed by Chromium WPT Sync on 27 March 2018, 05:42:26 UTC 
Revert "Don't adjust the NavigationTimings on redirects"
 
This reverts commit aeecb4f32ece14a8a294e4f9b80a5bb2278091c9.

Reason for revert: Causing lots of failures on webkit bots, e.g.:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/42143

Original change's description:
> Don't adjust the NavigationTimings on redirects
>
> We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
> shouldn't update in each AddRedirect() (which is called in a batch
> way after all the redirects are handled in the browser process with PlzNavigate,
> adjusting timings there with current timestamp is totally wrong)
>
> R=​ksakamoto,arthursonzogni
>
> Bug: 813889
> Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
> Reviewed-on: https://chromium-review.googlesource.com/974673
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546001}

TBR=kinuko@chromium.org,ksakamoto@chromium.org,arthursonzogni@chromium.org

Change-Id: I467ed888084ea0eda06faa903d1797fabffc47da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813889
Reviewed-on: https://chromium-review.googlesource.com/981912
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546025}
1 parent 8ec345b
Raw File
open-url-multi-window-6.htm 
<!DOCTYPE html>
<html>
  <head>
    <title>XMLHttpRequest: open() in document that is not fully active (but may be active) should throw</title>
    <script src="/resources/testharness.js"></script>
    <script src="/resources/testharnessreport.js"></script>
    <link rel="help" href="https://xhr.spec.whatwg.org/#the-open()-method">
  </head>
  <body>
    <div id="log"></div>
    <script>
      var test = async_test(),
          client,
          count = 0,
          win = window.open("resources/init.htm");
      test.add_cleanup(function() { win.close(); });
      function init() {
        test.step(function() {
          if(0 == count) {
            var doc = win.document;
            var ifr = document.createElement("iframe");
            ifr.onload = function() {
              // Again, do things async so we're not doing loads from inside
              // load events.
              test.step_timeout(function() {
                client = new ifr.contentWindow.XMLHttpRequest();
                count++;
                // Important to do a normal navigation, not a reload.
                win.location.href = "resources/init.htm?avoid-replace";
              }, 0);
            }
            doc.body.appendChild(ifr);
          } else if(1 == count) {
            assert_throws("InvalidStateError", function() { client.open("GET", "...") })
            test.done()
          }
        })
      }
    </script>
  </body>
</html>
back to top