Skip to main content

Browse the archive

Revision 03598e505d3e3cd46ce992b3d6f358791125b04f authored by Ben Wells on 27 March 2018, 05:42:26 UTC, committed by Chromium WPT Sync on 27 March 2018, 05:42:26 UTC 
Revert "Don't adjust the NavigationTimings on redirects"
 
This reverts commit aeecb4f32ece14a8a294e4f9b80a5bb2278091c9.

Reason for revert: Causing lots of failures on webkit bots, e.g.:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/42143

Original change's description:
> Don't adjust the NavigationTimings on redirects
>
> We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
> shouldn't update in each AddRedirect() (which is called in a batch
> way after all the redirects are handled in the browser process with PlzNavigate,
> adjusting timings there with current timestamp is totally wrong)
>
> R=​ksakamoto,arthursonzogni
>
> Bug: 813889
> Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
> Reviewed-on: https://chromium-review.googlesource.com/974673
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546001}

TBR=kinuko@chromium.org,ksakamoto@chromium.org,arthursonzogni@chromium.org

Change-Id: I467ed888084ea0eda06faa903d1797fabffc47da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813889
Reviewed-on: https://chromium-review.googlesource.com/981912
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546025}
1 parent 8ec345b
Raw File
progressevent-interface.html 
<!DOCTYPE html>
<title>The ProgressEvent interface</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<div id="log"></div>
<script>
test(function() {
  assert_equals(typeof ProgressEvent, "function")
  assert_equals(ProgressEvent.length, 1)
})
test(function() {
  var desc = Object.getOwnPropertyDescriptor(ProgressEvent, "prototype")
  assert_equals(desc.value, ProgressEvent.prototype)
  assert_equals(desc.writable, false)
  assert_equals(desc.enumerable, false)
  assert_equals(desc.configurable, false)
  assert_throws(new TypeError(), function() {
    "use strict";
    delete ProgressEvent.prototype;
  })
  assert_equals(ProgressEvent.prototype.constructor, ProgressEvent)
  assert_equals(Object.getPrototypeOf(ProgressEvent.prototype), Event.prototype)
}, "interface prototype object")
var attributes = [
  ["boolean", "lengthComputable"],
  ["unsigned long long", "loaded"],
  ["unsigned long long", "total"]
];
attributes.forEach(function(a) {
  test(function() {
    var desc = Object.getOwnPropertyDescriptor(ProgressEvent.prototype, a[1])
    assert_equals(desc.enumerable, true)
    assert_equals(desc.configurable, true)
    assert_throws(new TypeError(), function() {
      ProgressEvent.prototype[a[1]]
    })
  })
})
test(function() {
  for (var p in window) {
    assert_not_equals(p, "ProgressEvent")
  }
}, "Interface objects properties should not be Enumerable")
test(function() {
  assert_true(!!window.ProgressEvent, "Interface should exist.")
  assert_true(delete window.ProgressEvent, "The delete operator should return true.")
  assert_equals(window.ProgressEvent, undefined, "Interface should be gone.")
}, "Should be able to delete ProgressEvent.")
</script>
back to top