https://github.com/torvalds/linux
Revision 041d7b98ffe59c59fdd639931dea7d74f9aa9a59 authored by Richard Guy Briggs on 23 December 2014, 18:02:04 UTC, committed by Paul Moore on 23 December 2014, 21:40:18 UTC
A regression was caused by commit 780a7654cee8:
	 audit: Make testing for a valid loginuid explicit.
(which in turn attempted to fix a regression caused by e1760bd)

When audit_krule_to_data() fills in the rules to get a listing, there was a
missing clause to convert back from AUDIT_LOGINUID_SET to AUDIT_LOGINUID.

This broke userspace by not returning the same information that was sent and
expected.

The rule:
	auditctl -a exit,never -F auid=-1
gives:
	auditctl -l
		LIST_RULES: exit,never f24=0 syscall=all
when it should give:
		LIST_RULES: exit,never auid=-1 (0xffffffff) syscall=all

Tag it so that it is reported the same way it was set.  Create a new
private flags audit_krule field (pflags) to store it that won't interact with
the public one from the API.

Cc: stable@vger.kernel.org # v3.10-rc1+
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
1 parent 4a92843
History
Tip revision: 041d7b98ffe59c59fdd639931dea7d74f9aa9a59 authored by Richard Guy Briggs on 23 December 2014, 18:02:04 UTC
audit: restore AUDIT_LOGINUID unset ABI
Tip revision: 041d7b9
File Mode Size
partitions
Kconfig -rw-r--r-- 3.6 KB
Kconfig.iosched -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 948 bytes
bio-integrity.c -rw-r--r-- 17.5 KB
bio.c -rw-r--r-- 49.5 KB
blk-cgroup.c -rw-r--r-- 29.5 KB
blk-cgroup.h -rw-r--r-- 16.7 KB
blk-core.c -rw-r--r-- 89.1 KB
blk-exec.c -rw-r--r-- 3.4 KB
blk-flush.c -rw-r--r-- 13.6 KB
blk-integrity.c -rw-r--r-- 11.7 KB
blk-ioc.c -rw-r--r-- 10.2 KB
blk-iopoll.c -rw-r--r-- 5.8 KB
blk-lib.c -rw-r--r-- 7.3 KB
blk-map.c -rw-r--r-- 8.2 KB
blk-merge.c -rw-r--r-- 14.6 KB
blk-mq-cpu.c -rw-r--r-- 1.6 KB
blk-mq-cpumap.c -rw-r--r-- 2.5 KB
blk-mq-sysfs.c -rw-r--r-- 10.5 KB
blk-mq-tag.c -rw-r--r-- 13.7 KB
blk-mq-tag.h -rw-r--r-- 2.0 KB
blk-mq.c -rw-r--r-- 46.9 KB
blk-mq.h -rw-r--r-- 3.1 KB
blk-settings.c -rw-r--r-- 27.2 KB
blk-softirq.c -rw-r--r-- 4.4 KB
blk-sysfs.c -rw-r--r-- 15.1 KB
blk-tag.c -rw-r--r-- 9.4 KB
blk-throttle.c -rw-r--r-- 45.8 KB
blk-timeout.c -rw-r--r-- 5.6 KB
blk.h -rw-r--r-- 7.9 KB
bounce.c -rw-r--r-- 6.5 KB
bsg-lib.c -rw-r--r-- 6.0 KB
bsg.c -rw-r--r-- 23.6 KB
cfq-iosched.c -rw-r--r-- 119.7 KB
cmdline-parser.c -rw-r--r-- 4.9 KB
compat_ioctl.c -rw-r--r-- 20.8 KB
deadline-iosched.c -rw-r--r-- 11.3 KB
elevator.c -rw-r--r-- 23.7 KB
genhd.c -rw-r--r-- 44.1 KB
ioctl.c -rw-r--r-- 10.7 KB
ioprio.c -rw-r--r-- 5.0 KB
noop-iosched.c -rw-r--r-- 2.7 KB
partition-generic.c -rw-r--r-- 14.0 KB
scsi_ioctl.c -rw-r--r-- 19.1 KB

back to top