Revision 0447378a4a793da008451fad50bc0f93e9675ae6 authored by Marc Orr on 21 June 2018, 00:21:29 UTC, committed by Radim Krčmář on 22 June 2018, 14:46:26 UTC
This patch extends the checks done prior to a nested VM entry. Specifically, it extends the check_vmentry_prereqs function with checks for fields relevant to the VM-entry event injection information, as described in the Intel SDM, volume 3. This patch is motivated by a syzkaller bug, where a bad VM-entry interruption information field is generated in the VMCS02, which causes the nested VM launch to fail. Then, KVM fails to resume L1. While KVM should be improved to correctly resume L1 execution after a failed nested launch, this change is justified because the existing code to resume L1 is flaky/ad-hoc and the test coverage for resuming L1 is sparse. Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Marc Orr <marcorr@google.com> [Removed comment whose parts were describing previous revisions and the rest was obvious from function/variable naming. - Radim] Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
1 parent 5f9077c
debug.h
/* SPDX-License-Identifier: GPL-2.0 */
/*
* Debugging printout:
*/
#define ___P(f) if (desc->status_use_accessors & f) printk("%14s set\n", #f)
#define ___PS(f) if (desc->istate & f) printk("%14s set\n", #f)
/* FIXME */
#define ___PD(f) do { } while (0)
static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
{
static DEFINE_RATELIMIT_STATE(ratelimit, 5 * HZ, 5);
if (!__ratelimit(&ratelimit))
return;
printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n",
irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled);
printk("->handle_irq(): %p, %pS\n",
desc->handle_irq, desc->handle_irq);
printk("->irq_data.chip(): %p, %pS\n",
desc->irq_data.chip, desc->irq_data.chip);
printk("->action(): %p\n", desc->action);
if (desc->action) {
printk("->action->handler(): %p, %pS\n",
desc->action->handler, desc->action->handler);
}
___P(IRQ_LEVEL);
___P(IRQ_PER_CPU);
___P(IRQ_NOPROBE);
___P(IRQ_NOREQUEST);
___P(IRQ_NOTHREAD);
___P(IRQ_NOAUTOEN);
___PS(IRQS_AUTODETECT);
___PS(IRQS_REPLAY);
___PS(IRQS_WAITING);
___PS(IRQS_PENDING);
___PD(IRQS_INPROGRESS);
___PD(IRQS_DISABLED);
___PD(IRQS_MASKED);
}
#undef ___P
#undef ___PS
#undef ___PD
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...