Revision - 0525e95 - xfs: queue deferred rmap ops for cow staging extent alloc/free [...] - origin: https://github.com/torvalds/linux

visit type:

https://github.com/torvalds/linux

05 April 2024, 19:05:47 UTC

Revision 0525e952dcceb9fc947c6d395de7f72220c7d081 authored by Darrick J. Wong on 08 December 2017, 03:07:03 UTC, committed by Darrick J. Wong on 21 December 2017, 16:48:38 UTC

xfs: queue deferred rmap ops for cow staging extent alloc/free in the right order

Under the deferred rmap operation scheme, there's a certain order in
which the rmap deferred ops have to be queued to maintain integrity
during log replay.  For alloc/map operations that order is cui -> rui;
for free/unmap operations that order is cui -> rui -> efi.  However, the
initial refcount code got the ordering wrong in the free side of things
because it queued refcount free op and an EFI and the refcount free op
queued a rmap free op, resulting in the order cui -> efi -> rui.

If we fail before the efd finishes, the efi recovery will try to do a
wildcard rmap removal and the subsequent rui will fail to find the rmap
and blow up.  This didn't ever happen due to other screws up in handling
unknown owner rmap removals, but those other screw ups broke recovery in
other ways, so fix the ordering to follow the intended rules.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

1 parent 86d692b

Files
Changes

Permalinks

Tip revision: 0525e952dcceb9fc947c6d395de7f72220c7d081 authored by Darrick J. Wong on 08 December 2017, 03:07:03 UTC
xfs: queue deferred rmap ops for cow staging extent alloc/free in the right order

Tip revision: 0525e95

File	Mode	Size
Documentation
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.cocciconfig	-rw-r--r--	59 bytes
.get_maintainer.ignore	-rw-r--r--	31 bytes
.gitattributes	-rw-r--r--	30 bytes
.gitignore	-rw-r--r--	1.4 KB
.mailmap	-rw-r--r--	8.8 KB
COPYING	-rw-r--r--	18.3 KB
CREDITS	-rw-r--r--	96.2 KB
Kbuild	-rw-r--r--	2.2 KB
Kconfig	-rw-r--r--	287 bytes
MAINTAINERS	-rw-r--r--	425.9 KB
Makefile	-rw-r--r--	58.3 KB
README	-rw-r--r--	722 bytes

Showing with 0 additions and 0 deletions (0 / 0 diffs computed)

Computing file changes ...

https://github.com/torvalds/linux

xfs: queue deferred rmap ops for cow staging extent alloc/free in the right order

README