https://github.com/google/ExoPlayer
Revision 058333565d3f0e25e3a4d96789dd76c3c58a1c31 authored by Oliver Woodman on 15 July 2014, 12:55:59 UTC, committed by Oliver Woodman on 15 July 2014, 12:55:59 UTC
Why: This was a bad initial choice. Manifests typically define bandwidth in bits/sec. If you divide by 8 then you're throwing away information due to rounding. Unfortunately it turns out that SegmentTemplate based manifests require you to be able to recall the bitrate exactly (because it's substituted in during segment URL construction). Medium term: We should consider converting all our bandwidth estimation over to bits/sec as well. Note1: Also changed Period id to be a string, to match the mpd spec. Note2: Made small optimization in FormatEvaluator to not consider discarding the first chunk (durationBeforeThisSegmentUs will always be negative, and even in the error case where it's not, removing the first thunk should be an error).
1 parent 4366afc
Tip revision: 058333565d3f0e25e3a4d96789dd76c3c58a1c31 authored by Oliver Woodman on 15 July 2014, 12:55:59 UTC
Use bits/sec instead of bytes/sec for format bandwidth.
Use bits/sec instead of bytes/sec for format bandwidth.
Tip revision: 0583335
| File | Mode | Size |
|---|---|---|
| demo | ||
| gradle | ||
| library | ||
| CONTRIBUTING.md | -rw-r--r-- | 1.2 KB |
| LICENSE | -rw-r--r-- | 11.1 KB |
| README.md | -rw-r--r-- | 1.5 KB |
| build.gradle | -rw-r--r-- | 927 bytes |
| gradle.properties | -rw-r--r-- | 854 bytes |
| gradlew | -rwxr-xr-x | 5.0 KB |
| gradlew.bat | -rw-r--r-- | 2.3 KB |
| settings.gradle | -rw-r--r-- | 647 bytes |
Computing file changes ...
