Revision 05946bce839b4fed5442dbfab77060fb75e051f3 authored by Anton Vorontsov on 04 July 2008, 16:59:38 UTC, committed by Linus Torvalds on 04 July 2008, 17:40:06 UTC
This patch fixes following build error when CONFIG_PM is set.

  CC      drivers/video/fsl-diu-fb.o
drivers/video/fsl-diu-fb.c: In function 'fsl_diu_suspend':
drivers/video/fsl-diu-fb.c:1327: error: 'ofdev' undeclared (first use in this function)
drivers/video/fsl-diu-fb.c:1327: error: (Each undeclared identifier is reported only once
drivers/video/fsl-diu-fb.c:1327: error: for each function it appears in.)
drivers/video/fsl-diu-fb.c: In function 'fsl_diu_resume':
drivers/video/fsl-diu-fb.c:1337: error: 'ofdev' undeclared (first use in this function)

While I'm at it, also fix this warning:

drivers/video/fsl-diu-fb.c: In function 'fsl_diu_alloc':
drivers/video/fsl-diu-fb.c:314: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'phys_addr_t'

And these section mismatches:

..from the function fsl_diu_remove() to the function .exit.text:uninstall_fb()
..from the function fsl_diu_remove() to the function .exit.text:uninstall_fb()
..from the function install_fb() to the variable .devinit.data:fsl_diu_mode_db
..from the function install_fb() to the variable .devinit.data:fsl_diu_mode_db
..from the function fsl_diu_probe() to the function .exit.text:uninstall_fb()
..from the function fsl_diu_probe() to the function .exit.text:uninstall_fb()

Also, some sparse fixes: make two functions static, and use NULL where
appropriate. There are still a lot of sparse warnings, mainly wrt absence
of __iomem annotations, but some will require ugly __force stuff. I'll leave
them for now, since proper fix would be not that trivial as few one-liners
below.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Timur Tabi <timur@freescale.com>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: York Sun <yorksun@freescale.com>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 7059d4b
History
File Mode Size
Kconfig -rw-r--r-- 5.9 KB
Makefile -rw-r--r-- 600 bytes
config_roms.c -rw-r--r-- 4.5 KB
config_roms.h -rw-r--r-- 588 bytes
csr.c -rw-r--r-- 25.8 KB
csr.h -rw-r--r-- 2.6 KB
csr1212.c -rw-r--r-- 38.2 KB
csr1212.h -rw-r--r-- 14.5 KB
dma.c -rw-r--r-- 6.2 KB
dma.h -rw-r--r-- 2.5 KB
dv1394-private.h -rw-r--r-- 16.9 KB
dv1394.c -rw-r--r-- 72.2 KB
dv1394.h -rw-r--r-- 10.2 KB
eth1394.c -rw-r--r-- 47.2 KB
eth1394.h -rw-r--r-- 6.4 KB
highlevel.c -rw-r--r-- 17.5 KB
highlevel.h -rw-r--r-- 4.9 KB
hosts.c -rw-r--r-- 6.3 KB
hosts.h -rw-r--r-- 5.8 KB
ieee1394-ioctl.h -rw-r--r-- 3.6 KB
ieee1394.h -rw-r--r-- 5.6 KB
ieee1394_core.c -rw-r--r-- 36.6 KB
ieee1394_core.h -rw-r--r-- 5.2 KB
ieee1394_hotplug.h -rw-r--r-- 549 bytes
ieee1394_transactions.c -rw-r--r-- 13.8 KB
ieee1394_transactions.h -rw-r--r-- 1.5 KB
ieee1394_types.h -rw-r--r-- 1.7 KB
init_ohci1394_dma.c -rw-r--r-- 9.2 KB
iso.c -rw-r--r-- 13.0 KB
iso.h -rw-r--r-- 5.9 KB
nodemgr.c -rw-r--r-- 53.2 KB
nodemgr.h -rw-r--r-- 5.2 KB
ohci1394.c -rw-r--r-- 102.0 KB
ohci1394.h -rw-r--r-- 15.9 KB
pcilynx.c -rw-r--r-- 52.0 KB
pcilynx.h -rw-r--r-- 15.8 KB
raw1394-private.h -rw-r--r-- 2.1 KB
raw1394.c -rw-r--r-- 82.3 KB
raw1394.h -rw-r--r-- 5.0 KB
sbp2.c -rw-r--r-- 63.4 KB
sbp2.h -rw-r--r-- 10.0 KB
video1394.c -rw-r--r-- 42.0 KB
video1394.h -rw-r--r-- 2.0 KB

back to top