Revision 05946bce839b4fed5442dbfab77060fb75e051f3 authored by Anton Vorontsov on 04 July 2008, 16:59:38 UTC, committed by Linus Torvalds on 04 July 2008, 17:40:06 UTC
This patch fixes following build error when CONFIG_PM is set.

  CC      drivers/video/fsl-diu-fb.o
drivers/video/fsl-diu-fb.c: In function 'fsl_diu_suspend':
drivers/video/fsl-diu-fb.c:1327: error: 'ofdev' undeclared (first use in this function)
drivers/video/fsl-diu-fb.c:1327: error: (Each undeclared identifier is reported only once
drivers/video/fsl-diu-fb.c:1327: error: for each function it appears in.)
drivers/video/fsl-diu-fb.c: In function 'fsl_diu_resume':
drivers/video/fsl-diu-fb.c:1337: error: 'ofdev' undeclared (first use in this function)

While I'm at it, also fix this warning:

drivers/video/fsl-diu-fb.c: In function 'fsl_diu_alloc':
drivers/video/fsl-diu-fb.c:314: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'phys_addr_t'

And these section mismatches:

..from the function fsl_diu_remove() to the function .exit.text:uninstall_fb()
..from the function fsl_diu_remove() to the function .exit.text:uninstall_fb()
..from the function install_fb() to the variable .devinit.data:fsl_diu_mode_db
..from the function install_fb() to the variable .devinit.data:fsl_diu_mode_db
..from the function fsl_diu_probe() to the function .exit.text:uninstall_fb()
..from the function fsl_diu_probe() to the function .exit.text:uninstall_fb()

Also, some sparse fixes: make two functions static, and use NULL where
appropriate. There are still a lot of sparse warnings, mainly wrt absence
of __iomem annotations, but some will require ugly __force stuff. I'll leave
them for now, since proper fix would be not that trivial as few one-liners
below.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Timur Tabi <timur@freescale.com>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: York Sun <yorksun@freescale.com>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 7059d4b
Raw File
scsi_tgt_if.h
/*
 * SCSI target kernel/user interface
 *
 * Copyright (C) 2005 FUJITA Tomonori <tomof@acm.org>
 * Copyright (C) 2005 Mike Christie <michaelc@cs.wisc.edu>
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License as
 * published by the Free Software Foundation; either version 2 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
 * 02110-1301 USA
 */
#ifndef __SCSI_TARGET_IF_H
#define __SCSI_TARGET_IF_H

/* user -> kernel */
#define	TGT_UEVENT_CMD_RSP		0x0001
#define	TGT_UEVENT_IT_NEXUS_RSP		0x0002
#define	TGT_UEVENT_TSK_MGMT_RSP		0x0003

/* kernel -> user */
#define	TGT_KEVENT_CMD_REQ		0x1001
#define	TGT_KEVENT_CMD_DONE		0x1002
#define	TGT_KEVENT_IT_NEXUS_REQ		0x1003
#define	TGT_KEVENT_TSK_MGMT_REQ		0x1004

struct tgt_event_hdr {
	uint16_t version;
	uint16_t status;
	uint16_t type;
	uint16_t len;
} __attribute__ ((aligned (sizeof(uint64_t))));

struct tgt_event {
	struct tgt_event_hdr hdr;

	union {
		/* user-> kernel */
		struct {
			int host_no;
			int result;
			aligned_u64 itn_id;
			aligned_u64 tag;
			aligned_u64 uaddr;
			aligned_u64 sense_uaddr;
			uint32_t len;
			uint32_t sense_len;
			uint8_t rw;
		} cmd_rsp;
		struct {
			int host_no;
			int result;
			aligned_u64 itn_id;
			aligned_u64 mid;
		} tsk_mgmt_rsp;
		struct {
			__s32 host_no;
			__s32 result;
			aligned_u64 itn_id;
			__u32 function;
		} it_nexus_rsp;

		/* kernel -> user */
		struct {
			int host_no;
			uint32_t data_len;
			aligned_u64 itn_id;
			uint8_t scb[16];
			uint8_t lun[8];
			int attribute;
			aligned_u64 tag;
		} cmd_req;
		struct {
			int host_no;
			int result;
			aligned_u64 itn_id;
			aligned_u64 tag;
		} cmd_done;
		struct {
			int host_no;
			int function;
			aligned_u64 itn_id;
			aligned_u64 tag;
			uint8_t lun[8];
			aligned_u64 mid;
		} tsk_mgmt_req;
		struct {
			__s32 host_no;
			__u32 function;
			aligned_u64 itn_id;
			__u32 max_cmds;
			__u8 initiator_id[16];
		} it_nexus_req;
	} p;
} __attribute__ ((aligned (sizeof(uint64_t))));

#define TGT_RING_SIZE (1UL << 16)

#endif
back to top