https://github.com/torvalds/linux
Revision 05d5bcd60e8202e5c7b28cf61186043a4d612623 authored by Oleg Nesterov on 28 October 2006, 17:38:50 UTC, committed by Linus Torvalds on 28 October 2006, 18:30:54 UTC
1. ts = timespec_sub(uptime, current->group_leader->start_time); It is possible that current != tsk. Probably it was supposed to be 'tsk->group_leader->start_time. But why we are reading group_leader's start_time ? This accounting is per thread, not per procees, I changed this to 'tsk->start_time. Please corect me. 2. stats->ac_ppid = (tsk->parent) ? tsk->parent->pid : 0; tsk->parent never == NULL, and it is unsafe to dereference it. Both the task and it's parent may exit after the caller unlocks tasklist_lock, the memory could be unmapped (DEBUG_SLAB). (And we should use ->real_parent->tgid in fact). Q: I don't understand the 'if (thread_group_leader(tsk))' check. Why it is needed ? Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Cc: Shailabh Nagar <nagar@watson.ibm.com> Cc: Balbir Singh <balbir@in.ibm.com> Acked-by: Jay Lan <jlan@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent fca178c
Tip revision: 05d5bcd60e8202e5c7b28cf61186043a4d612623 authored by Oleg Nesterov on 28 October 2006, 17:38:50 UTC
[PATCH] bacct_add_tsk: fix unsafe and wrong parent/group_leader dereference
[PATCH] bacct_add_tsk: fix unsafe and wrong parent/group_leader dereference
Tip revision: 05d5bcd
| File | Mode | Size |
|---|---|---|
| Documentation | ||
| arch | ||
| block | ||
| crypto | ||
| drivers | ||
| fs | ||
| include | ||
| init | ||
| ipc | ||
| kernel | ||
| lib | ||
| mm | ||
| net | ||
| scripts | ||
| security | ||
| sound | ||
| usr | ||
| .gitignore | -rw-r--r-- | 542 bytes |
| COPYING | -rw-r--r-- | 18.3 KB |
| CREDITS | -rw-r--r-- | 88.2 KB |
| Kbuild | -rw-r--r-- | 1.2 KB |
| MAINTAINERS | -rw-r--r-- | 73.8 KB |
| Makefile | -rw-r--r-- | 49.0 KB |
| README | -rw-r--r-- | 16.2 KB |
| REPORTING-BUGS | -rw-r--r-- | 3.0 KB |
Computing file changes ...
