Revision 05e8854085ca783956fd33021a9a334d77ed4d9e authored by Haobo Xu on 21 March 2013, 22:59:47 UTC, committed by Haobo Xu on 03 May 2013, 23:59:02 UTC
Summary: This diff introduces a new Merge operation into rocksdb. The purpose of this review is mostly getting feedback from the team (everyone please) on the design. Please focus on the four files under include/leveldb/, as they spell the client visible interface change. include/leveldb/db.h include/leveldb/merge_operator.h include/leveldb/options.h include/leveldb/write_batch.h Please go over local/my_test.cc carefully, as it is a concerete use case. Please also review the impelmentation files to see if the straw man implementation makes sense. Note that, the diff does pass all make check and truly supports forward iterator over db and a version of Get that's based on iterator. Future work: - Integration with compaction - A raw Get implementation I am working on a wiki that explains the design and implementation choices, but coding comes just naturally and I think it might be a good idea to share the code earlier. The code is heavily commented. Test Plan: run all local tests Reviewers: dhruba, heyongqiang Reviewed By: dhruba CC: leveldb, zshao, sheki, emayanke, MarkCallaghan Differential Revision: https://reviews.facebook.net/D9651
1 parent 37e97b1
File | Mode | Size |
---|---|---|
VALGRIND_LOGS | ||
db | ||
doc | ||
hdfs | ||
helpers | ||
include | ||
java | ||
linters | ||
port | ||
scribe | ||
snappy | ||
table | ||
thrift | ||
tools | ||
util | ||
utilities | ||
.arcconfig | -rw-r--r-- | 243 bytes |
.gitignore | -rw-r--r-- | 174 bytes |
LICENSE | -rw-r--r-- | 1.4 KB |
Makefile | -rw-r--r-- | 11.1 KB |
README | -rw-r--r-- | 2.2 KB |
README.fb | -rw-r--r-- | 98 bytes |
build_detect_platform | -rwxr-xr-x | 8.9 KB |
build_detect_version | -rwxr-xr-x | 1.2 KB |
build_java.sh | -rwxr-xr-x | 1.9 KB |
e | -rw-r--r-- | 51 bytes |
fbcode.clang31.sh | -rw-r--r-- | 3.1 KB |
fbcode.gcc471.sh | -rw-r--r-- | 2.9 KB |
regression_build_test.sh | -rwxr-xr-x | 2.3 KB |
valgrind_test.sh | -rwxr-xr-x | 428 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...