Skip to main content

Browse the archive

https://github.com/torvalds/linux
27 March 2024, 02:37:15 UTC
Revision 0705e8d1e2207ceeb83dc6e1751b6b82718b353a authored by Theodore Ts'o on 02 July 2021, 22:05:03 UTC, committed by Theodore Ts'o on 08 July 2021, 12:37:31 UTC 
ext4: inline jbd2_journal_[un]register_shrinker()
 
The function jbd2_journal_unregister_shrinker() was getting called
twice when the file system was getting unmounted.  On Power and ARM
platforms this was causing kernel crash when unmounting the file
system, when a percpu_counter was destroyed twice.

Fix this by removing jbd2_journal_[un]register_shrinker() functions,
and inlining the shrinker setup and teardown into
journal_init_common() and jbd2_journal_destroy().  This means that
ext4 and ocfs2 now no longer need to know about registering and
unregistering jbd2's shrinker.

Also, while we're at it, rename the percpu counter from
j_jh_shrink_count to j_checkpoint_jh_count, since this makes it
clearer what this counter is intended to track.

Link: https://lore.kernel.org/r/20210705145025.3363130-1-tytso@mit.edu
Fixes: 4ba3fcdde7e3 ("jbd2,ext4: add a shrinker to release checkpointed buffers")
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Reported-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 0955901
Raw File
Tip revision: 0705e8d1e2207ceeb83dc6e1751b6b82718b353a authored by Theodore Ts'o on 02 July 2021, 22:05:03 UTC
ext4: inline jbd2_journal_[un]register_shrinker()
Tip revision: 0705e8d
.cocciconfig 
[spatch]
	options = --timeout 200
	options = --use-gitgrep
back to top