Revision 07718be265680dcf496347d475ce1a5442f55ad7 authored by Maxim Mikityanskiy on 10 June 2021, 16:40:30 UTC, committed by David S. Miller on 10 June 2021, 21:26:18 UTC
The TCP option parser in mptcp (mptcp_get_options) could read one byte
out of bounds. When the length is 1, the execution flow gets into the
loop, reads one byte of the opcode, and if the opcode is neither
TCPOPT_EOL nor TCPOPT_NOP, it reads one more byte, which exceeds the
length of 1.
This fix is inspired by commit 9609dad263f8 ("ipv4: tcp_input: fix stack
out of bounds when parsing TCP options.").
Cc: Young Xiao <92siuyang@gmail.com>
Fixes: cec37a6e41aa ("mptcp: Handle MP_CAPABLE options for outgoing connections")
Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5fc177a
| File | Mode | Size |
|---|---|---|
| tests | ||
| Kconfig | -rw-r--r-- | 3.3 KB |
| Makefile | -rw-r--r-- | 1.9 KB |
| acl.c | -rw-r--r-- | 3.2 KB |
| async-thread.c | -rw-r--r-- | 10.3 KB |
| async-thread.h | -rw-r--r-- | 1.6 KB |
| backref.c | -rw-r--r-- | 82.7 KB |
| backref.h | -rw-r--r-- | 10.5 KB |
| block-group.c | -rw-r--r-- | 103.9 KB |
| block-group.h | -rw-r--r-- | 10.8 KB |
| block-rsv.c | -rw-r--r-- | 16.2 KB |
| block-rsv.h | -rw-r--r-- | 3.1 KB |
| btrfs_inode.h | -rw-r--r-- | 10.5 KB |
| check-integrity.c | -rw-r--r-- | 89.0 KB |
| check-integrity.h | -rw-r--r-- | 599 bytes |
| compression.c | -rw-r--r-- | 45.4 KB |
| compression.h | -rw-r--r-- | 6.0 KB |
| ctree.c | -rw-r--r-- | 120.9 KB |
| ctree.h | -rw-r--r-- | 127.4 KB |
| delalloc-space.c | -rw-r--r-- | 16.6 KB |
| delalloc-space.h | -rw-r--r-- | 950 bytes |
| delayed-inode.c | -rw-r--r-- | 51.1 KB |
| delayed-inode.h | -rw-r--r-- | 4.3 KB |
| delayed-ref.c | -rw-r--r-- | 32.6 KB |
| delayed-ref.h | -rw-r--r-- | 11.0 KB |
| dev-replace.c | -rw-r--r-- | 38.4 KB |
| dev-replace.h | -rw-r--r-- | 970 bytes |
| dir-item.c | -rw-r--r-- | 11.3 KB |
| discard.c | -rw-r--r-- | 22.9 KB |
| discard.h | -rw-r--r-- | 1.4 KB |
| disk-io.c | -rw-r--r-- | 138.9 KB |
| disk-io.h | -rw-r--r-- | 5.6 KB |
| export.c | -rw-r--r-- | 7.1 KB |
| export.h | -rw-r--r-- | 533 bytes |
| extent-io-tree.h | -rw-r--r-- | 8.8 KB |
| extent-tree.c | -rw-r--r-- | 163.2 KB |
| extent_io.c | -rw-r--r-- | 184.3 KB |
| extent_io.h | -rw-r--r-- | 10.7 KB |
| extent_map.c | -rw-r--r-- | 17.3 KB |
| extent_map.h | -rw-r--r-- | 2.7 KB |
| file-item.c | -rw-r--r-- | 33.9 KB |
| file.c | -rw-r--r-- | 98.7 KB |
| free-space-cache.c | -rw-r--r-- | 107.5 KB |
| free-space-cache.h | -rw-r--r-- | 5.2 KB |
| free-space-tree.c | -rw-r--r-- | 39.5 KB |
| free-space-tree.h | -rw-r--r-- | 2.1 KB |
| inode-item.c | -rw-r--r-- | 11.0 KB |
| inode.c | -rw-r--r-- | 296.5 KB |
| ioctl.c | -rw-r--r-- | 119.4 KB |
| locking.c | -rw-r--r-- | 6.6 KB |
| locking.h | -rw-r--r-- | 4.3 KB |
| lzo.c | -rw-r--r-- | 11.7 KB |
| misc.h | -rw-r--r-- | 2.4 KB |
| ordered-data.c | -rw-r--r-- | 28.1 KB |
| ordered-data.h | -rw-r--r-- | 6.3 KB |
| orphan.c | -rw-r--r-- | 1.1 KB |
| print-tree.c | -rw-r--r-- | 12.2 KB |
| print-tree.h | -rw-r--r-- | 456 bytes |
| props.c | -rw-r--r-- | 10.0 KB |
| props.h | -rw-r--r-- | 800 bytes |
| qgroup.c | -rw-r--r-- | 109.1 KB |
| qgroup.h | -rw-r--r-- | 14.1 KB |
| raid56.c | -rw-r--r-- | 66.9 KB |
| raid56.h | -rw-r--r-- | 1.7 KB |
| rcu-string.h | -rw-r--r-- | 997 bytes |
| reada.c | -rw-r--r-- | 27.0 KB |
| ref-verify.c | -rw-r--r-- | 24.9 KB |
| ref-verify.h | -rw-r--r-- | 1.1 KB |
| reflink.c | -rw-r--r-- | 26.9 KB |
| reflink.h | -rw-r--r-- | 305 bytes |
| relocation.c | -rw-r--r-- | 107.5 KB |
| root-tree.c | -rw-r--r-- | 13.9 KB |
| scrub.c | -rw-r--r-- | 112.3 KB |
| send.c | -rw-r--r-- | 182.2 KB |
| send.h | -rw-r--r-- | 2.3 KB |
| space-info.c | -rw-r--r-- | 53.4 KB |
| space-info.h | -rw-r--r-- | 5.8 KB |
| struct-funcs.c | -rw-r--r-- | 6.1 KB |
| subpage.c | -rw-r--r-- | 12.9 KB |
| subpage.h | -rw-r--r-- | 3.1 KB |
| super.c | -rw-r--r-- | 73.1 KB |
| sysfs.c | -rw-r--r-- | 51.8 KB |
| sysfs.h | -rw-r--r-- | 1.6 KB |
| transaction.c | -rw-r--r-- | 71.6 KB |
| transaction.h | -rw-r--r-- | 7.9 KB |
| tree-checker.c | -rw-r--r-- | 53.3 KB |
| tree-checker.h | -rw-r--r-- | 702 bytes |
| tree-defrag.c | -rw-r--r-- | 3.5 KB |
| tree-log.c | -rw-r--r-- | 175.1 KB |
| tree-log.h | -rw-r--r-- | 2.8 KB |
| tree-mod-log.c | -rw-r--r-- | 23.5 KB |
| tree-mod-log.h | -rw-r--r-- | 1.7 KB |
| ulist.c | -rw-r--r-- | 6.7 KB |
| ulist.h | -rw-r--r-- | 1.9 KB |
| uuid-tree.c | -rw-r--r-- | 8.4 KB |
| volumes.c | -rw-r--r-- | 214.6 KB |
| volumes.h | -rw-r--r-- | 17.4 KB |
| xattr.c | -rw-r--r-- | 13.2 KB |
| xattr.h | -rw-r--r-- | 804 bytes |
| zlib.c | -rw-r--r-- | 11.7 KB |
| zoned.c | -rw-r--r-- | 37.2 KB |
| zoned.h | -rw-r--r-- | 8.5 KB |
| zstd.c | -rw-r--r-- | 18.4 KB |
Computing file changes ...
