https://github.com/torvalds/linux
Revision 0894da849f145af51bde88a6b84f95b9c9e0bc66 authored by Guenter Roeck on 23 July 2018, 21:39:33 UTC, committed by Linus Torvalds on 24 July 2018, 17:43:34 UTC
Including asm/cacheflush.h first results in the following build error
when trying to build sparc32:allmodconfig, because 'struct page' has not
been declared, and the function declaration ends up creating a separate
(private) declaration of struct page (as a result of function arguments
being in the scope of the function declaration and definition, not in
global scope).

The C scoping rules do not just affect variable visibility, they also
affect type declaration visibility.

The end result is that when the actual call site is seen in
<linux/highmem.h>, the 'struct page' type in the caller is not the same
'struct page' that the function was declared with, resulting in:

  In file included from arch/sparc/include/asm/page.h:10:0,
                   ...
                   from drivers/staging/media/omap4iss/iss_video.c:15:
  include/linux/highmem.h: In function 'clear_user_highpage':
  include/linux/highmem.h:137:31: error:
	passing argument 1 of 'sparc_flush_page_to_ram' from incompatible
	pointer type

Include generic includes files first to fix the problem.

Fixes: fc96d58c10162 ("[media] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices")
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: David S. Miller <davem@davemloft.net>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
[ Added explanation of C scope rules - Linus ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent d72e90f
History
Tip revision: 0894da849f145af51bde88a6b84f95b9c9e0bc66 authored by Guenter Roeck on 23 July 2018, 21:39:33 UTC
media: staging: omap4iss: Include asm/cacheflush.h after generic includes
Tip revision: 0894da8
File Mode Size
Makefile -rw-r--r-- 361 bytes
compat.c -rw-r--r-- 2.2 KB
ipc_sysctl.c -rw-r--r-- 5.4 KB
mq_sysctl.c -rw-r--r-- 2.9 KB
mqueue.c -rw-r--r-- 39.0 KB
msg.c -rw-r--r-- 29.7 KB
msgutil.c -rw-r--r-- 3.6 KB
namespace.c -rw-r--r-- 4.8 KB
sem.c -rw-r--r-- 61.2 KB
shm.c -rw-r--r-- 41.6 KB
syscall.c -rw-r--r-- 4.7 KB
util.c -rw-r--r-- 22.6 KB
util.h -rw-r--r-- 8.9 KB

back to top