Skip to main content

Browse the archive

https://github.com/torvalds/linux
02 December 2022, 17:28:11 UTC
Revision 0908cf4dfef35fc6ac12329007052ebe93ff1081 authored by linzhang on 25 May 2017, 06:07:18 UTC, committed by David S. Miller on 26 May 2017, 18:20:29 UTC 
net: llc: add lock_sock in llc_ui_bind to avoid a race condition
 
There is a race condition in llc_ui_bind if two or more processes/threads
try to bind a same socket.

If more processes/threads bind a same socket success that will lead to
two problems, one is this action is not what we expected, another is
will lead to kernel in unstable status or oops(in my simple test case,
cause llc2.ko can't unload).

The current code is test SOCK_ZAPPED bit to avoid a process to
bind a same socket twice but that is can't avoid more processes/threads
try to bind a same socket at the same time.

So, add lock_sock in llc_ui_bind like others, such as llc_ui_connect.

Signed-off-by: Lin Zhang <xiaolou4617@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 797a936
History
Tip revision: 0908cf4dfef35fc6ac12329007052ebe93ff1081 authored by linzhang on 25 May 2017, 06:07:18 UTC
net: llc: add lock_sock in llc_ui_bind to avoid a race condition
Tip revision: 0908cf4
File Mode Size
Documentation
arch
block
certs
crypto
drivers
firmware
fs
include
init
ipc
kernel
lib
mm
net
samples
scripts
security
sound
tools
usr
virt
.cocciconfig -rw-r--r-- 59 bytes
.get_maintainer.ignore -rw-r--r-- 31 bytes
.gitattributes -rw-r--r-- 30 bytes
.gitignore -rw-r--r-- 1.3 KB
.mailmap -rw-r--r-- 8.1 KB
COPYING -rw-r--r-- 18.3 KB
CREDITS -rw-r--r-- 96.2 KB
Kbuild -rw-r--r-- 2.2 KB
Kconfig -rw-r--r-- 252 bytes
MAINTAINERS -rw-r--r-- 397.7 KB
Makefile -rw-r--r-- 58.6 KB
README -rw-r--r-- 722 bytes

README

back to top