Revision 091901841af285f963ea80cd18d616fd0350ddbc authored by Peter Maydell on 16 October 2018, 17:25:03 UTC, committed by Kevin Wolf on 05 November 2018, 14:09:54 UTC
Taking the address of a field in a packed struct is a bad idea, because it might not be actually aligned enough for that pointer type (and thus cause a crash on dereference on some host architectures). Newer versions of clang warn about this. Avoid the bug by not using the "modify in place" byte swapping functions. There are a few places where the in-place swap function is used on something other than a packed struct field; we convert those anyway, for consistency. Patch produced with scripts/coccinelle/inplace-byteswaps.cocci. There are other places where we take the address of a packed member in this file for other purposes than passing it to a byteswap function (all the calls to qemu_uuid_*()); we leave those for now. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
1 parent 1229e46
| File | Mode | Size |
|---|---|---|
| Makefile.objs | -rw-r--r-- | 797 bytes |
| baum.c | -rw-r--r-- | 22.2 KB |
| char-console.c | -rw-r--r-- | 1.9 KB |
| char-fd.c | -rw-r--r-- | 4.6 KB |
| char-fe.c | -rw-r--r-- | 8.8 KB |
| char-file.c | -rw-r--r-- | 3.9 KB |
| char-io.c | -rw-r--r-- | 4.3 KB |
| char-mux.c | -rw-r--r-- | 11.3 KB |
| char-null.c | -rw-r--r-- | 1.8 KB |
| char-parallel.c | -rw-r--r-- | 8.7 KB |
| char-pipe.c | -rw-r--r-- | 5.5 KB |
| char-pty.c | -rw-r--r-- | 8.2 KB |
| char-ringbuf.c | -rw-r--r-- | 6.8 KB |
| char-serial.c | -rw-r--r-- | 8.3 KB |
| char-socket.c | -rw-r--r-- | 37.1 KB |
| char-stdio.c | -rw-r--r-- | 4.5 KB |
| char-udp.c | -rw-r--r-- | 7.0 KB |
| char-win-stdio.c | -rw-r--r-- | 7.7 KB |
| char-win.c | -rw-r--r-- | 6.3 KB |
| char.c | -rw-r--r-- | 30.1 KB |
| msmouse.c | -rw-r--r-- | 5.4 KB |
| spice.c | -rw-r--r-- | 10.9 KB |
| testdev.c | -rw-r--r-- | 3.5 KB |
| trace-events | -rw-r--r-- | 611 bytes |
| wctablet.c | -rw-r--r-- | 10.3 KB |
Computing file changes ...
