Revision 091901841af285f963ea80cd18d616fd0350ddbc authored by Peter Maydell on 16 October 2018, 17:25:03 UTC, committed by Kevin Wolf on 05 November 2018, 14:09:54 UTC
Taking the address of a field in a packed struct is a bad idea, because it might not be actually aligned enough for that pointer type (and thus cause a crash on dereference on some host architectures). Newer versions of clang warn about this. Avoid the bug by not using the "modify in place" byte swapping functions. There are a few places where the in-place swap function is used on something other than a packed struct field; we convert those anyway, for consistency. Patch produced with scripts/coccinelle/inplace-byteswaps.cocci. There are other places where we take the address of a packed member in this file for other purposes than passing it to a byteswap function (all the calls to qemu_uuid_*()); we leave those for now. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
1 parent 1229e46
File | Mode | Size |
---|---|---|
Makefile.objs | -rw-r--r-- | 146 bytes |
pr-helper.h | -rw-r--r-- | 1.5 KB |
pr-manager-helper.c | -rw-r--r-- | 9.0 KB |
pr-manager-stub.c | -rw-r--r-- | 661 bytes |
pr-manager.c | -rw-r--r-- | 3.8 KB |
qemu-pr-helper.c | -rw-r--r-- | 29.6 KB |
trace-events | -rw-r--r-- | 210 bytes |
utils.c | -rw-r--r-- | 17.9 KB |
Computing file changes ...