https://github.com/torvalds/linux
Revision 092cab7e2cd868cb0b30209a0337689c3ffd6133 authored by Pablo Neira Ayuso on 16 December 2008, 09:19:41 UTC, committed by David S. Miller on 16 December 2008, 09:19:41 UTC
This patch fixes an inconsistency in nfnetlink_conntrack.h that
I introduced myself. The problem is that CTA_NAT_SEQ_UNSPEC is
missing from enum ctattr_natseq. This inconsistency may lead to
problems in the message parsing in userspace (if the message
contains the CTA_NAT_SEQ_* attributes, of course).

This patch breaks backward compatibility, however, the only known
client of this code is libnetfilter_conntrack which indeed crashes
because it assumes the existence of CTA_NAT_SEQ_UNSPEC to do
the parsing.

The CTA_NAT_SEQ_* attributes were introduced in 2.6.25.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent a3dd154
History
Tip revision: 092cab7e2cd868cb0b30209a0337689c3ffd6133 authored by Pablo Neira Ayuso on 16 December 2008, 09:19:41 UTC
netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC
Tip revision: 092cab7

back to top