Revision 0933840acf7b65d6d30a5b6089d882afea57aca3 authored by Jiri Olsa on 20 October 2016, 11:10:11 UTC, committed by Ingo Molnar on 28 October 2016, 09:06:25 UTC
CAI Qian reported a crash in the PMU uncore device removal code,
enabled by the CONFIG_DEBUG_TEST_DRIVER_REMOVE=y option:

  https://marc.info/?l=linux-kernel&m=147688837328451

The reason for the crash is that perf_pmu_unregister() tries to remove
a PMU device which is not added at this point. We add PMU devices
only after pmu_bus is registered, which happens in the
perf_event_sysfs_init() call and sets the 'pmu_bus_running' flag.

The fix is to get the 'pmu_bus_running' flag state at the point
the PMU is taken out of the PMU list and remove the device
later only if it's set.

Reported-by: CAI Qian <caiqian@redhat.com>
Tested-by: CAI Qian <caiqian@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20161020111011.GA13361@krava
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 889882b
History
File Mode Size
aoe
drbd
mtip32xx
paride
rsxx
xen-blkback
zram
DAC960.c -rw-r--r-- 259.7 KB
DAC960.h -rw-r--r-- 148.2 KB
Kconfig -rw-r--r-- 18.4 KB
Makefile -rw-r--r-- 1.4 KB
amiflop.c -rw-r--r-- 46.9 KB
ataflop.c -rw-r--r-- 52.0 KB
brd.c -rw-r--r-- 15.2 KB
cciss.c -rw-r--r-- 149.2 KB
cciss.h -rw-r--r-- 11.1 KB
cciss_cmd.h -rw-r--r-- 7.3 KB
cciss_scsi.c -rw-r--r-- 47.7 KB
cciss_scsi.h -rw-r--r-- 3.0 KB
cryptoloop.c -rw-r--r-- 4.9 KB
floppy.c -rw-r--r-- 117.5 KB
hd.c -rw-r--r-- 18.6 KB
loop.c -rw-r--r-- 50.0 KB
loop.h -rw-r--r-- 2.3 KB
mg_disk.c -rw-r--r-- 25.9 KB
nbd.c -rw-r--r-- 22.9 KB
null_blk.c -rw-r--r-- 18.8 KB
osdblk.c -rw-r--r-- 15.6 KB
pktcdvd.c -rw-r--r-- 73.4 KB
ps3disk.c -rw-r--r-- 13.9 KB
ps3vram.c -rw-r--r-- 22.3 KB
rbd.c -rw-r--r-- 166.7 KB
rbd_types.h -rw-r--r-- 2.2 KB
skd_main.c -rw-r--r-- 136.8 KB
skd_s1120.h -rw-r--r-- 9.6 KB
smart1,2.h -rw-r--r-- 7.1 KB
sunvdc.c -rw-r--r-- 25.4 KB
swim.c -rw-r--r-- 19.8 KB
swim3.c -rw-r--r-- 31.7 KB
swim_asm.S -rw-r--r-- 4.6 KB
sx8.c -rw-r--r-- 39.8 KB
umem.c -rw-r--r-- 29.9 KB
umem.h -rw-r--r-- 3.6 KB
virtio_blk.c -rw-r--r-- 23.0 KB
xen-blkfront.c -rw-r--r-- 72.5 KB
xsysace.c -rw-r--r-- 32.6 KB
z2ram.c -rw-r--r-- 9.1 KB

back to top