Revision 0933840acf7b65d6d30a5b6089d882afea57aca3 authored by Jiri Olsa on 20 October 2016, 11:10:11 UTC, committed by Ingo Molnar on 28 October 2016, 09:06:25 UTC
CAI Qian reported a crash in the PMU uncore device removal code,
enabled by the CONFIG_DEBUG_TEST_DRIVER_REMOVE=y option:

  https://marc.info/?l=linux-kernel&m=147688837328451

The reason for the crash is that perf_pmu_unregister() tries to remove
a PMU device which is not added at this point. We add PMU devices
only after pmu_bus is registered, which happens in the
perf_event_sysfs_init() call and sets the 'pmu_bus_running' flag.

The fix is to get the 'pmu_bus_running' flag state at the point
the PMU is taken out of the PMU list and remove the device
later only if it's set.

Reported-by: CAI Qian <caiqian@redhat.com>
Tested-by: CAI Qian <caiqian@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20161020111011.GA13361@krava
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 889882b
History
File Mode Size
gameport
joystick
keyboard
misc
mouse
rmi4
serio
tablet
touchscreen
Kconfig -rw-r--r-- 6.0 KB
Makefile -rw-r--r-- 909 bytes
apm-power.c -rw-r--r-- 2.6 KB
evbug.c -rw-r--r-- 3.1 KB
evdev.c -rw-r--r-- 33.2 KB
ff-core.c -rw-r--r-- 9.0 KB
ff-memless.c -rw-r--r-- 14.4 KB
input-compat.c -rw-r--r-- 3.3 KB
input-compat.h -rw-r--r-- 1.7 KB
input-leds.c -rw-r--r-- 5.2 KB
input-mt.c -rw-r--r-- 12.5 KB
input-polldev.c -rw-r--r-- 9.3 KB
input.c -rw-r--r-- 60.2 KB
joydev.c -rw-r--r-- 24.0 KB
matrix-keymap.c -rw-r--r-- 5.6 KB
mousedev.c -rw-r--r-- 26.1 KB
sparse-keymap.c -rw-r--r-- 8.6 KB

back to top