Revision 0933840acf7b65d6d30a5b6089d882afea57aca3 authored by Jiri Olsa on 20 October 2016, 11:10:11 UTC, committed by Ingo Molnar on 28 October 2016, 09:06:25 UTC
CAI Qian reported a crash in the PMU uncore device removal code,
enabled by the CONFIG_DEBUG_TEST_DRIVER_REMOVE=y option:

  https://marc.info/?l=linux-kernel&m=147688837328451

The reason for the crash is that perf_pmu_unregister() tries to remove
a PMU device which is not added at this point. We add PMU devices
only after pmu_bus is registered, which happens in the
perf_event_sysfs_init() call and sets the 'pmu_bus_running' flag.

The fix is to get the 'pmu_bus_running' flag state at the point
the PMU is taken out of the PMU list and remove the device
later only if it's set.

Reported-by: CAI Qian <caiqian@redhat.com>
Tested-by: CAI Qian <caiqian@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20161020111011.GA13361@krava
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 889882b
History
File Mode Size
Kconfig -rw-r--r-- 10.6 KB
Makefile -rw-r--r-- 1.3 KB
amd_iommu.c -rw-r--r-- 101.6 KB
amd_iommu_init.c -rw-r--r-- 67.3 KB
amd_iommu_proto.h -rw-r--r-- 3.4 KB
amd_iommu_types.h -rw-r--r-- 22.1 KB
amd_iommu_v2.c -rw-r--r-- 22.0 KB
arm-smmu-v3.c -rw-r--r-- 69.4 KB
arm-smmu.c -rw-r--r-- 56.7 KB
dma-iommu.c -rw-r--r-- 20.7 KB
dmar.c -rw-r--r-- 49.8 KB
exynos-iommu.c -rw-r--r-- 36.6 KB
fsl_pamu.c -rw-r--r-- 33.5 KB
fsl_pamu.h -rw-r--r-- 13.3 KB
fsl_pamu_domain.c -rw-r--r-- 27.5 KB
fsl_pamu_domain.h -rw-r--r-- 2.6 KB
intel-iommu.c -rw-r--r-- 135.0 KB
intel-svm.c -rw-r--r-- 17.6 KB
intel_irq_remapping.c -rw-r--r-- 35.8 KB
io-pgtable-arm-v7s.c -rw-r--r-- 23.6 KB
io-pgtable-arm.c -rw-r--r-- 28.0 KB
io-pgtable.c -rw-r--r-- 2.0 KB
io-pgtable.h -rw-r--r-- 6.6 KB
iommu-sysfs.c -rw-r--r-- 3.0 KB
iommu-traces.c -rw-r--r-- 633 bytes
iommu.c -rw-r--r-- 41.1 KB
iova.c -rw-r--r-- 23.5 KB
ipmmu-vmsa.c -rw-r--r-- 21.9 KB
irq_remapping.c -rw-r--r-- 4.3 KB
irq_remapping.h -rw-r--r-- 2.2 KB
msm_iommu.c -rw-r--r-- 19.0 KB
msm_iommu.h -rw-r--r-- 3.2 KB
msm_iommu_hw-8xxx.h -rw-r--r-- 74.0 KB
mtk_iommu.c -rw-r--r-- 18.5 KB
mtk_iommu.h -rw-r--r-- 1.9 KB
mtk_iommu_v1.c -rw-r--r-- 19.0 KB
of_iommu.c -rw-r--r-- 6.1 KB
omap-iommu-debug.c -rw-r--r-- 6.4 KB
omap-iommu.c -rw-r--r-- 29.5 KB
omap-iommu.h -rw-r--r-- 6.0 KB
omap-iopgtable.h -rw-r--r-- 2.8 KB
rockchip-iommu.c -rw-r--r-- 32.4 KB
s390-iommu.c -rw-r--r-- 8.8 KB
tegra-gart.c -rw-r--r-- 12.0 KB
tegra-smmu.c -rw-r--r-- 21.8 KB

back to top