Revision 0933840acf7b65d6d30a5b6089d882afea57aca3 authored by Jiri Olsa on 20 October 2016, 11:10:11 UTC, committed by Ingo Molnar on 28 October 2016, 09:06:25 UTC
CAI Qian reported a crash in the PMU uncore device removal code, enabled by the CONFIG_DEBUG_TEST_DRIVER_REMOVE=y option: https://marc.info/?l=linux-kernel&m=147688837328451 The reason for the crash is that perf_pmu_unregister() tries to remove a PMU device which is not added at this point. We add PMU devices only after pmu_bus is registered, which happens in the perf_event_sysfs_init() call and sets the 'pmu_bus_running' flag. The fix is to get the 'pmu_bus_running' flag state at the point the PMU is taken out of the PMU list and remove the device later only if it's set. Reported-by: CAI Qian <caiqian@redhat.com> Tested-by: CAI Qian <caiqian@redhat.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Kan Liang <kan.liang@intel.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Rob Herring <robh@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20161020111011.GA13361@krava Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 889882b
File | Mode | Size |
---|---|---|
lsi | ||
Kconfig | -rw-r--r-- | 3.3 KB |
Makefile | -rw-r--r-- | 466 bytes |
mptbase.c | -rw-r--r-- | 237.1 KB |
mptbase.h | -rw-r--r-- | 31.5 KB |
mptctl.c | -rw-r--r-- | 86.3 KB |
mptctl.h | -rw-r--r-- | 13.6 KB |
mptdebug.h | -rw-r--r-- | 7.0 KB |
mptfc.c | -rw-r--r-- | 41.8 KB |
mptlan.c | -rw-r--r-- | 42.9 KB |
mptlan.h | -rw-r--r-- | 4.6 KB |
mptsas.c | -rw-r--r-- | 147.2 KB |
mptsas.h | -rw-r--r-- | 6.6 KB |
mptscsih.c | -rw-r--r-- | 90.8 KB |
mptscsih.h | -rw-r--r-- | 6.0 KB |
mptspi.c | -rw-r--r-- | 42.8 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...