Revision 0933840acf7b65d6d30a5b6089d882afea57aca3 authored by Jiri Olsa on 20 October 2016, 11:10:11 UTC, committed by Ingo Molnar on 28 October 2016, 09:06:25 UTC
CAI Qian reported a crash in the PMU uncore device removal code, enabled by the CONFIG_DEBUG_TEST_DRIVER_REMOVE=y option: https://marc.info/?l=linux-kernel&m=147688837328451 The reason for the crash is that perf_pmu_unregister() tries to remove a PMU device which is not added at this point. We add PMU devices only after pmu_bus is registered, which happens in the perf_event_sysfs_init() call and sets the 'pmu_bus_running' flag. The fix is to get the 'pmu_bus_running' flag state at the point the PMU is taken out of the PMU list and remove the device later only if it's set. Reported-by: CAI Qian <caiqian@redhat.com> Tested-by: CAI Qian <caiqian@redhat.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Kan Liang <kan.liang@intel.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Rob Herring <robh@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20161020111011.GA13361@krava Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 889882b
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 12.9 KB |
Makefile | -rw-r--r-- | 2.0 KB |
core.c | -rw-r--r-- | 23.7 KB |
pwm-ab8500.c | -rw-r--r-- | 3.3 KB |
pwm-atmel-hlcdc.c | -rw-r--r-- | 7.7 KB |
pwm-atmel-tcb.c | -rw-r--r-- | 11.7 KB |
pwm-atmel.c | -rw-r--r-- | 10.7 KB |
pwm-bcm-iproc.c | -rw-r--r-- | 7.5 KB |
pwm-bcm-kona.c | -rw-r--r-- | 9.5 KB |
pwm-bcm2835.c | -rw-r--r-- | 5.0 KB |
pwm-berlin.c | -rw-r--r-- | 7.3 KB |
pwm-bfin.c | -rw-r--r-- | 3.1 KB |
pwm-brcmstb.c | -rw-r--r-- | 8.3 KB |
pwm-clps711x.c | -rw-r--r-- | 4.3 KB |
pwm-crc.c | -rw-r--r-- | 3.6 KB |
pwm-cros-ec.c | -rw-r--r-- | 6.0 KB |
pwm-ep93xx.c | -rw-r--r-- | 5.8 KB |
pwm-fsl-ftm.c | -rw-r--r-- | 12.2 KB |
pwm-img.c | -rw-r--r-- | 8.0 KB |
pwm-imx.c | -rw-r--r-- | 8.6 KB |
pwm-jz4740.c | -rw-r--r-- | 4.8 KB |
pwm-lp3943.c | -rw-r--r-- | 7.5 KB |
pwm-lpc18xx-sct.c | -rw-r--r-- | 13.6 KB |
pwm-lpc32xx.c | -rw-r--r-- | 4.4 KB |
pwm-lpss-pci.c | -rw-r--r-- | 2.5 KB |
pwm-lpss-platform.c | -rw-r--r-- | 1.9 KB |
pwm-lpss.c | -rw-r--r-- | 5.0 KB |
pwm-lpss.h | -rw-r--r-- | 937 bytes |
pwm-meson.c | -rw-r--r-- | 13.4 KB |
pwm-mtk-disp.c | -rw-r--r-- | 7.2 KB |
pwm-mxs.c | -rw-r--r-- | 4.7 KB |
pwm-omap-dmtimer.c | -rw-r--r-- | 10.3 KB |
pwm-pca9685.c | -rw-r--r-- | 9.8 KB |
pwm-puv3.c | -rw-r--r-- | 3.5 KB |
pwm-pxa.c | -rw-r--r-- | 5.5 KB |
pwm-rcar.c | -rw-r--r-- | 6.6 KB |
pwm-renesas-tpu.c | -rw-r--r-- | 11.9 KB |
pwm-rockchip.c | -rw-r--r-- | 9.6 KB |
pwm-samsung.c | -rw-r--r-- | 16.9 KB |
pwm-spear.c | -rw-r--r-- | 6.5 KB |
pwm-sti.c | -rw-r--r-- | 16.6 KB |
pwm-stmpe.c | -rw-r--r-- | 7.2 KB |
pwm-sun4i.c | -rw-r--r-- | 9.2 KB |
pwm-tegra.c | -rw-r--r-- | 6.6 KB |
pwm-tiecap.c | -rw-r--r-- | 8.1 KB |
pwm-tiehrpwm.c | -rw-r--r-- | 15.7 KB |
pwm-tipwmss.c | -rw-r--r-- | 1.6 KB |
pwm-twl-led.c | -rw-r--r-- | 8.6 KB |
pwm-twl.c | -rw-r--r-- | 9.4 KB |
pwm-vt8500.c | -rw-r--r-- | 6.8 KB |
sysfs.c | -rw-r--r-- | 9.4 KB |
Computing file changes ...